maksaska commented on code in PR #11612:
URL: https://github.com/apache/ignite/pull/11612#discussion_r1825746883


##########
modules/core/src/main/java/org/apache/ignite/internal/cdc/CdcMain.java:
##########
@@ -616,6 +652,18 @@ private void 
consumeSegmentActively(IgniteWalIteratorFactory.IteratorParametersB
         catch (IgniteCheckedException | IOException e) {
             throw new IgniteException(e);
         }
+        finally {
+            updateWalProcessingMetrics(System.nanoTime() - start);
+        }
+    }
+
+    /**
+     * Updates consumer event coonsumption metrics.
+     * @param duration - Operation durtion.
+     */
+    private void updateWalProcessingMetrics(long duration) {

Review Comment:
   I added it for consistency between `eventsConsumptionTime` and 
`eventsConsumptionTimeTotal`. By calling this method we fix the duration as a 
method variable, and assign the same value to both metrics.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to