alex-plekhanov commented on code in PR #11637:
URL: https://github.com/apache/ignite/pull/11637#discussion_r1825965412
##########
modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java:
##########
@@ -937,8 +937,11 @@ private boolean pingNode(TcpDiscoveryNode node) {
if
(IgniteSpiOperationTimeoutHelper.checkFailureTimeoutReached(e)
&& (spi.failureDetectionTimeoutEnabled() ||
timeout != 0)) {
- log.warning("Failed to ping node [nodeId=" +
nodeId + "]. Reached the timeout " +
- (timeout == 0 ? spi.failureDetectionTimeout()
: timeout) + "ms. Cause: " + e.getMessage());
+ if (log.isDebugEnabled()) {
Review Comment:
1. pingNode can be called not only by cleanIpFinder, currently spams only
cleanIpFinder method, but for other calls information about error is helpful
and we shouldn't disable it.
2. Only timeout error is fixed, but there can be other causes. Next time
pingNode can spam log again, but with another error message.
3. What about test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
