[GitHub] [ignite] vshipb opened a new pull request, #10794: IGNITE-19786 Move Persistence and Property task classes to command class packages

2023-06-21 Thread via GitHub
vshipb opened a new pull request, #10794: URL: https://github.com/apache/ignite/pull/10794 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10794: IGNITE-19786 Move Persistence and Property task classes to command class packages

2023-06-21 Thread via GitHub
sonarcloud[bot] commented on PR #10794: URL: https://github.com/apache/ignite/pull/10794#issuecomment-1600334944 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite-3] sanpwc commented on a diff in pull request #2227: IGNITE-19745 Added a method for local obtaining entries in MetaStorage from lower bound revision to upper bound revision.

2023-06-21 Thread via GitHub
sanpwc commented on code in PR #2227: URL: https://github.com/apache/ignite-3/pull/2227#discussion_r1236521082 ## modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/impl/MetaStorageManagerImpl.java: ## @@ -319,6 +321,19 @@ public CompletableFuture get(ByteA

[GitHub] [ignite-3] sanpwc commented on a diff in pull request #2227: IGNITE-19745 Added a method for local obtaining entries in MetaStorage from lower bound revision to upper bound revision.

2023-06-21 Thread via GitHub
sanpwc commented on code in PR #2227: URL: https://github.com/apache/ignite-3/pull/2227#discussion_r1236521868 ## modules/metastorage-api/src/main/java/org/apache/ignite/internal/metastorage/MetaStorageManager.java: ## @@ -60,6 +61,13 @@ public interface MetaStorageManager exten

[GitHub] [ignite-3] sanpwc commented on a diff in pull request #2227: IGNITE-19745 Added a method for local obtaining entries in MetaStorage from lower bound revision to upper bound revision.

2023-06-21 Thread via GitHub
sanpwc commented on code in PR #2227: URL: https://github.com/apache/ignite-3/pull/2227#discussion_r1236524093 ## modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/KeyValueStorage.java: ## @@ -70,6 +70,16 @@ public interface KeyValueStorage extends

[GitHub] [ignite-3] sanpwc commented on a diff in pull request #2227: IGNITE-19745 Added a method for local obtaining entries in MetaStorage from lower bound revision to upper bound revision.

2023-06-21 Thread via GitHub
sanpwc commented on code in PR #2227: URL: https://github.com/apache/ignite-3/pull/2227#discussion_r1236531427 ## modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/persistence/RocksDbKeyValueStorage.java: ## @@ -1215,6 +1227,54 @@ private Entry doGe

[GitHub] [ignite] nizhikov merged pull request #10794: IGNITE-19786 Move Persistence and Property task classes to command class packages

2023-06-21 Thread via GitHub
nizhikov merged PR #10794: URL: https://github.com/apache/ignite/pull/10794 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ig

[GitHub] [ignite-3] sanpwc commented on a diff in pull request #2227: IGNITE-19745 Added a method for local obtaining entries in MetaStorage from lower bound revision to upper bound revision.

2023-06-21 Thread via GitHub
sanpwc commented on code in PR #2227: URL: https://github.com/apache/ignite-3/pull/2227#discussion_r1236601472 ## modules/metastorage/src/test/java/org/apache/ignite/internal/metastorage/server/BasicOperationsKeyValueStorageTest.java: ## @@ -190,6 +192,67 @@ void getWithRevision

[GitHub] [ignite-3] sanpwc commented on a diff in pull request #2227: IGNITE-19745 Added a method for local obtaining entries in MetaStorage from lower bound revision to upper bound revision.

2023-06-21 Thread via GitHub
sanpwc commented on code in PR #2227: URL: https://github.com/apache/ignite-3/pull/2227#discussion_r1236604998 ## modules/metastorage/src/test/java/org/apache/ignite/internal/metastorage/server/BasicOperationsKeyValueStorageTest.java: ## @@ -190,6 +192,67 @@ void getWithRevision

[GitHub] [ignite] vshipb opened a new pull request, #10795: IGNITE-19787 Move Snapshot and Wal task classes to command class packages

2023-06-21 Thread via GitHub
vshipb opened a new pull request, #10795: URL: https://github.com/apache/ignite/pull/10795 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

[GitHub] [ignite-3] rpuch opened a new pull request, #2228: IGNITE-19209 Implement installing table schema updates

2023-06-21 Thread via GitHub
rpuch opened a new pull request, #2228: URL: https://github.com/apache/ignite-3/pull/2228 https://issues.apache.org/jira/browse/IGNITE-19209 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [ignite-3] ptupitsyn opened a new pull request, #2229: IGNITE-19560 Fix Netty buffer leak

2023-06-21 Thread via GitHub
ptupitsyn opened a new pull request, #2229: URL: https://github.com/apache/ignite-3/pull/2229 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

[GitHub] [ignite] Vladsz83 commented on a diff in pull request #10783: IGNITE-19766 Added topology snapshot info to services system view

2023-06-21 Thread via GitHub
Vladsz83 commented on code in PR #10783: URL: https://github.com/apache/ignite/pull/10783#discussion_r1236641674 ## modules/core/src/main/java/org/apache/ignite/spi/systemview/view/ServiceView.java: ## @@ -98,4 +99,14 @@ public boolean staticallyConfigured() { public UUID o

[GitHub] [ignite] nizhikov merged pull request #10795: IGNITE-19787 Move Snapshot and Wal task classes to command class packages

2023-06-21 Thread via GitHub
nizhikov merged PR #10795: URL: https://github.com/apache/ignite/pull/10795 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ig

[GitHub] [ignite] NSAmelchev commented on a diff in pull request #10783: IGNITE-19766 Added topology snapshot info to services system view

2023-06-21 Thread via GitHub
NSAmelchev commented on code in PR #10783: URL: https://github.com/apache/ignite/pull/10783#discussion_r1236648958 ## modules/core/src/main/java/org/apache/ignite/spi/systemview/view/ServiceView.java: ## @@ -98,4 +99,14 @@ public boolean staticallyConfigured() { public UUID

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10795: IGNITE-19787 Move Snapshot and Wal task classes to command class packages

2023-06-21 Thread via GitHub
sonarcloud[bot] commented on PR #10795: URL: https://github.com/apache/ignite/pull/10795#issuecomment-1600456373 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10783: IGNITE-19766 Added topology snapshot info to services system view

2023-06-21 Thread via GitHub
sonarcloud[bot] commented on PR #10783: URL: https://github.com/apache/ignite/pull/10783#issuecomment-1600462939 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qua

[GitHub] [ignite] Vladsz83 commented on a diff in pull request #10783: IGNITE-19766 Added topology snapshot info to services system view

2023-06-21 Thread via GitHub
Vladsz83 commented on code in PR #10783: URL: https://github.com/apache/ignite/pull/10783#discussion_r123941 ## modules/core/src/test/java/org/apache/ignite/internal/metric/SystemViewSelfTest.java: ## @@ -289,6 +289,7 @@ public void testServices() throws Exception {

[GitHub] [ignite] NSAmelchev commented on a diff in pull request #10783: IGNITE-19766 Added topology snapshot info to services system view

2023-06-21 Thread via GitHub
NSAmelchev commented on code in PR #10783: URL: https://github.com/apache/ignite/pull/10783#discussion_r1236667771 ## modules/core/src/test/java/org/apache/ignite/internal/metric/SystemViewSelfTest.java: ## @@ -289,6 +289,7 @@ public void testServices() throws Exception {

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10783: IGNITE-19766 Added topology snapshot info to services system view

2023-06-21 Thread via GitHub
sonarcloud[bot] commented on PR #10783: URL: https://github.com/apache/ignite/pull/10783#issuecomment-1600481069 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qua

[GitHub] [ignite] Vladsz83 commented on a diff in pull request #10783: IGNITE-19766 Added topology snapshot info to services system view

2023-06-21 Thread via GitHub
Vladsz83 commented on code in PR #10783: URL: https://github.com/apache/ignite/pull/10783#discussion_r1236677583 ## modules/control-utility/src/test/java/org/apache/ignite/util/SystemViewCommandTest.java: ## @@ -346,6 +346,7 @@ public void testServices() { assertEquals(

[GitHub] [ignite] Vladsz83 commented on a diff in pull request #10783: IGNITE-19766 Added topology snapshot info to services system view

2023-06-21 Thread via GitHub
Vladsz83 commented on code in PR #10783: URL: https://github.com/apache/ignite/pull/10783#discussion_r1236677583 ## modules/control-utility/src/test/java/org/apache/ignite/util/SystemViewCommandTest.java: ## @@ -346,6 +346,7 @@ public void testServices() { assertEquals(

[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2199: IGNITE-19726: Sql. Migrate index operations to ScannableTable.

2023-06-21 Thread via GitHub
AMashenkov commented on code in PR #2199: URL: https://github.com/apache/ignite-3/pull/2199#discussion_r1236694204 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/TransformingPublisher.java: ## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Softwa

[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2199: IGNITE-19726: Sql. Migrate index operations to ScannableTable.

2023-06-21 Thread via GitHub
AMashenkov commented on code in PR #2199: URL: https://github.com/apache/ignite-3/pull/2199#discussion_r1236697380 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/TransformingPublisher.java: ## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Softwa

[GitHub] [ignite] vshipb opened a new pull request, #10796: IGNITE-19754 Move remaining Cache classes to command classes package

2023-06-21 Thread via GitHub
vshipb opened a new pull request, #10796: URL: https://github.com/apache/ignite/pull/10796 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

[GitHub] [ignite] NSAmelchev commented on a diff in pull request #10783: IGNITE-19766 Added topology snapshot info to services system view

2023-06-21 Thread via GitHub
NSAmelchev commented on code in PR #10783: URL: https://github.com/apache/ignite/pull/10783#discussion_r1236701307 ## modules/control-utility/src/test/java/org/apache/ignite/util/SystemViewCommandTest.java: ## @@ -346,6 +346,7 @@ public void testServices() { assertEqual

[GitHub] [ignite-3] lowka commented on a diff in pull request #2199: IGNITE-19726: Sql. Migrate index operations to ScannableTable.

2023-06-21 Thread via GitHub
lowka commented on code in PR #2199: URL: https://github.com/apache/ignite-3/pull/2199#discussion_r1236703915 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/TransformingPublisher.java: ## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10783: IGNITE-19766 Added topology snapshot info to services system view

2023-06-21 Thread via GitHub
sonarcloud[bot] commented on PR #10783: URL: https://github.com/apache/ignite/pull/10783#issuecomment-1600515645 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qua

[GitHub] [ignite-3] lowka commented on a diff in pull request #2199: IGNITE-19726: Sql. Migrate index operations to ScannableTable.

2023-06-21 Thread via GitHub
lowka commented on code in PR #2199: URL: https://github.com/apache/ignite-3/pull/2199#discussion_r1236709047 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/TransformingPublisher.java: ## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2199: IGNITE-19726: Sql. Migrate index operations to ScannableTable.

2023-06-21 Thread via GitHub
AMashenkov commented on code in PR #2199: URL: https://github.com/apache/ignite-3/pull/2199#discussion_r1236712245 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ScannableTableImpl.java: ## @@ -63,6 +72,113 @@ public Publisher scan(ExecutionConte

[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2199: IGNITE-19726: Sql. Migrate index operations to ScannableTable.

2023-06-21 Thread via GitHub
AMashenkov commented on code in PR #2199: URL: https://github.com/apache/ignite-3/pull/2199#discussion_r1236717349 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ScannableTableImpl.java: ## @@ -63,6 +72,113 @@ public Publisher scan(ExecutionConte

[GitHub] [ignite] nizhikov merged pull request #10796: IGNITE-19754 Move remaining Cache classes to command classes package

2023-06-21 Thread via GitHub
nizhikov merged PR #10796: URL: https://github.com/apache/ignite/pull/10796 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ig

[GitHub] [ignite-3] ibessonov commented on a diff in pull request #2225: IGNITE-19539 Added exception mapper utility

2023-06-21 Thread via GitHub
ibessonov commented on code in PR #2225: URL: https://github.com/apache/ignite-3/pull/2225#discussion_r1236693712 ## modules/api/src/main/java/org/apache/ignite/lang/IgniteExceptionMapperFuture.java: ## @@ -0,0 +1,436 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10796: IGNITE-19754 Move remaining Cache classes to command classes package

2023-06-21 Thread via GitHub
sonarcloud[bot] commented on PR #10796: URL: https://github.com/apache/ignite/pull/10796#issuecomment-1600529803 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2199: IGNITE-19726: Sql. Migrate index operations to ScannableTable.

2023-06-21 Thread via GitHub
AMashenkov commented on code in PR #2199: URL: https://github.com/apache/ignite-3/pull/2199#discussion_r1236719996 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ScannableTableImpl.java: ## @@ -63,6 +72,113 @@ public Publisher scan(ExecutionConte

[GitHub] [ignite-3] ibessonov commented on a diff in pull request #2225: IGNITE-19539 Added exception mapper utility

2023-06-21 Thread via GitHub
ibessonov commented on code in PR #2225: URL: https://github.com/apache/ignite-3/pull/2225#discussion_r1236712924 ## modules/api/src/test/java/org/apache/ignite/lang/IgniteExceptionMapperUtilTest.java: ## @@ -0,0 +1,238 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [ignite-3] ibessonov commented on a diff in pull request #2225: IGNITE-19539 Added exception mapper utility

2023-06-21 Thread via GitHub
ibessonov commented on code in PR #2225: URL: https://github.com/apache/ignite-3/pull/2225#discussion_r1236708527 ## modules/api/src/main/java/org/apache/ignite/lang/IgniteExceptionMappersProvider.java: ## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [ignite] Vladsz83 commented on a diff in pull request #10783: IGNITE-19766 Added topology snapshot info to services system view

2023-06-21 Thread via GitHub
Vladsz83 commented on code in PR #10783: URL: https://github.com/apache/ignite/pull/10783#discussion_r1236720397 ## modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/metric/SqlViewExporterSpiTest.java: ## @@ -309,6 +310,7 @@ public void testServices() {

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10788: IGNITE-19725 SQL Calclite: Implement local flag support

2023-06-21 Thread via GitHub
sonarcloud[bot] commented on PR #10788: URL: https://github.com/apache/ignite/pull/10788#issuecomment-1600537124 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qua

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10783: IGNITE-19766 Added topology snapshot info to services system view

2023-06-21 Thread via GitHub
sonarcloud[bot] commented on PR #10783: URL: https://github.com/apache/ignite/pull/10783#issuecomment-1600567012 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qua

[GitHub] [ignite-3] sergeyuttsel commented on a diff in pull request #2227: IGNITE-19745 Added a method for local obtaining entries in MetaStorage from lower bound revision to upper bound revision.

2023-06-21 Thread via GitHub
sergeyuttsel commented on code in PR #2227: URL: https://github.com/apache/ignite-3/pull/2227#discussion_r1236757037 ## modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/KeyValueStorage.java: ## @@ -70,6 +70,16 @@ public interface KeyValueStorage ex

[GitHub] [ignite-3] sergeyuttsel commented on a diff in pull request #2227: IGNITE-19745 Added a method for local obtaining entries in MetaStorage from lower bound revision to upper bound revision.

2023-06-21 Thread via GitHub
sergeyuttsel commented on code in PR #2227: URL: https://github.com/apache/ignite-3/pull/2227#discussion_r1236757755 ## modules/metastorage/src/test/java/org/apache/ignite/internal/metastorage/server/BasicOperationsKeyValueStorageTest.java: ## @@ -190,6 +192,67 @@ void getWithRe

[GitHub] [ignite-3] sergeyuttsel commented on a diff in pull request #2227: IGNITE-19745 Added a method for local obtaining entries in MetaStorage from lower bound revision to upper bound revision.

2023-06-21 Thread via GitHub
sergeyuttsel commented on code in PR #2227: URL: https://github.com/apache/ignite-3/pull/2227#discussion_r1236758044 ## modules/metastorage/src/test/java/org/apache/ignite/internal/metastorage/server/BasicOperationsKeyValueStorageTest.java: ## @@ -190,6 +192,67 @@ void getWithRe

[GitHub] [ignite-3] lowka commented on a diff in pull request #2199: IGNITE-19726: Sql. Migrate index operations to ScannableTable.

2023-06-21 Thread via GitHub
lowka commented on code in PR #2199: URL: https://github.com/apache/ignite-3/pull/2199#discussion_r1236759236 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ScannableTableImpl.java: ## @@ -63,6 +72,113 @@ public Publisher scan(ExecutionContext c

[GitHub] [ignite-3] lowka commented on a diff in pull request #2199: IGNITE-19726: Sql. Migrate index operations to ScannableTable.

2023-06-21 Thread via GitHub
lowka commented on code in PR #2199: URL: https://github.com/apache/ignite-3/pull/2199#discussion_r1236760687 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ScannableTableImpl.java: ## @@ -63,6 +72,113 @@ public Publisher scan(ExecutionContext c

[GitHub] [ignite-3] lowka commented on a diff in pull request #2199: IGNITE-19726: Sql. Migrate index operations to ScannableTable.

2023-06-21 Thread via GitHub
lowka commented on code in PR #2199: URL: https://github.com/apache/ignite-3/pull/2199#discussion_r1236762824 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ScannableTableImpl.java: ## @@ -63,6 +72,113 @@ public Publisher scan(ExecutionContext c

[GitHub] [ignite-3] lowka commented on a diff in pull request #2199: IGNITE-19726: Sql. Migrate index operations to ScannableTable.

2023-06-21 Thread via GitHub
lowka commented on code in PR #2199: URL: https://github.com/apache/ignite-3/pull/2199#discussion_r1236763358 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/TransformingPublisher.java: ## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] [ignite] nizhikov opened a new pull request, #10797: IGNITE-19753 Move task classes to commands

2023-06-21 Thread via GitHub
nizhikov opened a new pull request, #10797: URL: https://github.com/apache/ignite/pull/10797 Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### Th

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10797: IGNITE-19753 Move task classes to commands

2023-06-21 Thread via GitHub
sonarcloud[bot] commented on PR #10797: URL: https://github.com/apache/ignite/pull/10797#issuecomment-1600606510 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite-3] ptupitsyn opened a new pull request, #2230: IGNITE-19624 Java client: propagate compute deployment units

2023-06-21 Thread via GitHub
ptupitsyn opened a new pull request, #2230: URL: https://github.com/apache/ignite-3/pull/2230 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2199: IGNITE-19726: Sql. Migrate index operations to ScannableTable.

2023-06-21 Thread via GitHub
AMashenkov commented on code in PR #2199: URL: https://github.com/apache/ignite-3/pull/2199#discussion_r1236786310 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/framework/NoOpTransaction.java: ## @@ -43,14 +43,32 @@ public final class NoOpTransaction

[GitHub] [ignite-3] isapego commented on a diff in pull request #2215: IGNITE-19617 Embedded basic Data Streamer

2023-06-21 Thread via GitHub
isapego commented on code in PR #2215: URL: https://github.com/apache/ignite-3/pull/2215#discussion_r1236832053 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/storage/InternalTableImpl.java: ## @@ -648,18 +648,26 @@ public CompletableFuture upsertAl

[GitHub] [ignite-3] sk0x50 commented on a diff in pull request #2225: IGNITE-19539 Added exception mapper utility

2023-06-21 Thread via GitHub
sk0x50 commented on code in PR #2225: URL: https://github.com/apache/ignite-3/pull/2225#discussion_r1236832620 ## modules/api/src/main/java/org/apache/ignite/lang/IgniteExceptionMapperFuture.java: ## @@ -0,0 +1,436 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] [ignite] Vladsz83 commented on a diff in pull request #10783: IGNITE-19766 Added topology snapshot info to services system view

2023-06-21 Thread via GitHub
Vladsz83 commented on code in PR #10783: URL: https://github.com/apache/ignite/pull/10783#discussion_r1236859131 ## modules/core/src/main/java/org/apache/ignite/internal/managers/systemview/SystemViewMBean.java: ## @@ -289,7 +290,7 @@ else if (clazz.isEnum()) else i

[GitHub] [ignite-3] lowka commented on a diff in pull request #2199: IGNITE-19726: Sql. Migrate index operations to ScannableTable.

2023-06-21 Thread via GitHub
lowka commented on code in PR #2199: URL: https://github.com/apache/ignite-3/pull/2199#discussion_r1236859774 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/exec/ExecutableTableRegistrySelfTest.java: ## @@ -79,9 +88,10 @@ public void testGetTable() {

[GitHub] [ignite-3] lowka commented on a diff in pull request #2199: IGNITE-19726: Sql. Migrate index operations to ScannableTable.

2023-06-21 Thread via GitHub
lowka commented on code in PR #2199: URL: https://github.com/apache/ignite-3/pull/2199#discussion_r1236860441 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/TransformingPublisher.java: ## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] [ignite-3] tkalkirill opened a new pull request, #2231: IGNITE-19641 Catalog events are triggered too early.

2023-06-21 Thread via GitHub
tkalkirill opened a new pull request, #2231: URL: https://github.com/apache/ignite-3/pull/2231 https://issues.apache.org/jira/browse/IGNITE-19641 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [ignite] Vladsz83 commented on a diff in pull request #10783: IGNITE-19766 Added topology snapshot info to services system view

2023-06-21 Thread via GitHub
Vladsz83 commented on code in PR #10783: URL: https://github.com/apache/ignite/pull/10783#discussion_r1236720397 ## modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/metric/SqlViewExporterSpiTest.java: ## @@ -309,6 +310,7 @@ public void testServices() {

[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2205: IGNITE-19755: move common test classes to testFixtures for runner module

2023-06-21 Thread via GitHub
AMashenkov commented on code in PR #2205: URL: https://github.com/apache/ignite-3/pull/2205#discussion_r1236861779 ## modules/runner/build.gradle: ## @@ -158,8 +158,21 @@ dependencies { integrationTestImplementation libs.typesafe.config integrationTestImplementation li

[GitHub] [ignite] Vladsz83 commented on a diff in pull request #10783: IGNITE-19766 Added topology snapshot info to services system view

2023-06-21 Thread via GitHub
Vladsz83 commented on code in PR #10783: URL: https://github.com/apache/ignite/pull/10783#discussion_r1236677583 ## modules/control-utility/src/test/java/org/apache/ignite/util/SystemViewCommandTest.java: ## @@ -346,6 +346,7 @@ public void testServices() { assertEquals(

[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2205: IGNITE-19755: move common test classes to testFixtures for runner module

2023-06-21 Thread via GitHub
AMashenkov commented on code in PR #2205: URL: https://github.com/apache/ignite-3/pull/2205#discussion_r1236861779 ## modules/runner/build.gradle: ## @@ -158,8 +158,21 @@ dependencies { integrationTestImplementation libs.typesafe.config integrationTestImplementation li

[GitHub] [ignite] Vladsz83 commented on a diff in pull request #10783: IGNITE-19766 Added topology snapshot info to services system view

2023-06-21 Thread via GitHub
Vladsz83 commented on code in PR #10783: URL: https://github.com/apache/ignite/pull/10783#discussion_r1236863684 ## modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/metric/SqlViewExporterSpiTest.java: ## @@ -309,6 +310,7 @@ public void testServices() {

[GitHub] [ignite] Vladsz83 commented on a diff in pull request #10783: IGNITE-19766 Added topology snapshot info to services system view

2023-06-21 Thread via GitHub
Vladsz83 commented on code in PR #10783: URL: https://github.com/apache/ignite/pull/10783#discussion_r1236859131 ## modules/core/src/main/java/org/apache/ignite/internal/managers/systemview/SystemViewMBean.java: ## @@ -289,7 +290,7 @@ else if (clazz.isEnum()) else i

[GitHub] [ignite-3] ptupitsyn commented on a diff in pull request #2215: IGNITE-19617 Embedded basic Data Streamer

2023-06-21 Thread via GitHub
ptupitsyn commented on code in PR #2215: URL: https://github.com/apache/ignite-3/pull/2215#discussion_r1236880669 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/storage/InternalTableImpl.java: ## @@ -648,18 +648,26 @@ public CompletableFuture upsert

[GitHub] [ignite-3] ptupitsyn commented on a diff in pull request #2215: IGNITE-19617 Embedded basic Data Streamer

2023-06-21 Thread via GitHub
ptupitsyn commented on code in PR #2215: URL: https://github.com/apache/ignite-3/pull/2215#discussion_r1236882310 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/storage/InternalTableImpl.java: ## @@ -648,18 +648,26 @@ public CompletableFuture upsert

[GitHub] [ignite-3] vldpyatkov merged pull request #2209: IGNITE-19731 Fixed ItTableScanTest different test failed

2023-06-21 Thread via GitHub
vldpyatkov merged PR #2209: URL: https://github.com/apache/ignite-3/pull/2209 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

[GitHub] [ignite-3] ptupitsyn merged pull request #2215: IGNITE-19617 Embedded basic Data Streamer

2023-06-21 Thread via GitHub
ptupitsyn merged PR #2215: URL: https://github.com/apache/ignite-3/pull/2215 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

[GitHub] [ignite-3] sergeyuttsel commented on a diff in pull request #2227: IGNITE-19745 Added a method for local obtaining entries in MetaStorage from lower bound revision to upper bound revision.

2023-06-21 Thread via GitHub
sergeyuttsel commented on code in PR #2227: URL: https://github.com/apache/ignite-3/pull/2227#discussion_r1236949433 ## modules/metastorage-api/src/main/java/org/apache/ignite/internal/metastorage/MetaStorageManager.java: ## @@ -60,6 +61,13 @@ public interface MetaStorageManager

[GitHub] [ignite-3] sk0x50 commented on a diff in pull request #2225: IGNITE-19539 Added exception mapper utility

2023-06-21 Thread via GitHub
sk0x50 commented on code in PR #2225: URL: https://github.com/apache/ignite-3/pull/2225#discussion_r1236963103 ## modules/api/src/main/java/org/apache/ignite/lang/IgniteExceptionMapperUtil.java: ## @@ -0,0 +1,149 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [ignite-3] sk0x50 commented on a diff in pull request #2225: IGNITE-19539 Added exception mapper utility

2023-06-21 Thread via GitHub
sk0x50 commented on code in PR #2225: URL: https://github.com/apache/ignite-3/pull/2225#discussion_r1236972592 ## modules/api/src/main/java/org/apache/ignite/lang/IgniteExceptionMapperUtil.java: ## @@ -0,0 +1,149 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [ignite] NSAmelchev commented on a diff in pull request #10783: IGNITE-19766 Added topology snapshot info to services system view

2023-06-21 Thread via GitHub
NSAmelchev commented on code in PR #10783: URL: https://github.com/apache/ignite/pull/10783#discussion_r1236978603 ## modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/metric/SqlViewExporterSpiTest.java: ## @@ -309,6 +310,7 @@ public void testServices()

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10783: IGNITE-19766 Added topology snapshot info to services system view

2023-06-21 Thread via GitHub
sonarcloud[bot] commented on PR #10783: URL: https://github.com/apache/ignite/pull/10783#issuecomment-1600822282 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qua

[GitHub] [ignite-3] sk0x50 merged pull request #2178: IGNITE-19535 Removed a requirement to have a special constructor for Ignite exceptions

2023-06-21 Thread via GitHub
sk0x50 merged PR #2178: URL: https://github.com/apache/ignite-3/pull/2178 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@igni

[GitHub] [ignite-3] sergeyuttsel opened a new pull request, #2232: IGNITE-19735 Created interface for interaction with local KeyValueStorage of the meta storage

2023-06-21 Thread via GitHub
sergeyuttsel opened a new pull request, #2232: URL: https://github.com/apache/ignite-3/pull/2232 https://issues.apache.org/jira/browse/IGNITE-19735 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2231: IGNITE-19641 Catalog events are triggered too early.

2023-06-21 Thread via GitHub
AMashenkov commented on code in PR #2231: URL: https://github.com/apache/ignite-3/pull/2231#discussion_r1237074963 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogServiceImpl.java: ## @@ -651,18 +456,12 @@ public CompletableFuture createDistributionZo

[GitHub] [ignite-3] ptupitsyn merged pull request #2229: IGNITE-19560 Java client: fix Netty buffer leak

2023-06-21 Thread via GitHub
ptupitsyn merged PR #2229: URL: https://github.com/apache/ignite-3/pull/2229 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

[GitHub] [ignite-3] sk0x50 commented on a diff in pull request #2225: IGNITE-19539 Added exception mapper utility

2023-06-21 Thread via GitHub
sk0x50 commented on code in PR #2225: URL: https://github.com/apache/ignite-3/pull/2225#discussion_r1236972592 ## modules/api/src/main/java/org/apache/ignite/lang/IgniteExceptionMapperUtil.java: ## @@ -0,0 +1,149 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [ignite-3] sk0x50 commented on a diff in pull request #2225: IGNITE-19539 Added exception mapper utility

2023-06-21 Thread via GitHub
sk0x50 commented on code in PR #2225: URL: https://github.com/apache/ignite-3/pull/2225#discussion_r1236963103 ## modules/api/src/main/java/org/apache/ignite/lang/IgniteExceptionMapperUtil.java: ## @@ -0,0 +1,149 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2231: IGNITE-19641 Catalog events are triggered too early.

2023-06-21 Thread via GitHub
AMashenkov commented on code in PR #2231: URL: https://github.com/apache/ignite-3/pull/2231#discussion_r1237108035 ## modules/catalog/src/test/java/org/apache/ignite/internal/catalog/CatalogServiceSelfTest.java: ## @@ -1248,19 +1275,22 @@ public void testCreateIndexEvents() {

[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2231: IGNITE-19641 Catalog events are triggered too early.

2023-06-21 Thread via GitHub
AMashenkov commented on code in PR #2231: URL: https://github.com/apache/ignite-3/pull/2231#discussion_r1237108035 ## modules/catalog/src/test/java/org/apache/ignite/internal/catalog/CatalogServiceSelfTest.java: ## @@ -1248,19 +1275,22 @@ public void testCreateIndexEvents() {

[GitHub] [ignite-3] ibessonov commented on a diff in pull request #2231: IGNITE-19641 Catalog events are triggered too early.

2023-06-21 Thread via GitHub
ibessonov commented on code in PR #2231: URL: https://github.com/apache/ignite-3/pull/2231#discussion_r1237119534 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogServiceImpl.java: ## @@ -277,82 +259,62 @@ private Catalog catalogAt(long timestamp) {

[GitHub] [ignite-website] Daikon5 opened a new pull request, #168: IGNITE-19797 Added GA4 property

2023-06-21 Thread via GitHub
Daikon5 opened a new pull request, #168: URL: https://github.com/apache/ignite-website/pull/168 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [ignite-website] ashapkin merged pull request #168: IGNITE-19797 Added GA4 property

2023-06-21 Thread via GitHub
ashapkin merged PR #168: URL: https://github.com/apache/ignite-website/pull/168 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr..

[ignite-website] branch master updated: IGNITE-19797 Added GA4 property (#168)

2023-06-21 Thread ashapkin
This is an automated email from the ASF dual-hosted git repository. ashapkin pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/ignite-website.git The following commit(s) were added to refs/heads/master by this push: new e83ac81519 IGNITE-19797 Added GA4 prop

[GitHub] [ignite] yurinaryshkin opened a new pull request, #10798: Ignite 19675

2023-06-21 Thread via GitHub
yurinaryshkin opened a new pull request, #10798: URL: https://github.com/apache/ignite/pull/10798 Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: #

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10798: Ignite 19675

2023-06-21 Thread via GitHub
sonarcloud[bot] commented on PR #10798: URL: https://github.com/apache/ignite/pull/10798#issuecomment-1601279680 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10783: IGNITE-19766 Added topology snapshot info to services system view

2023-06-21 Thread via GitHub
sonarcloud[bot] commented on PR #10783: URL: https://github.com/apache/ignite/pull/10783#issuecomment-1601346024 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qua

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #2231: IGNITE-19641 Catalog events are triggered too early.

2023-06-21 Thread via GitHub
tkalkirill commented on code in PR #2231: URL: https://github.com/apache/ignite-3/pull/2231#discussion_r1237456344 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogServiceImpl.java: ## @@ -651,18 +456,12 @@ public CompletableFuture createDistributionZo

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #2231: IGNITE-19641 Catalog events are triggered too early.

2023-06-21 Thread via GitHub
tkalkirill commented on code in PR #2231: URL: https://github.com/apache/ignite-3/pull/2231#discussion_r1237464401 ## modules/catalog/src/test/java/org/apache/ignite/internal/catalog/CatalogServiceSelfTest.java: ## @@ -1248,19 +1275,22 @@ public void testCreateIndexEvents() {

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #2231: IGNITE-19641 Catalog events are triggered too early.

2023-06-21 Thread via GitHub
tkalkirill commented on code in PR #2231: URL: https://github.com/apache/ignite-3/pull/2231#discussion_r1237469616 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogServiceImpl.java: ## @@ -277,82 +259,62 @@ private Catalog catalogAt(long timestamp) {

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #2231: IGNITE-19641 Catalog events are triggered too early.

2023-06-21 Thread via GitHub
tkalkirill commented on code in PR #2231: URL: https://github.com/apache/ignite-3/pull/2231#discussion_r1237515837 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogServiceImpl.java: ## @@ -277,82 +259,62 @@ private Catalog catalogAt(long timestamp) {

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #2231: IGNITE-19641 Catalog events are triggered too early.

2023-06-21 Thread via GitHub
tkalkirill commented on code in PR #2231: URL: https://github.com/apache/ignite-3/pull/2231#discussion_r1237551575 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/commands/AbstractIndexCommandParams.java: ## @@ -41,6 +47,20 @@ public String schemaName() {

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #2231: IGNITE-19641 Catalog events are triggered too early.

2023-06-21 Thread via GitHub
tkalkirill commented on code in PR #2231: URL: https://github.com/apache/ignite-3/pull/2231#discussion_r1237557975 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/events/AddColumnEventParameters.java: ## @@ -24,25 +24,27 @@ * Add column event parameters con

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #2231: IGNITE-19641 Catalog events are triggered too early.

2023-06-21 Thread via GitHub
tkalkirill commented on code in PR #2231: URL: https://github.com/apache/ignite-3/pull/2231#discussion_r1237562111 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/events/AlterColumnEventParameters.java: ## @@ -23,32 +23,36 @@ * Create table event parameters

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #2231: IGNITE-19641 Catalog events are triggered too early.

2023-06-21 Thread via GitHub
tkalkirill commented on code in PR #2231: URL: https://github.com/apache/ignite-3/pull/2231#discussion_r1237563034 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/events/AlterZoneEventParameters.java: ## @@ -23,25 +23,25 @@ * Alter zone event parameters con

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #2231: IGNITE-19641 Catalog events are triggered too early.

2023-06-21 Thread via GitHub
tkalkirill commented on code in PR #2231: URL: https://github.com/apache/ignite-3/pull/2231#discussion_r1237583162 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/storage/CatalogFireEvent.java: ## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software Found

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #2231: IGNITE-19641 Catalog events are triggered too early.

2023-06-21 Thread via GitHub
tkalkirill commented on code in PR #2231: URL: https://github.com/apache/ignite-3/pull/2231#discussion_r1237587629 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/storage/UpdateLogImpl.java: ## @@ -167,7 +169,7 @@ private void restoreStateFromVault(OnUpdateHa

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #2231: IGNITE-19641 Catalog events are triggered too early.

2023-06-21 Thread via GitHub
tkalkirill commented on code in PR #2231: URL: https://github.com/apache/ignite-3/pull/2231#discussion_r1238002599 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/storage/UpdateEntry.java: ## @@ -18,9 +18,11 @@ package org.apache.ignite.internal.catalog.stor

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #2223: IGNITE-19668 Sql. Fix testLengthExpressionWithDynamicParameter

2023-06-21 Thread via GitHub
korlov42 commented on code in PR #2223: URL: https://github.com/apache/ignite-3/pull/2223#discussion_r1238013978 ## modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/engine/datatypes/varbinary/ItVarBinaryExpressionTest.java: ## @@ -67,24 +67,32 @@ public voi

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #2231: IGNITE-19641 Catalog events are triggered too early.

2023-06-21 Thread via GitHub
korlov42 commented on code in PR #2231: URL: https://github.com/apache/ignite-3/pull/2231#discussion_r1238017426 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/events/AddColumnEventParameters.java: ## @@ -24,25 +24,27 @@ * Add column event parameters conta

  1   2   >