Vladsz83 commented on code in PR #10783:
URL: https://github.com/apache/ignite/pull/10783#discussion_r1236677583


##########
modules/control-utility/src/test/java/org/apache/ignite/util/SystemViewCommandTest.java:
##########
@@ -346,6 +346,7 @@ public void testServices() {
         assertEquals(srvcCfg.getName(), sysView.get(1)); // name
         assertEquals(DummyService.class.getName(), sysView.get(2)); // 
serviceClass
         assertEquals(Integer.toString(srvcCfg.getMaxPerNodeCount()), 
sysView.get(6)); // maxPerNodeCount
+        
assertEquals(F.first(ignite0.services().serviceDescriptors()).topologySnapshot().toString(),
 sysView.get(10));

Review Comment:
   Suggestion:
   `
   for(Ignite ig : G.allGrids()){
               List<List<String>> srvsView = systemView((IgniteEx)ig, 
SVCS_VIEW);
   
               assertEquals(1, srvsView.size());
   
               List<String> sysView = srvsView.get(0);
   
               assertEquals(srvcCfg.getName(), sysView.get(1)); // name
               assertEquals(DummyService.class.getName(), sysView.get(2)); // 
serviceClass
               assertEquals(Integer.toString(srvcCfg.getMaxPerNodeCount()), 
sysView.get(6)); // maxPerNodeCount
               
assertEquals(F.first(ig.services().serviceDescriptors()).topologySnapshot().toString(),
 sysView.get(10));
           }
   `
   Up2U



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to