Re: [PR] IGNITE-23934 Prevent duplicate node names [ignite-3]

2025-04-05 Thread via GitHub
valepakh commented on code in PR #5255: URL: https://github.com/apache/ignite-3/pull/5255#discussion_r2002787120 ## modules/api/src/main/java/org/apache/ignite/lang/ErrorGroups.java: ## @@ -500,6 +500,9 @@ public static class Network { /** Could not resolve address. *

Re: [PR] IGNITE-23934 Prevent duplicate node names [ignite-3]

2025-03-19 Thread via GitHub
PakhomovAlexander merged PR #5255: URL: https://github.com/apache/ignite-3/pull/5255 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsub

Re: [PR] IGNITE-23934 Prevent duplicate node names [ignite-3]

2025-03-19 Thread via GitHub
valepakh commented on code in PR #5255: URL: https://github.com/apache/ignite-3/pull/5255#discussion_r2002762256 ## modules/network/src/main/java/org/apache/ignite/internal/network/scalecube/ScaleCubeTopologyService.java: ## @@ -140,6 +156,12 @@ void updateLocalMetadata(@Nullabl

Re: [PR] IGNITE-23934 Prevent duplicate node names [ignite-3]

2025-03-19 Thread via GitHub
valepakh commented on code in PR #5255: URL: https://github.com/apache/ignite-3/pull/5255#discussion_r2002787902 ## modules/network-api/src/main/java/org/apache/ignite/internal/network/DuplicateConsistentIdException.java: ## @@ -0,0 +1,30 @@ +/* + * Licensed to the Apache Softwa

Re: [PR] IGNITE-23934 Prevent duplicate node names [ignite-3]

2025-03-19 Thread via GitHub
rpuch commented on code in PR #5255: URL: https://github.com/apache/ignite-3/pull/5255#discussion_r2002616315 ## modules/network-api/src/main/java/org/apache/ignite/internal/network/DuplicateConsistentIdException.java: ## @@ -0,0 +1,30 @@ +/* + * Licensed to the Apache Software

Re: [PR] IGNITE-23934 Prevent duplicate node names [ignite-3]

2025-03-15 Thread via GitHub
valepakh commented on code in PR #5255: URL: https://github.com/apache/ignite-3/pull/5255#discussion_r1988989988 ## modules/network/src/main/java/org/apache/ignite/internal/network/scalecube/ScaleCubeTopologyService.java: ## @@ -187,8 +190,9 @@ public ClusterNode getByAddress(Ne

Re: [PR] IGNITE-23934 Prevent duplicate node names [ignite-3]

2025-03-11 Thread via GitHub
valepakh commented on code in PR #5255: URL: https://github.com/apache/ignite-3/pull/5255#discussion_r1988991483 ## modules/cluster-management/src/main/java/org/apache/ignite/internal/cluster/management/ClusterManagementGroupManager.java: ## @@ -875,23 +875,23 @@ private void se

Re: [PR] IGNITE-23934 Prevent duplicate node names [ignite-3]

2025-03-05 Thread via GitHub
rpuch commented on code in PR #5255: URL: https://github.com/apache/ignite-3/pull/5255#discussion_r1981123166 ## modules/cluster-management/src/main/java/org/apache/ignite/internal/cluster/management/ClusterManagementGroupManager.java: ## @@ -875,23 +875,23 @@ private void sendC

Re: [PR] IGNITE-23934 Prevent duplicate node names [ignite-3]

2025-03-05 Thread via GitHub
rpuch commented on code in PR #5255: URL: https://github.com/apache/ignite-3/pull/5255#discussion_r1981118741 ## modules/network/src/main/java/org/apache/ignite/internal/network/scalecube/ScaleCubeTopologyService.java: ## @@ -187,8 +190,9 @@ public ClusterNode getByAddress(Netwo

Re: [PR] IGNITE-23934 Prevent duplicate node names [ignite-3]

2025-03-04 Thread via GitHub
valepakh commented on code in PR #5255: URL: https://github.com/apache/ignite-3/pull/5255#discussion_r1979571865 ## modules/cluster-management/src/main/java/org/apache/ignite/internal/cluster/management/ClusterManagementGroupManager.java: ## @@ -871,6 +883,17 @@ private void sen

Re: [PR] IGNITE-23934 Prevent duplicate node names [ignite-3]

2025-03-04 Thread via GitHub
valepakh commented on code in PR #5255: URL: https://github.com/apache/ignite-3/pull/5255#discussion_r1979573430 ## modules/runner/src/integrationTest/java/org/apache/ignite/internal/cluster/management/ItDuplicateNodesTest.java: ## @@ -0,0 +1,172 @@ +/* + * Licensed to the Apach

Re: [PR] IGNITE-23934 Prevent duplicate node names [ignite-3]

2025-03-04 Thread via GitHub
valepakh commented on code in PR #5255: URL: https://github.com/apache/ignite-3/pull/5255#discussion_r1979572340 ## modules/cluster-management/src/test/java/org/apache/ignite/internal/cluster/management/ClusterInitializerTest.java: ## @@ -200,11 +196,10 @@ void testInitNoCancel(

Re: [PR] IGNITE-23934 Prevent duplicate node names [ignite-3]

2025-03-04 Thread via GitHub
valepakh commented on code in PR #5255: URL: https://github.com/apache/ignite-3/pull/5255#discussion_r1979571459 ## modules/cluster-management/src/main/java/org/apache/ignite/internal/cluster/management/ClusterInitializer.java: ## @@ -184,6 +188,20 @@ public CompletableFuture in

Re: [PR] IGNITE-23934 Prevent duplicate node names [ignite-3]

2025-03-04 Thread via GitHub
valepakh commented on code in PR #5255: URL: https://github.com/apache/ignite-3/pull/5255#discussion_r1979572983 ## modules/network/src/main/java/org/apache/ignite/internal/network/scalecube/ScaleCubeTopologyService.java: ## @@ -57,8 +58,8 @@ final class ScaleCubeTopologyService

Re: [PR] IGNITE-23934 Prevent duplicate node names [ignite-3]

2025-03-03 Thread via GitHub
rpuch commented on code in PR #5255: URL: https://github.com/apache/ignite-3/pull/5255#discussion_r1977280745 ## modules/cluster-management/src/main/java/org/apache/ignite/internal/cluster/management/ClusterInitializer.java: ## @@ -184,6 +188,20 @@ public CompletableFuture initC