valepakh commented on code in PR #5255:
URL: https://github.com/apache/ignite-3/pull/5255#discussion_r1988989988
##########
modules/network/src/main/java/org/apache/ignite/internal/network/scalecube/ScaleCubeTopologyService.java:
##########
@@ -187,8 +190,9 @@ public ClusterNode getByAddress(NetworkAddress addr) {
/** {@inheritDoc} */
@Override
- public ClusterNode getByConsistentId(String consistentId) {
- return consistentIdToMemberMap.get(consistentId);
+ public @Nullable ClusterNode getByConsistentId(String consistentId) {
+ Map<UUID, ClusterNode> nodes =
consistentIdToMemberMap.get(consistentId);
+ return nodes != null ? nodes.values().iterator().next() : null;
Review Comment:
It's non trivial to distinguish between calls to this method meaning logical
topology or physical.
I tried to implement this so to not touch the 'business code' really, so
this will log an error and throw an exception only when we try to pick a node
by its name when it's not in the logical topology but has a duplicate in the
physical one.
I used option 3 and introduced a listener in the `IgniteImpl` - this seems
cleaner than try to introduce a dependency on physical topology.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
