valepakh commented on code in PR #5255:
URL: https://github.com/apache/ignite-3/pull/5255#discussion_r1979571865
##########
modules/cluster-management/src/main/java/org/apache/ignite/internal/cluster/management/ClusterManagementGroupManager.java:
##########
@@ -871,6 +883,17 @@ private void sendClusterState(CmgRaftService raftService,
Collection<ClusterNode
return nullCompletedFuture();
}
+ Collection<ClusterNode> duplicates =
findDuplicateConsistentIds(topology, nodes);
+ if (!duplicates.isEmpty()) {
+ CancelJoinMessage msg = msgFactory.cancelJoinMessage()
+ .reason("Duplicate consistent id detected")
Review Comment:
Fixed
##########
modules/cluster-management/src/main/java/org/apache/ignite/internal/cluster/management/ClusterManagementGroupManager.java:
##########
@@ -871,6 +883,17 @@ private void sendClusterState(CmgRaftService raftService,
Collection<ClusterNode
return nullCompletedFuture();
}
+ Collection<ClusterNode> duplicates =
findDuplicateConsistentIds(topology, nodes);
+ if (!duplicates.isEmpty()) {
+ CancelJoinMessage msg = msgFactory.cancelJoinMessage()
+ .reason("Duplicate consistent id detected")
+ .build();
+ for (ClusterNode duplicate : duplicates) {
+ sendWithRetry(duplicate, msg);
+ }
+ return nullCompletedFuture();
Review Comment:
Fixed, although I have no idea how to create a test for this scenario
##########
modules/cluster-management/src/main/java/org/apache/ignite/internal/cluster/management/ClusterManagementGroupManager.java:
##########
@@ -895,6 +918,11 @@ private void sendClusterState(CmgRaftService raftService,
Collection<ClusterNode
});
}
+ private static Collection<ClusterNode>
findDuplicateConsistentIds(LogicalTopologySnapshot topology,
Collection<ClusterNode> nodes) {
Review Comment:
Fixed
##########
modules/cluster-management/src/main/java/org/apache/ignite/internal/cluster/management/network/messages/CancelJoinMessage.java:
##########
@@ -0,0 +1,32 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.cluster.management.network.messages;
+
+import org.apache.ignite.internal.network.NetworkMessage;
+import org.apache.ignite.internal.network.annotations.Transferable;
+
+/**
+ * Message signaling that the join process has failed and needs to be aborted.
Review Comment:
Renamed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
