rpuch commented on code in PR #5255:
URL: https://github.com/apache/ignite-3/pull/5255#discussion_r1981118741
##########
modules/network/src/main/java/org/apache/ignite/internal/network/scalecube/ScaleCubeTopologyService.java:
##########
@@ -187,8 +190,9 @@ public ClusterNode getByAddress(NetworkAddress addr) {
/** {@inheritDoc} */
@Override
- public ClusterNode getByConsistentId(String consistentId) {
- return consistentIdToMemberMap.get(consistentId);
+ public @Nullable ClusterNode getByConsistentId(String consistentId) {
+ Map<UUID, ClusterNode> nodes =
consistentIdToMemberMap.get(consistentId);
+ return nodes != null ? nodes.values().iterator().next() : null;
Review Comment:
I think we can achieve this at least in one of the following ways:
1. Extract LogicalTopology, listener and whatever is needed to a module like
`logical-topology-api` and use it in the `network` module
2. Introduce an interface `JoinedNodes` having methods `joined()` and
`left()` in `network-api`, implement it in `ScaleCubeTopologyService` and call
its methods from `LogicalTopologyImpl` (here, logical topology would depend on
physical topology)
3. Same as 2, but some component external to both logical topology and
cluster service (maybe `IgniteImpl` itself) installs a listener on
LogicalTopology, and this listener calls `JoinedNodes`' methods
Item 2 seems to be preferrable to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
