Re: [PATCH v10 3/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2021-01-20 Thread Lukasz Stelmach
It was <2021-01-15 pią 17:27>, when Jakub Kicinski wrote: > On Wed, 13 Jan 2021 19:40:28 +0100 Łukasz Stelmach wrote: >> ASIX AX88796[1] is a versatile ethernet adapter chip, that can be >> connected to a CPU with a 8/16-bit bus or with an SPI. This driver >> supports SPI connection. >> >> The dri

Re: [PATCH v8 3/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-12-15 Thread Lukasz Stelmach
It was <2020-12-04 pią 19:37>, when Jakub Kicinski wrote: > On Wed, 2 Dec 2020 22:47:09 +0100 Łukasz Stelmach wrote: >> ASIX AX88796[1] is a versatile ethernet adapter chip, that can be >> connected to a CPU with a 8/16-bit bus or with an SPI. This driver >> supports SPI connection. >> Before we

Re: [PATCH v8 3/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-12-16 Thread Lukasz Stelmach
It was <2020-12-15 wto 17:46>, when Jakub Kicinski wrote: > On Wed, 16 Dec 2020 01:42:03 +0100 Lukasz Stelmach wrote: >>>> + ax_local->stats.rx_packets++; >>>> + ax_local->stats.rx_bytes += skb->len; >>>> + skb->dev = ndev; >&g

Re: [PATCH v8 3/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-12-17 Thread Lukasz Stelmach
It was <2020-12-16 śro 08:13>, when Jakub Kicinski wrote: > On Wed, 16 Dec 2020 13:21:52 +0100 Lukasz Stelmach wrote: >> So, the only thing that's left is pskb_expand_head(). I need to wrap my >> head around it. Can you tell me how a cloned skb is different and why >&

Re: [PATCH v9 3/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-12-17 Thread Lukasz Stelmach
It was <2020-12-17 czw 11:08>, when Jakub Kicinski wrote: > On Thu, 17 Dec 2020 12:53:30 +0100 Łukasz Stelmach wrote: >> ASIX AX88796[1] is a versatile ethernet adapter chip, that can be >> connected to a CPU with a 8/16-bit bus or with an SPI. This driver >> supports SPI connection. >> >> The dri

Re: [PATCH v7 3/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-12-02 Thread Lukasz Stelmach
It was <2020-11-25 śro 13:26>, when Jakub Kicinski wrote: > On Tue, 24 Nov 2020 13:03:30 +0100 Łukasz Stelmach wrote: >> +static int >> +ax88796c_start_xmit(struct sk_buff *skb, struct net_device *ndev) >> +{ >> +struct ax88796c_device *ax_local = to_ax88796c_device(ndev); >> + >> +skb_queu

Re: [PATCH v7 3/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-12-02 Thread Lukasz Stelmach
It was <2020-12-02 śro 09:18>, when Jakub Kicinski wrote: > On Wed, 02 Dec 2020 11:46:28 +0100 Lukasz Stelmach wrote: >> >> + status = netif_rx(skb); >> > >> > If I'm reading things right this is in process context, so netif_rx_ni() >

Re: [PATCH v7 3/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-11-24 Thread Lukasz Stelmach
It was <2020-11-24 wto 13:17>, when Krzysztof Kozlowski wrote: > On Tue, Nov 24, 2020 at 01:03:30PM +0100, Łukasz Stelmach wrote: >> ASIX AX88796[1] is a versatile ethernet adapter chip, that can be >> connected to a CPU with a 8/16-bit bus or with an SPI. This driver >> supports SPI connection. >>

Re: [PATCH v6 3/5] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-11-16 Thread Lukasz Stelmach
It was <2020-11-13 pią 12:35>, when Jakub Kicinski wrote: > On Thu, 12 Nov 2020 12:51:04 +0100 Łukasz Stelmach wrote: >> ASIX AX88796[1] is a versatile ethernet adapter chip, that can be >> connected to a CPU with a 8/16-bit bus or with an SPI. This driver >> supports SPI connection. >> >> The dri

Re: [PATCH v2 2/4] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-10-19 Thread Lukasz Stelmach
It was <2020-10-02 pią 22:36>, when Andrew Lunn wrote: >> +static int >> +ax88796c_open(struct net_device *ndev) >> +{ >> +struct ax88796c_device *ax_local = to_ax88796c_device(ndev); >> +int ret; >> +unsigned long irq_flag = IRQF_SHARED; >> + >> +mutex_lock(&ax_local->spi_lock); >>

Re: [PATCH v3 3/5] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-10-22 Thread Lukasz Stelmach
It was <2020-10-22 czw 09:15>, when Marek Szyprowski wrote: > On 21.10.2020 23:49, Łukasz Stelmach wrote: >> ASIX AX88796[1] is a versatile ethernet adapter chip, that can be >> connected to a CPU with a 8/16-bit bus or with an SPI. This driver >> supports SPI connection. >> >> The driver has been

Re: [PATCH v3 2/5] dt-bindings: net: Add bindings for AX88796C SPI Ethernet Adapter

2020-10-23 Thread Lukasz Stelmach
It was <2020-10-23 pią 18:27>, when Krzysztof Kozlowski wrote: > On Fri, 23 Oct 2020 at 18:05, Rob Herring wrote: >> >> On Wed, 21 Oct 2020 23:49:07 +0200, Łukasz Stelmach wrote: >> > Add bindings for AX88796C SPI Ethernet Adapter. >> > >> > Signed-off-by: Łukasz Stelmach >> > --- >> > .../bindi

Re: [PATCH v4 3/5] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-10-29 Thread Lukasz Stelmach
It was <2020-10-29 czw 01:31>, when Andrew Lunn wrote: >> +static void >> +ax88796c_get_regs(struct net_device *ndev, struct ethtool_regs *regs, void >> *_p) >> +{ >> +struct ax88796c_device *ax_local = to_ax88796c_device(ndev); >> +u16 *p = _p; >> +int offset, i; > > You missed a reve

Re: [PATCH v4 2/5] dt-bindings: net: Add bindings for AX88796C SPI Ethernet Adapter

2020-10-29 Thread Lukasz Stelmach
It was <2020-10-29 czw 18:06>, when Marc Kleine-Budde wrote: > On 10/28/20 10:40 PM, Łukasz Stelmach wrote: >> Add bindings for AX88796C SPI Ethernet Adapter. >> >> Signed-off-by: Łukasz Stelmach >> --- >> .../bindings/net/asix,ax88796c.yaml | 69 +++ >> 1 file changed,

Re: [PATCH v4 3/5] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-10-29 Thread Lukasz Stelmach
It was <2020-10-29 czw 01:31>, when Andrew Lunn wrote: > > Reverse christmass tree > >> + >> +static int ax88796c_process_isr(struct ax88796c_device *ax_local) >> +{ >> +u16 isr; >> +u8 done = 0; >> +struct net_device *ndev = ax_local->ndev; > > ... > >> +static irqreturn_t ax88796c_int

Re: [PATCH v4 3/5] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-10-29 Thread Lukasz Stelmach
It was <2020-10-29 czw 18:27>, when Marc Kleine-Budde wrote: > On 10/28/20 10:40 PM, Łukasz Stelmach wrote: >> ASIX AX88796[1] is a versatile ethernet adapter chip, that can be >> connected to a CPU with a 8/16-bit bus or with an SPI. This driver >> supports SPI connection. >> >> The driver has be

[BUG] ax88179_178a - broken hw checksumming after resume

2020-11-03 Thread Lukasz Stelmach
Hi, I've got a generic AX88179 based USB ethernet interface and I am experiencing a following problem. + After resuming from suspend + hw tx-checksuming doesn't work + for UDP packets. I've got an RPi4 on the other end of the cable. To test the connection I use the following commands tcptracero

Re: [PATCH v5 3/5] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-11-04 Thread Lukasz Stelmach
It was <2020-11-04 śro 03:42>, when Andrew Lunn wrote: >> +config SPI_AX88796C_COMPRESSION >> +bool "SPI transfer compression" >> +default n >> +depends on SPI_AX88796C >> +help >> + Say Y here to enable SPI transfer compression. It saves up >> + to 24 dummy cycles during

Re: [PATCH 1/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-09-07 Thread Lukasz Stelmach
It was <2020-08-25 wto 20:01>, when Andrew Lunn wrote: > Hi Łukasz > > It is pretty clear this is a "vendor crap driver". I can't deny. > It needs quite a bit more work on it. I'll be more than happy to take your suggestions. > On Tue, Aug 25, 2020 at 07:03:09PM +0200, Łukasz Stelmach wrote: >

Re: [PATCH 1/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-09-07 Thread Lukasz Stelmach
It was <2020-08-26 śro 09:13>, when Geert Uytterhoeven wrote: > On Tue, Aug 25, 2020 at 8:02 PM Andrew Lunn wrote: >> On Tue, Aug 25, 2020 at 07:03:09PM +0200, Łukasz Stelmach wrote: >> > + if (netif_msg_pktdata(ax_local)) { >> > + int loop; >> > + netdev_info(ndev, "TX

Re: [PATCH 1/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-09-07 Thread Lukasz Stelmach
It was <2020-08-26 śro 15:06>, when David Laight wrote: > From: Lukasz Stelmach >> Sent: 26 August 2020 15:59 >> >> It was <2020-08-25 wto 20:44>, when Krzysztof Kozlowski wrote: >> > On Tue, Aug 25, 2020 at 07:03:09PM +0200, Łukasz Stelmach wrote: >

Re: [PATCH 1/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-09-08 Thread Lukasz Stelmach
It was <2020-09-07 pon 20:18>, when Andrew Lunn wrote: >> > On Tue, Aug 25, 2020 at 07:03:09PM +0200, Łukasz Stelmach wrote: >> >> +++ b/drivers/net/ethernet/asix/ax88796c_ioctl.c >> > >> > This is an odd filename. The ioctl code is wrong anyway, but there is >> > a lot more than ioctl in here. I s

Re: [PATCH v2 0/4] AX88796C SPI Ethernet Adapter

2020-10-06 Thread Lukasz Stelmach
It was <2020-10-02 pią 21:45>, when Andrew Lunn wrote: > On Fri, Oct 02, 2020 at 09:22:06PM +0200, Łukasz Stelmach wrote: >> This is a driver for AX88796C Ethernet Adapter connected in SPI mode as >> found on ARTIK5 evaluation board. The driver has been ported from a >> v3.10.9 vendor kernel for AR

Re: [PATCH v2 3/4] ARM: dts: exynos: Add Ethernet to Artik 5 board

2020-10-06 Thread Lukasz Stelmach
It was <2020-10-03 sob 12:13>, when Krzysztof Kozlowski wrote: > On Fri, 2 Oct 2020 at 21:22, Łukasz Stelmach wrote: >> >> Add node for ax88796c ethernet chip. >> >> Signed-off-by: Łukasz Stelmach >> --- >> arch/arm/boot/dts/exynos3250-artik5-eval.dts | 21 >> 1 file changed

Re: [PATCH v2 3/4] ARM: dts: exynos: Add Ethernet to Artik 5 board

2020-10-06 Thread Lukasz Stelmach
It was <2020-10-06 wto 12:17>, when Krzysztof Kozlowski wrote: > On Tue, 6 Oct 2020 at 12:06, Lukasz Stelmach wrote: >> It was <2020-10-03 sob 12:13>, when Krzysztof Kozlowski wrote: >>> On Fri, 2 Oct 2020 at 21:22, Łukasz Stelmach wrote: >>>>

Re: [PATCH v2 2/4] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-10-13 Thread Lukasz Stelmach
It was <2020-10-03 sob 14:59>, when Heiner Kallweit wrote: > On 02.10.2020 21:22, Łukasz Stelmach wrote: >> ASIX AX88796[1] is a versatile ethernet adapter chip, that can be >> connected to a CPU with a 8/16-bit bus or with an SPI. This driver >> supports SPI connection. >> >> The driver has been

Re: [PATCH v2 2/4] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-10-13 Thread Lukasz Stelmach
It was <2020-10-02 pią 22:36>, when Andrew Lunn wrote: >> +static u32 ax88796c_get_link(struct net_device *ndev) >> +{ >> +struct ax88796c_device *ax_local = to_ax88796c_device(ndev); >> + >> +mutex_lock(&ax_local->spi_lock); >> + >> +phy_read_status(ndev->phydev); >> + >> +mutex_un

Re: [PATCH] net: phy: Prevent reporting advertised modes when autoneg is off

2020-10-14 Thread Lukasz Stelmach
It was <2020-10-14 śro 14:32>, when Russell King - ARM Linux admin wrote: > On Wed, Oct 14, 2020 at 02:56:50PM +0200, Łukasz Stelmach wrote: >> Do not report advertised link modes when autonegotiation is turned >> off. mii_ethtool_get_link_ksettings() exhibits the same behaviour. > > Please explain

Re: [PATCH] net: phy: Prevent reporting advertised modes when autoneg is off

2020-10-14 Thread Lukasz Stelmach
It was <2020-10-14 śro 23:04>, when Russell King - ARM Linux admin wrote: > On Wed, Oct 14, 2020 at 04:39:47PM +0200, Lukasz Stelmach wrote: >> It was <2020-10-14 śro 14:32>, when Russell King - ARM Linux admin wrote: >> > In any case, the mii.c code does fil

Re: [PATCH v2 2/4] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-10-16 Thread Lukasz Stelmach
It was <2020-10-16 pią 20:01>, when Andrew Lunn wrote: >> >> +static void >> >> +ax88796c_get_regs(struct net_device *ndev, struct ethtool_regs *regs, >> >> void *_p) >> >> +{ >> >> + struct ax88796c_device *ax_local = to_ax88796c_device(ndev); >> >> + u16 *p = _p; >> >> + int offset, i; >> >> + >

Re: [PATCH v2] net: phy: Prevent reporting advertised modes when autoneg is off

2020-10-16 Thread Lukasz Stelmach
It was <2020-10-16 pią 20:09>, when Andrew Lunn wrote: > On Thu, Oct 15, 2020 at 10:44:35AM +0200, Łukasz Stelmach wrote: >> Do not report advertised link modes (local and remote) when >> autonegotiation is turned off. mii_ethtool_get_link_ksettings() exhibits >> the same behaviour and this patch a

Re: [PATCH 1/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-08-25 Thread Lukasz Stelmach
It was <2020-08-25 wto 10:19>, when Randy Dunlap wrote: > On 8/25/20 10:03 AM, Łukasz Stelmach wrote: >> diff --git a/drivers/net/ethernet/asix/Kconfig >> b/drivers/net/ethernet/asix/Kconfig >> new file mode 100644 >> index ..4b127a4a659a >> --- /dev/null >> +++ b/drivers/net/ethernet/

Re: [PATCH 3/3] ARM: defconfig: Enable ax88796c driver

2020-08-25 Thread Lukasz Stelmach
It was <2020-08-25 wto 20:51>, when Krzysztof Kozlowski wrote: > On Tue, Aug 25, 2020 at 07:03:11PM +0200, Łukasz Stelmach wrote: >> Enable ax88796c driver for the ethernet chip on Exynos3250-based >> ARTIK5 boards. >> >> Signed-off-by: Łukasz Stelmach >> --- >> arch/arm/configs/exynos_defconfig

Re: [PATCH 1/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-08-26 Thread Lukasz Stelmach
It was <2020-08-25 wto 20:44>, when Krzysztof Kozlowski wrote: > On Tue, Aug 25, 2020 at 07:03:09PM +0200, Łukasz Stelmach wrote: >> ASIX AX88796[1] is a versatile ethernet adapter chip, that can be >> connected to a CPU with a 8/16-bit bus or with an SPI. This driver >> supports SPI connection. >>

Re: [PATCH] net/smscx5xx: change to of_get_mac_address() eth_platform_get_mac_address()

2020-10-02 Thread Lukasz Stelmach
It was <2020-10-01 czw 19:45>, when Florian Fainelli wrote: > On 10/1/2020 7:05 PM, David Miller wrote: >> From: Łukasz Stelmach >> Date: Wed, 30 Sep 2020 16:25:25 +0200 >> >>> Use more generic eth_platform_get_mac_address() which can get a MAC >>> address from other than DT platform specific sour

ipv6 source address selection in addrconf.c (2.6.17)

2006-06-20 Thread Lukasz Stelmach
Greetings. net/ipv6/addrconf.c:971 is /* Rule 2: Prefer appropriate scope */ if (hiscore.rule < 2) { hiscore.scope = __ipv6_addr_src_scope(hiscore.addr_type); hiscore.rule++; } I am afraid, that it does not make any sense for I find no place where a value is assigned to hiscore.ad

[patch] ipv6 source address selection in addrconf.c (2.6.17)

2006-06-21 Thread Lukasz Stelmach
Lukasz Stelmach wrote: > I found it when I was trying to figure out why when trying to connect to > > 2001:200:0:8002:203:47ff:fea5:3085 (www.kame.net) > > with two global addresses assigned to the ethernet card > > fd24:6f44:46bd:face::254 > 2002:531f:d667:face::254 &

Re: [patch] ipv6 source address selection in addrconf.c (2.6.17)

2006-06-21 Thread Lukasz Stelmach
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 - --- linux/net/ipv6/addrconf.c.orig2006-06-21 11:41:22.0 +0200 +++ linux/net/ipv6/addrconf.c 2006-06-21 17:18:56.0 +0200 @@ -862,6 +862,8 @@ static int inline ipv6_saddr_label(const *2002::/16 2 *::/9

Re: ipv6 source address selection in addrconf.c (2.6.17)

2006-06-21 Thread Lukasz Stelmach
Lukasz Stelmach wrote: > Lukasz Stelmach wrote: > >> [...] when trying to connect to >> >> 2001:200:0:8002:203:47ff:fea5:3085 (www.kame.net) >> >> with two global addresses assigned to the ethernet card >> >> fd24:6f44:46bd:face::254 >> 2002:

Re: ipv6 source address selection in addrconf.c (2.6.17)

2006-06-22 Thread Lukasz Stelmach
YOSHIFUJI Hideaki / 吉藤英明 wrote: > In article <[EMAIL PROTECTED]> (at Thu, 22 Jun 2006 00:57:56 +0200), Lukasz > Stelmach <[EMAIL PROTECTED]> says: > >> Lukasz Stelmach wrote: >>> Lukasz Stelmach wrote: [] >> >> fd24:6f44:46bd:face:EUI64 fd2