It was <2020-10-16 pią 20:09>, when Andrew Lunn wrote: > On Thu, Oct 15, 2020 at 10:44:35AM +0200, Łukasz Stelmach wrote: >> Do not report advertised link modes (local and remote) when >> autonegotiation is turned off. mii_ethtool_get_link_ksettings() exhibits >> the same behaviour and this patch aims at unifying the behavior of both >> functions. > > Does ethtool allow you to configure advertised modes with autoneg off? > If it can, it would be useful to see what is being configured, before > it is actually turned on. > > ethtool -s eth42 autoneg off advertise 0xf > > does not give an error on an interface i have.
Yes, this is a good point. Do you think I should change the if()[1] in mii_ethtool_get_link_ksettings() instead? I really think these two function should report the same. [1] https://elixir.bootlin.com/linux/v5.9/source/drivers/net/mii.c#L174 [2] https://elixir.bootlin.com/linux/v5.9/source/drivers/net/mii.c#L145 Kind regards, -- Łukasz Stelmach Samsung R&D Institute Poland Samsung Electronics
signature.asc
Description: PGP signature
