Bump
On 6/6/19 8:16 AM, Dan Murphy wrote:
Marc
Bump
On 5/31/19 6:51 AM, Dan Murphy wrote:
Marc
On 5/15/19 3:54 PM, Dan Murphy wrote:
Marc
On 5/9/19 11:11 AM, Dan Murphy wrote:
Create a m_can platform framework that peripheral
devices can register to and use common code and register sets
Hello
On 7/10/19 7:08 AM, Dan Murphy wrote:
Hello
On 6/17/19 10:09 AM, Dan Murphy wrote:
Marc
On 6/10/19 11:35 AM, Dan Murphy wrote:
Bump
On 6/6/19 8:16 AM, Dan Murphy wrote:
Marc
Bump
On 5/31/19 6:51 AM, Dan Murphy wrote:
Marc
On 5/15/19 3:54 PM, Dan Murphy wrote:
Marc
On 5/9/19 11
Konstantin
On 7/29/19 6:19 AM, FIXED-TERM Buecheler Konstantin (ETAS-SEC/ECT-Mu) wrote:
Hi all,
I am currently working on a project where I am trying to use the tcan4550 chip
with a Raspberry PI 3B.
I am struggling to create a working device tree overlay file for the Raspberry
Pi.
Has anyone
Andrew
On 11/19/20 7:49 PM, Andrew Lunn wrote:
+static int dp83td510_config_init(struct phy_device *phydev)
+{
+ struct dp83td510_private *dp83td510 = phydev->priv;
+ int ret = 0;
+
+ if (phy_interface_is_rgmii(phydev)) {
+ if (dp83td510->rgmii_delay) {
+
fixes this problem by changing the case to CAN_STATE_ERROR_WARNING.
Signed-off-by: Wu Bo
Link: http://lore.kernel.org/r/20200129022330.21248-2-wubo.o...@gmail.com
Cc: Dan Murphy
Fixes: e0d1f4816f2a ("can: m_can: add Bosch M_CAN controller support")
Signed-off-by: Marc Kleine-Budde
---
d
Marc
On 11/15/20 11:41 AM, Marc Kleine-Budde wrote:
Change the order in tcan4x5x_can_remove() to be the exact inverse of
tcan4x5x_can_probe(). First m_can_class_unregister(), then power down the
device.
Fixes: 5443c226ba91 ("can: tcan4x5x: Add tcan4x5x driver to the kernel")
Cc:
Marc
On 11/15/20 11:41 AM, Marc Kleine-Budde wrote:
This patch adds the missing error checking when initializing the regmap
interface fails.
Fixes: 5443c226ba91 ("can: tcan4x5x: Add tcan4x5x driver to the kernel")
Cc: Dan Murphy
Link: http://lore.kernel.org/r/20201019154233
x27;s
capability.
Dan
Dan Murphy (4):
ethtool: Add 10base-T1L link mode entries
dt-bindings: net: Add Rx/Tx output configuration for 10base T1L
dt-bindings: dp83td510: Add binding for DP83TD510 Ethernet PHY
net: phy: dp83td510: Add support for the DP83TD510 Ethernet PHY
.../devicetree/binding
a top level ethernet document.
Signed-off-by: Dan Murphy
---
Documentation/devicetree/bindings/net/ethernet-phy.yaml | 6 ++
1 file changed, 6 insertions(+)
diff --git a/Documentation/devicetree/bindings/net/ethernet-phy.yaml
b/Documentation/devicetree/bindings/net/ethernet-phy.yaml
to auto negotiation to
determine the proper p2p voltage.
Signed-off-by: Dan Murphy
---
v4 - Considerable rework of the code after secondary test setup was created.
This version also uses the handle_interrupt call back and reduces the
configuration arrays as it was determined that 80% of the
PHYAD: 1
Transceiver: external
Supports Wake-on: gs
Wake-on: d
SecureOn password: 00:00:00:00:00:00
Current message level: 0x (0)
Link detected: yes
Reviewed-by: Andrew Lunn
Reviewed-by: Florian Fainelli
Signed-off-by: Dan Murphy
The DP83TD510 is a 10M single twisted pair Ethernet PHY
Signed-off-by: Dan Murphy
---
.../devicetree/bindings/net/ti,dp83td510.yaml | 64 +++
1 file changed, 64 insertions(+)
create mode 100644 Documentation/devicetree/bindings/net/ti,dp83td510.yaml
diff --git a/Documentation
Andrew
On 11/17/20 2:31 PM, Andrew Lunn wrote:
On Tue, Nov 17, 2020 at 02:15:53PM -0600, Dan Murphy wrote:
Per the 802.3cg spec the 10base T1L can operate at 2 different
differential voltages 1v p2p and 2.4v p2p. The abiility of the PHY to
ability
Ack
drive that output is dependent on the
Andrew
On 10/16/20 5:02 PM, Andrew Lunn wrote:
On Thu, Oct 08, 2020 at 11:23:47AM -0500, Dan Murphy wrote:
The DP83TD510E is an ultra-low power Ethernet physical layer transceiver
that supports 10M single pair cable.
Hi Dan
I think you are going to have to add
Andrew
On 10/19/20 4:55 PM, Andrew Lunn wrote:
On Mon, Oct 19, 2020 at 04:33:18PM -0500, Dan Murphy wrote:
Andrew
On 10/16/20 5:02 PM, Andrew Lunn wrote:
On Thu, Oct 08, 2020 at 11:23:47AM -0500, Dan Murphy wrote:
The DP83TD510E is an ultra-low power Ethernet physical layer transceiver
that
Andrew
On 10/19/20 5:04 PM, Dan Murphy wrote:
Andrew
On 10/19/20 4:55 PM, Andrew Lunn wrote:
On Mon, Oct 19, 2020 at 04:33:18PM -0500, Dan Murphy wrote:
Andrew
On 10/16/20 5:02 PM, Andrew Lunn wrote:
On Thu, Oct 08, 2020 at 11:23:47AM -0500, Dan Murphy wrote:
The DP83TD510E is an ultra-low
: MII
PHYAD: 1
Transceiver: external
Supports Wake-on: gs
Wake-on: d
SecureOn password: 00:00:00:00:00:00
Current message level: 0x (0)
Link detected: yes
Signed-off-by: Dan Murphy
---
drivers/net/phy/phy-core.c | 4 +++-
include/uapi
The DP83TD510 is a 10M single twisted pair Ethernet PHY
Signed-off-by: Dan Murphy
---
.../devicetree/bindings/net/ti,dp83td510.yaml | 72 +++
1 file changed, 72 insertions(+)
create mode 100644 Documentation/devicetree/bindings/net/ti,dp83td510.yaml
diff --git a/Documentation
to auto negotiation to
determine the proper p2p voltage.
Signed-off-by: Dan Murphy
---
drivers/net/phy/Kconfig | 6 +
drivers/net/phy/Makefile| 1 +
drivers/net/phy/dp83td510.c | 600
3 files changed, 607 insertions(+)
create mode 100644 drivers
x27;s
capability.
Dan
Dan Murphy (3):
ethtool: Add 10base-T1L link mode entries
dt-bindings: dp83td510: Add binding for DP83TD510 Ethernet PHY
net: phy: dp83td510: Add support for the DP83TD510 Ethernet PHY
.../devicetree/bindings/net/ti,dp83td510.yaml | 72 +++
drivers/net/phy/Kc
Andrew
On 10/20/20 2:07 PM, Andrew Lunn wrote:
Humm. Are 1v and 2.4v advertised so it can be auto negotiated? Maybe a
PHY tunable is not correct? Is this voltage selection actually more
like pause and EEE?
[Goes and looks at the datasheet]
Register 0x20E, bit 13:
1 = Advertise that the 10BASE
x27;s
capability.
Dan
Dan Murphy (4):
ethtool: Add 10base-T1L link mode entries
dt-bindings: net: Add Rx/Tx output configuration for 10base T1L
dt-bindings: dp83td510: Add binding for DP83TD510 Ethernet PHY
net: phy: dp83td510: Add support for the DP83TD510 Ethernet PHY
.../devicetree/binding
PHYAD: 1
Transceiver: external
Supports Wake-on: gs
Wake-on: d
SecureOn password: 00:00:00:00:00:00
Current message level: 0x (0)
Link detected: yes
Signed-off-by: Dan Murphy
---
drivers/net/phy/phy-core.c | 4 +++-
include/uapi/linux
to auto negotiation to
determine the proper p2p voltage.
Signed-off-by: Dan Murphy
---
drivers/net/phy/Kconfig | 6 +
drivers/net/phy/Makefile| 1 +
drivers/net/phy/dp83td510.c | 681
3 files changed, 688 insertions(+)
create mode 100644 drivers
The DP83TD510 is a 10M single twisted pair Ethernet PHY
Signed-off-by: Dan Murphy
---
.../devicetree/bindings/net/ti,dp83td510.yaml | 62 +++
1 file changed, 62 insertions(+)
create mode 100644 Documentation/devicetree/bindings/net/ti,dp83td510.yaml
diff --git a/Documentation
a top level ethernet document.
Signed-off-by: Dan Murphy
---
Documentation/devicetree/bindings/net/ethernet-phy.yaml | 5 +
1 file changed, 5 insertions(+)
diff --git a/Documentation/devicetree/bindings/net/ethernet-phy.yaml
b/Documentation/devicetree/bindings/net/ethernet-phy.yaml
Andrew
On 10/30/20 2:56 PM, Andrew Lunn wrote:
On Fri, Oct 30, 2020 at 12:29:48PM -0500, Dan Murphy wrote:
Per the 802.3cg spec the 10base T1L can operate at 2 different
differential voltages 1v p2p and 2.4v p2p. The abiility of the PHY to
drive that output is dependent on the PHY's on
Andrew
On 10/30/20 3:15 PM, Andrew Lunn wrote:
+static int dp83td510_config_init(struct phy_device *phydev)
+{
+ struct dp83td510_private *dp83td510 = phydev->priv;
+ int mst_slave_cfg;
+ int ret = 0;
+
+ if (phy_interface_is_rgmii(phydev)) {
+ if (dp83td510
Hello
On 10/30/20 6:03 PM, Jakub Kicinski wrote:
On Fri, 30 Oct 2020 12:29:50 -0500 Dan Murphy wrote:
The DP83TD510E is an ultra-low power Ethernet physical layer transceiver
that supports 10M single pair cable.
The device supports both 2.4-V p2p and 1-V p2p output voltage as defined
by IEEE
Andrew
On 11/3/20 11:21 AM, Andrew Lunn wrote:
On Tue, Nov 03, 2020 at 11:09:44AM -0600, Dan Murphy wrote:
Hello
On 10/30/20 6:03 PM, Jakub Kicinski wrote:
On Fri, 30 Oct 2020 12:29:50 -0500 Dan Murphy wrote:
The DP83TD510E is an ultra-low power Ethernet physical layer transceiver
that
Andrew
On 11/3/20 11:18 AM, Andrew Lunn wrote:
On Tue, Nov 03, 2020 at 11:07:00AM -0600, Dan Murphy wrote:
Andrew
On 10/30/20 3:15 PM, Andrew Lunn wrote:
+static int dp83td510_config_init(struct phy_device *phydev)
+{
+ struct dp83td510_private *dp83td510 = phydev->priv;
+
/description
Signed-off-by: Dan Murphy
---
drivers/net/phy/dp83822.c | 42 ---
1 file changed, 39 insertions(+), 3 deletions(-)
diff --git a/drivers/net/phy/dp83822.c b/drivers/net/phy/dp83822.c
index 6e8a2a4f3a6e..5c379ff25dac 100644
--- a/drivers/net/phy/dp83822
All
On 05/08/2018 09:11 AM, Dan Murphy wrote:
> Add support for the DP83811 phy by extending
> the DP83822 driver to recognize the PHY IDs.
>
> The DP83811 supports both rgmii and sgmii interfaces.
> There are 2 part numbers for this the DP83811R does not
> reliably support t
Andrew
On 05/08/2018 11:49 AM, Andrew Lunn wrote:
> On Tue, May 08, 2018 at 10:56:55AM -0500, Dan Murphy wrote:
>> All
>>
>> On 05/08/2018 09:11 AM, Dan Murphy wrote:
>>> Add support for the DP83811 phy by extending
>>> the DP83822 driver to recognize th
Florian
On 05/08/2018 12:14 PM, Florian Fainelli wrote:
> On 05/08/2018 10:13 AM, Dan Murphy wrote:
>> Andrew
>>
>> On 05/08/2018 11:49 AM, Andrew Lunn wrote:
>>> On Tue, May 08, 2018 at 10:56:55AM -0500, Dan Murphy wrote:
>>>> All
>>>>
&g
this is controlled via the DT
to indicate which phy mode is required. Or the part can be
strapped to a certain interface.
Data sheet can be found here:
http://www.ti.com/product/DP83TC811S-Q1/description
http://www.ti.com/product/DP83TC811R-Q1/description
Signed-off-by: Dan Murphy
---
drivers/net
at
> soon after the reset.
OK I will remove it.
>
>> +
>> +return 0;
>> +}
>> +
>
>> +static struct phy_driver dp83811_driver[] = {
>> +{
>> +.phy_id = DP83TC811_PHY_ID,
>> +.phy_id_mask = 0xfff0,
>> +.name = "TI DP83TC811",
>> +.features = PHY_BASIC_FEATURES,
>> +.flags = PHY_HAS_INTERRUPT,
>> +.config_init = genphy_config_init,
>
>
>
I missed that I must have had the config init being called in my testing
through the reset function.
I will update.
> Andrew
>
--
--
Dan Murphy
Andrew
On 05/09/2018 08:58 AM, Andrew Lunn wrote:
> On Wed, May 09, 2018 at 08:50:58AM -0500, Dan Murphy wrote:
>> Andrew
>>
>> Thanks for the review
>>
>> On 05/09/2018 08:43 AM, Andrew Lunn wrote:
>>>> +static int dp83811_config_aneg(struc
this is controlled via the DT
to indicate which phy mode is required. Or the part can be
strapped to a certain interface.
Data sheet can be found here:
http://www.ti.com/product/DP83TC811S-Q1/description
http://www.ti.com/product/DP83TC811R-Q1/description
Signed-off-by: Dan Murphy
---
v2 - Remove
this is controlled via the DT
to indicate which phy mode is required. Or the part can be
strapped to a certain interface.
Data sheet can be found here:
http://www.ti.com/product/DP83TC811S-Q1/description
http://www.ti.com/product/DP83TC811R-Q1/description
Signed-off-by: Dan Murphy
---
v3
Andrew
On 05/11/2018 01:30 PM, Andrew Lunn wrote:
> On Fri, May 11, 2018 at 01:08:19PM -0500, Dan Murphy wrote:
>> Add support for the DP83811 phy.
>>
>> The DP83811 supports both rgmii and sgmii interfaces.
>> There are 2 part numbers for this the DP83TC811R does
Bump
On 2/14/19 12:27 PM, Dan Murphy wrote:
> Hello
>
> OK I did not give up on this patch series just got a little preoccupied with
> some other kernel work. But here is the update per the comments.
>
> It should be understood I broke these out for reviewability.
> F
d of this week!
>>
>> Wolfgang.
>>
>> Am 21.02.19 um 17:24 schrieb Dan Murphy:
>>> Bump
>>>
>>> On 2/14/19 12:27 PM, Dan Murphy wrote:
>>>> Hello
>>>>
>>>> OK I did not give up on this patch series just got a little
Wolfgang
On 2/22/19 6:50 AM, Dan Murphy wrote:
> Wolfgang
>
> On 2/22/19 3:38 AM, Wolfgang Grandegger wrote:
>> Hello Dan,
>>
>> what kernel version is that patch series for. I have problems to apply it!
>>
>
> It is based off of Master
>
> co
Wolfgang
On 2/24/19 5:27 AM, Wolfgang Grandegger wrote:
> Hello Dan,
>
> Am 22.02.19 um 18:05 schrieb Dan Murphy:
>> Wolfgang
>>
>> On 2/22/19 6:50 AM, Dan Murphy wrote:
>>> Wolfgang
>>>
>>> On 2/22/19 3:38 AM, Wolfgang Grandegger wrote:
Wolfgang
On 2/28/19 10:40 AM, Wolfgang Grandegger wrote:
> Hello,
>
> Am 14.02.19 um 19:27 schrieb Dan Murphy:
>> Hello
>>
>> OK I did not give up on this patch series just got a little preoccupied with
>> some other kernel work. But here is the update per
Wolfgang
On 2/28/19 11:33 AM, Wolfgang Grandegger wrote:
> Am 14.02.19 um 19:27 schrieb Dan Murphy:
>> Migrate the m_can code to use the m_can_platform framework
>> code.
>>
>> Signed-off-by: Dan Murphy
>> ---
>>
>> v5 - Updated copyright, chang
Wolfgang
On 2/28/19 11:50 AM, Wolfgang Grandegger wrote:
>
>
> Am 14.02.19 um 19:27 schrieb Dan Murphy:
>> Add the TCAN4x5x SPI CAN driver. This device
>> uses the Bosch MCAN IP core along with a SPI
>> interface map. Leverage the MCAN common core
>> code
Hello
On 2/28/19 1:41 PM, Wolfgang Grandegger wrote:
> Hello Dan,
>
> Am 28.02.19 um 18:57 schrieb Dan Murphy:
>> Wolfgang
>>
>> On 2/28/19 11:33 AM, Wolfgang Grandegger wrote:
>>> Am 14.02.19 um 19:27 schrieb Dan Murphy:
>>>> Migrate the m_can co
Wolfgang
On 2/28/19 2:07 PM, Wolfgang Grandegger wrote:
>
> Am 28.02.19 um 19:03 schrieb Dan Murphy:
>>
>> Wolfgang
>>
>> On 2/28/19 11:50 AM, Wolfgang Grandegger wrote:
>>>
>>>
>>> Am 14.02.19 um 19:27 schrieb Dan Murphy:
>>>&
Wolfgang
On 2/28/19 2:12 PM, Wolfgang Grandegger wrote:
>
> Am 14.02.19 um 19:27 schrieb Dan Murphy:
>> Create a m_can platform framework that peripherial
>> devices can register to and use common code and register sets.
>> The peripherial devices may provide read
Rename the common m_can_priv class structure to
m_can_classdev as this is more descriptive.
Signed-off-by: Dan Murphy
---
v6 - No changes only rebase changes possibly can squash into the first patch -
https://lore.kernel.org/patchwork/patch/1042444/
drivers/net/can/m_can/m_can.c
Create a m_can platform framework that peripherial
devices can register to and use common code and register sets.
The peripherial devices may provide read/write and configuration
support of the IP.
Signed-off-by: Dan Murphy
---
v6 - Squashed platform patch to this patch for bissectablity, fixed
Add the TCAN4x5x SPI CAN driver. This device uses the
Bosch MCAN IP core along with a SPI interface map.
Register to the MCAN common core code to manage the MCAN IP.
This device has a special method to indicate a write/read
operation on the data payload.
Signed-off-by: Dan Murphy
---
v6
DT binding documentation for TI TCAN4x5x driver.
Signed-off-by: Dan Murphy
---
v6 - No changes - https://lore.kernel.org/patchwork/patch/1042445/
.../devicetree/bindings/net/can/tcan4x5x.txt | 37 +++
1 file changed, 37 insertions(+)
create mode 100644 Documentation
Wolfgang
On 3/4/19 10:56 AM, Wolfgang Grandegger wrote:
> Hello Dan,
>
> the series already looks quite good. I still realized a few (minor)
> issues while browsing the patch/code...
>
Thanks for the review. It is getting there.
> Am 01.03.19 um 19:50 schrieb Dan Murphy:
nstance
struct m_can_plat_priv *priv = (struct m_can_plat_priv
*)m_can_class->device_data;
will become
struct m_can_plat_priv *priv =
(struct m_can_plat_priv
*)m_can_class->device_data;
> Am 01.03.19 um 19:50 schrieb Dan Murphy:
>> Rename the
Wolfgang
On 3/4/19 12:29 PM, Wolfgang Grandegger wrote:
> Hello Dan,
>
> Am 01.03.19 um 19:50 schrieb Dan Murphy:
>> Add the TCAN4x5x SPI CAN driver. This device uses the
>> Bosch MCAN IP core along with a SPI interface map.
>> Register to the MCAN common core
Wolfgang
On 3/4/19 12:13 PM, Wolfgang Grandegger wrote:
>
>
> Am 04.03.19 um 18:22 schrieb Dan Murphy:
>> Wolfgang
>>
>> On 3/4/19 10:56 AM, Wolfgang Grandegger wrote:
>>> Hello Dan,
>>>
>>> the series already looks quite good. I still real
On 3/4/19 10:56 AM, Wolfgang Grandegger wrote:
> Hello Dan,
>
> the series already looks quite good. I still realized a few (minor)
> issues while browsing the patch/code...
>
> Am 01.03.19 um 19:50 schrieb Dan Murphy:
>> Create a m_can platform framework that peripherial
Create a m_can platform framework that peripherial
devices can register to and use common code and register sets.
The peripherial devices may provide read/write and configuration
support of the IP.
Signed-off-by: Dan Murphy
---
v7 - Fixed remaining new checkpatch issues, removed CSR setting
Rename the common m_can_priv class structure to
m_can_classdev as this is more descriptive.
Signed-off-by: Dan Murphy
---
v7 - Fixed remaining checkpatch issues, renamed priv to cdev -
https://lore.kernel.org/patchwork/patch/1047219/
v6 - No changes only rebase changes possibly can squash
Add the TCAN4x5x SPI CAN driver. This device uses the
Bosch MCAN IP core along with a SPI interface map.
Register to the MCAN common core code to manage the MCAN IP.
This device has a special method to indicate a write/read
operation on the data payload.
Signed-off-by: Dan Murphy
---
v7
DT binding documentation for TI TCAN4x5x driver.
Signed-off-by: Dan Murphy
---
v7 - Made device state optional -
https://lore.kernel.org/patchwork/patch/1047218/
v6 - No changes - https://lore.kernel.org/patchwork/patch/1042445/
.../devicetree/bindings/net/can/tcan4x5x.txt | 37
Wolfgang
On 3/8/19 4:25 AM, Wolfgang Grandegger wrote:
>
>
> Am 05.03.19 um 16:52 schrieb Dan Murphy:
>> Rename the common m_can_priv class structure to
>> m_can_classdev as this is more descriptive.
>>
>> Signed-off-by: Dan Murphy
>> ---
>>
>&
Wolfgang
On 3/8/19 4:10 AM, Wolfgang Grandegger wrote:
> Hallo Dan,
>
> Am 05.03.19 um 16:52 schrieb Dan Murphy:
>> Create a m_can platform framework that peripherial
>> devices can register to and use common code and register sets.
>> The peripherial devices
Wolfgang
On 3/8/19 8:41 AM, Wolfgang Grandegger wrote:
> Hello Dan,
>
> thinking more about it...
>
> Am 08.03.19 um 14:29 schrieb Wolfgang Grandegger:
>> Hello Dan,
>>
>> Am 08.03.19 um 13:44 schrieb Dan Murphy:
>>> Wolfgang
>>>
>>>
On 3/8/19 11:08 AM, Wolfgang Grandegger wrote:
> Hello,
>
> Am 08.03.19 um 16:48 schrieb Dan Murphy:
>> Wolfgang
>>
>> On 3/8/19 8:41 AM, Wolfgang Grandegger wrote:
>>> Hello Dan,
>>>
>>> thinking more about it...
>>>
>&
On 3/8/19 11:40 AM, Wolfgang Grandegger wrote:
> Hello Dan,
>
> Am 08.03.19 um 18:25 schrieb Dan Murphy:
>> On 3/8/19 11:08 AM, Wolfgang Grandegger wrote:
>>> Hello,
>>>
>>> Am 08.03.19 um 16:48 schrieb Dan Murphy:
>>>> Wolfgang
>>>&
On 3/8/19 12:06 PM, Wolfgang Grandegger wrote:
>
>
> Am 08.03.19 um 18:52 schrieb Dan Murphy:
>> On 3/8/19 11:40 AM, Wolfgang Grandegger wrote:
>>> Hello Dan,
>>>
>>> Am 08.03.19 um 18:25 schrieb Dan Murphy:
>>>> On 3/8/19 11:08 AM, Wolfgang
Marc
On 5/9/19 11:11 AM, Dan Murphy wrote:
> Create a m_can platform framework that peripheral
> devices can register to and use common code and register sets.
> The peripheral devices may provide read/write and configuration
> support of the IP.
>
> Acked-by: Wolfgang Grande
Forwarded message --
> Date: Thu, 5 Oct 2017 21:38:28 +0800
> From: kbuild test robot
> To: kbu...@01.org
> Cc: Julia Lawall
> Subject: Re: [PATCH] net: phy: DP83822 initial driver submission
>
> CC: kbuild-...@01.org
> In-Reply-To: <20171003155316.12312-1-dmur...@t
t; + genphy_suspend(phydev);
>
> Releasing the lock before calling genphy_suspend() is not so nice.
> Maybe add a version which assumes the lock has already been taken?
>
The marvell driver does not take a lock and calls genphy_suspend/resume
so I am wondering if this driver
er needs to take a lock.
The at803x needs to take the lock because it does not call into the genphy
functions.
I will submit a new version with the lock removed.
Dan
> Andrew
>
--
--
Dan Murphy
Removing the DP83822 device from the DP83848 to
support the TI DP83822 dedicated driver that will
initially support WoL settings.
Signed-off-by: Dan Murphy
---
v3 - No changes made
v2 - There was no v1 on this patch this is new.
drivers/net/phy/dp83848.c | 3 ---
1 file changed, 3 deletions
Change the return error code to EINVAL if the MAC
address is not valid in the set_wol function.
Signed-off-by: Dan Murphy
---
v3 - No changes made
v2 - There was no v1 on this patch this is new.
drivers/net/phy/at803x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
Add support for the TI DP83822 10/100Mbit ethernet phy.
The DP83822 provides flexibility to connect to a MAC through a
standard MII, RMII or RGMII interface.
Datasheet:
http://www.ti.com/product/DP83822I/datasheet
Signed-off-by: Dan Murphy
---
v3 - Fixed WoL indication bit and removed mutex
Florian
On 10/09/2017 11:44 AM, Florian Fainelli wrote:
> On 10/09/2017 05:03 AM, Dan Murphy wrote:
>> Removing the DP83822 device from the DP83848 to
>> support the TI DP83822 dedicated driver that will
>> initially support WoL settings.
> Hi Dan,
>
> The orderin
://www.ti.com/product/DP83822I/datasheet
Signed-off-by: Dan Murphy
---
v4 - Squash DP83822 removal patch into this patch -
https://www.mail-archive.com/netdev@vger.kernel.org/msg192424.html
v3 - Fixed WoL indication bit and removed mutex for suspend/resume -
https://www.mail-archive.com/netdev
Change the return error code to EINVAL if the MAC
address is not valid in the set_wol function.
Signed-off-by: Dan Murphy
---
v4 - Updated $subject to include the part number -
https://www.mail-archive.com/netdev@vger.kernel.org/msg192424.html
v3 - No changes made
v2 - There was no v1 on this
Andrew
Thanks for the review
On 10/09/2017 02:12 PM, Andrew F. Davis wrote:
> On 10/09/2017 11:59 AM, Dan Murphy wrote:
>> Add support for the TI DP83822 10/100Mbit ethernet phy.
>>
>> The DP83822 provides flexibility to connect to a MAC through a
>> standard M
Change the return error code to EINVAL if the MAC
address is not valid in the set_wol function.
Signed-off-by: Dan Murphy
---
v5 - No changes made
v4 - Updated $subject to include the part number -
https://www.mail-archive.com/netdev@vger.kernel.org/msg192424.html
v3 - No changes made
v2
://www.ti.com/product/DP83822I/datasheet
Signed-off-by: Dan Murphy
---
v5 - Fixed bit mask, added config_init to set WOL register bits, fixed spacing
issues, moved password storage under secure on if statement, and added INT_EN
bit
setting for interrupt enable.
https://www.mail-archive.com/netdev
+
>> +physcr_status = phy_read(phydev, MII_DP83822_PHYSCR);
>> +if (physcr_status < 0)
>> +return physcr_status;
>> +
>> +physcr_status |= DP83822_PHYSCR_INT_OE |
>> DP83822_PHYSCR_INTEN;
>> +
> Don't want to be picky, but seeing extra blank line here.
>
Let me know if you want me to fix this up. Or if you will when you apply it.
Dan
--
--
Dan Murphy
If SGMII was selected in the DT then the device should
write the SGMII enable bit.
If SGMII is not selected in the DT then the SGMII bit
should be disabled.
Signed-off-by: Dan Murphy
---
arch/arm/configs/omap2plus_defconfig | 1 +
drivers/net/phy/dp83tc811.c | 20
Add INT_STAT3 interrupt setting and clearing.
Also fixed writing to INT_STAT2 when disabling
the interrupts as there was a double write to
INT_STAT1.
Signed-off-by: Dan Murphy
---
drivers/net/phy/dp83tc811.c | 28 +++-
1 file changed, 27 insertions(+), 1 deletion
Andrew
On 06/28/2018 03:20 AM, Andrew Lunn wrote:
> On Wed, Jun 27, 2018 at 01:16:18PM -0500, Dan Murphy wrote:
>> If SGMII was selected in the DT then the device should
>> write the SGMII enable bit.
>>
>> If SGMII is not selected in the DT then the SGMII bit
>>
a bug fix, and so should be in a patch of its own, for
> net, not net-next.
>
Yes I was debating whether to include this change in the patch or have it
stand alone for stable back port.
I will pull it out and cc stable
> Andrew
>
--
--
Dan Murphy
Fix a bug where INT_STAT1 was written twice and
INT_STAT2 was ignored when disabling interrupts.
Signed-off-by: Dan Murphy
---
drivers/net/phy/dp83tc811.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/phy/dp83tc811.c b/drivers/net/phy/dp83tc811.c
index
Add support for the TI DP83822 10/100Mbit ethernet phy.
The DP83822 provides flexibility to connect to a MAC through a
standard MII, RMII or RGMII interface.
Datasheet:
http://www.ti.com/product/DP83822I/datasheet
Signed-off-by: Dan Murphy
---
drivers/net/phy/Kconfig | 5 +
drivers/net
All
On 10/03/2017 10:53 AM, Dan Murphy wrote:
> Add support for the TI DP83822 10/100Mbit ethernet phy.
>
> The DP83822 provides flexibility to connect to a MAC through a
> standard MII, RMII or RGMII interface.
>
I need to submit an additional patch to remove DP83822 from t
Florian
Thanks for the review
On 10/03/2017 12:15 PM, Florian Fainelli wrote:
> On 10/03/2017 08:53 AM, Dan Murphy wrote:
>> Add support for the TI DP83822 10/100Mbit ethernet phy.
>>
>> The DP83822 provides flexibility to connect to a MAC through a
>> standard M
Florian
On 10/03/2017 01:31 PM, Florian Fainelli wrote:
> On 10/03/2017 11:03 AM, Dan Murphy wrote:
>> Florian
>>
>> Thanks for the review
>>
>> On 10/03/2017 12:15 PM, Florian Fainelli wrote:
>>>> + } else {
>>&g
Florian
On 10/04/2017 11:18 AM, Florian Fainelli wrote:
> On 10/04/2017 08:41 AM, Dan Murphy wrote:
>> Florian
>>
>> On 10/03/2017 01:31 PM, Florian Fainelli wrote:
>>> On 10/03/2017 11:03 AM, Dan Murphy wrote:
>>>> Florian
>>>>
>>>&g
Change the return error code to EINVAL if the MAC
address is not valid in the set_wol function.
Signed-off-by: Dan Murphy
---
v2 - There was no v1 on this patch this is new.
drivers/net/phy/at803x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/phy/at803x.c b
Removing the DP83822 device from the DP83848 to
support the TI DP83822 dedicated driver that will
initially support WoL settings.
Signed-off-by: Dan Murphy
---
v2 - There was no v1 on this patch this is new.
drivers/net/phy/dp83848.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a
Add support for the TI DP83822 10/100Mbit ethernet phy.
The DP83822 provides flexibility to connect to a MAC through a
standard MII, RMII or RGMII interface.
Datasheet:
http://www.ti.com/product/DP83822I/datasheet
Signed-off-by: Dan Murphy
---
v2 - Updated per comments. Removed unnessary
ssion")
Signed-off-by: Dan Murphy
---
drivers/net/phy/dp83822.c | 30 ++
1 file changed, 14 insertions(+), 16 deletions(-)
diff --git a/drivers/net/phy/dp83822.c b/drivers/net/phy/dp83822.c
index fe9aa3ad52a7..1dd19d0cb269 100644
--- a/drivers/net/phy/dp83822.c
+++
t for the
DP83TC811 phy")
Signed-off-by: Dan Murphy
---
drivers/net/phy/dp83tc811.c | 21 -
1 file changed, 12 insertions(+), 9 deletions(-)
diff --git a/drivers/net/phy/dp83tc811.c b/drivers/net/phy/dp83tc811.c
index 06f08832ebcd..d73725312c7c 100644
--- a/drivers/net/phy
Hello
The WoL feature for each device was enabled during boot or when the PHY was
brought up which may be undesired. These patches disable the WoL in the
config_init. The disabling and enabling of the WoL is now done though the
set_wol call.
Dan
Dan Murphy (2):
net: phy: DP83822: Fix WoL in
1 - 100 of 342 matches
Mail list logo
