Wolfgang
On 3/4/19 11:31 AM, Wolfgang Grandegger wrote:
> Hello,
>
> there are still "LTL" after renaming m_can_priv to m_can_classdev.
>
Yes I know but some of those become unreadable if I break them apart.
But if you want me to break them I can do it.
For instance
struct m_can_plat_priv *priv = (struct m_can_plat_priv
*)m_can_class->device_data;
will become
struct m_can_plat_priv *priv =
(struct m_can_plat_priv
*)m_can_class->device_data;
> Am 01.03.19 um 19:50 schrieb Dan Murphy:
>> Rename the common m_can_priv class structure to
>> m_can_classdev as this is more descriptive.
>
> If you change the struct name, I think you should also change the
> variable name to something more meaning full e.g.:
>
> struct m_can_classdev *cdev
>
> instead of
>
> struct m_can_classdev *priv
>
>
Ack. This change will grow this patch as s/priv/cdev is used 250x
Dan
> ... snip ...
>
> Wolfgang.
>
--
------------------
Dan Murphy
