On 10/10/20 10:49 PM, Oliver Hartkopp wrote:
> As pointed out by Jakub Kicinski here:
> https://marc.info/?l=linux-can&m=160229286216008
> this patch addresses the remarked issues:
>
> - remove empty lines in comment
> - remove default=y for CAN_ISOTP in Kconfig
> - make use of pr_notice_once()
>
On 10/10/20 7:32 PM, Jakub Kicinski wrote:
> On Thu, 8 Oct 2020 23:40:19 +0200 Marc Kleine-Budde wrote:
>> The first patch is part of my pull request
>> "linux-can-fixes-for-5.9-20201006",
>> so consider that one obsolete and take this instead.
>>
>> The first patch is by Lucas Stach and fixes m_
On 10/10/20 10:49 PM, Oliver Hartkopp wrote:
> As pointed out by Jakub Kicinski here:
> https://marc.info/?l=linux-can&m=160229286216008
Better use https://lore.kernel.org for this. The URL is constructed by adding
"/r/$MESSAGE_ID":
http://lore.kernel.org/r/20201009175751.5c540...@kicinski-fedor
Hello,
syzbot found the following issue on:
HEAD commit:a804ab08 Add linux-next specific files for 20201006
git tree: linux-next
console output: https://syzkaller.appspot.com/x/log.txt?x=1073270b90
kernel config: https://syzkaller.appspot.com/x/.config?x=26c1b4cc4a62ccb
dashboard l
On Tue, Sep 08, 2020 at 02:55:36PM +0200, Daniel Borkmann wrote:
> I would strongly prefer something where nf integrates into existing
> tc hook, not only due to the hook reuse which would be better,
> but also to allow for a more flexible interaction between tc/BPF
> use cases
[...]
> one option t
On Sat Oct 10 2020, Florian Fainelli wrote:
> On 10/10/2020 9:46 AM, Kurt Kanzenbach wrote:
>> Convert the b53 DSA device tree bindings to YAML in order to allow
>> for automatic checking and such.
>>
>> Suggested-by: Florian Fainelli
>> Signed-off-by: Kurt Kanzenbach
>
> Thanks for making this
On Tue, Sep 15, 2020 at 12:02:03AM +0200, Daniel Borkmann wrote:
> today it is possible and
> perfectly fine to e.g. redirect to a host-facing veth from tc ingress which
> then goes into container. Only traffic that goes up the host stack is seen
> by nf ingress hook in that case. Likewise, reply t
Since the documentation currently referenced in the manpage no longer
exists.
---
man/man8/ss.8 | 75 ++-
1 file changed, 74 insertions(+), 1 deletion(-)
diff --git a/man/man8/ss.8 b/man/man8/ss.8
index 3b2559ff..f9e629f6 100644
--- a/man/man8/ss.8
Transmit Buffer Register Empty replaces TXERR on RM9200 and signals the
sender may try to send again becase the last queued frame is no longer
in queue (being transmitted or already transmitted).
Cc: Nicolas Ferre
Cc: Claudiu Beznea
Cc: Daniel Palmer
Signed-off-by: Willy Tarreau
---
drivers/n
The at91rm9200 variant used by a few chips including the MSC313 supports
two Tx descriptors (one frame being serialized and another one queued).
However the driver only implemented a single one, which adds a dead time
after each transfer to receive and process the interrupt and wake the
queue up, p
Hi,
while running some tests on my Breadbee board, I noticed poor network
Tx performance. I had a look at the driver (macb, at91ether variant)
and noticed that at91ether_start_xmit() immediately stops the queue
after sending a frame and waits for the interrupt to restart the queue,
causing a dead
The RM9200 supports one frame being sent while another one is waiting in
queue. This avoids the dead time that follows the emission of a frame
and which prevents one from reaching line speed.
Right now the driver supports only a single skb, so we'll first replace
the rm9200-specific skb info with
A helper for checking whether a net_device belongs to mscc_ocelot
already existed and did not need to be rewritten. Use it.
Fixes: 319e4dd11a20 ("net: mscc: ocelot: introduce conversion helpers between
port and netdev")
Signed-off-by: Vladimir Oltean
---
drivers/net/ethernet/mscc/ocelot_net.c |
On Sun, 11 Oct 2020 01:40:02 +0200
Daniel Borkmann wrote:
> Add an efficient ingress to ingress netns switch that can be used out of tc
> BPF
> programs in order to redirect traffic from host ns ingress into a container
> veth device ingress without having to go via CPU backlog queue [0]. For lo
On 10.10.2020 17:22, Jakub Kicinski wrote:
> On Sat, 10 Oct 2020 15:08:15 +0200 Heiner Kallweit wrote:
>> On 09.10.2020 18:06, Heiner Kallweit wrote:
>>> On 09.10.2020 17:58, Jakub Kicinski wrote:
On Fri, 9 Oct 2020 16:54:06 +0200 Heiner Kallweit wrote:
> I'm thinking about a __napi_sc
As pointed out by Jakub Kicinski here:
http://lore.kernel.org/r/20201009175751.5c540...@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com
this patch removes the obsolete version information of the different
CAN protocols and the AF_CAN core module.
Signed-off-by: Oliver Hartkopp
---
include/linux/ca
As pointed out by Jakub Kicinski here:
http://lore.kernel.org/r/20201009175751.5c540...@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com
this patch addresses the remarked issues:
- remove empty line in comment
- remove default=y for CAN_ISOTP in Kconfig
- make use of pr_notice_once()
- use GFP_KERNEL
This series contains these main changes:
1. Change of default message level to enable more logging.
2. Some cleanups related to processing async events from firmware.
3. Allow online ethtool selftest on multi-function PFs.
4. Return stored firmware version information to devlink.
Michael Chan (4)
From: Vasundhara Volam
If NVRAM resources are locked, NVM writes are not permitted. In such
scenarios, firmware returns HWRM_ERR_CODE_RESOURCE_LOCKED error to
firmware commands.
Reviewed-by: Edwin Peer
Signed-off-by: Vasundhara Volam
Signed-off-by: Michael Chan
---
drivers/net/ethernet/broad
From: Vasundhara Volam
This patch adds FW versions stored in the flash to devlink info_get
callback. Return the correct fw.psid running version using the
newly added bp->nvm_cfg_ver.
Reviewed-by: Andy Gospodarek
Signed-off-by: Vasundhara Volam
Signed-off-by: Michael Chan
---
.../net/etherne
If the VF virtual link is set to always enabled, the speed may be
unknown when the physical link is down. The driver currently logs
the link speed as 4294967295 Mbps which is SPEED_UNKNOWN. Modify
the link up log message as "speed unknown" which makes more sense.
Reviewed-by: Vasundhara Volam
R
From: Vasundhara Volam
Add a new bnxt_hwrm_nvm_get_dev_info() to query firmware version
information via NVM_GET_DEV_INFO firmware command. Use it to
get the running version of the NVM configuration information.
This new function will also be used in subsequent patches to get the
stored firmware
From: Vasundhara Volam
Online self tests are not disruptive and can be run in NPAR mode
and in multi-host NIC as well.
Reviewed-by: Edwin Peer
Signed-off-by: Vasundhara Volam
Signed-off-by: Michael Chan
---
drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 8
1 file changed, 4 ins
From: Vasundhara Volam
Add a new function bnxt_dl_info_put() to simplify the code, as there
are more stored firmware version fields to be added in the next patch.
Also, rename fw_ver variable name to ncsi_ver for better naming while
copying to devlink info_get cb.
Reviewed-by: Pavan Chebbi
Rev
Log these values that contain useful firmware state information.
Reviewed-by: Edwin Peer
Reviewed-by: Vasundhara Volam
Signed-off-by: Michael Chan
---
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
b/d
event_data1 and event_data2 are used when processing most events.
Store these in local variables at the beginning of the function to
simplify many of the case statements.
Reviewed-by: Edwin Peer
Signed-off-by: Michael Chan
---
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 12 +++-
1 file
Currently, bp->msg_enable has default value of 0. It is more useful
to have the commonly used NETIF_MSG_DRV and NETIF_MSG_HW enabled by
default.
Reviewed-by: Edwin Peer
Reviewed-by: Vasundhara Volam
Signed-off-by: Michael Chan
---
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 2 ++
1 file chang
On 11 October 2020 12:37:29 CEST, Andrey Konovalov
wrote:
>I initially hesitated to do that, as it would multiply the number of
>kcov callbacks. But perhaps you're right and a clean API look
>outweighs the rest. I will do this in v3.
Yeah, OK, dunno. You can always make it an inline calling
Replace commas with semicolons. Commas introduce unnecessary
variability in the code structure and are hard to see. What is done
is essentially described by the following Coccinelle semantic patch
(http://coccinelle.lip6.fr/):
//
@@ expression e1,e2; @@
e1
-,
+;
e2
... when any
//
Signed-off-
These patches replace commas by semicolons. Commas introduce
unnecessary variability in the code structure and are hard to see.
This was done using the Coccinelle semantic patch
(http://coccinelle.lip6.fr/) shown below.
This semantic patch ensures that commas inside for loop headers will
not be t
Replace commas with semicolons. Commas introduce unnecessary
variability in the code structure and are hard to see. What is done
is essentially described by the following Coccinelle semantic patch
(http://coccinelle.lip6.fr/):
//
@@ expression e1,e2; @@
e1
-,
+;
e2
... when any
//
Signed-off-
Replace commas with semicolons. Commas introduce unnecessary
variability in the code structure and are hard to see. What is done
is essentially described by the following Coccinelle semantic patch
(http://coccinelle.lip6.fr/):
//
@@ expression e1,e2; @@
e1
-,
+;
e2
... when any
//
Signed-off-
Replace commas with semicolons. Commas introduce unnecessary
variability in the code structure and are hard to see. What is done
is essentially described by the following Coccinelle semantic patch
(http://coccinelle.lip6.fr/):
//
@@ expression e1,e2; @@
e1
-,
+;
e2
... when any
//
Signed-off-
Replace commas with semicolons. Commas introduce unnecessary
variability in the code structure and are hard to see. What is done
is essentially described by the following Coccinelle semantic patch
(http://coccinelle.lip6.fr/):
//
@@ expression e1,e2; @@
e1
-,
+;
e2
... when any
//
Signed-off-
Memory was not freed when driver is unloaded from the kernel.
Signed-off-by: Valentin Vidic
---
drivers/net/ethernet/korina.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/korina.c b/drivers/net/ethernet/korina.c
index 03e034918d14..99146145f020 100644
--- a/drivers/ne
On Tue Oct 06 2020, Vladimir Oltean wrote:
> On Tue, Oct 06, 2020 at 03:23:36PM +0200, Kurt Kanzenbach wrote:
>> So you're saying private VLANs can be used but the user or the other
>> kernel modules shouldn't be allowed to use them to simplify the
>> implementation? Makes sense to me.
>
> It woul
On Tue, Oct 6, 2020 at 6:08 AM Andrew Lunn wrote:
>
> > It depends a lot on what portion of the kernel gets enabled for W=1.
> >
> > As long as it's only drivers that are actively maintained, and they
> > make up a fairly small portion of all code, it should not be a problem
> > to find someone to
On 10.10.2020 17:22, Jakub Kicinski wrote:
> On Sat, 10 Oct 2020 15:08:15 +0200 Heiner Kallweit wrote:
>> On 09.10.2020 18:06, Heiner Kallweit wrote:
>>> On 09.10.2020 17:58, Jakub Kicinski wrote:
On Fri, 9 Oct 2020 16:54:06 +0200 Heiner Kallweit wrote:
> I'm thinking about a __napi_sc
On Sat, Oct 10, 2020 at 06:38:54PM +0800, Muchun Song wrote:
> The amount of memory allocated to sockets buffer can become significant.
> However, we do not display the amount of memory consumed by sockets
> buffer. In this case, knowing where the memory is consumed by the kernel
> is very difficul
On Sat, Oct 10, 2020 at 11:58 AM Cong Wang wrote:
>
> Well, AF_PACKET RAW socket is supposed to construct L2 headers
> from the user buffer, and for a tunnel device these headers are indeed its
> L2. If users do not want to do this, they can switch to DGRAM anyway.
>
> I know how inconvenient it i
Hello Friend.I am Mrs.CHANTAL I am sending this brief
letter to solicit your partnership to transfer $7.2 Million US
Dollars.I shall send you more information and procedures when I receive
positive response From you. Please send me a message in My private
email address is ( mrscha
On Sun, Oct 11, 2020 at 02:29:08PM +0200, Kurt Kanzenbach wrote:
> On Tue Oct 06 2020, Vladimir Oltean wrote:
> > It would be interesting to see if you could simply turn off VLAN
> > awareness in standalone mode, and still use unique pvids per port.
>
> That doesn't work, just tested. When VLAN awa
Commit 109f6e39fa07c48f5801 ("af_unix: Allow SO_PEERCRED
to work across namespaces.") introduced the old_pid variable
in unix_listen, but it's never used.
Remove the declaration and the call to put_pid.
Signed-off-by: Or Cohen
---
net/unix/af_unix.c | 2 --
1 file changed, 2 deletions(-)
diff -
On Sun, 11 Oct 2020 11:24:07 +0200 Oliver Hartkopp wrote:
> diff --git a/net/can/isotp.c b/net/can/isotp.c
> index e6ff032b5426..22187669c5c9 100644
> --- a/net/can/isotp.c
> +++ b/net/can/isotp.c
> @@ -79,6 +79,8 @@ MODULE_LICENSE("Dual BSD/GPL");
> MODULE_AUTHOR("Oliver Hartkopp ");
> MODULE_AL
On Sun, 11 Oct 2020 11:24:07 +0200 Oliver Hartkopp wrote:
> @@ -769,7 +771,7 @@ static enum hrtimer_restart isotp_tx_timer_handler(struct
> hrtimer *hrtimer)
>
> isotp_tx_burst:
> skb = alloc_skb(so->ll.mtu + sizeof(struct can_skb_priv),
> - gfp_any());
On 10/11/2020 1:32 AM, Kurt Kanzenbach wrote:
On Sat Oct 10 2020, Florian Fainelli wrote:
On 10/10/2020 9:46 AM, Kurt Kanzenbach wrote:
Convert the b53 DSA device tree bindings to YAML in order to allow
for automatic checking and such.
Suggested-by: Florian Fainelli
Signed-off-by: Kurt Kan
From: Tom Rix
The clang build reports this warning
fw.c:1485:21: warning: address of array 'rtwdev->chip->fw_fifo_addr'
will always evaluate to 'true'
if (!rtwdev->chip->fw_fifo_addr) {
fw_fifo_addr is an array in rtw_chip_info so it is always
nonzero. A better check is if the first
On Sun, 11 Oct 2020 15:42:24 +0200 Heiner Kallweit wrote:
> On 10.10.2020 17:22, Jakub Kicinski wrote:
> > On Sat, 10 Oct 2020 15:08:15 +0200 Heiner Kallweit wrote:
> >> On 09.10.2020 18:06, Heiner Kallweit wrote:
> >>> On 09.10.2020 17:58, Jakub Kicinski wrote:
> On Fri, 9 Oct 2020 16
On Sun, Oct 11, 2020 at 9:53 PM Mike Rapoport wrote:
>
> On Sat, Oct 10, 2020 at 06:38:54PM +0800, Muchun Song wrote:
> > The amount of memory allocated to sockets buffer can become significant.
> > However, we do not display the amount of memory consumed by sockets
> > buffer. In this case, knowi
On Sun, 11 Oct 2020 11:24:41 +0200 Heiner Kallweit wrote:
> >> qeth_qdio_poll
> >> netvsc_channel_cb
> >> napi_watchdog
> >
> > This one runs from a hrtimer, which I believe will be a hard irq
> > context on anything but RT. I could be wrong.
> >
>
> A similar discussion can be found e.g. he
On Sat, 10 Oct 2020 18:17:11 +0200 Armin Wolf wrote:
> Correct a typo in ne.c and ne2k-pci.c which
> prevented activation of the RW-Bugfix.
> Also enable the RW-Bugfix by default since
> not doing so could (according to the Datasheet)
> cause the system to lock up with some chips.
>
> Signed-off-b
On Sun, 11 Oct 2020 02:39:29 +0530 Anmol Karn wrote:
> Flag ``ETHTOOL_A_STRSET_COUNTS_ONLY`` tells the kernel to only return the
> string
> counts of the sets, but, when req_info->counts_only tries to read the
> tb[ETHTOOL_A_STRSET_COUNTS_ONLY] it gets out of bound.
>
> - net/ethtool/strset.c
On 10/11/20 11:22 AM, Jesper Dangaard Brouer wrote:
On Sun, 11 Oct 2020 01:40:02 +0200
Daniel Borkmann wrote:
Add an efficient ingress to ingress netns switch that can be used out of tc BPF
programs in order to redirect traffic from host ns ingress into a container
veth device ingress without
In set_ethernet_addr(), if get_registers() succeeds, the ethernet address
that was read must be copied over. Otherwise, a random ethernet address
must be assigned.
get_registers() returns 0 if successful, and negative error number
otherwise. However, in set_ethernet_addr(), this return value is
in
Hello:
This series was applied to bpf/bpf-next.git (refs/heads/master):
On Sun, 11 Oct 2020 01:40:00 +0200 you wrote:
> This series addresses most of the feedback [0] that was to be followed
> up from the last series, that is, UAPI helper comment improvements and
> getting rid of the ifindex obj
On Sun, 11 Oct 2020 23:00:30 +0530 Anant Thazhemadam wrote:
> In set_ethernet_addr(), if get_registers() succeeds, the ethernet address
> that was read must be copied over. Otherwise, a random ethernet address
> must be assigned.
>
> get_registers() returns 0 if successful, and negative error numb
Hi Oliver,
I love your patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
url:
https://github.com/0day-ci/linux/commits/Oliver-Hartkopp/can-isotp-implement-cleanups-improvements-from-review/20201012-55
base: https://git.kernel.org/pub/scm/linux/kernel/git
On Wed, 7 Oct 2020 12:48:19 +0300 Claudiu Manoil wrote:
> Transitioning the enetc driver from phylib to phylink.
> Offloading the serdes configuration to the PCS_LYNX
> module is a mandatory part of this transition. Aiming
> for a cleaner, more maintainable design, and better
> code reuse.
> The f
On Thu, 8 Oct 2020 14:56:57 +0300 Vladimir Oltean wrote:
> This series offloads one more action to the VCAP IS1 ingress TCAM, which
> is to change the classified VLAN for packets, according to the VCAP IS1
> keys (VLAN, source MAC, source IP, EtherType, etc).
Applied, thanks!
On Sat, 10 Oct 2020 12:51:30 -0400 Willem de Bruijn wrote:
> > > @@ -1385,7 +1386,17 @@ static int ibmveth_poll(struct napi_struct *napi,
> > > int budget)
> > > skb_put(skb, length);
> > > skb->protocol = eth_type_trans(skb, netdev);
> > >
> > > -
On Sun, 2020-10-11 at 10:59 -0700, Jakub Kicinski wrote:
> On Sun, 11 Oct 2020 23:00:30 +0530 Anant Thazhemadam wrote:
> > In set_ethernet_addr(), if get_registers() succeeds, the ethernet address
> > that was read must be copied over. Otherwise, a random ethernet address
> > must be assigned.
> >
On Thu, 8 Oct 2020 11:45:26 -0700 Jonathan Lemon wrote:
> From: Jonathan Lemon
>
> netcons calls napi_poll with a budget of 0 to transmit packets.
> Handle this by:
> - skipping RX processing
> - do not try to recycle TX packets to the RX cache
>
> Signed-off-by: Jonathan Lemon
Tariq, Saeed
On Sun, Oct 11, 2020 at 7:46 AM Valentin Vidic
wrote:
>
> Memory was not freed when driver is unloaded from the kernel.
>
> Signed-off-by: Valentin Vidic
Makes sense.
Fixes: ef11291bcd5f ("Add support the Korina (IDT RC32434) Ethernet MAC")
Slightly off-topic, but I don't fully fathom what goe
On Sat, Oct 10, 2020 at 3:39 AM Muchun Song wrote:
>
> The amount of memory allocated to sockets buffer can become significant.
> However, we do not display the amount of memory consumed by sockets
> buffer. In this case, knowing where the memory is consumed by the kernel
We do it via `ss -m`. Is
On Fri, 2020-10-09 at 17:01 +, Aleksandr Nogikh wrote:
> From: Aleksandr Nogikh
>
> This patch series enables remote KCOV coverage collection during
> 802.11 frames processing. These changes make it possible to perform
> coverage-guided fuzzing in search of remotely triggerable bugs.
Btw, it
On Fri, 9 Oct 2020 22:33:31 +0200 Loic Poulain wrote:
> This patch adds a new network driver implementing MHI transport for
> network packets. Packets can be in any format, though QMAP (rmnet)
> is the usual protocol (flow control + PDN mux).
>
> It support two MHI devices, IP_HW0 which is, the p
Hello sir,
On Sun, Oct 11, 2020 at 10:24 PM Jakub Kicinski wrote:
>
> On Sun, 11 Oct 2020 02:39:29 +0530 Anmol Karn wrote:
> > Flag ``ETHTOOL_A_STRSET_COUNTS_ONLY`` tells the kernel to only return the
> > string
> > counts of the sets, but, when req_info->counts_only tries to read the
> > tb[ETHT
GRE tunnel has its own header_ops, ipgre_header_ops, and sets it
conditionally. When it is set, it assumes the outer IP header is
already created before ipgre_xmit().
This is not true when we send packets through a raw packet socket,
where L2 headers are supposed to be constructed by user. Packet
#syz fix: net_sched: check error pointer in tcf_dump_walker()
On Sun, 11 Oct 2020 12:11:40 +0800 Xianting Tian wrote:
> In architecture like powerpc, we can have cpus without any local memory
> attached to it. In such cases the node does not have real memory.
>
> Use local_memory_node(), which is guaranteed to have memory.
> local_memory_node is a noop in ot
On Thu, 8 Oct 2020 19:30:15 +0530 Ayush Sawal wrote:
> @@ -140,8 +141,8 @@ static int ch_ipsec_uld_state_change(void *handle, enum
> cxgb4_state new_state)
> return 0;
> }
>
> -static inline int chcr_ipsec_setauthsize(struct xfrm_state *x,
> - struct
On 20-10-11 11:33:00, Joe Perches wrote:
> On Sun, 2020-10-11 at 10:59 -0700, Jakub Kicinski wrote:
> > On Sun, 11 Oct 2020 23:00:30 +0530 Anant Thazhemadam wrote:
> > > In set_ethernet_addr(), if get_registers() succeeds, the ethernet address
> > > that was read must be copied over. Otherwise, a r
On Sun, 11 Oct 2020 06:22:55 -0400 Michael Chan wrote:
> Currently, bp->msg_enable has default value of 0. It is more useful
> to have the commonly used NETIF_MSG_DRV and NETIF_MSG_HW enabled by
> default.
>
> Reviewed-by: Edwin Peer
> Reviewed-by: Vasundhara Volam
> Signed-off-by: Michael Chan
In several places the same code is used to populate rtnl_link_stats64
fields with data from pcpu_sw_netstats. Therefore factor out this code
to a new function dev_fetch_sw_netstats().
Heiner Kallweit (12):
net: core: add function dev_fetch_sw_netstats for fetching
pcpu_sw_netstats
IB/hfi1:
In several places the same code is used to populate rtnl_link_stats64
fields with data from pcpu_sw_netstats. Therefore factor out this code
to a new function dev_fetch_sw_netstats().
Signed-off-by: Heiner Kallweit
---
include/linux/netdevice.h | 2 ++
net/core/dev.c| 36 +++
Simplify the code by using new function dev_fetch_sw_netstats().
Signed-off-by: Heiner Kallweit
---
net/openvswitch/vport-internal_dev.c | 20 +---
1 file changed, 1 insertion(+), 19 deletions(-)
diff --git a/net/openvswitch/vport-internal_dev.c
b/net/openvswitch/vport-internal
Simplify the code by using new function dev_fetch_sw_netstats().
Signed-off-by: Heiner Kallweit
---
net/dsa/slave.c | 21 +
1 file changed, 1 insertion(+), 20 deletions(-)
diff --git a/net/dsa/slave.c b/net/dsa/slave.c
index e7c1d62fd..3bc5ca40c 100644
--- a/net/dsa/slave.c
Simplify the code by using new function dev_fetch_sw_netstats().
Signed-off-by: Heiner Kallweit
---
net/bridge/br_device.c | 21 +
1 file changed, 1 insertion(+), 20 deletions(-)
diff --git a/net/bridge/br_device.c b/net/bridge/br_device.c
index 9a2fb4aa1..6f742fee8 100644
-
Simplify the code by using new function dev_fetch_sw_netstats().
Signed-off-by: Heiner Kallweit
---
drivers/net/usb/qmi_wwan.c | 24 +---
1 file changed, 1 insertion(+), 23 deletions(-)
diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
index 5ca1356b8..a32
Simplify the code by using new function dev_fetch_sw_netstats().
Signed-off-by: Heiner Kallweit
---
net/xfrm/xfrm_interface.c | 22 +-
1 file changed, 1 insertion(+), 21 deletions(-)
diff --git a/net/xfrm/xfrm_interface.c b/net/xfrm/xfrm_interface.c
index 5b120936d..aa4cdcf6
Simplify the code by using new function dev_fetch_sw_netstats().
Signed-off-by: Heiner Kallweit
---
drivers/net/usb/usbnet.c | 24 +---
1 file changed, 1 insertion(+), 23 deletions(-)
diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c
index 963d260d1..6062dc278
Simplify the code by using new function dev_fetch_sw_netstats().
Signed-off-by: Heiner Kallweit
---
net/mac80211/iface.c | 23 +--
1 file changed, 1 insertion(+), 22 deletions(-)
diff --git a/net/mac80211/iface.c b/net/mac80211/iface.c
index 240862a74..1be775979 100644
--- a
Simplify the code by using new function dev_fetch_sw_netstats().
Signed-off-by: Heiner Kallweit
---
drivers/net/wireless/quantenna/qtnfmac/core.c | 27 +--
1 file changed, 1 insertion(+), 26 deletions(-)
diff --git a/drivers/net/wireless/quantenna/qtnfmac/core.c
b/drivers/net/w
Simplify the code by using new function dev_fetch_sw_netstats().
Signed-off-by: Heiner Kallweit
---
drivers/net/macsec.c | 25 +
1 file changed, 1 insertion(+), 24 deletions(-)
diff --git a/drivers/net/macsec.c b/drivers/net/macsec.c
index 2b0c8f01d..e74483279 100644
---
Simplify the code by using new function dev_fetch_sw_netstats().
Signed-off-by: Heiner Kallweit
---
drivers/infiniband/hw/hfi1/ipoib_main.c | 34 +
1 file changed, 1 insertion(+), 33 deletions(-)
diff --git a/drivers/infiniband/hw/hfi1/ipoib_main.c
b/drivers/infiniband/
Simplify the code by using new function dev_fetch_sw_netstats().
Signed-off-by: Heiner Kallweit
---
net/ipv4/ip_tunnel_core.c | 23 +--
1 file changed, 1 insertion(+), 22 deletions(-)
diff --git a/net/ipv4/ip_tunnel_core.c b/net/ipv4/ip_tunnel_core.c
index b2ea1a8c5..25f1caf
On Sun, 11 Oct 2020 21:36:43 +0200
Heiner Kallweit wrote:
> +void dev_fetch_sw_netstats(struct rtnl_link_stats64 *s,
> +struct pcpu_sw_netstats __percpu *netstats)
netstats is unmodified, should it be const?
> +{
> + int cpu;
> +
> + if (IS_ERR_OR_NULL(netstats))
From: Alexei Starovoitov
Move the bpf/bpf-next patch processing queue to patchwork.kernel.org.
Signed-off-by: Alexei Starovoitov
---
Hi All BPF developers,
we've migrated bpf patchwork to kernel.org.
Please monitor the bpf queue at
https://patchwork.kernel.org/project/netdevbpf/list/?delegate
On 10/10/20 3:42 PM, Toke Høiland-Jørgensen wrote:
Daniel Borkmann writes:
On 10/9/20 11:28 PM, David Ahern wrote:
On 10/9/20 11:42 AM, Toke Høiland-Jørgensen wrote:
David Ahern writes:
On 10/9/20 3:13 AM, Toke Høiland-Jørgensen wrote:
The bpf_fib_lookup() helper performs a neighbour looku
On Sun, Oct 11, 2020 at 7:18 AM Julia Lawall wrote:
>
> Replace commas with semicolons. Commas introduce unnecessary
> variability in the code structure and are hard to see. What is done
> is essentially described by the following Coccinelle semantic patch
> (http://coccinelle.lip6.fr/):
>
> //
Hello:
This patch was applied to bpf/bpf-next.git (refs/heads/master):
On Sun, 11 Oct 2020 13:01:49 -0700 you wrote:
> From: Alexei Starovoitov
>
> Move the bpf/bpf-next patch processing queue to patchwork.kernel.org.
>
> Signed-off-by: Alexei Starovoitov
> ---
>
> [...]
Here is the summary
From: Tom Rix
Clang static analysis reports this representative problem
ptp_clockmatrix.c:1852:2: warning: 5th function call argument
is an uninitialized value
snprintf(idtcm->version, sizeof(idtcm->version), "%u.%u.%u",
^
On Sun, 2020-10-11 at 22:31 +0300, Petko Manolov wrote:
> On 20-10-11 11:33:00, Joe Perches wrote:
> > On Sun, 2020-10-11 at 10:59 -0700, Jakub Kicinski wrote:
> > > On Sun, 11 Oct 2020 23:00:30 +0530 Anant Thazhemadam wrote:
> > > > In set_ethernet_addr(), if get_registers() succeeds, the ethernet
On Sun, Oct 11, 2020 at 09:41:27PM +0200, Heiner Kallweit wrote:
> Simplify the code by using new function dev_fetch_sw_netstats().
>
> Signed-off-by: Heiner Kallweit
> ---
Tested-by: Vladimir Oltean
On 11.10.2020 21:54, Stephen Hemminger wrote:
> On Sun, 11 Oct 2020 21:36:43 +0200
> Heiner Kallweit wrote:
>
>> +void dev_fetch_sw_netstats(struct rtnl_link_stats64 *s,
>> + struct pcpu_sw_netstats __percpu *netstats)
>
> netstats is unmodified, should it be const?
>
>> +
On Sun, Oct 11, 2020 at 12:11 PM Cong Wang wrote:
>
> GRE tunnel has its own header_ops, ipgre_header_ops, and sets it
> conditionally. When it is set, it assumes the outer IP header is
> already created before ipgre_xmit().
>
> This is not true when we send packets through a raw packet socket,
>
On Sun, Oct 11, 2020 at 3:11 PM Cong Wang wrote:
>
> GRE tunnel has its own header_ops, ipgre_header_ops, and sets it
> conditionally. When it is set, it assumes the outer IP header is
> already created before ipgre_xmit().
>
> This is not true when we send packets through a raw packet socket,
> w
On Sun, Oct 11, 2020 at 4:42 PM Xie He wrote:
>
> On Sun, Oct 11, 2020 at 12:11 PM Cong Wang wrote:
> >
> > GRE tunnel has its own header_ops, ipgre_header_ops, and sets it
> > conditionally. When it is set, it assumes the outer IP header is
> > already created before ipgre_xmit().
> >
> > This i
On Sun, Oct 11, 2020 at 12:34 PM Jakub Kicinski wrote:
>
> On Sun, 11 Oct 2020 06:22:55 -0400 Michael Chan wrote:
> > Currently, bp->msg_enable has default value of 0. It is more useful
> > to have the commonly used NETIF_MSG_DRV and NETIF_MSG_HW enabled by
> > default.
> >
> > Reviewed-by: Edwin
On Sun, Oct 11, 2020 at 02:37:33PM -0400, Willem de Bruijn wrote:
> Slightly off-topic, but I don't fully fathom what goes on with this
> pointer straight after the initial kmalloc.
>
> lp->td_ring = (struct dma_desc *)KSEG1ADDR(lp->td_ring);
KSEG1ADDR should rewrite the memory address in
1 - 100 of 166 matches
Mail list logo
