Re: [PATCH net-next 0/8] s390/qeth: updates 2020-08-27

2020-08-27 Thread David Miller
From: Julian Wiedmann Date: Thu, 27 Aug 2020 10:16:57 +0200 > please apply the following patch series for qeth to netdev's net-next tree. > > Patch 8 makes some improvements to how we handle HW address events, > avoiding some uncertainty around processing stale events after we > switched off the

Re: [PATCH net-next 1/2] ipv6: add ipv6_fragment hook in ipv6_stub

2020-08-27 Thread David Miller
From: we...@ucloud.cn Date: Thu, 27 Aug 2020 18:39:51 +0800 > From: wenxu > > Add ipv6_fragment to ipv6_stub to avoid calling netfilter when > access ip6_fragment. > > Signed-off-by: wenxu Please test these changes with ipv6 disabled. It will crash, you have to update the default stub in net

Re: [net v3 PATCH] net: ethernet: ti: cpsw_new: fix error handling in cpsw_ndo_vlan_rx_kill_vid()

2020-08-27 Thread Murali Karicheri
Hi Dave, On 8/25/20 12:36 PM, David Miller wrote: From: Murali Karicheri Date: Mon, 24 Aug 2020 13:01:00 -0400 + ret = cpsw_ale_del_vlan(cpsw->ale, vid, 0); + if (ret) + dev_err(priv->dev, "%s: failed %d: ret %d\n", + __func__, __LINE__, ret); +

[PATCH net v4] net: ethernet: ti: cpsw_new: fix error handling in cpsw_ndo_vlan_rx_kill_vid()

2020-08-27 Thread Murali Karicheri
This patch fixes a bunch of issues in cpsw_ndo_vlan_rx_kill_vid() - pm_runtime_get_sync() returns non zero value. This results in non zero value return to caller which will be interpreted as error. So overwrite ret with zero. - If VID matches with port VLAN VID, then set error code. - Cur

Re: [PATCH][next] b43legacy: Use fallthrough pseudo-keyword

2020-08-27 Thread Kalle Valo
"Gustavo A. R. Silva" wrote: > Replace the existing /* fall through */ comments and its variants with > the new pseudo-keyword macro fallthrough[1]. > > [1] > https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through > > Signed-off-by:

Re: [PATCH][next] atmel: Use fallthrough pseudo-keyword

2020-08-27 Thread Kalle Valo
"Gustavo A. R. Silva" wrote: > Replace the existing /* fall through */ comments and its variants with > the new pseudo-keyword macro fallthrough[1]. > > [1] > https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through > > Signed-off-by:

Re: [PATCH][next] iwlegacy: Use fallthrough pseudo-keyword

2020-08-27 Thread Kalle Valo
"Gustavo A. R. Silva" wrote: > Replace the existing /* fall through */ comments and its variants with > the new pseudo-keyword macro fallthrough[1]. > > [1] > https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through > > Signed-off-by:

Re: [PATCH][next] b43: Use fallthrough pseudo-keyword

2020-08-27 Thread Kalle Valo
"Gustavo A. R. Silva" wrote: > Replace the existing /* fall through */ comments and its variants with > the new pseudo-keyword macro fallthrough[1]. > > [1] > https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through > > Signed-off-by:

Re: [PATCH][next] orinoco: Use fallthrough pseudo-keyword

2020-08-27 Thread Kalle Valo
"Gustavo A. R. Silva" wrote: > Replace the existing /* fall through */ comments and its variants with > the new pseudo-keyword macro fallthrough[1]. > > [1] > https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through > > Signed-off-by:

Re: [PATCH][next] prism54: Use fallthrough pseudo-keyword

2020-08-27 Thread Kalle Valo
"Gustavo A. R. Silva" wrote: > Replace the existing /* fall through */ comments and its variants with > the new pseudo-keyword macro fallthrough[1]. > > [1] > https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through > > Signed-off-by:

Re: [PATCH 00/30] Set 3: Rid W=1 warnings in Wireless

2020-08-27 Thread Kalle Valo
Lee Jones writes: > This set is part of a larger effort attempting to clean-up W=1 > kernel builds, which are currently overwhelmingly riddled with > niggly little warnings. > > There are quite a few W=1 warnings in the Wireless. My plan > is to work through all of them over the next few weeks.

Re: [PATCH 00/30] Set 3: Rid W=1 warnings in Wireless

2020-08-27 Thread Lee Jones
On Thu, 27 Aug 2020, Kalle Valo wrote: > Lee Jones writes: > > > This set is part of a larger effort attempting to clean-up W=1 > > kernel builds, which are currently overwhelmingly riddled with > > niggly little warnings. > > > > There are quite a few W=1 warnings in the Wireless. My plan > >

[PATCH net 1/7] rxrpc: Keep the ACK serial in a var in rxrpc_input_ack()

2020-08-27 Thread David Howells
Keep the ACK serial number in a variable in rxrpc_input_ack() as it's used frequently. Signed-off-by: David Howells --- net/rxrpc/input.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/net/rxrpc/input.c b/net/rxrpc/input.c index 767579328a06..a7699

[PATCH net 6/7] afs: Don't use VL probe running state to make decisions outside probe code

2020-08-27 Thread David Howells
Don't use the running state for VL server probes to make decisions about which server to use as the state is cleared at the start of a probe and intermediate values might also be misleading. Instead, add a separate 'latest known' rtt in the afs_vlserver struct and a flag to indicate if the server

Re: [PATCH net-next v3] gtp: add notification mechanism

2020-08-27 Thread David Miller
From: Nicolas Dichtel Date: Thu, 27 Aug 2020 14:19:23 +0200 > Like all other network functions, let's notify gtp context on creation and > deletion. > > Signed-off-by: Nicolas Dichtel > Tested-by: Gabriel Ganne > Acked-by: Harald Welte Applied, thanks.

[PATCH net 7/7] afs: Fix error handling in VL server rotation

2020-08-27 Thread David Howells
The error handling in the VL server rotation in the case of there being no contactable servers is not correct. In such a case, the records of all the servers in the list are scanned and the errors and abort codes are mapped and prioritised and one error is chosen. This is then forgotten and the d

[PATCH net 5/7] afs: Expose information from afs_vlserver through /proc for debugging

2020-08-27 Thread David Howells
Convert various bitfields in afs_vlserver::probe to a mask and then expose this and some other bits of information through /proc/net/afs//vlservers to make it easier to debug VL server communication issues. Signed-off-by: David Howells --- fs/afs/internal.h |9 + fs/afs/proc.c

Hi

2020-08-27 Thread Liz Johnson
Hi How are you? I’m Liz, 24 years old. I saw your email contact and i decided to contact you, I think you are a kind person, If you may, I would like to be your friend. I will tell you more about me, when i receive your acceptance Thanks! Wanting to be your friend. Regards. Liz.

[PATCH net 4/7] afs: Remove afs_vlserver->probe.have_result

2020-08-27 Thread David Howells
Remove afs_vlserver->probe.have_result as it's neither read nor waited upon. Fixes: 3bf0fb6f33dd ("afs: Probe multiple fileservers simultaneously") Signed-off-by: David Howells --- fs/afs/internal.h |1 - fs/afs/vl_probe.c |5 + 2 files changed, 1 insertion(+), 5 deletions(-) diff

[PATCH net 2/7] rxrpc: Fix loss of RTT samples due to interposed ACK

2020-08-27 Thread David Howells
The Rx protocol has a mechanism to help generate RTT samples that works by a client transmitting a REQUESTED-type ACK when it receives a DATA packet that has the REQUEST_ACK flag set. The peer, however, may interpose other ACKs before transmitting the REQUESTED-ACK, as can be seen in the following

[PATCH net 3/7] rxrpc: Make rxrpc_kernel_get_srtt() indicate validity

2020-08-27 Thread David Howells
Fix rxrpc_kernel_get_srtt() to indicate the validity of the returned smoothed RTT. If we haven't had any valid samples yet, the SRTT isn't useful. Fixes: c410bf01933e ("rxrpc: Fix the excessive initial retransmission timeout") Signed-off-by: David Howells --- fs/afs/fs_probe.c |4 ++-

Re: [PATCH] net: Fix some comments

2020-08-27 Thread David Miller
From: Miaohe Lin Date: Thu, 27 Aug 2020 07:27:49 -0400 > Fix some comments, including wrong function name, duplicated word and so > on. > > Signed-off-by: Miaohe Lin Applied, thanks.

[PATCH net 0/7] rxrpc, afs: Fix probing issues

2020-08-27 Thread David Howells
Here are some fixes for rxrpc and afs to fix issues in the RTT measuring in rxrpc and thence the Volume Location server probing in afs: (1) Move the serial number of a received ACK into a local variable to simplify the next patch. (2) Fix the loss of RTT samples due to extra interposed A

Re: [PATCH net 1/2] net: disable netpoll on fresh napis

2020-08-27 Thread Jakub Kicinski
On Thu, 27 Aug 2020 00:25:31 -0700 Eric Dumazet wrote: > On 8/26/20 12:40 PM, Jakub Kicinski wrote: > > To ensure memory ordering is correct we need to use RCU accessors. > > > + set_bit(NAPI_STATE_NPSVC, &napi->state); > > + list_add_rcu(&napi->dev_list, &dev->napi_list); > > > > > - list

RE: [PATCH] iavf: use kvzalloc instead of kzalloc for rx/tx_bi buffer

2020-08-27 Thread Li,Rongqing
> -Original Message- > From: Eric Dumazet [mailto:eric.duma...@gmail.com] > Sent: Thursday, August 27, 2020 5:55 PM > To: Li,Rongqing ; Eric Dumazet > ; netdev@vger.kernel.org; > intel-wired-...@lists.osuosl.org > Subject: Re: [PATCH] iavf: use kvzalloc instead of kzalloc for rx/tx_bi buf

Re: [PATCH 12/30] wireless: ath: wil6210: wmi: Correct misnamed function parameter 'ptr_'

2020-08-27 Thread Kalle Valo
c: patch does not apply >> > stg import: Diff does not apply cleanly >> > >> > Patch set to Changes Requested. >> >> Are you applying them in order? >> >> It may be affected by: >> >> wireless: ath: wil6210: wmi: Fix formatting and demot

[PATCH] net: Call ip_hdrlen() when skbuff is not fragment

2020-08-27 Thread Miaohe Lin
When skbuff is fragment, we exit immediately and leave ip_hdrlen() as unused. And remove the unnecessary local variable fragment. Signed-off-by: Miaohe Lin --- net/core/skbuff.c | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/net/core/skbuff.c b/net/core/skbuff.

Re: RFC: inet_timewait_sock->tw_timer list corruption

2020-08-27 Thread Eric W. Biederman
Wang Long writes: > Hi, > > we encountered a kernel panic as following: > > [4394470.273792] general protection fault: [#1] SMP NOPTI > [4394470.274038] CPU: 0 PID: 0 Comm: swapper/0 Kdump: loaded Tainted: GW > - - - 4.18.0-80.el8.x86_64 #1 > [4394470.274477] Hardware name: Sugo

[PATCH] net: Add 'else' to split mutually exclusive case

2020-08-27 Thread Miaohe Lin
Add else to split mutually exclusive case and avoid unnecessary check. Signed-off-by: Miaohe Lin --- net/ipv4/ping.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv4/ping.c b/net/ipv4/ping.c index 19a947bf0faa..265676fd2bbd 100644 --- a/net/ipv4/ping.c +++ b/net/ipv4/

Re: powering off phys on 'ip link set down'

2020-08-27 Thread Heiner Kallweit
On 27.08.2020 13:00, Rasmus Villemoes wrote: > On 27/08/2020 12.29, Heiner Kallweit wrote: >> On 27.08.2020 12:08, Rasmus Villemoes wrote: >>> Hi, >>> >>> We have a requirement that when an interface is taken down >>> administratively, the phy should be powered off. That also works when >>> the int

Re: [PATCH][next] ath11k: fix error check on return from call to ath11k_core_firmware_request

2020-08-27 Thread Kalle Valo
Colin King wrote: > From: Colin Ian King > > The call to ath11k_core_firmware_request is returning a pointer that > can be set to an error code, however, this is not being checked. > Instead ret is being incorrecly checked for the error return. Fix the > error checking. > > Addresses-Coverity:

Re: powering off phys on 'ip link set down'

2020-08-27 Thread Heiner Kallweit
On 27.08.2020 13:00, Rasmus Villemoes wrote: > On 27/08/2020 12.29, Heiner Kallweit wrote: >> On 27.08.2020 12:08, Rasmus Villemoes wrote: >>> Hi, >>> >>> We have a requirement that when an interface is taken down >>> administratively, the phy should be powered off. That also works when >>> the int

[PATCH] net: Fix some comments

2020-08-27 Thread Miaohe Lin
Fix some comments, including wrong function name, duplicated word and so on. Signed-off-by: Miaohe Lin --- include/linux/skbuff.h | 4 ++-- include/uapi/linux/in.h | 2 +- net/core/sock.c | 2 +- net/ipv4/raw.c | 2 +- net/l3mdev/l3mdev.c | 2 +- net/socket.c| 4

[PATCH net-next v1 2/3] hinic: add support to query rq info

2020-08-27 Thread Luo bin
add debugfs node for querying rq info, for example: cat /sys/kernel/debug/hinic/:15:00.0/RQs/0x0/rq_hw_pi Signed-off-by: Luo bin --- V0~V1: - remove command interfaces to the read only files - split addition of each object into a separate patch .../net/ethernet/huawei/hinic/hinic_debugfs.c

[PATCH] net: Set trailer iff skb1 is the last one

2020-08-27 Thread Miaohe Lin
Set trailer iff skb1 is the skbuff where the tailbits space begins. Signed-off-by: Miaohe Lin --- net/core/skbuff.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/core/skbuff.c b/net/core/skbuff.c index 0b24aed04060..18ed56316e56 100644 --- a/net/core/skbuff.c +++ b/ne

[PATCH net-next v1 1/3] hinic: add support to query sq info

2020-08-27 Thread Luo bin
add debugfs node for querying sq info, for example: cat /sys/kernel/debug/hinic/:15:00.0/SQs/0x0/sq_pi Signed-off-by: Luo bin --- V0~V1: - remove command interfaces to the read only files - split addition of each object into a separate patch drivers/net/ethernet/huawei/hinic/Makefile|

[PATCH net-next v1 3/3] hinic: add support to query function table

2020-08-27 Thread Luo bin
add debugfs node for querying function table, for example: cat /sys/kernel/debug/hinic/:15:00.0/func_table/valid Signed-off-by: Luo bin --- V0~V1: - remove command interfaces to the read only files - split addition of each object into a separate patch .../net/ethernet/huawei/hinic/hinic_deb

[PATCH net-next v1 0/3] hinic: add debugfs support

2020-08-27 Thread Luo bin
add debugfs node for querying sq/rq info and function table Luo bin (3): hinic: add support to query sq info hinic: add support to query rq info hinic: add support to query function table drivers/net/ethernet/huawei/hinic/Makefile| 3 +- .../net/ethernet/huawei/hinic/hinic_debugfs.c

[PATCH v2 2/2] dt-bindings: can: rcar_can: Document r8a774e1 support

2020-08-27 Thread Lad Prabhakar
Document SoC specific bindings for RZ/G2H (R8A774E1) SoC. Signed-off-by: Lad Prabhakar Reviewed-by: Marian-Cristian Rotariu Reviewed-by: Geert Uytterhoeven Acked-by: Rob Herring --- Documentation/devicetree/bindings/net/can/rcar_can.txt | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(

[PATCH v2 0/2] dt-bindings: can: document R8A774E1

2020-08-27 Thread Lad Prabhakar
Hi All, Both the patches are part of series [1] (patch 18/20, 19/20), rest of the patches have been acked/merged so just sending two patches from the series. [1] https://lkml.org/lkml/2020/7/15/515 Cheers, Prabhakar Changes for v2: * Added R8A774E1 to the list of SoCs that can use CANFD through

[PATCH v2 1/2] dt-bindings: can: rcar_canfd: Document r8a774e1 support

2020-08-27 Thread Lad Prabhakar
Document the support for rcar_canfd on R8A774E1 SoC devices. Signed-off-by: Lad Prabhakar Reviewed-by: Marian-Cristian Rotariu Reviewed-by: Geert Uytterhoeven Acked-by: Rob Herring --- Documentation/devicetree/bindings/net/can/rcar_canfd.txt | 5 +++-- 1 file changed, 3 insertions(+), 2 delet

Re: [PATCH net 1/2] net: disable netpoll on fresh napis

2020-08-27 Thread Eric Dumazet
On 8/27/20 8:10 AM, Jakub Kicinski wrote: > On Thu, 27 Aug 2020 00:25:31 -0700 Eric Dumazet wrote: >> On 8/26/20 12:40 PM, Jakub Kicinski wrote: >>> To ensure memory ordering is correct we need to use RCU accessors. >> >>> + set_bit(NAPI_STATE_NPSVC, &napi->state); >>> + list_add_rcu(&napi->

Re: [PATCH] Revert "wlcore: Adding suppoprt for IGTK key in wlcore driver"

2020-08-27 Thread Steve deRosier
On Tue, Aug 25, 2020 at 10:49 PM Mauro Carvalho Chehab wrote: > > This patch causes a regression betwen Kernel 5.7 and 5.8 at wlcore: > with it applied, WiFi stops working, and the Kernel starts printing > this message every second: > >wlcore: PHY firmware version: Rev 8.2.0.0.242 >wlcore:

[PATCH net] rxrpc: Fix memory leak in rxkad_verify_response()

2020-08-27 Thread David Howells
From: Dinghao Liu Fix a memory leak in rxkad_verify_response() whereby the response buffer doesn't get freed if we fail to allocate a ticket buffer. Fixes: ef68622da9cc ("rxrpc: Handle temporary errors better in rxkad security") Signed-off-by: Dinghao Liu Signed-off-by: David Howells --- net

Re: [PATCH] net: Add 'else' to split mutually exclusive case

2020-08-27 Thread David Miller
From: Miaohe Lin Date: Thu, 27 Aug 2020 07:15:52 -0400 > Add else to split mutually exclusive case and avoid unnecessary check. > > Signed-off-by: Miaohe Lin I see no value to this, the compiler is doing the right thing already and this does not add to code readability either. I'm not applyin

Re: [PATCH] net: Call ip_hdrlen() when skbuff is not fragment

2020-08-27 Thread David Miller
From: Miaohe Lin Date: Thu, 27 Aug 2020 07:17:59 -0400 > When skbuff is fragment, we exit immediately and leave ip_hdrlen() as > unused. And remove the unnecessary local variable fragment. > > Signed-off-by: Miaohe Lin I don't think this is a useful optimization sorry, the common case will be

Re: [PATCH] net: exit immediately when encounter ipv6 fragment in skb_checksum_setup_ipv6()

2020-08-27 Thread David Miller
From: Miaohe Lin Date: Thu, 27 Aug 2020 07:21:59 -0400 > skb_checksum_setup_ipv6() always return -EPROTO if ipv6 packet is fragment. > So we should not continue to parse other header type in this case. Also > remove unnecessary local variable 'fragment'. > > Signed-off-by: Miaohe Lin Again, th

Re: [PATCH net v4] net: ethernet: ti: cpsw_new: fix error handling in cpsw_ndo_vlan_rx_kill_vid()

2020-08-27 Thread David Miller
From: Murali Karicheri Date: Thu, 27 Aug 2020 10:38:39 -0400 > This patch fixes a bunch of issues in cpsw_ndo_vlan_rx_kill_vid() > > - pm_runtime_get_sync() returns non zero value. This results in >non zero value return to caller which will be interpreted as error. >So overwrite ret wit

Re: INFO: task can't die in p9_fd_close

2020-08-27 Thread Dominique Martinet
Mark Brown wrote on Wed, Aug 26, 2020: > On Wed, Aug 26, 2020 at 03:38:15AM -0700, syzbot wrote: > > > console output: https://syzkaller.appspot.com/x/log.txt?x=10615b3690 > > kernel config: https://syzkaller.appspot.com/x/.config?x=a61d44f28687f508 > > dashboard link: https://syzkaller.appsp

Re: [PATCH v3 5/8] net: dsa: hellcreek: Add TAPRIO offloading support

2020-08-27 Thread Richard Cochran
On Tue, Aug 25, 2020 at 11:55:37AM +0200, Kurt Kanzenbach wrote: > > I get your point. But how to do it? We would need a timer based on the > PTP clock in the switch. Can't you use an hrtimer based on CLOCK_MONOTONIC? I would expect the driver to work based solely on the device's clock. Thanks,

Re: [PATCH net-next v3] gtp: add notification mechanism

2020-08-27 Thread Nicolas Dichtel
Le 27/08/2020 à 17:05, David Miller a écrit : > From: Nicolas Dichtel > Date: Thu, 27 Aug 2020 14:19:23 +0200 > >> Like all other network functions, let's notify gtp context on creation and >> deletion. >> >> Signed-off-by: Nicolas Dichtel >> Tested-by: Gabriel Ganne >> Acked-by: Harald Welte

[PATCH RFC] netlabel: remove unused param from audit_log_format()

2020-08-27 Thread Alex Dewar
Commit d3b990b7f327 ("netlabel: fix problems with mapping removal") added a check to return an error if ret_val != 0, before ret_val is later used in a log message. Now it will unconditionally print "... res=0". So don't print res anymore. Addresses-Coverity: ("Dead code") Fixes: d3b990b7f327 ("ne

Re: [PATCH] ptp: ptp_ines: Remove redundant null check

2020-08-27 Thread Richard Cochran
On Wed, Aug 26, 2020 at 03:12:51AM +, Xu Wang wrote: > Because kfree_skb already checked NULL skb parameter, > so the additional check is unnecessary, just remove it. > > Signed-off-by: Xu Wang Acked-by: Richard Cochran

Re: [PATCH 6/9] dt-bindings: gpio: renesas,rcar-gpio: Add r8a774e1 support

2020-08-27 Thread Lad, Prabhakar
Hi Linus and Bartosz, On Mon, Jul 13, 2020 at 10:35 PM Lad Prabhakar wrote: > > Document Renesas RZ/G2H (R8A774E1) GPIO blocks compatibility within the > relevant dt-bindings. > > Signed-off-by: Lad Prabhakar > --- > Documentation/devicetree/bindings/gpio/renesas,rcar-gpio.yaml | 1 + > 1 file

Re: [PATCH net-next v3] gtp: add notification mechanism

2020-08-27 Thread David Miller
From: Nicolas Dichtel Date: Thu, 27 Aug 2020 18:37:32 +0200 > Le 27/08/2020 à 17:05, David Miller a écrit : >> From: Nicolas Dichtel >> Date: Thu, 27 Aug 2020 14:19:23 +0200 >> >>> Like all other network functions, let's notify gtp context on creation and >>> deletion. >>> >>> Signed-off-by: Ni

Re: [PATCH net-next v3] gtp: add notification mechanism

2020-08-27 Thread Nicolas Dichtel
Le 27/08/2020 à 18:44, David Miller a écrit : > Was build testing, it's pushed out now. > Thanks David!

Re: [PATCH 02/20] dt-bindings: thermal: rcar-gen3-thermal: Add r8a774e1 support

2020-08-27 Thread Lad, Prabhakar
Hi Zhang,Daniel,Amit, On Wed, Jul 15, 2020 at 12:09 PM Lad Prabhakar wrote: > > Document RZ/G2H (R8A774E1) SoC bindings. > > Signed-off-by: Lad Prabhakar > --- > Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml | 1 + > 1 file changed, 1 insertion(+) > Gentle ping. Cheers, Prab

Re: [PATCH 05/20] dt-bindings: timer: renesas,cmt: Document r8a774e1 CMT support

2020-08-27 Thread Lad, Prabhakar
Hi Daniel and Thomas, On Wed, Jul 15, 2020 at 12:09 PM Lad Prabhakar wrote: > > Document SoC specific bindings for RZ/G2H (r8a774e1) SoC. > > Signed-off-by: Lad Prabhakar > --- > Documentation/devicetree/bindings/timer/renesas,cmt.yaml | 2 ++ > 1 file changed, 2 insertions(+) > Gentle ping. C

Re: [PATCH RFC] netlabel: remove unused param from audit_log_format()

2020-08-27 Thread Paul Moore
On Thu, Aug 27, 2020 at 12:39 PM Alex Dewar wrote: > > Commit d3b990b7f327 ("netlabel: fix problems with mapping removal") > added a check to return an error if ret_val != 0, before ret_val is > later used in a log message. Now it will unconditionally print "... > res=0". So don't print res anymor

Re: [PATCH RFC] netlabel: remove unused param from audit_log_format()

2020-08-27 Thread Alex Dewar
On Thu, Aug 27, 2020 at 01:00:58PM -0400, Paul Moore wrote: > On Thu, Aug 27, 2020 at 12:39 PM Alex Dewar wrote: > > > > Commit d3b990b7f327 ("netlabel: fix problems with mapping removal") > > added a check to return an error if ret_val != 0, before ret_val is > > later used in a log message. Now

RE: [net-next v5 01/15] virtchnl: Extend AVF ops

2020-08-27 Thread Brady, Alan
> -Original Message- > From: Jakub Kicinski > Sent: Monday, August 24, 2020 12:43 PM > To: Nguyen, Anthony L > Cc: da...@davemloft.net; Michael, Alice ; > netdev@vger.kernel.org; nhor...@redhat.com; sassm...@redhat.com; > Kirsher, Jeffrey T ; Brady, Alan > ; Burra, Phani R ; Hay, > Joshua

Re: [PATCH RFC] netlabel: remove unused param from audit_log_format()

2020-08-27 Thread Alex Dewar
On Thu, Aug 27, 2020 at 06:06:34PM +0100, Alex Dewar wrote: > On Thu, Aug 27, 2020 at 01:00:58PM -0400, Paul Moore wrote: > > On Thu, Aug 27, 2020 at 12:39 PM Alex Dewar wrote: > > > > > > Commit d3b990b7f327 ("netlabel: fix problems with mapping removal") > > > added a check to return an error if

RE: [net-next v5 04/15] iecm: Common module introduction and function stubs

2020-08-27 Thread Brady, Alan
> -Original Message- > From: Jakub Kicinski > Sent: Monday, August 24, 2020 1:41 PM > To: Nguyen, Anthony L > Cc: da...@davemloft.net; Michael, Alice ; > netdev@vger.kernel.org; nhor...@redhat.com; sassm...@redhat.com; > Kirsher, Jeffrey T ; Brady, Alan > ; Burra, Phani R ; Hay, > Joshua

RE: [net-next v5 11/15] iecm: Add splitq TX/RX

2020-08-27 Thread Brady, Alan
> -Original Message- > From: Jakub Kicinski > Sent: Monday, August 24, 2020 1:41 PM > To: Nguyen, Anthony L > Cc: da...@davemloft.net; Michael, Alice ; > netdev@vger.kernel.org; nhor...@redhat.com; sassm...@redhat.com; > Kirsher, Jeffrey T ; Brady, Alan > ; Burra, Phani R ; Hay, > Joshua

RE: [net-next v5 08/15] iecm: Implement vector allocation

2020-08-27 Thread Brady, Alan
> -Original Message- > From: Jakub Kicinski > Sent: Monday, August 24, 2020 1:42 PM > To: Nguyen, Anthony L > Cc: da...@davemloft.net; Michael, Alice ; > netdev@vger.kernel.org; nhor...@redhat.com; sassm...@redhat.com; > Kirsher, Jeffrey T ; Brady, Alan > ; Burra, Phani R ; Hay, > Joshua

RE: [net-next v5 13/15] iecm: Add ethtool

2020-08-27 Thread Brady, Alan
> -Original Message- > From: Michal Kubecek > Sent: Monday, August 24, 2020 2:45 PM > To: Nguyen, Anthony L > Cc: da...@davemloft.net; Michael, Alice ; > netdev@vger.kernel.org; nhor...@redhat.com; sassm...@redhat.com; > Kirsher, Jeffrey T ; Brady, Alan > ; Burra, Phani R ; Hay, > Joshua

[Patch net] net_sched: fix error path in red_init()

2020-08-27 Thread Cong Wang
When ->init() fails, ->destroy() is called to clean up. So it is unnecessary to clean up in red_init(), and it would cause some refcount underflow. Fixes: aee9caa03fc3 ("net: sched: sch_red: Add qevents "early_drop" and "mark"") Reported-and-tested-by: syzbot+b33c1cb0a30ebdc8a...@syzkaller.appspot

Re: [PATCH] Revert "wlcore: Adding suppoprt for IGTK key in wlcore driver"

2020-08-27 Thread Mauro Carvalho Chehab
Em Thu, 27 Aug 2020 08:48:30 -0700 Steve deRosier escreveu: > On Tue, Aug 25, 2020 at 10:49 PM Mauro Carvalho Chehab > wrote: > > > > This patch causes a regression betwen Kernel 5.7 and 5.8 at wlcore: > > with it applied, WiFi stops working, and the Kernel starts printing > > this message every

Re: [PATCH net 1/2] net: disable netpoll on fresh napis

2020-08-27 Thread Jakub Kicinski
On Thu, 27 Aug 2020 08:43:22 -0700 Eric Dumazet wrote: > On 8/27/20 8:10 AM, Jakub Kicinski wrote: > > On Thu, 27 Aug 2020 00:25:31 -0700 Eric Dumazet wrote: > >> On 8/26/20 12:40 PM, Jakub Kicinski wrote: > >>> To ensure memory ordering is correct we need to use RCU accessors. > >> > >>> +

Re: [PATCH] net: usb: Fix uninit-was-stored issue in asix_read_phy_addr()

2020-08-27 Thread Eric Biggers
On Thu, Aug 27, 2020 at 12:23:55PM +0530, Himadri Pandya wrote: > The buffer size is 2 Bytes and we expect to receive the same amount of > data. But sometimes we receive less data and run into uninit-was-stored > issue upon read. Hence modify the error check on the return value to match > with the

[PATCH v2 net-next 00/12] ionic memory usage rework

2020-08-27 Thread Shannon Nelson
Previous review comments have suggested [1],[2] that this driver needs to rework how queue resources are managed and reconfigured so that we don't do a full driver reset and to better handle potential allocation failures. This patchset is intended to address those comments. The first few patches

[PATCH v2 net-next 01/12] ionic: set MTU floor at ETH_MIN_MTU

2020-08-27 Thread Shannon Nelson
The NIC might tell us its minimum MTU, but let's be sure not to use something smaller than ETH_MIN_MTU. Signed-off-by: Shannon Nelson --- drivers/net/ethernet/pensando/ionic/ionic_lif.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/pensando/ionic/ioni

[PATCH v2 net-next 02/12] ionic: fix up a couple of debug strings

2020-08-27 Thread Shannon Nelson
Fix the queue name displayed. Signed-off-by: Shannon Nelson --- drivers/net/ethernet/pensando/ionic/ionic_lif.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/pensando/ionic/ionic_lif.c b/drivers/net/ethernet/pensando/ionic/ionic_lif.c index 2352

[PATCH v2 net-next 03/12] ionic: use kcalloc for new arrays

2020-08-27 Thread Shannon Nelson
Use kcalloc for allocating arrays of structures. Following along after commit e71642009cbdA ("ionic_lif: Use devm_kcalloc() in ionic_qcq_alloc()") there are a couple more array allocations that can be converted to using devm_kcalloc(). Signed-off-by: Shannon Nelson --- drivers/net/ethernet/pens

[PATCH v2 net-next 09/12] ionic: change mtu without full queue rebuild

2020-08-27 Thread Shannon Nelson
We really don't need to tear down and rebuild the whole queue structure when changing the MTU; we can simply stop the queues, clean and refill, then restart the queues. Signed-off-by: Shannon Nelson --- .../net/ethernet/pensando/ionic/ionic_lif.c | 57 --- 1 file changed, 49 in

[PATCH v2 net-next 05/12] ionic: rework and simplify handling of the queue stats block

2020-08-27 Thread Shannon Nelson
Use a block of stats structs attached to the lif instead of little ones attached to each qcq. This simplifies our memory management and gets rid of a lot of unnecessary indirection. Signed-off-by: Shannon Nelson --- .../ethernet/pensando/ionic/ionic_ethtool.c | 4 +- .../net/ethernet/pensan

[PATCH v2 net-next 11/12] ionic: change queue count with no reset

2020-08-27 Thread Shannon Nelson
Add to our new ionic_reconfigure_queues() to also be able to change the number of queues in use, and to change the queue interrupt layout between split and combined. Signed-off-by: Shannon Nelson --- .../ethernet/pensando/ionic/ionic_ethtool.c | 88 --- .../net/ethernet/pensando/ionic/ion

[PATCH v2 net-next 06/12] ionic: clean up unnecessary non-static functions

2020-08-27 Thread Shannon Nelson
ionic_open() and ionic_stop() are not referenced outside of their defining file, so make them static. Signed-off-by: Shannon Nelson --- drivers/net/ethernet/pensando/ionic/ionic_lif.c | 4 ++-- drivers/net/ethernet/pensando/ionic/ionic_lif.h | 2 -- 2 files changed, 2 insertions(+), 4 deletions(

[PATCH v2 net-next 07/12] ionic: reduce contiguous memory allocation requirement

2020-08-27 Thread Shannon Nelson
Split out the queue descriptor blocks into separate dma allocations to make for smaller blocks. Authored-by: Neel Patel Signed-off-by: Shannon Nelson --- .../ethernet/pensando/ionic/ionic_debugfs.c | 23 ++-- .../net/ethernet/pensando/ionic/ionic_lif.c | 100 +++--- .../net/eth

[PATCH v2 net-next 10/12] ionic: change the descriptor ring length without full reset

2020-08-27 Thread Shannon Nelson
The original way of changing ring length was to completely tear down the lif's queue structure and then rebuild it, while running the risk of allocations that might fail in the middle and leave us with a broken driver. Instead, we can set up all the new queue and descriptor allocations first, then

[PATCH v2 net-next 04/12] ionic: remove lif list concept

2020-08-27 Thread Shannon Nelson
As we aren't yet supporting multiple lifs, we can remove complexity by removing the list concept and related code, to be re-engineered later when actually needed. Signed-off-by: Shannon Nelson --- drivers/net/ethernet/pensando/ionic/ionic.h | 4 +- .../ethernet/pensando/ionic/ionic_bus_pci.c

[PATCH v2 net-next 12/12] ionic: pull reset_queues into tx_timeout handler

2020-08-27 Thread Shannon Nelson
Convert tx_timeout handler to not do the full reset. As this was the last user of ionic_reset_queues(), we can drop it. Signed-off-by: Shannon Nelson --- .../net/ethernet/pensando/ionic/ionic_lif.c | 39 --- .../net/ethernet/pensando/ionic/ionic_lif.h | 1 - 2 files changed

[PATCH v2 net-next 08/12] ionic: use index not pointer for queue tracking

2020-08-27 Thread Shannon Nelson
Use index counters rather than pointers for tracking head and tail in the queues to save a little memory and to perhaps slightly faster queue processing. Signed-off-by: Shannon Nelson --- .../ethernet/pensando/ionic/ionic_debugfs.c | 6 +- .../net/ethernet/pensando/ionic/ionic_dev.c | 40 ++

Re: [PATCH bpf-next 2/5] bpf: add main_thread_only customization for task/task_file iterators

2020-08-27 Thread Yonghong Song
On 8/26/20 10:07 PM, Andrii Nakryiko wrote: On Wed, Aug 26, 2020 at 5:07 PM Yonghong Song wrote: Currently, task and task_file by default iterates through all tasks. For task_file, by default, all files from all tasks will be traversed. But for a user process, the file_table is shared by a

Re: [05/16] atmel: convert tasklets to use new tasklet_setup() API

2020-08-27 Thread Kees Cook
On Thu, Aug 27, 2020 at 01:23:20PM +, Kalle Valo wrote: > Allen Pais wrote: > > > From: Allen Pais > > > > In preparation for unconditionally passing the > > struct tasklet_struct pointer to all tasklet > > callbacks, switch to using the new tasklet_setup() > > and from_tasklet() to pass th

Re: [net-next v5 08/15] iecm: Implement vector allocation

2020-08-27 Thread Jakub Kicinski
On Thu, 27 Aug 2020 17:28:29 + Brady, Alan wrote: > > On Mon, 24 Aug 2020 10:32:59 -0700 Tony Nguyen wrote: > > > static void iecm_mb_intr_rel_irq(struct iecm_adapter *adapter) { > > > - /* stub */ > > > + int irq_num; > > > + > > > + irq_num = adapter->msix_entries[0].vector; > > > + synch

Re: [PATCH net-next 2/3] devlink: Consider other controller while building phys_port_name

2020-08-27 Thread Jakub Kicinski
On Thu, 27 Aug 2020 04:31:43 + Parav Pandit wrote: > > > $ devlink port show looks like below without a controller annotation. > > > pci/:00:08.0/0: type eth netdev eth5 flavour physical > > > pci/:00:08.0/1: type eth netdev eth6 flavour pcipf pfnum 0 > > > pci/:00:08.0/2: type eth

VRRP not working on i40e X722 S2600WFT

2020-08-27 Thread Lennart Sorensen
I have hit a new problem with the X722 chipset (Intel R1304WFT server). VRRP simply does not work. When keepalived registers a vmac interface, and starts transmitting multicast packets with the vrp message, it never receives those packets from the peers, so all nodes think they are the master. tc

Re: [PATCH 6/9] dt-bindings: gpio: renesas,rcar-gpio: Add r8a774e1 support

2020-08-27 Thread Bartosz Golaszewski
On Thu, Aug 27, 2020 at 6:40 PM Lad, Prabhakar wrote: > > Hi Linus and Bartosz, > > On Mon, Jul 13, 2020 at 10:35 PM Lad Prabhakar > wrote: > > > > Document Renesas RZ/G2H (R8A774E1) GPIO blocks compatibility within the > > relevant dt-bindings. > > > > Signed-off-by: Lad Prabhakar > > --- > >

Re: [PATCH][next] atmel: Use fallthrough pseudo-keyword

2020-08-27 Thread Gustavo A. R. Silva
On Thu, Aug 27, 2020 at 01:09:33PM +, Kalle Valo wrote: > "Gustavo A. R. Silva" wrote: > > > Replace the existing /* fall through */ comments and its variants with > > the new pseudo-keyword macro fallthrough[1]. > > > > [1] > > https://www.kernel.org/doc/html/v5.7/process/deprecated.html?h

Re: [PATCH bpf-next v3 2/4] selftests/bpf: add test for freplace program with write access

2020-08-27 Thread Udip Pant
On 8/26/20, 11:05 PM, "Andrii Nakryiko" wrote: On Tue, Aug 25, 2020 at 4:21 PM Udip Pant wrote: >> >> This adds a selftest that tests the behavior when a freplace target program >> attempts to make a write access on a packet. The expectation is that the >> read or write >> access is granted

Re: [PATCH net-next v1 3/3] hinic: add support to query function table

2020-08-27 Thread Jakub Kicinski
On Thu, 27 Aug 2020 19:13:21 +0800 Luo bin wrote: > + switch (idx) { > + case VALID: > + return funcfg_table_elem->dw0.bs.valid; > + case RX_MODE: > + return funcfg_table_elem->dw0.bs.nic_rx_mode; > + case MTU: > + return funcfg_table_elem->dw1.bs

Re: [PATCH v2 net-next 07/12] ionic: reduce contiguous memory allocation requirement

2020-08-27 Thread Jakub Kicinski
On Thu, 27 Aug 2020 11:07:30 -0700 Shannon Nelson wrote: > + q_base = (void *)PTR_ALIGN((uintptr_t)new->q_base, PAGE_SIZE); The point of PTR_ALIGN is to make the casts unnecessary. Does it not work?

Re: [PATCH v2 net-next 07/12] ionic: reduce contiguous memory allocation requirement

2020-08-27 Thread Jakub Kicinski
On Thu, 27 Aug 2020 11:07:30 -0700 Shannon Nelson wrote: > Authored-by: Neel Patel Also - what's Authored-by? :S Do we need a sign-off for this? Perhaps Co-developed-by, which is more standard?

Re: [PATCH v2 net-next 07/12] ionic: reduce contiguous memory allocation requirement

2020-08-27 Thread Shannon Nelson
On 8/27/20 12:46 PM, Jakub Kicinski wrote: On Thu, 27 Aug 2020 11:07:30 -0700 Shannon Nelson wrote: + q_base = (void *)PTR_ALIGN((uintptr_t)new->q_base, PAGE_SIZE); The point of PTR_ALIGN is to make the casts unnecessary. Does it not work? Here's what I see from two different compiler

[PATCH] Remove ipvs v6 dependency on iptables

2020-08-27 Thread Lach
This dependency was added in 63dca2c0b0e7a92cb39d1b1ecefa32ffda201975, because this commit had dependency on ipv6_find_hdr, which was located in iptables-specific code But it is no longer required, because f8f626754ebeca613cf1af2e6f890cfde0e74d5b moved them to a more common location --- net/net

Re: [PATCH net 0/7] rxrpc, afs: Fix probing issues

2020-08-27 Thread David Miller
From: David Howells Date: Thu, 27 Aug 2020 16:03:33 +0100 > > Here are some fixes for rxrpc and afs to fix issues in the RTT measuring in > rxrpc and thence the Volume Location server probing in afs: > > (1) Move the serial number of a received ACK into a local variable to > simplify the

Re: [PATCH net] rxrpc: Fix memory leak in rxkad_verify_response()

2020-08-27 Thread David Miller
From: David Howells Date: Thu, 27 Aug 2020 16:55:46 +0100 > From: Dinghao Liu > > Fix a memory leak in rxkad_verify_response() whereby the response buffer > doesn't get freed if we fail to allocate a ticket buffer. > > Fixes: ef68622da9cc ("rxrpc: Handle temporary errors better in rxkad > sec

Re: [PATCH RFC] netlabel: remove unused param from audit_log_format()

2020-08-27 Thread Paul Moore
On Thu, Aug 27, 2020 at 1:20 PM Alex Dewar wrote: > On Thu, Aug 27, 2020 at 06:06:34PM +0100, Alex Dewar wrote: > > On Thu, Aug 27, 2020 at 01:00:58PM -0400, Paul Moore wrote: > > > On Thu, Aug 27, 2020 at 12:39 PM Alex Dewar > > > wrote: > > > > > > > > Commit d3b990b7f327 ("netlabel: fix probl

RE: [PATCH net-next 2/3] devlink: Consider other controller while building phys_port_name

2020-08-27 Thread Parav Pandit
> From: Jakub Kicinski > Sent: Friday, August 28, 2020 12:02 AM > > On Thu, 27 Aug 2020 04:31:43 + Parav Pandit wrote: > > > > $ devlink port show looks like below without a controller annotation. > > > > pci/:00:08.0/0: type eth netdev eth5 flavour physical > > > > pci/:00:08.0/1:

<    1   2   3   >