> -----Original Message-----
> From: Jakub Kicinski <k...@kernel.org>
> Sent: Monday, August 24, 2020 12:43 PM
> To: Nguyen, Anthony L <anthony.l.ngu...@intel.com>
> Cc: da...@davemloft.net; Michael, Alice <alice.mich...@intel.com>;
> netdev@vger.kernel.org; nhor...@redhat.com; sassm...@redhat.com;
> Kirsher, Jeffrey T <jeffrey.t.kirs...@intel.com>; Brady, Alan
> <alan.br...@intel.com>; Burra, Phani R <phani.r.bu...@intel.com>; Hay,
> Joshua A <joshua.a....@intel.com>; Chittim, Madhu
> <madhu.chit...@intel.com>; Linga, Pavan Kumar
> <pavan.kumar.li...@intel.com>; Skidmore, Donald C
> <donald.c.skidm...@intel.com>; Brandeburg, Jesse
> <jesse.brandeb...@intel.com>; Samudrala, Sridhar
> <sridhar.samudr...@intel.com>
> Subject: Re: [net-next v5 01/15] virtchnl: Extend AVF ops
>
> On Mon, 24 Aug 2020 10:32:52 -0700 Tony Nguyen wrote:
> > +struct virtchnl_rss_hash {
> > + u64 hash;
> > + u16 vport_id;
> > +};
> > +
> > +VIRTCHNL_CHECK_STRUCT_LEN(16, virtchnl_rss_hash);
>
> I've added 32bit builds to my local setup since v4 was posted - looks like
> there's
> a number of errors here. You can't assume u64 forces a 64bit alignment. Best
> to
> specify the padding explicitly.
>
> FWIW these are the errors I got but there may be more:
>
It seems like these are triggering on old messages too, curious why this wasn't
caught sooner. Will fix, thanks.
-Alan
