> -----Original Message-----
> From: Jakub Kicinski <k...@kernel.org>
> Sent: Monday, August 24, 2020 1:41 PM
> To: Nguyen, Anthony L <anthony.l.ngu...@intel.com>
> Cc: da...@davemloft.net; Michael, Alice <alice.mich...@intel.com>;
> netdev@vger.kernel.org; nhor...@redhat.com; sassm...@redhat.com;
> Kirsher, Jeffrey T <jeffrey.t.kirs...@intel.com>; Brady, Alan
> <alan.br...@intel.com>; Burra, Phani R <phani.r.bu...@intel.com>; Hay,
> Joshua A <joshua.a....@intel.com>; Chittim, Madhu
> <madhu.chit...@intel.com>; Linga, Pavan Kumar
> <pavan.kumar.li...@intel.com>; Skidmore, Donald C
> <donald.c.skidm...@intel.com>; Brandeburg, Jesse
> <jesse.brandeb...@intel.com>; Samudrala, Sridhar
> <sridhar.samudr...@intel.com>
> Subject: Re: [net-next v5 11/15] iecm: Add splitq TX/RX
> 
> On Mon, 24 Aug 2020 10:33:02 -0700 Tony Nguyen wrote:
> >  void iecm_get_stats64(struct net_device *netdev,
> >                   struct rtnl_link_stats64 *stats)  {
> > -   /* stub */
> > +   struct iecm_vport *vport = iecm_netdev_to_vport(netdev);
> > +
> > +   iecm_send_get_stats_msg(vport);
> 
> Doesn't this call sleep? This .ndo callback can't sleep.

Will fix

-Alan

Reply via email to