On Thu, 27 Aug 2020 19:13:21 +0800 Luo bin wrote:
> + switch (idx) {
> + case VALID:
> + return funcfg_table_elem->dw0.bs.valid;
> + case RX_MODE:
> + return funcfg_table_elem->dw0.bs.nic_rx_mode;
> + case MTU:
> + return funcfg_table_elem->dw1.bs.mtu;
> + case VLAN_MODE:
> + return funcfg_table_elem->dw1.bs.vlan_mode;
> + case VLAN_ID:
> + return funcfg_table_elem->dw1.bs.vlan_id;
> + case RQ_DEPTH:
> + return funcfg_table_elem->dw13.bs.cfg_rq_depth;
> + case QUEUE_NUM:
> + return funcfg_table_elem->dw13.bs.cfg_q_num;
The first two patches look fairly unobjectionable to me, but here the
information does not seem that driver-specific. What's vlan_mode, and
vlan_id in the context of PF? Why expose mtu, is it different than
netdev mtu? What's valid? rq_depth?
