Re: [PATCH net-next 13/18] ionic: Add initial ethtool support

2019-06-24 Thread Michal Kubecek
On Fri, Jun 21, 2019 at 03:30:20PM -0700, Shannon Nelson wrote: > On 6/20/19 7:32 PM, Michal Kubecek wrote: > > On Thu, Jun 20, 2019 at 01:24:19PM -0700, Shannon Nelson wrote: > > > + if (ring->tx_pending > IONIC_MAX_TXRX_DESC || > > > + ring->tx_pending < IONIC_MIN_TXRX_DESC || > > > + rin

Re: [PATCH net-next 1/4] cxgb4: Re-work the logic for mps refcounting

2019-06-24 Thread Raju Rangoju
On Sunday, June 06/23/19, 2019 at 11:34:23 -0700, David Miller wrote: > From: Raju Rangoju > Date: Fri, 21 Jun 2019 20:06:33 +0530 > > > +struct mps_entries_ref { > > + struct list_head list; > > + u8 addr[ETH_ALEN]; > > + u8 mask[ETH_ALEN]; > > + u16 idx; > > + atomic_t refcnt; > > +};

Re: [PATCH net-next 10/16] qlge: Factor out duplicated expression

2019-06-24 Thread Benjamin Poirier
On 2019/06/23 10:59, David Miller wrote: > From: Benjamin Poirier > Date: Mon, 17 Jun 2019 16:48:52 +0900 > > > Signed-off-by: Benjamin Poirier > > --- > > drivers/net/ethernet/qlogic/qlge/qlge.h | 6 ++ > > drivers/net/ethernet/qlogic/qlge/qlge_main.c | 18 ++ > > 2 f

[PATCH net] tipc: check msg->req data len in tipc_nl_compat_bearer_disable

2019-06-24 Thread Xin Long
This patch is to fix an uninit-value issue, reported by syzbot: BUG: KMSAN: uninit-value in memchr+0xce/0x110 lib/string.c:981 Call Trace: __dump_stack lib/dump_stack.c:77 [inline] dump_stack+0x191/0x1f0 lib/dump_stack.c:113 kmsan_report+0x130/0x2a0 mm/kmsan/kmsan.c:622 __msan_

[PATCH net] tipc: remove the unnecessary msg->req check from tipc_nl_compat_bearer_set

2019-06-24 Thread Xin Long
tipc_nl_compat_bearer_set() is only called by tipc_nl_compat_link_set() which already does the check for msg->req check, so remove it from tipc_nl_compat_bearer_set(), and do the same in tipc_nl_compat_media_set(). Signed-off-by: Xin Long --- net/tipc/netlink_compat.c | 10 -- 1 file cha

Re: [PATCH net] tipc: check msg->req data len in tipc_nl_compat_bearer_disable

2019-06-24 Thread Eric Dumazet
On 6/24/19 12:59 AM, Xin Long wrote: > This patch is to fix an uninit-value issue, reported by syzbot: > > BUG: KMSAN: uninit-value in memchr+0xce/0x110 lib/string.c:981 > Call Trace: > __dump_stack lib/dump_stack.c:77 [inline] > dump_stack+0x191/0x1f0 lib/dump_stack.c:113 > kms

[PATCH v2 net-next 1/4] cxgb4: Re-work the logic for mps refcounting

2019-06-24 Thread Raju Rangoju
Remove existing mps refcounting code which was added only for encap filters and add necessary data structures/functions to support mps reference counting for all the mac filters. Also add wrapper functions for allocating and freeing encap mac filters. Signed-off-by: Raju Rangoju --- drivers/net/

[PATCH v2 net-next 2/4] cxgb4: Add MPS TCAM refcounting for raw mac filters

2019-06-24 Thread Raju Rangoju
This patch adds TCAM reference counting support for raw mac filters. Signed-off-by: Raju Rangoju --- drivers/net/ethernet/chelsio/cxgb4/cxgb4.h | 16 + drivers/net/ethernet/chelsio/cxgb4/cxgb4_mps.c | 46 ++ 2 files changed, 62 insertions(+) diff --git a/driv

[PATCH v2 net-next 0/4] cxgb4: Reference count MPS TCAM entries within a PF

2019-06-24 Thread Raju Rangoju
Firmware reference counts the MPS TCAM entries by PF and VF, but it does not do it for usage within a PF or VF. This patch adds the support to track MPS TCAM entries within a PF. v1->v2: Use refcount_t type instead of atomic_t for mps reference count Raju Rangoju (4): cxgb4: Re-work the logic

[PATCH v2 net-next 4/4] cxgb4: Add MPS refcounting for alloc/free mac filters

2019-06-24 Thread Raju Rangoju
This patch adds reference counting support for alloc/free mac filters Signed-off-by: Raju Rangoju --- drivers/net/ethernet/chelsio/cxgb4/cxgb4.h | 6 +++ drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 12 +++-- drivers/net/ethernet/chelsio/cxgb4/cxgb4_mps.c | 72 +++

[PATCH v2 net-next 3/4] cxgb4: Add MPS TCAM refcounting for cxgb4 change mac

2019-06-24 Thread Raju Rangoju
This patch adds TCAM reference counting support for cxgb4 change mac path Signed-off-by: Raju Rangoju --- drivers/net/ethernet/chelsio/cxgb4/cxgb4.h | 7 +++ drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 14 +++--- drivers/net/ethernet/chelsio/cxgb4/cxgb4_mps.c | 15 ++

Re: [PATCH bpf-next] libbpf: add xsk_ring_prod__free() function

2019-06-24 Thread Eelco Chaudron
On 21 Jun 2019, at 21:13, Andrii Nakryiko wrote: On Fri, Jun 21, 2019 at 8:26 AM Eelco Chaudron wrote: When an AF_XDP application received X packets, it does not mean X frames can be stuffed into the producer ring. To make it easier for AF_XDP applications this API allows them to check how

[PATCH net] net/packet: fix memory leak in packet_set_ring()

2019-06-24 Thread Eric Dumazet
syzbot found we can leak memory in packet_set_ring(), if user application provides buggy parameters. Fixes: 7f953ab2ba46 ("af_packet: TX_RING support for TPACKET_V3") Signed-off-by: Eric Dumazet Cc: Sowmini Varadhan Reported-by: syzbot --- net/packet/af_packet.c | 3 ++- 1 file changed, 2 inse

Re: [PATCH] xsk: sample kernel code is now in libbpf

2019-06-24 Thread Björn Töpel
On Fri, 21 Jun 2019 at 22:55, Eric Leblond wrote: > > Fix documentation that mention xdpsock_kern.c which has been > replaced by code embedded in libbpf. > > Signed-off-by: Eric Leblond Thanks Eric! Acked-by: Björn Töpel > --- > Documentation/networking/af_xdp.rst | 16 +++- > 1

Re: [PATCH bpf-next] libbpf: add xsk_ring_prod__free() function

2019-06-24 Thread Magnus Karlsson
On Mon, Jun 24, 2019 at 11:53 AM Eelco Chaudron wrote: > > > > On 21 Jun 2019, at 21:13, Andrii Nakryiko wrote: > > > On Fri, Jun 21, 2019 at 8:26 AM Eelco Chaudron > > wrote: > >> > >> When an AF_XDP application received X packets, it does not mean X > >> frames can be stuffed into the producer

[PATCH v4 rdma-next 1/3] qed*: Change dpi_addr to be denoted with __iomem

2019-06-24 Thread Michal Kalderon
Several casts were required around dpi_addr parameter in qed_rdma_if.h This is an address on the doorbell bar and should therefore be marked with __iomem. Reported-by: Jason Gunthorpe Signed-off-by: Michal Kalderon --- drivers/infiniband/hw/qedr/main.c | 2 +- drivers/infiniband/hw/qed

[PATCH v4 rdma-next 3/3] RDMA/qedr: Add iWARP doorbell recovery support

2019-06-24 Thread Michal Kalderon
This patch adds the iWARP specific doorbells to the doorbell recovery mechanism Signed-off-by: Ariel Elior Signed-off-by: Michal Kalderon --- drivers/infiniband/hw/qedr/qedr.h | 12 +++- drivers/infiniband/hw/qedr/verbs.c | 37 - 2 files changed, 43

[PATCH v4 rdma-next 0/3] RDMA/qedr: Use the doorbell overflow recovery mechanism for RDMA

2019-06-24 Thread Michal Kalderon
This patch series used the doorbell overflow recovery mechanism introduced in commit 36907cd5cd72 ("qed: Add doorbell overflow recovery mechanism") for rdma ( RoCE and iWARP ) rdma-core pull request #493 Changes from V3: - Remove casts from void to u8. Pointer arithmetic can be done on void - reb

[PATCH v4 rdma-next 2/3] RDMA/qedr: Add doorbell overflow recovery support

2019-06-24 Thread Michal Kalderon
Use the doorbell recovery mechanism to register rdma related doorbells that will be restored in case there is a doorbell overflow attention. Signed-off-by: Ariel Elior Signed-off-by: Michal Kalderon --- drivers/infiniband/hw/qedr/qedr.h | 13 +- drivers/infiniband/hw/qedr/verbs.c | 351 ++

[PATCH net-next v2 0/3] mlxsw: Thermal and hwmon extensions

2019-06-24 Thread Ido Schimmel
From: Ido Schimmel This patchset from Vadim includes various enhancements to thermal and hwmon code in mlxsw. Patch #1 adds a thermal zone for each inter-connect device (gearbox). These devices are present in SN3800 systems and code to expose their temperature via hwmon was added in commit 2e265

[PATCH net-next v2 1/3] mlxsw: core: Extend thermal core with per inter-connect device thermal zones

2019-06-24 Thread Ido Schimmel
From: Vadim Pasternak Add a dedicated thermal zone for each inter-connect device. The current temperature is obtained from inter-connect temperature sensor and the default trip points are set to the same values as default ASIC trip points. These settings could be changed from the user space. A co

[PATCH net-next v2 3/3] mlxsw: core: Add support for negative temperature readout

2019-06-24 Thread Ido Schimmel
From: Vadim Pasternak Extend macros MLXSW_REG_MTMP_TEMP_TO_MC() to allow support of negative temperature readout, since chip and others thermal components are capable of operating within the negative temperature. With no such support negative temperature will be consider as very high temperature

[PATCH net-next v2 2/3] mlxsw: core: Add the hottest thermal zone detection

2019-06-24 Thread Ido Schimmel
From: Vadim Pasternak When multiple sensors are mapped to the same cooling device, the cooling device should be set according the worst sensor from the sensors associated with this cooling device. Provide the hottest thermal zone detection and enforce cooling device to follow the temperature tre

RE: [EXT] Re: [PATCH v3 rdma-next 0/3] RDMA/qedr: Use the doorbell overflow recovery mechanism for RDMA

2019-06-24 Thread Michal Kalderon
> From: Jason Gunthorpe > Sent: Friday, June 21, 2019 10:58 PM > > External Email > > -- > On Fri, Jun 21, 2019 at 07:49:39PM +, Michal Kalderon wrote: > > > From: linux-rdma-ow...@vger.kernel.org > > ow...@vger.kernel.org>

Re: [PATCH net-next 1/7] net: aquantia: replace internal driver version code with uts

2019-06-24 Thread Igor Russkikh
> >> Devlink has just gained something similar to ethtool -i. Maybe we >> should get the devlink core to also report the kernel version? > > I don't think we have the driver version at all there, my usual > inclination being to not duplicate information across APIs. Do we > have non-hypothetic

Re: [PATCH net-next 2/7] net: aquantia: add documentation for the atlantic driver

2019-06-24 Thread Igor Russkikh
>> + increase the MTU size. For example: >> + >> +ifconfig mtu 16000 up > > ifconfig has been deprecated for many years. Please document the > iproute2 command. Thanks for review, Andrew, yep, will update that. >> + supports-priv-flags: no > > Shouldn't there be 5.2-rc5 in here some

[PATCH] samples: bpf: make the use of xdp samples consistent

2019-06-24 Thread Daniel T. Lee
Currently, each xdp samples are inconsistent in the use. Most of the samples fetch the interface with it's name. (ex. xdp1, xdp2skb, xdp_redirect, xdp_sample_pkts, etc.) But only xdp_adjst_tail and xdp_tx_iptunnel fetch the interface with ifindex by command argument. This commit enables those two

Re: [PATCH net-next v2 1/3] mlxsw: core: Extend thermal core with per inter-connect device thermal zones

2019-06-24 Thread Jiri Pirko
Mon, Jun 24, 2019 at 12:32:01PM CEST, ido...@idosch.org wrote: >From: Vadim Pasternak > >Add a dedicated thermal zone for each inter-connect device. The >current temperature is obtained from inter-connect temperature sensor >and the default trip points are set to the same values as default ASIC >t

Re: [PATCH net-next v2 3/3] mlxsw: core: Add support for negative temperature readout

2019-06-24 Thread Jiri Pirko
Mon, Jun 24, 2019 at 12:32:03PM CEST, ido...@idosch.org wrote: >From: Vadim Pasternak > >Extend macros MLXSW_REG_MTMP_TEMP_TO_MC() to allow support of negative >temperature readout, since chip and others thermal components are >capable of operating within the negative temperature. >With no such su

Re: [PATCH rdma-next v1 08/12] IB/mlx5: Introduce MLX5_IB_OBJECT_DEVX_ASYNC_EVENT_FD

2019-06-24 Thread Jason Gunthorpe
On Tue, Jun 18, 2019 at 08:15:36PM +0300, Leon Romanovsky wrote: > From: Yishai Hadas > > Introduce MLX5_IB_OBJECT_DEVX_ASYNC_EVENT_FD and its initial > implementation. > > This object is from type class FD and will be used to read DEVX > async events. > > Signed-off-by: Yishai Hadas > Signed-

Re: [PATCH rdma-next v1 09/12] IB/mlx5: Register DEVX with mlx5_core to get async events

2019-06-24 Thread Jason Gunthorpe
On Tue, Jun 18, 2019 at 08:15:37PM +0300, Leon Romanovsky wrote: > void __mlx5_ib_remove(struct mlx5_ib_dev *dev, > diff --git a/drivers/infiniband/hw/mlx5/mlx5_ib.h > b/drivers/infiniband/hw/mlx5/mlx5_ib.h > index 9cf23ae6324e..556af34b788b 100644 > +++ b/drivers/infiniband/hw/mlx5/mlx5_ib.h > @

Re: [PATCH rdma-next v1 10/12] IB/mlx5: Enable subscription for device events over DEVX

2019-06-24 Thread Jason Gunthorpe
On Tue, Jun 18, 2019 at 08:15:38PM +0300, Leon Romanovsky wrote: > From: Yishai Hadas > > Enable subscription for device events over DEVX. > > Each subscription is added to the two level XA data structure according > to its event number and the DEVX object information in case was given > with th

Re: [PATCH rdma-next v1 11/12] IB/mlx5: Implement DEVX dispatching event

2019-06-24 Thread Jason Gunthorpe
On Tue, Jun 18, 2019 at 08:15:39PM +0300, Leon Romanovsky wrote: > From: Yishai Hadas > > Implement DEVX dispatching event by looking up for the applicable > subscriptions for the reported event and using their target fd to > signal/set the event. > > Signed-off-by: Yishai Hadas > Signed-off-by

Re: [PATCH rdma-next v1 12/12] IB/mlx5: Add DEVX support for CQ events

2019-06-24 Thread Jason Gunthorpe
On Tue, Jun 18, 2019 at 08:15:40PM +0300, Leon Romanovsky wrote: > From: Yishai Hadas > > Add DEVX support for CQ events by creating and destroying the CQ via > mlx5_core and set an handler to manage its completions. > > Signed-off-by: Yishai Hadas > Signed-off-by: Leon Romanovsky > drivers/i

Re: [PATCH rdma-next v1 08/12] IB/mlx5: Introduce MLX5_IB_OBJECT_DEVX_ASYNC_EVENT_FD

2019-06-24 Thread Yishai Hadas
On 6/24/2019 2:51 PM, Jason Gunthorpe wrote: On Tue, Jun 18, 2019 at 08:15:36PM +0300, Leon Romanovsky wrote: From: Yishai Hadas Introduce MLX5_IB_OBJECT_DEVX_ASYNC_EVENT_FD and its initial implementation. This object is from type class FD and will be used to read DEVX async events. Signed-o

Re: [PATCH rdma-next v1 09/12] IB/mlx5: Register DEVX with mlx5_core to get async events

2019-06-24 Thread Yishai Hadas
On 6/24/2019 2:52 PM, Jason Gunthorpe wrote: On Tue, Jun 18, 2019 at 08:15:37PM +0300, Leon Romanovsky wrote: void __mlx5_ib_remove(struct mlx5_ib_dev *dev, diff --git a/drivers/infiniband/hw/mlx5/mlx5_ib.h b/drivers/infiniband/hw/mlx5/mlx5_ib.h index 9cf23ae6324e..556af34b788b 100644 +++ b/d

Re: [PATCH bpf] bpf: fix NULL deref in btf_type_is_resolve_source_only

2019-06-24 Thread Daniel Borkmann
On 06/19/2019 09:01 PM, Stanislav Fomichev wrote: > Commit 1dc92851849c ("bpf: kernel side support for BTF Var and DataSec") > added invocations of btf_type_is_resolve_source_only before > btf_type_nosize_or_null which checks for the NULL pointer. > Swap the order of btf_type_nosize_or_null and > b

[PATCH net v2 0/2] ipv6: fix neighbour resolution with raw socket

2019-06-24 Thread Nicolas Dichtel
The first patch prepares the fix, it constify rt6_nexthop(). The detail of the bug is explained in the second patch. v1 -> v2: - fix compilation warnings - split the initial patch drivers/net/vrf.c| 2 +- include/net/ip6_route.h | 4 ++-- net/bluetooth/6lowpan.c

[PATCH net v2 1/2] ipv6: constify rt6_nexthop()

2019-06-24 Thread Nicolas Dichtel
There is no functional change in this patch, it only prepares the next one. rt6_nexthop() will be used by ip6_dst_lookup_neigh(), which uses const variables. Signed-off-by: Nicolas Dichtel --- drivers/net/vrf.c| 2 +- include/net/ip6_route.h | 4 ++-- net/bluetooth/6low

[PATCH net v2 2/2] ipv6: fix neighbour resolution with raw socket

2019-06-24 Thread Nicolas Dichtel
The scenario is the following: the user uses a raw socket to send an ipv6 packet, destinated to a not-connected network, and specify a connected nh. Here is the corresponding python script to reproduce this scenario: import socket IPPROTO_RAW = 255 send_s = socket.socket(socket.AF_INET6, socket

Re: [PATCH bpf] samples/bpf: xdp_redirect, correctly get dummy program id

2019-06-24 Thread Daniel Borkmann
On 06/20/2019 08:58 AM, Prashant Bhole wrote: > When we terminate xdp_redirect, it ends up with following message: > "Program on iface OUT changed, not removing" > This results in dummy prog still attached to OUT interface. > It is because signal handler checks if the programs are the same that > w

Re: [PATCH net] net/tls: fix page double free on TX cleanup

2019-06-24 Thread David Miller
From: Jakub Kicinski Date: Sun, 23 Jun 2019 21:26:58 -0700 > From: Dirk van der Merwe > > With commit 94850257cf0f ("tls: Fix tls_device handling of partial records") > a new path was introduced to cleanup partial records during sk_proto_close. > This path does not handle the SW KTLS tx_list cl

Re: [PATCH bpf-next] bpftool: Add BPF_F_QUERY_EFFECTIVE support in bpftool cgroup [show|tree]

2019-06-24 Thread Daniel Borkmann
On 06/22/2019 12:33 AM, Takshak Chahande wrote: > With different bpf attach_flags available to attach bpf programs specially > with BPF_F_ALLOW_OVERRIDE and BPF_F_ALLOW_MULTI, the list of effective > bpf-programs available to any sub-cgroups really needs to be available for > easy debugging. > > U

Re: [net-next v2] tipc: add loopback device tracking

2019-06-24 Thread David Miller
From: john.rutherf...@dektech.com.au Date: Mon, 24 Jun 2019 16:44:35 +1000 > Since node internal messages are passed directly to socket it is not > possible to observe this message exchange via tcpdump or wireshark. > > We now remedy this by making it possible to clone such messages and send > th

Re: [PATCH 01/11] i40e: simplify Rx buffer recycle

2019-06-24 Thread Björn Töpel
On Thu, 20 Jun 2019 at 19:25, Kevin Laatz wrote: > > Currently, the dma, addr and handle are modified when we reuse Rx buffers > in zero-copy mode. However, this is not required as the inputs to the > function are copies, not the original values themselves. As we use the > copies within the functi

Re: [net-next] tipc: fix missing indentation in source code

2019-06-24 Thread David Miller
From: John Rutherford Date: Mon, 24 Jun 2019 14:01:23 +1000 > Fix misalignment of policy statement in netlink.c due to automatic > spatch code transformation. > > Fixes: 3b0f31f2b8c9 ("genetlink: make policy common to family") > Acked-by: Jon Maloy > Signed-off-by: John Rutherford Applied.

Re: [PATCH rdma-next v1 08/12] IB/mlx5: Introduce MLX5_IB_OBJECT_DEVX_ASYNC_EVENT_FD

2019-06-24 Thread Jason Gunthorpe
On Mon, Jun 24, 2019 at 04:25:37PM +0300, Yishai Hadas wrote: > On 6/24/2019 2:51 PM, Jason Gunthorpe wrote: > > On Tue, Jun 18, 2019 at 08:15:36PM +0300, Leon Romanovsky wrote: > > > From: Yishai Hadas > > > > > > Introduce MLX5_IB_OBJECT_DEVX_ASYNC_EVENT_FD and its initial > > > implementation.

Re: [PATCH rdma-next v1 09/12] IB/mlx5: Register DEVX with mlx5_core to get async events

2019-06-24 Thread Jason Gunthorpe
On Mon, Jun 24, 2019 at 04:36:44PM +0300, Yishai Hadas wrote: > On 6/24/2019 2:52 PM, Jason Gunthorpe wrote: > > On Tue, Jun 18, 2019 at 08:15:37PM +0300, Leon Romanovsky wrote: > > > void __mlx5_ib_remove(struct mlx5_ib_dev *dev, > > > diff --git a/drivers/infiniband/hw/mlx5/mlx5_ib.h > > > b/d

Re: [PATCH 02/11] ixgbe: simplify Rx buffer recycle

2019-06-24 Thread Björn Töpel
On Thu, 20 Jun 2019 at 19:25, Kevin Laatz wrote: > > Currently, the dma, addr and handle are modified when we reuse Rx buffers > in zero-copy mode. However, this is not required as the inputs to the > function are copies, not the original values themselves. As we use the > copies within the functi

Re: [PATCH 03/11] xdp: add offset param to zero_copy_allocator

2019-06-24 Thread Björn Töpel
On Thu, 20 Jun 2019 at 19:25, Kevin Laatz wrote: > > This patch adds an offset parameter for zero_copy_allocator. > > This change is required for the unaligned chunk mode which will come later > in this patch set. The offset parameter is required for calculating the > original handle in unaligned

Re: [PATCH 04/11] i40e: add offset to zca_free

2019-06-24 Thread Björn Töpel
On Thu, 20 Jun 2019 at 19:25, Kevin Laatz wrote: > > This patch adds the offset param to for zero_copy_allocator to > i40e_zca_free. This change is required to calculate the handle, otherwise, > this function will not work in unaligned chunk mode since we can't easily mask > back to the original h

Re: [PATCH 05/11] ixgbe: add offset to zca_free

2019-06-24 Thread Björn Töpel
On Thu, 20 Jun 2019 at 19:25, Kevin Laatz wrote: > > This patch adds the offset param to for zero_copy_allocator to > ixgbe_zca_free. This change is required to calculate the handle, otherwise, > this function will not work in unaligned chunk mode since we can't easily mask > back to the original

Re: [PATCH net] tipc: remove the unnecessary msg->req check from tipc_nl_compat_bearer_set

2019-06-24 Thread David Miller
From: Xin Long Date: Mon, 24 Jun 2019 16:02:42 +0800 > tipc_nl_compat_bearer_set() is only called by tipc_nl_compat_link_set() > which already does the check for msg->req check, so remove it from > tipc_nl_compat_bearer_set(), and do the same in tipc_nl_compat_media_set(). > > Signed-off-by: Xin

Re: Removing skb_orphan() from ip_rcv_core()

2019-06-24 Thread Jamal Hadi Salim
On 2019-06-21 1:58 p.m., Joe Stringer wrote: Hi folks, picking this up again.. [..] During LSFMM, it seemed like no-one knew quite why the skb_orphan() is necessary in that path in the current version of the code, and that we may be able to remove it. Florian, I know you weren't in the room for

Re: [PATCH bpf-next v5 00/16] AF_XDP infrastructure improvements and mlx5e support

2019-06-24 Thread Daniel Borkmann
On 06/20/2019 11:13 AM, Björn Töpel wrote: > On Tue, 18 Jun 2019 at 14:00, Maxim Mikityanskiy wrote: >> >> This series contains improvements to the AF_XDP kernel infrastructure >> and AF_XDP support in mlx5e. The infrastructure improvements are >> required for mlx5e, but also some of them benefit

Re: [PATCH v2 net-next 0/4] cxgb4: Reference count MPS TCAM entries within a PF

2019-06-24 Thread David Miller
From: Raju Rangoju Date: Mon, 24 Jun 2019 14:20:33 +0530 > Firmware reference counts the MPS TCAM entries by PF and VF, > but it does not do it for usage within a PF or VF. This patch > adds the support to track MPS TCAM entries within a PF. > > v1->v2: > Use refcount_t type instead of atomic_t

[PATCH RFC net-next 0/5] net: dsa: MT7530: Convert to PHYLINK and add support for port 5

2019-06-24 Thread René van Dorst
Here by I am sending my current patches for review. I want to know if I am on the right track. 1. 0001-net-dsa-mt7530-Convert-to-PHYLINK-API.patch This patch converts mt7530 to PHYLINK API. 2. 0002-dt-bindings-net-dsa-mt7530-Add-support-for-port-5.patch 3. 0003-net-dsa-mt7530-Add-support-for-po

[PATCH RFC net-next 4/5] dt-bindings: net: dsa: mt7530: Add mediatek,ephy-handle to isolate ext. phy

2019-06-24 Thread René van Dorst
On some platforum the external phy can only interface to the port 5 of the switch because the RGMII TX and RX lines are swapped. But it still can be useful to use the internal phy of the switch to act as a WAN port which connectes to the 2nd GMAC. This gives WAN port dedicated bandwidth to the SOC.

[PATCH RFC net-next 5/5] net: dsa: mt7530: Add mediatek,ephy-handle to isolate external phy

2019-06-24 Thread René van Dorst
On some platforms the external phy can only interface with the port 5 of the switch because the xMII TX and RX lines are swapped. But it still can be useful to use the internal phy of the switch to act as a WAN port which connectes to the 2nd GMAC. This gives the SOC a double the bandwidth between

Re: [PATCH v2 net-next 0/4] cxgb4: Reference count MPS TCAM entries within a PF

2019-06-24 Thread David Miller
From: David Miller Date: Mon, 24 Jun 2019 07:51:32 -0700 (PDT) > From: Raju Rangoju > Date: Mon, 24 Jun 2019 14:20:33 +0530 > >> Firmware reference counts the MPS TCAM entries by PF and VF, >> but it does not do it for usage within a PF or VF. This patch >> adds the support to track MPS TCAM en

[PATCH RFC net-next 2/5] dt-bindings: net: dsa: mt7530: Add support for port 5

2019-06-24 Thread René van Dorst
MT7530 port 5 has many modes/configurations. Update the documentation how to use port 5. Signed-off-by: René van Dorst CC: devicet...@vger.kernel.org --- .../devicetree/bindings/net/dsa/mt7530.txt| 215 ++ 1 file changed, 215 insertions(+) diff --git a/Documentation/devicetr

[PATCH RFC net-next 3/5] net: dsa: mt7530: Add support for port 5

2019-06-24 Thread René van Dorst
Adding support for port 5. Port 5 ca muxed/interface to: - internal 5th GMAC of the switch; can be used as 2nd CPU port or as extra port with an external phy for a 6th ethernet port. - internal PHY of port 0 or 4; Used in most applications so that port 0 or 4 is the WAN port and interfaces wit

[PATCH RFC net-next 1/5] net: dsa: mt7530: Convert to PHYLINK API

2019-06-24 Thread René van Dorst
Convert mt7530 to PHYLINK API Signed-off-by: René van Dorst --- drivers/net/dsa/mt7530.c | 237 +-- drivers/net/dsa/mt7530.h | 9 ++ 2 files changed, 187 insertions(+), 59 deletions(-) diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c index 3

Re: [PATCH v2 net-next 0/4] cxgb4: Reference count MPS TCAM entries within a PF

2019-06-24 Thread David Miller
From: David Miller Date: Mon, 24 Jun 2019 07:53:23 -0700 (PDT) > You just changed it to a refcount_t and didn't try compiling the > result? You also need to fix this, which I tried to take care of this time: Applying: cxgb4: Re-work the logic for mps refcounting .git/rebase-apply/patch:291: new

Re: [PATCH] xsk: sample kernel code is now in libbpf

2019-06-24 Thread Daniel Borkmann
On 06/21/2019 10:13 PM, Eric Leblond wrote: > Fix documentation that mention xdpsock_kern.c which has been > replaced by code embedded in libbpf. > > Signed-off-by: Eric Leblond Applied, thanks!

Re: [PATCH net] net/packet: fix memory leak in packet_set_ring()

2019-06-24 Thread David Miller
From: Eric Dumazet Date: Mon, 24 Jun 2019 02:38:20 -0700 > syzbot found we can leak memory in packet_set_ring(), if user application > provides buggy parameters. > > Fixes: 7f953ab2ba46 ("af_packet: TX_RING support for TPACKET_V3") > Signed-off-by: Eric Dumazet > Cc: Sowmini Varadhan > Reporte

Re: [PATCH net-next 1/7] net: aquantia: replace internal driver version code with uts

2019-06-24 Thread David Miller
From: Igor Russkikh Date: Mon, 24 Jun 2019 11:02:54 + > >> >>> Devlink has just gained something similar to ethtool -i. Maybe we >>> should get the devlink core to also report the kernel version? >> >> I don't think we have the driver version at all there, my usual >> inclination being to

[PATCH net-next v2 2/8] net: aquantia: add documentation for the atlantic driver

2019-06-24 Thread Igor Russkikh
Document contains configuration options description, details and examples of driver various settings. Signed-off-by: Igor Russkikh --- .../device_drivers/aquantia/atlantic.txt | 437 ++ 1 file changed, 437 insertions(+) create mode 100644 Documentation/networking/device_dr

[PATCH net-next v2 4/8] net: aquantia: make all files GPL-2.0-only

2019-06-24 Thread Igor Russkikh
It was noticed some files had -or-later, however overall driver has -only license. Clean this up. Signed-off-by: Igor Russkikh --- drivers/net/ethernet/aquantia/atlantic/aq_drvinfo.c | 2 +- drivers/net/ethernet/aquantia/atlantic/aq_drvinfo.h | 2 +- drivers/net/ethernet/aquantia/atlantic/aq_fil

[PATCH net-next v2 3/8] maintainers: declare aquantia atlantic driver maintenance

2019-06-24 Thread Igor Russkikh
Aquantia is resposible now for all new features and bugfixes. Reflect that in MAINTAINERS. Signed-off-by: Igor Russkikh --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 606d1f80bc49..82f762ddbe7a 100644 --- a/MAINTAINERS +++ b/MAINTAINE

[PATCH net-next v2 6/8] net: aquantia: adding fields and device features for vlan offload

2019-06-24 Thread Igor Russkikh
Updating features and vlan_features with vlan HW offload. Added vlan_tag fields to rx/tx ring_buff to track vlan related data. Tested-by: Nikita Danilov Signed-off-by: Igor Russkikh --- drivers/net/ethernet/aquantia/atlantic/aq_nic.c| 9 ++--- drivers/net/ethernet/aquantia/atlantic

[PATCH net-next v2 5/8] net: aquantia: added vlan offload related macros and functions

2019-06-24 Thread Igor Russkikh
Register declaration macros required to work with vlan offload mode. Tested-by: Nikita Danilov Signed-off-by: Igor Russkikh --- .../atlantic/hw_atl/hw_atl_b0_internal.h | 7 +++ .../aquantia/atlantic/hw_atl/hw_atl_llh.c | 16 .../aquantia/atlantic/hw_atl/hw_atl_

[PATCH net-next v2 1/8] net: aquantia: replace internal driver version code with uts

2019-06-24 Thread Igor Russkikh
As it was discussed some time previously, driver is better to report kernel version string, as it in a best way identifies the codebase. Signed-off-by: Igor Russkikh --- drivers/net/ethernet/aquantia/atlantic/aq_cfg.h | 7 +++ drivers/net/ethernet/aquantia/atlantic/ver.h| 5 - 2 file

[PATCH net-next v2 0/8] net: aquantia: implement vlan offloads

2019-06-24 Thread Igor Russkikh
This patchset introduces hardware VLAN offload support and also does some maintenance: we replace driver version with uts version string, add documentation file for atlantic driver, and update maintainers adding Igor as a maintainer. v2: updates in doc, gpl spdx tag cleanup Igor Russkikh (8): n

[PATCH net-next v2 7/8] net: aquantia: vlan offloads logic in datapath

2019-06-24 Thread Igor Russkikh
Update datapath by adding logic related to hardware assisted vlan strip/insert behaviour. Tested-by: Nikita Danilov Signed-off-by: Igor Russkikh --- .../net/ethernet/aquantia/atlantic/aq_nic.c | 23 +--- .../net/ethernet/aquantia/atlantic/aq_ring.c | 4 ++ .../aquantia/atlantic/hw_atl/h

[PATCH net-next v2 8/8] net: aquantia: implement vlan offload configuration

2019-06-24 Thread Igor Russkikh
set_features should update flags and reinit hardware if vlan offload settings were changed. Signed-off-by: Igor Russkikh Tested-by: Nikita Danilov --- .../net/ethernet/aquantia/atlantic/aq_main.c | 34 +++ 1 file changed, 27 insertions(+), 7 deletions(-) diff --git a/drivers/n

[PATCH iproute2] tc: adjust xtables_match and xtables_target to changes in recent iptables

2019-06-24 Thread Eyal Birger
iptables commit 933400b37d09 ("nft: xtables: add the infrastructure to translate from iptables to nft") added an additional member to struct xtables_match and struct xtables_target. This change is available for libxtables12 and up. Add these members conditionally to support both newer and older v

Re: [PATCH net-next v2 0/3] mlxsw: Thermal and hwmon extensions

2019-06-24 Thread David Miller
From: Ido Schimmel Date: Mon, 24 Jun 2019 13:32:00 +0300 > From: Ido Schimmel > > This patchset from Vadim includes various enhancements to thermal and > hwmon code in mlxsw. > > Patch #1 adds a thermal zone for each inter-connect device (gearbox). > These devices are present in SN3800 systems

Re: [PATCH 06/11] xsk: add support to allow unaligned chunk placement

2019-06-24 Thread Björn Töpel
On Thu, 20 Jun 2019 at 19:25, Kevin Laatz wrote: > > Currently, addresses are chunk size aligned. This means, we are very > restricted in terms of where we can place chunk within the umem. For > example, if we have a chunk size of 2k, then our chunks can only be placed > at 0,2k,4k,6k,8k... and so

Re: [PATCH 07/11] libbpf: add flags to umem config

2019-06-24 Thread Björn Töpel
On Thu, 20 Jun 2019 at 19:26, Kevin Laatz wrote: > > This patch adds a 'flags' field to the umem_config and umem_reg structs. > This will allow for more options to be added for configuring umems. > > The first use for the flags field is to add a flag for unaligned chunks > mode. These flags can ei

Re: [PATCH 08/11] samples/bpf: add unaligned chunks mode support to xdpsock

2019-06-24 Thread Björn Töpel
On Thu, 20 Jun 2019 at 19:25, Kevin Laatz wrote: > > This patch adds support for the unaligned chunks mode. The addition of the > unaligned chunks option will allow users to run the application with more > relaxed chunk placement in the XDP umem. > > Unaligned chunks mode can be used with the '-u'

Re: [PATCH 11/11] doc/af_xdp: include unaligned chunk case

2019-06-24 Thread Björn Töpel
On Thu, 20 Jun 2019 at 19:25, Kevin Laatz wrote: > > The addition of unaligned chunks mode, the documentation needs to be > updated to indicate that the incoming addr to the fill ring will only be > masked if the user application is run in the aligned chunk mode. This patch > also adds a line to e

Re: [PATCH 09/11] samples/bpf: add buffer recycling for unaligned chunks to xdpsock

2019-06-24 Thread Björn Töpel
On Thu, 20 Jun 2019 at 19:25, Kevin Laatz wrote: > > This patch adds buffer recycling support for unaligned buffers. Since we > don't mask the addr to 2k at umem_teg in unaligned mode, we need to make > sure we give back the correct, original addr to the fill queue. To do this, > we need to mask t

Re: [PATCH 10/11] samples/bpf: use hugepages in xdpsock app

2019-06-24 Thread Björn Töpel
On Thu, 20 Jun 2019 at 19:25, Kevin Laatz wrote: > > This patch modifies xdpsock to use mmap instead of posix_memalign. With > this change, we can use hugepages when running the application in unaligned > chunks mode. Using hugepages makes it more likely that we have physically > contiguous memory

Re: [PATCH 00/11] XDP unaligned chunk placement support

2019-06-24 Thread Björn Töpel
On Thu, 20 Jun 2019 at 18:55, Kevin Laatz wrote: > > This patchset adds the ability to use unaligned chunks in the XDP umem. > > Currently, all chunk addresses passed to the umem are masked to be chunk > size aligned (default is 2k, max is PAGE_SIZE). This limits where we can > place chunks within

Re: [PATCH RFC net-next 1/5] net: dsa: mt7530: Convert to PHYLINK API

2019-06-24 Thread Russell King - ARM Linux admin
Hi, On Mon, Jun 24, 2019 at 04:52:47PM +0200, René van Dorst wrote: > Convert mt7530 to PHYLINK API > > Signed-off-by: René van Dorst > --- > drivers/net/dsa/mt7530.c | 237 +-- > drivers/net/dsa/mt7530.h | 9 ++ > 2 files changed, 187 insertions(+), 59 del

Re: [PATCH v2 net-next 4/4] cxgb4: Add MPS refcounting for alloc/free mac filters

2019-06-24 Thread kbuild test robot
Hi Raju, Thank you for the patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Raju-Rangoju/cxgb4-Reference-count-MPS-TCAM-entries-within-a-PF/20190624-230630 config: ia64-allmodconfig (attached as .config) compiler: ia64

Re: [PATCH net] tipc: remove the unnecessary msg->req check from tipc_nl_compat_bearer_set

2019-06-24 Thread Xin Long
On Mon, Jun 24, 2019 at 10:35 PM David Miller wrote: > > From: Xin Long > Date: Mon, 24 Jun 2019 16:02:42 +0800 > > > tipc_nl_compat_bearer_set() is only called by tipc_nl_compat_link_set() > > which already does the check for msg->req check, so remove it from > > tipc_nl_compat_bearer_set(), and

Re: [PATCH net] tipc: remove the unnecessary msg->req check from tipc_nl_compat_bearer_set

2019-06-24 Thread David Miller
From: Xin Long Date: Mon, 24 Jun 2019 23:54:02 +0800 > On Mon, Jun 24, 2019 at 10:35 PM David Miller wrote: >> >> From: Xin Long >> Date: Mon, 24 Jun 2019 16:02:42 +0800 >> >> > tipc_nl_compat_bearer_set() is only called by tipc_nl_compat_link_set() >> > which already does the check for msg->re

Re: [PATCH net] tipc: check msg->req data len in tipc_nl_compat_bearer_disable

2019-06-24 Thread Xin Long
On Mon, Jun 24, 2019 at 4:33 PM Eric Dumazet wrote: > > > > On 6/24/19 12:59 AM, Xin Long wrote: > > This patch is to fix an uninit-value issue, reported by syzbot: > > > > BUG: KMSAN: uninit-value in memchr+0xce/0x110 lib/string.c:981 > > Call Trace: > > __dump_stack lib/dump_stack.c:77 [

Re: [PATCH v2 0/3] fix bugs when enable route_localnet

2019-06-24 Thread David Miller
From: luoshijie Date: Tue, 18 Jun 2019 15:14:02 + > From: Shijie Luo > > When enable route_localnet, route of the 127/8 address is enabled. > But in some situations like arp_announce=2, ARP requests or reply > work abnormally. > > This patchset fix some bugs when enable route_localnet. >

Re: [PATCH rdma-next v1 10/12] IB/mlx5: Enable subscription for device events over DEVX

2019-06-24 Thread Yishai Hadas
On 6/24/2019 2:57 PM, Jason Gunthorpe wrote: On Tue, Jun 18, 2019 at 08:15:38PM +0300, Leon Romanovsky wrote: From: Yishai Hadas Enable subscription for device events over DEVX. Each subscription is added to the two level XA data structure according to its event number and the DEVX object inf

Re: [PATCH net] tipc: check msg->req data len in tipc_nl_compat_bearer_disable

2019-06-24 Thread David Miller
From: Xin Long Date: Tue, 25 Jun 2019 00:00:39 +0800 > Sorry, David, do I need to resend this one? Yes, please, that helps me a lot.

[PATCH net] sctp: change to hold sk after auth shkey is created successfully

2019-06-24 Thread Xin Long
Now in sctp_endpoint_init(), it holds the sk then creates auth shkey. But when the creation fails, it doesn't release the sk, which causes a sk defcnf leak, Here to fix it by only holding the sk when auth shkey is created successfully. Fixes: a29a5bd4f5c3 ("[SCTP]: Implement SCTP-AUTH initializat

Re: [PATCH v2 00/17] net: introduce Qualcomm IPA driver

2019-06-24 Thread Alex Elder
On 6/18/19 2:14 PM, Johannes Berg wrote: > On Tue, 2019-06-18 at 08:16 -0500, Alex Elder wrote: >> On 6/17/19 6:28 AM, Johannes Berg wrote: >>> On Tue, 2019-06-11 at 13:56 +0200, Arnd Bergmann wrote: On Tue, Jun 11, 2019 at 10:12 AM Johannes Berg wrote: >> As I've made clear bef

[PATCH bpf-next v8 0/9] bpf: getsockopt and setsockopt hooks

2019-06-24 Thread Stanislav Fomichev
This series implements two new per-cgroup hooks: getsockopt and setsockopt along with a new sockopt program type. The idea is pretty similar to recently introduced cgroup sysctl hooks, but implementation is simpler (no need to convert to/from strings). What this can be applied to: * move business

[PATCH bpf-next v8 1/9] bpf: implement getsockopt and setsockopt hooks

2019-06-24 Thread Stanislav Fomichev
Implement new BPF_PROG_TYPE_CGROUP_SOCKOPT program type and BPF_CGROUP_{G,S}ETSOCKOPT cgroup hooks. BPF_CGROUP_SETSOCKOPT get a read-only view of the setsockopt arguments. BPF_CGROUP_GETSOCKOPT can modify the supplied buffer. Both of them reuse existing PTR_TO_PACKET{,_END} infrastructure. The bu

[PATCH bpf-next v8 2/9] bpf: sync bpf.h to tools/

2019-06-24 Thread Stanislav Fomichev
Export new prog type and hook points to the libbpf. Cc: Martin Lau Signed-off-by: Stanislav Fomichev --- tools/include/uapi/linux/bpf.h | 14 ++ 1 file changed, 14 insertions(+) diff --git a/tools/include/uapi/linux/bpf.h b/tools/include/uapi/linux/bpf.h index b077507efa3f..a396b51

Re: [PATCH net-next 4/6] arm64: dts: fsl: ls1028a: Add Felix switch port DT node

2019-06-24 Thread Andrew Lunn
On Mon, Jun 24, 2019 at 05:23:45PM +0200, Allan W. Nielsen wrote: > Hi Andrew, > > The 06/24/2019 16:26, Andrew Lunn wrote: > > > > Yeah, there are 2 ethernet controller ports (managed by the enetc > > > > driver) > > > > connected inside the SoC via SGMII links to 2 of the switch ports, one >

[PATCH bpf-next v8 4/9] selftests/bpf: test sockopt section name

2019-06-24 Thread Stanislav Fomichev
Add tests that make sure libbpf section detection works. Cc: Martin Lau Signed-off-by: Stanislav Fomichev --- tools/testing/selftests/bpf/test_section_names.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/tools/testing/selftests/bpf/test_section_names.c b/tools/testing/selfte

  1   2   3   >