From: David Miller <da...@davemloft.net>
Date: Mon, 24 Jun 2019 07:51:32 -0700 (PDT)
> From: Raju Rangoju <ra...@chelsio.com>
> Date: Mon, 24 Jun 2019 14:20:33 +0530
>
>> Firmware reference counts the MPS TCAM entries by PF and VF,
>> but it does not do it for usage within a PF or VF. This patch
>> adds the support to track MPS TCAM entries within a PF.
>>
>> v1->v2:
>> Use refcount_t type instead of atomic_t for mps reference count
>
> Series applied, thanks.
Umm, REALLY?!?!?!
drivers/net/ethernet/chelsio/cxgb4/cxgb4_mps.c: In function
‘cxgb4_mps_ref_dec_by_mac’:
drivers/net/ethernet/chelsio/cxgb4/cxgb4_mps.c:17:29: error: passing argument 1
of ‘atomic_dec_and_test’ from incompatible pointer type
[-Werror=incompatible-pointer-types]
if (!atomic_dec_and_test(&mps_entry->refcnt)) {
^~~~~~~~~~~~~~~~~~
You just changed it to a refcount_t and didn't try compiling the
result?
The whole point of refcount_t is that it uses a different set of
interfaces to manipulate the object and you have to therefore
update all the call sites properly.
Reverted...
