On 06/22/2019 12:33 AM, Takshak Chahande wrote: > With different bpf attach_flags available to attach bpf programs specially > with BPF_F_ALLOW_OVERRIDE and BPF_F_ALLOW_MULTI, the list of effective > bpf-programs available to any sub-cgroups really needs to be available for > easy debugging. > > Using BPF_F_QUERY_EFFECTIVE flag, one can get the list of not only attached > bpf-programs to a cgroup but also the inherited ones from parent cgroup. > > So "-e" option is introduced to use BPF_F_QUERY_EFFECTIVE query flag here to > list all the effective bpf-programs available for execution at a specified > cgroup. > > Reused modified test program test_cgroup_attach from > tools/testing/selftests/bpf: > # ./test_cgroup_attach > > With old bpftool (without -e option): > > # bpftool cgroup show /sys/fs/cgroup/cgroup-test-work-dir/cg1/ > ID AttachType AttachFlags Name > 271 egress multi pkt_cntr_1 > 272 egress multi pkt_cntr_2 > > Attached new program pkt_cntr_4 in cg2 gives following: > > # bpftool cgroup show /sys/fs/cgroup/cgroup-test-work-dir/cg1/cg2 > ID AttachType AttachFlags Name > 273 egress override pkt_cntr_4 > > And with new "-e" option it shows all effective programs for cg2: > > # bpftool -e cgroup show /sys/fs/cgroup/cgroup-test-work-dir/cg1/cg2 > ID AttachType AttachFlags Name > 273 egress override pkt_cntr_4 > 271 egress override pkt_cntr_1 > 272 egress override pkt_cntr_2 > > Signed-off-by: Takshak Chahande <ctaks...@fb.com> > Acked-by: Andrey Ignatov <r...@fb.com>
Applied, thanks!
