[PATCH net-next] Update my email address

2019-05-31 Thread Wei Liu
Signed-off-by: Wei Liu --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 0c55b0fedbe2..e212c6a42ddf 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -17295,7 +17295,7 @@ F: Documentation/ABI/stable/sysfs-hypervisor-xen F: Do

[PATCH net-next] netfilter: missing #include for nf_ct_frag6_gather declaration

2019-05-31 Thread Pablo Neira Ayuso
In file included from net/netfilter/utils.c:5: include/linux/netfilter_ipv6.h: In function 'nf_ipv6_br_defrag': include/linux/netfilter_ipv6.h:110:9: error: implicit declaration of function 'nf_ct_frag6_gather'; did you mean 'nf_ct_attach'? [-Werror=implicit-function-declaration] return nf_ct_f

[net-next 01/13] iavf: Use printf instead of gnu_printf for iavf_debug_d

2019-05-31 Thread Jeff Kirsher
From: Nathan Chancellor Clang warns: In file included from drivers/net/ethernet/intel/iavf/iavf_main.c:4: In file included from drivers/net/ethernet/intel/iavf/iavf.h:37: In file included from drivers/net/ethernet/intel/iavf/iavf_type.h:8: drivers/net/ethernet/intel/iavf/iavf_osdep.h:49:18: warn

[net-next 07/13] iavf: rename i40e functions to be iavf

2019-05-31 Thread Jeff Kirsher
From: Alice Michael Update the old i40e function names to be iavf Signed-off-by: Alice Michael Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/iavf/iavf_adminq.c| 6 +++--- drivers/net/ethernet/intel/iavf/iavf_prototype.h | 4 ++-- 2 files changed, 5 i

[net-next 03/13] iavf: use struct_size() in kzalloc()

2019-05-31 Thread Jeff Kirsher
From: "Gustavo A. R. Silva" One of the more common cases of allocation size calculations is finding the size of a structure that has a zero-sized array at the end, along with memory for some number of elements for that array. For example: struct foo { int stuff; struct boo entry[]; }; s

[net-next 04/13] iavf: iavf_client: use struct_size() helper

2019-05-31 Thread Jeff Kirsher
From: "Gustavo A. R. Silva" One of the more common cases of allocation size calculations is finding the size of a structure that has a zero-sized array at the end, along with memory for some number of elements for that array. For example: struct foo { int stuff; struct boo entry[]; }; s

[net-next 13/13] iavf: update comments and file checks to match iavf

2019-05-31 Thread Jeff Kirsher
From: Alice Michael Some small things were missed with recent name changes from i40e to iavf. Having a separate patch allows to correct the small misses in one place. Signed-off-by: Alice Michael Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/iavf/iavf_c

[net-next 00/13][pull request] Intel Wired LAN Driver Updates 2019-05-31

2019-05-31 Thread Jeff Kirsher
This series contains updates to the iavf driver. Nathan Chancellor converts the use of gnu_printf to printf. Aleksandr modifies the driver to limit the number of RSS queues to the number of online CPUs in order to avoid creating misconfigured RSS queues. Gustavo A. R. Silva converts a couple of

[net-next 10/13] iavf: rename iavf_client.h defines to match driver name

2019-05-31 Thread Jeff Kirsher
From: Alice Michael The defines in iavf_client.h were still vastly i40e, and they should be iavf. Signed-off-by: Alice Michael Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/iavf/iavf.h| 2 +- drivers/net/ethernet/intel/iavf/iavf_client.c | 84

[net-next 09/13] iavf: rename iavf_status structure flags

2019-05-31 Thread Jeff Kirsher
From: Alice Michael rename the flags inside of iavf_status from I40E_* to IAVF_* Signed-off-by: Alice Michael Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/iavf/iavf_adminq.c | 42 +-- drivers/net/ethernet/intel/iavf/iavf_adminq.h | 2 +- drivers/net/

[net-next 02/13] iavf: Limiting RSS queues to CPUs

2019-05-31 Thread Jeff Kirsher
From: Aleksandr Loktionov Limiting RSS queues number to online CPUs number in order to avoid issues with creating misconfigured RSS queues. Signed-off-by: Aleksandr Loktionov Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/iavf/iavf_virtchnl.c | 2 +- 1 fi

[net-next 08/13] iavf: replace i40e variables with iavf

2019-05-31 Thread Jeff Kirsher
From: Alice Michael Update the old variables and flags marked as i40e to match the iavf name of the driver. Signed-off-by: Alice Michael Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/iavf/iavf_adminq.c | 80 +-- drivers/net/ethernet/intel/iavf/iavf_admi

[net-next 06/13] iavf: change iavf_status_code to iavf_status

2019-05-31 Thread Jeff Kirsher
From: Sergey Nemov Instead of typedefing the enum iavf_status_code with iavf_status, just shorten the enum itself and get rid of typedef. Signed-off-by: Sergey Nemov Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/iavf/iavf.h| 2 +- drivers/net/et

[net-next 11/13] iavf: change remaining i40e defines to be iavf

2019-05-31 Thread Jeff Kirsher
From: Alice Michael There were a couple of erroneously missed i40e names to update to iavf left after the larger chunks. Updated them separately so now they should all be aligned as iavf. Signed-off-by: Alice Michael Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ether

[net-next 12/13] iavf: rename i40e_device to iavf_device

2019-05-31 Thread Jeff Kirsher
From: Alice Michael Renaming remaining defines from i40e to iavf Signed-off-by: Alice Michael Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/iavf/iavf.h| 4 ++-- drivers/net/ethernet/intel/iavf/iavf_client.c | 20 +-- 2 files chan

[net-next 05/13] iavf: Rename i40e_adminq* files to iavf_adminq*

2019-05-31 Thread Jeff Kirsher
From: Alice Michael With the rename of the iavf driver, there were some files that were missed in renaming. Update these to be iavf as well. Signed-off-by: Alice Michael Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/iavf/Makefile

RE: [PATCH net-next] Update my email address

2019-05-31 Thread Paul Durrant
> -Original Message- > From: Wei Liu [mailto:wei.l...@citrix.com] > Sent: 31 May 2019 08:31 > To: netdev@vger.kernel.org > Cc: Xen-devel ; Paul Durrant > ; David Miller > ; Wei Liu > Subject: [PATCH net-next] Update my email address > > Signed-off-by: Wei Liu Acked-by: Paul Durrant >

Re: [PATCH V1 net-next 02/11] net: ena: ethtool: add extra properties retrieval via get_priv_flags

2019-05-31 Thread Michal Kubecek
On Wed, May 29, 2019 at 12:49:55PM +0300, same...@amazon.com wrote: > From: Arthur Kiyanovski > > This commit adds a mechanism for exposing different driver > properties via ethtool's priv_flags. > > In this commit we: > > Add commands, structs and defines necessary for handling > extra propert

[PATCH RFC iproute2-next v2] tc: add support for act ctinfo

2019-05-31 Thread ldir . kdb
From: Kevin Darbyshire-Bryant ctinfo is an action restoring data stored in conntrack marks to various fields. At present it has two independent modes of operation, restoration of DSCP into IPv4/v6 diffserv and restoration of conntrack marks into packet skb marks. It understands a number of para

Re: [PATCH] inet: frags: Remove unnecessary smp_store_release/READ_ONCE

2019-05-31 Thread Dmitry Vyukov
On Wed, May 29, 2019 at 7:48 AM Herbert Xu wrote: > > On Wed, May 29, 2019 at 07:43:51AM +0200, Dmitry Vyukov wrote: > > > > If fqdir->dead read/write are concurrent, then this still needs to be > > READ_ONCE/WRITE_ONCE. Ordering is orthogonal to atomicity. > > No they do not. READ_ONCE/WRITE_ONC

[PATCH] net/neighbour: fix potential null pointer deference

2019-05-31 Thread Young Xiao
There is a possible null pointer deference bugs in neigh_fill_info(), which is similar to the bug which was fixed in commit 6adc5fd6a142 ("net/neighbour: fix crash at dumping device-agnostic proxy entries"). Signed-off-by: Young Xiao <92siuy...@gmail.com> --- net/core/neighbour.c | 2 +- 1 file c

Re: [RFC PATCH iproute2-next 1/1] tc: add support for act ctinfo

2019-05-31 Thread Kevin 'ldir' Darbyshire-Bryant
> On 30 May 2019, at 20:59, Stephen Hemminger > wrote: > > On Thu, 30 May 2019 16:43:20 + > Kevin 'ldir' Darbyshire-Bryant wrote: > > Please don't use HTML encoded mail. I.e not exchange. As far as I know I’m not sending HTML emails, or I’m trying hard to send plain text from mac mail,

[PATCH] net/vxlan: fix potential null pointer deference

2019-05-31 Thread Young Xiao
There is a possible null pointer deference bug in vxlan_fdb_info(), which is similar to the bug which was fixed in commit 6adc5fd6a142 ("net/neighbour: fix crash at dumping device-agnostic proxy entries"). Signed-off-by: Young Xiao <92siuy...@gmail.com> --- drivers/net/vxlan.c | 2 +- 1 file chan

Re: [PATCH] net/neighbour: fix potential null pointer deference

2019-05-31 Thread Konstantin Khlebnikov
On 31.05.2019 11:29, Young Xiao wrote: There is a possible null pointer deference bugs in neigh_fill_info(), which is similar to the bug which was fixed in commit 6adc5fd6a142 ("net/neighbour: fix crash at dumping device-agnostic proxy entries"). Have you seen this in real life? I see nobody wh

Re: [PATCH] net/neighbour: fix potential null pointer deference

2019-05-31 Thread Paolo Abeni
On Fri, 2019-05-31 at 16:29 +0800, Young Xiao wrote: > There is a possible null pointer deference bugs in neigh_fill_info(), > which is similar to the bug which was fixed in commit 6adc5fd6a142 > ("net/neighbour: fix crash at dumping device-agnostic proxy entries"). > > Signed-off-by: Young Xiao <

Re: [PATCH] net/vxlan: fix potential null pointer deference

2019-05-31 Thread Paolo Abeni
On Fri, 2019-05-31 at 16:34 +0800, Young Xiao wrote: > There is a possible null pointer deference bug in vxlan_fdb_info(), > which is similar to the bug which was fixed in commit 6adc5fd6a142 > ("net/neighbour: fix crash at dumping device-agnostic proxy entries"). > > Signed-off-by: Young Xiao <92

Re: [PATCH net v2 1/3] net/sched: act_csum: pull all VLAN headers before checksumming

2019-05-31 Thread Davide Caratti
On Thu, 2019-05-30 at 11:08 -0700, Stephen Hemminger wrote: > On Thu, 30 May 2019 20:03:41 +0200 > Davide Caratti wrote: > > > > > +static inline int tc_skb_pull_vlans(struct sk_buff *skb, > > + unsigned int *hdr_count, > > + __be16 *p

[PATCH net-next] netfilter: ipv6: fix compile err unknown field br_defrag and br_fragment

2019-05-31 Thread wenxu
From: wenxu When CONFIG_IPV6 is not build with modules and CONIFG_NF_CONNTRACK_BRIDGE=m There will compile err: net/ipv6/netfilter.c:242:2: error: unknown field 'br_defrag' specified in initializer .br_defrag = nf_ct_frag6_gather, net/ipv6/netfilter.c:243:2: error: unknown field 'br_fragment'

Re: [PATCH net-next] netfilter: missing #include for nf_ct_frag6_gather declaration

2019-05-31 Thread Pablo Neira Ayuso
+Cc we...@ucloud.cn On Fri, May 31, 2019 at 10:11:43AM +0200, Pablo Neira Ayuso wrote: > In file included from net/netfilter/utils.c:5: > include/linux/netfilter_ipv6.h: In function 'nf_ipv6_br_defrag': > include/linux/netfilter_ipv6.h:110:9: error: implicit declaration of function > 'nf_ct_frag6

Re: [PATCH net-next] netfilter: nf_conntrack_bridge: Fix build error without IPV6

2019-05-31 Thread Yuehaibing
On 2019/5/31 16:02, Pablo Neira Ayuso wrote: > On Fri, May 31, 2019 at 11:06:49AM +0800, Yuehaibing wrote: >> +cc netdev >> >> On 2019/5/31 10:46, YueHaibing wrote: >>> Fix gcc build error while CONFIG_IPV6 is not set >>> >>> In file included from net/netfilter/core.c:19:0: >>> ./include/linux/n

[PATCH] netfilter: nf_conntrack_bridge: fix CONFIG_IPV6=y

2019-05-31 Thread Pablo Neira Ayuso
This patch fixes a few problems with CONFIG_IPV6=y and CONFIG_NF_CONNTRACK_BRIDGE=m: In file included from net/netfilter/utils.c:5: include/linux/netfilter_ipv6.h: In function 'nf_ipv6_br_defrag': include/linux/netfilter_ipv6.h:110:9: error: implicit declaration of function 'nf_ct_frag6_gather';

[PATCH net-next,v2] netfilter: nf_conntrack_bridge: fix CONFIG_IPV6=y

2019-05-31 Thread Pablo Neira Ayuso
This patch fixes a few problems with CONFIG_IPV6=y and CONFIG_NF_CONNTRACK_BRIDGE=m: In file included from net/netfilter/utils.c:5: include/linux/netfilter_ipv6.h: In function 'nf_ipv6_br_defrag': include/linux/netfilter_ipv6.h:110:9: error: implicit declaration of function 'nf_ct_frag6_gather';

Re: [PATCH] netfilter: nf_conntrack_bridge: fix CONFIG_IPV6=y

2019-05-31 Thread Pablo Neira Ayuso
On Fri, May 31, 2019 at 11:11:24AM +0200, Pablo Neira Ayuso wrote: > This patch fixes a few problems with CONFIG_IPV6=y and > CONFIG_NF_CONNTRACK_BRIDGE=m: > > In file included from net/netfilter/utils.c:5: > include/linux/netfilter_ipv6.h: In function 'nf_ipv6_br_defrag': > include/linux/netfilte

Re: [PATCH net-next] netfilter: ipv6: fix compile err unknown field br_defrag and br_fragment

2019-05-31 Thread Pablo Neira Ayuso
Hi, On Fri, May 31, 2019 at 05:02:55PM +0800, we...@ucloud.cn wrote: > From: wenxu > > When CONFIG_IPV6 is not build with modules and CONIFG_NF_CONNTRACK_BRIDGE=m > There will compile err: > net/ipv6/netfilter.c:242:2: error: unknown field 'br_defrag' specified in > initializer > .br_defrag

Re: [RFC] vsock: proposal to support multiple transports at runtime

2019-05-31 Thread Jorgen Hansen
On 30 May 2019, at 13:19, Stefano Garzarella wrote: > > On Tue, May 28, 2019 at 04:01:00PM +, Jorgen Hansen wrote: >>> On Thu, May 23, 2019 at 04:37:03PM +0100, Stefan Hajnoczi wrote: On Tue, May 14, 2019 at 10:15:43AM +0200, Stefano Garzarella wrote: > > > > 2. listen() /

[PATCH bpf-next v4] selftests/bpf: measure RTT from xdp using xdping

2019-05-31 Thread Alan Maguire
xdping allows us to get latency estimates from XDP. Output looks like this: ./xdping -I eth4 192.168.55.8 Setting up XDP for eth4, please wait... XDP setup disrupts network connectivity, hit Ctrl+C to quit Normal ping RTT data [Ignore final RTT; it is distorted by XDP using the reply] PING 192.1

Re: [PATCH 2/2] ethtool: Add 100BaseT1 and 1000BaseT1 link modes

2019-05-31 Thread Michal Kubecek
On Thu, May 30, 2019 at 08:06:16PM +0200, Andrew Lunn wrote: > The kernel can now indicate if the PHY supports operating over a > single pair at 100Mbps or 1000Mbps. > > Signed-off-by: Andrew Lunn > --- > ethtool.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/ethtool.c b/ethto

[PATCH iproute2] tc: simple: don't hardcode the control action

2019-05-31 Thread Davide Caratti
don't hardcode the 'pipe' control action, so that the following TDC test b776 - Replace simple action with invalid goto chain control can detect kernels that correctly validate 'goto chain' control action. CC: Andrea Claudi CC: Marcelo Ricardo Leitner Signed-off-by: Davide Caratti --- tc/m_

Re: [PATCH net-next,v2] netfilter: nf_conntrack_bridge: fix CONFIG_IPV6=y

2019-05-31 Thread wenxu
Signed-off-by: wenxu On 5/31/2019 5:15 PM, Pablo Neira Ayuso wrote: > This patch fixes a few problems with CONFIG_IPV6=y and > CONFIG_NF_CONNTRACK_BRIDGE=m: > > In file included from net/netfilter/utils.c:5: > include/linux/netfilter_ipv6.h: In function 'nf_ipv6_br_defrag': > include/linux/netf

[PATCH bpf-next v2 2/2] net: xdp: remove XDP_QUERY_PROG{,_HW}

2019-05-31 Thread Björn Töpel
From: Björn Töpel Remove all use of XDP_QUERY_PROG{,_HW}, since it was moved to the generic code path. Signed-off-by: Björn Töpel --- drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c | 4 .../net/ethernet/cavium/thunder/nicvf_main.c | 3 --- .../net/ethernet/freescale/dpaa2/dpaa2-eth.c |

[PATCH bpf-next v2 1/2] net: xdp: refactor XDP_QUERY_PROG{,_HW} to netdev

2019-05-31 Thread Björn Töpel
From: Björn Töpel All XDP capable drivers need to implement the XDP_QUERY_PROG{,_HW} command of ndo_bpf. The query code is fairly generic. This commit refactors the query code up from the drivers to the netdev level. The struct net_device has gained two new members: xdp_prog_hw and xdp_flags. Th

[PATCH bpf-next v2 0/2] net: xdp: refactor the XDP_QUERY_PROG and XDP_QUERY_PROG_HW code

2019-05-31 Thread Björn Töpel
Here's yet another attempt tomove the XDP_QUERY_PROG{,_HW} code out from the drivers to generic netdev code. The first patch in the series move the XDP query functionality, and the second remove XDP_QUERY_PROG{,_HW} from all drivers. Please refer to the individual commit messages for more details

Re: [PATCH bpf-next v2 0/2] net: xdp: refactor the XDP_QUERY_PROG and XDP_QUERY_PROG_HW code

2019-05-31 Thread Björn Töpel
On Fri, 31 May 2019 at 11:42, Björn Töpel wrote: > [...] > > I, hopefully, addressed all comments from Jakub and Saeed, except one; > I did not move the XDP struct net_device into a struct of its own. > Uhm, the last sentence was weird. What I meant was: I did not move the newly introduced XDP m

Re: [PATCH net-next] vrf: local route leaking

2019-05-31 Thread George Wilkie
On Thu, May 30, 2019 at 03:50:09PM -0600, David Ahern wrote: > On 5/30/19 2:52 PM, George Wilkie wrote: > > This doesn't work for me (again, not using namespaces). > > For traffic coming in on vrf-b to a destination on 10.200.2.0, > > I see ARPs going out for the destination on xvrf2/in on xvrf1, >

Re: [PATCH net-next] cxgb4: Set initial IRQ affinity hints

2019-05-31 Thread kbuild test robot
Hi Nirranjan, Thank you for the patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Nirranjan-Kirubaharan/cxgb4-Set-initial-IRQ-affinity-hints/20190531-180720 config: xtensa-allyesconfig (attached as .config) compiler

Re: [PATCH v2 bpf-next 1/2] bpf: Allow bpf_map_lookup_elem() on an xskmap

2019-05-31 Thread Björn Töpel
On 2019-05-30 20:57, Jonathan Lemon wrote: Currently, the AF_XDP code uses a separate map in order to determine if an xsk is bound to a queue. Instead of doing this, have bpf_map_lookup_elem() return the queue_id, as a way of indicating that there is a valid entry at the map index. Rearrange so

Re: [PATCH v2 bpf-next 2/2] libbpf: remove qidconf and better support external bpf programs.

2019-05-31 Thread Björn Töpel
On 2019-05-30 20:57, Jonathan Lemon wrote: Use the recent change to XSKMAP bpf_map_lookup_elem() to test if there is a xsk present in the map instead of duplicating the work with qidconf. Fix things so callers using XSK_LIBBPF_FLAGS__INHIBIT_PROG_LOAD bypass any internal bpf maps, so xsk_socket_

Re: [PATCH 2/2] ethtool: Add 100BaseT1 and 1000BaseT1 link modes

2019-05-31 Thread Andrew Lunn
> > @@ -634,10 +636,14 @@ static void dump_link_caps(const char *prefix, const > > char *an_prefix, > > "100baseT/Half" }, > > { 1, ETHTOOL_LINK_MODE_100baseT_Full_BIT, > > "100baseT/Full" }, > > + { 1, ETHTOOL_LINK_MODE_100baseT1_Full_BIT, > > +

[PATCH iproute2] man: tc-skbedit.8: document 'inheritdsfield'

2019-05-31 Thread Davide Caratti
while at it, fix missing square bracket near 'ptype' and a typo in the action description (it's -> its). Signed-off-by: Davide Caratti --- man/man8/tc-skbedit.8 | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/man/man8/tc-skbedit.8 b/man/man8/tc-skbedit.8 index

Re: [PATCH 2/2] ethtool: Add 100BaseT1 and 1000BaseT1 link modes

2019-05-31 Thread Lucas Stach
Am Freitag, den 31.05.2019, 13:59 +0200 schrieb Andrew Lunn: > > > @@ -634,10 +636,14 @@ static void dump_link_caps(const char *prefix, > > > const char *an_prefix, > > > > > >     "100baseT/Half" }, > > > > > >   { 1, ETHTOOL_LINK_MODE_100baseT_Full_BIT, > > > > > >  

Re: [PATCH] net: phy: support C45 phys in SIOCGMIIREG/SIOCSMIIREG ioctls

2019-05-31 Thread Andrew Lunn
On Fri, May 31, 2019 at 10:47:27AM +0300, Nikita Yushchenko wrote: > This change allows phytool [1] and similar tools to read and write C45 phy > registers from userspace. > > This is useful for debugging and for porting vendor phy diagnostics tools. > > [1] https://github.com/wkz/phytool Hi Nik

support for popping multiple MPLS labels with iproute2?

2019-05-31 Thread Alan Maguire
I was wondering if there is a way to pop multiple MPLS labels at once for local delivery using iproute2? Adding multiple labels for encapsulation is supported via label1/label2/... syntax, but I can't find a way to do the same for popping multiple labels for local delivery. For example if I run

[PATCH net-next v2 0/7] net: add rcu annotations for ifa_list

2019-05-31 Thread Florian Westphal
v2: - remove ifa_list iteration in afs instead of conversion All other patches are unchanged. Eric Dumazet reported following problem: It looks that unless RTNL is held, accessing ifa_list needs proper RCU protection. indev->ifa_list can be changed under us by another cpu (which owns RTN

[PATCH net-next v2 1/7] afs: do not send list of client addresses

2019-05-31 Thread Florian Westphal
David Howell says: I'm told that there's not really any point populating the list. Current OpenAFS ignores it, as does AuriStor - and IBM AFS 3.6 will do the right thing. The list is actually useless as it's the client's view of the world, not the servers, so if there's any NAT in the way

[PATCH net-next v2 3/7] devinet: use in_dev_for_each_ifa_rcu in more places

2019-05-31 Thread Florian Westphal
This also replaces spots that used for_primary_ifa(). for_primary_ifa() aborts the loop on the first secondary address seen. Replace it with either the rcu or rtnl variant of in_dev_for_each_ifa(), but two places will now also consider secondary addresses too: inet_addr_onlink() and inet_ifa_bypr

[PATCH net-next v2 4/7] netfilter: use in_dev_for_each_ifa_rcu

2019-05-31 Thread Florian Westphal
Netfilter hooks are always running under rcu read lock, use the new iterator macro so sparse won't complain once we add proper __rcu annotations. Signed-off-by: Florian Westphal --- net/ipv4/netfilter/nf_tproxy_ipv4.c| 9 +++-- net/netfilter/nf_conntrack_broadcast.c | 9 +++-- net/ne

[PATCH net-next v2 7/7] net: ipv4: provide __rcu annotation for ifa_list

2019-05-31 Thread Florian Westphal
ifa_list is protected by rcu, yet code doesn't reflect this. Add the __rcu annotations and fix up all places that are now reported by sparse. I've done this in the same commit to not add intermediate patches that result in new warnings. Reported-by: Eric Dumazet Signed-off-by: Florian Westphal

[PATCH net-next v2 6/7] drivers: use in_dev_for_each_ifa_rtnl/rcu

2019-05-31 Thread Florian Westphal
Like previous patches, use the new iterator macros to avoid sparse warnings once proper __rcu annotations are added. Compile tested only. Signed-off-by: Florian Westphal --- drivers/infiniband/core/roce_gid_mgmt.c | 5 +++-- drivers/infiniband/hw/cxgb4/cm.c |

[PATCH net-next v2 5/7] net: use new in_dev_ifa iterators

2019-05-31 Thread Florian Westphal
Use in_dev_for_each_ifa_rcu/rtnl instead. This prevents sparse warnings once proper __rcu annotations are added. Signed-off-by: Florian Westphal t di# Last commands done (6 commands done): --- net/ipv4/fib_frontend.c | 24 +--- net/ipv4/igmp.c | 5 +++-- net/ipv6/ad

[PATCH net-next v2 2/7] net: inetdevice: provide replacement iterators for in_ifaddr walk

2019-05-31 Thread Florian Westphal
The ifa_list is protected either by rcu or rtnl lock, but the current iterators do not account for this. This adds two iterators as replacement, a later patch in the series will update them with the needed rcu/rtnl_dereference calls. Its not done in this patch yet to avoid sparse warnings -- the

Re: [PATCH 2/2] ethtool: Add 100BaseT1 and 1000BaseT1 link modes

2019-05-31 Thread Andrew Lunn
> That's not just theory. The Broadcom BCM54811 PHY supports both > 100/1000baseT, as well as 100baseT1. Hi Lucus There does not appear to be a driver for it, which is why i've not seen it, nor have we had this conversation before. Do you have a driver to submit? Andrew

[PATCH net-next 0/3] net/mlx5: use indirect call wrappers

2019-05-31 Thread Paolo Abeni
The mlx5_core driver uses several indirect calls in fast-path, some of them are invoked on each ingress packet, even for the XDP-only traffic. This series leverage the indirect call wrappers infrastructure the avoid the expansive RETPOLINE overhead for 2 indirect calls in fast-path. Each call is

[PATCH net-next 3/3] net/mlx5e: use indirect calls wrapper for the rx packet handler

2019-05-31 Thread Paolo Abeni
We can avoid another indirect call per packet wrapping the rx handler call with the proper helper. To ensure that even the last listed direct call experience measurable gain, despite the additional conditionals we must traverse before reaching it, I tested reversing the order of the listed options

[PATCH net-next 2/3] indirect call wrappers: add helpers for 3 and 4 ways switch

2019-05-31 Thread Paolo Abeni
Experimental results[1] has shown that resorting to several branches and a direct-call is faster than indirect call via retpoline, even when the number of added branches go up 5. This change adds two additional helpers, to cope with indirect calls with up to 4 available direct call option. We will

[PATCH net-next 1/3] net/mlx5e: use indirect calls wrapper for skb allocation

2019-05-31 Thread Paolo Abeni
We can avoid an indirect call per packet wrapping the skb creation with the appropriate helper. Signed-off-by: Paolo Abeni --- .../net/ethernet/mellanox/mlx5/core/en_rx.c | 22 ++- 1 file changed, 17 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5

Re: [PATCH net] net: phylink: ensure consistent phy interface mode

2019-05-31 Thread Andrew Lunn
On Tue, May 28, 2019 at 10:27:21AM +0100, Russell King wrote: > Ensure that we supply the same phy interface mode to mac_link_down() as > we did for the corresponding mac_link_up() call. This ensures that MAC > drivers that use the phy interface mode in these methods can depend on > mac_link_down(

Re: [PATCH 2/2] ethtool: Add 100BaseT1 and 1000BaseT1 link modes

2019-05-31 Thread Lucas Stach
Am Freitag, den 31.05.2019, 14:30 +0200 schrieb Andrew Lunn: > > That's not just theory. The Broadcom BCM54811 PHY supports both > > 100/1000baseT, as well as 100baseT1. > > Hi Lucus > > There does not appear to be a driver for it, which is why i've not > seen it, nor have we had this conversatio

Zdravstvuyte! Vas interesuyut kliyentskiye bazy dannykh?

2019-05-31 Thread netdev
Zdravstvuyte! Vas interesuyut kliyentskiye bazy dannykh?

Re: [PATCH net] net: phylink: ensure consistent phy interface mode

2019-05-31 Thread Russell King - ARM Linux admin
On Fri, May 31, 2019 at 03:02:26PM +0200, Andrew Lunn wrote: > On Tue, May 28, 2019 at 10:27:21AM +0100, Russell King wrote: > > Ensure that we supply the same phy interface mode to mac_link_down() as > > we did for the corresponding mac_link_up() call. This ensures that MAC > > drivers that use t

[PATCH v2 0/2] Add 100BaseT1 and 1000BaseT1

2019-05-31 Thread Andrew Lunn
Import the latest ethtool.h and add two new links modes. v2: Move the new speeds to the end of the all_advertised_modes_bits[]. Remove the same_line bit for the new moved Add the new modes to the man page. Andrew Lunn (2): ethtool: sync ethtool-copy.h with linux-next from 30/05/2019 ethtool:

[PATCH v2 2/2] ethtool: Add 100BaseT1 and 1000BaseT1 link modes

2019-05-31 Thread Andrew Lunn
The kernel can now indicate if the PHY supports operating over a single pair at 100Mbps or 1000Mbps. Signed-off-by: Andrew Lunn --- ethtool.8.in | 2 ++ ethtool.c| 6 ++ 2 files changed, 8 insertions(+) diff --git a/ethtool.8.in b/ethtool.8.in index 430d11b915af..6af63455c636 100644 ---

[PATCH v2 1/2] ethtool: sync ethtool-copy.h with linux-next from 30/05/2019

2019-05-31 Thread Andrew Lunn
Sync ethtool-copy.h with linux-next from 22/05/2019. This provides access to the new link modes for 100BaseT1 and 1000BaseT1. Signed-off-by: Andrew Lunn --- ethtool-copy.h | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/ethtool-copy.h b/ethtool-copy.h index 92ab10d65fc9

Re: [PATCH net-next 6/6] seg6: Add support to rearrange SRH for AH ICV calculation

2019-05-31 Thread Ahmed Abdelsalam
On Thu, 30 May 2019 14:50:21 -0700 Tom Herbert wrote: > Mutable fields related to segment routing are: destination address, > segments left, and modifiable TLVs (those whose high order bit is set). > > Add support to rearrange a segment routing (type 4) routing header to > handle these mutabilit

Re: [PATCH] inet: frags: Remove unnecessary smp_store_release/READ_ONCE

2019-05-31 Thread Herbert Xu
On Fri, May 31, 2019 at 10:24:08AM +0200, Dmitry Vyukov wrote: > > OK, let's call it barrier. But we need more than a barrier here then. READ_ONCE/WRITE_ONCE is not some magical dust that you sprinkle around in your code to make it work without locks. You need to understand exactly why you need t

Re: [PATCH net-next 6/6] seg6: Add support to rearrange SRH for AH ICV calculation

2019-05-31 Thread Tom Herbert
On Fri, May 31, 2019 at 7:05 AM Ahmed Abdelsalam wrote: > > On Thu, 30 May 2019 14:50:21 -0700 > Tom Herbert wrote: > > > Mutable fields related to segment routing are: destination address, > > segments left, and modifiable TLVs (those whose high order bit is set). > > > > Add support to rearrang

Re: [PATCH net-next] vrf: local route leaking

2019-05-31 Thread David Ahern
On 5/31/19 4:38 AM, George Wilkie wrote: > What are your thoughts on creating a "vrfdefault" for "local" table? >ip link add vrfdefault type vrf table local >ip link set dev vrfdefault up >ip ro add vrf vrfA 10.10.3.0/24 dev vrfdefault >ip ro add 10.10.2.0/24 dev vrfA >ip -6 ro

Re: [PATCH] net/neighbour: fix potential null pointer deference

2019-05-31 Thread Eric Dumazet
On 5/31/19 1:29 AM, Young Xiao wrote: > There is a possible null pointer deference bugs in neigh_fill_info(), > which is similar to the bug which was fixed in commit 6adc5fd6a142 > ("net/neighbour: fix crash at dumping device-agnostic proxy entries"). > > Signed-off-by: Young Xiao <92siuy...@gm

Re: [PATCH] net/vxlan: fix potential null pointer deference

2019-05-31 Thread Eric Dumazet
On 5/31/19 1:34 AM, Young Xiao wrote: > There is a possible null pointer deference bug in vxlan_fdb_info(), > which is similar to the bug which was fixed in commit 6adc5fd6a142 > ("net/neighbour: fix crash at dumping device-agnostic proxy entries"). > > Signed-off-by: Young Xiao <92siuy...@gmai

Re: [PATCH V4 net-next 2/6] net: Introduce a new MII time stamping interface.

2019-05-31 Thread kbuild test robot
Hi Richard, I love your patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Richard-Cochran/Peer-to-Peer-One-Step-time-stamping/20190531-213601 config: s390-debug_defconfig (attached as .config) compiler: s390-linux-gcc

Re: [PATCH net-next v2 1/7] afs: do not send list of client addresses

2019-05-31 Thread David Howells
Florian Westphal wrote: > David Howell says: "Howells" Apart from that: Tested-by: David Howells

Re: [PATCH] inet: frags: Remove unnecessary smp_store_release/READ_ONCE

2019-05-31 Thread Eric Dumazet
On 5/31/19 7:45 AM, Herbert Xu wrote: > On Fri, May 31, 2019 at 10:24:08AM +0200, Dmitry Vyukov wrote: >> >> OK, let's call it barrier. But we need more than a barrier here then. > > READ_ONCE/WRITE_ONCE is not some magical dust that you sprinkle > around in your code to make it work without lo

Re: [PATCH v2] hooks: fix a missing-check bug in selinux_sb_eat_lsm_opts()

2019-05-31 Thread Paul Moore
On Thu, May 30, 2019 at 9:34 PM Gen Zhang wrote: > > In selinux_sb_eat_lsm_opts(), 'arg' is allocated by kmemdup_nul(). It > returns NULL when fails. So 'arg' should be checked. > > Signed-off-by: Gen Zhang > Reviewed-by: Ondrej Mosnacek > Fixes: 99dbbb593fe6 ("selinux: rewrite selinux_sb_eat_ls

Re: [PATCH v2 2/2] ethtool: Add 100BaseT1 and 1000BaseT1 link modes

2019-05-31 Thread Michal Kubecek
On Fri, May 31, 2019 at 03:57:48PM +0200, Andrew Lunn wrote: > The kernel can now indicate if the PHY supports operating over a > single pair at 100Mbps or 1000Mbps. > > Signed-off-by: Andrew Lunn > --- Reviewed-by: Michal Kubecek > ethtool.8.in | 2 ++ > ethtool.c| 6 ++ > 2 files ch

Re: [PATCH v2 1/2] ethtool: sync ethtool-copy.h with linux-next from 30/05/2019

2019-05-31 Thread Michal Kubecek
On Fri, May 31, 2019 at 03:57:47PM +0200, Andrew Lunn wrote: > Sync ethtool-copy.h with linux-next from 22/05/2019. This provides > access to the new link modes for 100BaseT1 and 1000BaseT1. > > Signed-off-by: Andrew Lunn > --- Reviewed-by: Michal Kubecek BtW, this differs from the file "make

Re: [PATCH bpf-next v4] selftests/bpf: measure RTT from xdp using xdping

2019-05-31 Thread Song Liu
> On May 31, 2019, at 2:24 AM, Alan Maguire wrote: > > xdping allows us to get latency estimates from XDP. Output looks > like this: > > ./xdping -I eth4 192.168.55.8 > Setting up XDP for eth4, please wait... > XDP setup disrupts network connectivity, hit Ctrl+C to quit > > Normal ping RTT

Re: [PATCH iproute2] man: tc-skbedit.8: document 'inheritdsfield'

2019-05-31 Thread Andrea Claudi
On Fri, May 31, 2019 at 2:12 PM Davide Caratti wrote: > > while at it, fix missing square bracket near 'ptype' and a typo in the > action description (it's -> its). > > Signed-off-by: Davide Caratti > --- > man/man8/tc-skbedit.8 | 13 ++--- > 1 file changed, 10 insertions(+), 3 deletions

Re: [PATCH v2 1/2] ethtool: sync ethtool-copy.h with linux-next from 30/05/2019

2019-05-31 Thread Andrew Lunn
> Reviewed-by: Michal Kubecek > > BtW, this differs from the file "make headers_install" produces in > net-next but only in white space so that it doesn't really matter and it > gets sorted in a future sync. Yes, there is something odd going on. It looks like two tabs have been converted to spac

Re: [PATCH V4 net-next 6/6] ptp: Add a driver for InES time stamping IP core.

2019-05-31 Thread kbuild test robot
Hi Richard, I love your patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Richard-Cochran/Peer-to-Peer-One-Step-time-stamping/20190531-213601 config: m68k-allmodconfig (attached as .config) compiler: m68k-linux

Re: [net-next 01/13] iavf: Use printf instead of gnu_printf for iavf_debug_d

2019-05-31 Thread Joe Perches
On Fri, 2019-05-31 at 01:15 -0700, Jeff Kirsher wrote: > From: Nathan Chancellor > We can convert from gnu_printf to printf without any side effects [] > diff --git a/drivers/net/ethernet/intel/iavf/iavf_osdep.h > b/drivers/net/ethernet/intel/iavf/iavf_osdep.h [] > @@ -46,7 +46,7 @@ struct iavf_v

Re: Bad XDP performance with mlx5

2019-05-31 Thread Jesper Dangaard Brouer
On Fri, 31 May 2019 08:51:43 +0200 Tom Barbette wrote: > CCing mlx5 maintainers and commiters of bce2b2b. TLDK: there is a huge > CPU increase on CX5 when introducing a XDP program. > > See https://www.youtube.com/watch?v=o5hlJZbN4Tk&feature=youtu.be > around 0:40. We're talking something like

Re: [PATCH v2 bpf-next 1/2] bpf: Allow bpf_map_lookup_elem() on an xskmap

2019-05-31 Thread Jonathan Lemon
On 31 May 2019, at 4:49, Björn Töpel wrote: > On 2019-05-30 20:57, Jonathan Lemon wrote: >> Currently, the AF_XDP code uses a separate map in order to >> determine if an xsk is bound to a queue. Instead of doing this, >> have bpf_map_lookup_elem() return the queue_id, as a way of >> indicating th

[PATCH net-next v3] net: add rcu annotations for ifa_list

2019-05-31 Thread Florian Westphal
v3: fix typo in patch1 commit message All other patches are unchanged. v2: remove ifa_list iteration in afs instead of conversion Eric Dumazet reported following problem: It looks that unless RTNL is held, accessing ifa_list needs proper RCU protection. indev->ifa_list can be changed und

[PATCH net-next v3 1/7] afs: do not send list of client addresses

2019-05-31 Thread Florian Westphal
David Howells says: I'm told that there's not really any point populating the list. Current OpenAFS ignores it, as does AuriStor - and IBM AFS 3.6 will do the right thing. The list is actually useless as it's the client's view of the world, not the servers, so if there's any NAT in the wa

[PATCH net-next v3 3/7] devinet: use in_dev_for_each_ifa_rcu in more places

2019-05-31 Thread Florian Westphal
This also replaces spots that used for_primary_ifa(). for_primary_ifa() aborts the loop on the first secondary address seen. Replace it with either the rcu or rtnl variant of in_dev_for_each_ifa(), but two places will now also consider secondary addresses too: inet_addr_onlink() and inet_ifa_bypr

[PATCH net-next v3 4/7] netfilter: use in_dev_for_each_ifa_rcu

2019-05-31 Thread Florian Westphal
Netfilter hooks are always running under rcu read lock, use the new iterator macro so sparse won't complain once we add proper __rcu annotations. Signed-off-by: Florian Westphal --- net/ipv4/netfilter/nf_tproxy_ipv4.c| 9 +++-- net/netfilter/nf_conntrack_broadcast.c | 9 +++-- net/ne

[PATCH net-next v3 6/7] drivers: use in_dev_for_each_ifa_rtnl/rcu

2019-05-31 Thread Florian Westphal
Like previous patches, use the new iterator macros to avoid sparse warnings once proper __rcu annotations are added. Compile tested only. Signed-off-by: Florian Westphal --- drivers/infiniband/core/roce_gid_mgmt.c | 5 +++-- drivers/infiniband/hw/cxgb4/cm.c |

[PATCH net-next v3 5/7] net: use new in_dev_ifa iterators

2019-05-31 Thread Florian Westphal
Use in_dev_for_each_ifa_rcu/rtnl instead. This prevents sparse warnings once proper __rcu annotations are added. Signed-off-by: Florian Westphal t di# Last commands done (6 commands done): --- net/ipv4/fib_frontend.c | 24 +--- net/ipv4/igmp.c | 5 +++-- net/ipv6/ad

[PATCH net-next v3 2/7] net: inetdevice: provide replacement iterators for in_ifaddr walk

2019-05-31 Thread Florian Westphal
The ifa_list is protected either by rcu or rtnl lock, but the current iterators do not account for this. This adds two iterators as replacement, a later patch in the series will update them with the needed rcu/rtnl_dereference calls. Its not done in this patch yet to avoid sparse warnings -- the

[PATCH net-next v3 7/7] net: ipv4: provide __rcu annotation for ifa_list

2019-05-31 Thread Florian Westphal
ifa_list is protected by rcu, yet code doesn't reflect this. Add the __rcu annotations and fix up all places that are now reported by sparse. I've done this in the same commit to not add intermediate patches that result in new warnings. Reported-by: Eric Dumazet Signed-off-by: Florian Westphal

Re: [PATCH net-next v2 1/7] afs: do not send list of client addresses

2019-05-31 Thread Florian Westphal
David Howells wrote: > Florian Westphal wrote: > > > David Howell says: > > "Howells" My bad. > Apart from that: > > Tested-by: David Howells Thanks, a lot, I've re-submitted this as v3 retaining your tested-by.

  1   2   3   >