> On 30 May 2019, at 20:59, Stephen Hemminger <step...@networkplumber.org>
> wrote:
>
> On Thu, 30 May 2019 16:43:20 +0000
> Kevin 'ldir' Darbyshire-Bryant <l...@darbyshire-bryant.me.uk> wrote:
>
> Please don't use HTML encoded mail. I.e not exchange.
As far as I know I’m not sending HTML emails, or I’m trying hard to send
plain text from mac mail, and using git send-email to send patches.
The office365 smtp server appears to be mangling patches in some way,
sending using git send-email via icloud v office365 produces different
results despite setting 8bit encoding rather than base64. So I remain
confused.
Anyway, have sent a v2 via an icloud smtp server after your advice &
checkpatch etc etc. Hopefully improved.
>
>> +
>> + if (argc) {
>> + if (matches(*argv, "dscp") == 0) {
>> + NEXT_ARG();
>> + char *slash;
>> + if ((slash = strchr(*argv, '/')))
>> + *slash = '\0';
>
> Don't mix assignment and conditional on same line
Checkpatch found that too :-)
