On 5/31/19 1:34 AM, Young Xiao wrote:
> There is a possible null pointer deference bug in vxlan_fdb_info(),
> which is similar to the bug which was fixed in commit 6adc5fd6a142
> ("net/neighbour: fix crash at dumping device-agnostic proxy entries").
>
> Signed-off-by: Young Xiao <92siuy...@gmail.com>
> ---
> drivers/net/vxlan.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
> index 5994d54..1ba5977 100644
> --- a/drivers/net/vxlan.c
> +++ b/drivers/net/vxlan.c
> @@ -274,7 +274,7 @@ static int vxlan_fdb_info(struct sk_buff *skb, struct
> vxlan_dev *vxlan,
> } else
> ndm->ndm_family = AF_BRIDGE;
> ndm->ndm_state = fdb->state;
> - ndm->ndm_ifindex = vxlan->dev->ifindex;
> + ndm->ndm_ifindex = vxlan->dev ? vxlan->dev->ifindex : 0;
> ndm->ndm_flags = fdb->flags;
> if (rdst->offloaded)
> ndm->ndm_flags |= NTF_OFFLOADED;
>
Please provide a stack trace, and/or a Fixes: tag, and a detailed
analysis.
