[PATCH v2] samples: bpf: fix style in bpf_load

2019-05-23 Thread Daniel T. Lee
This commit fixes style problem in samples/bpf/bpf_load.c Styles that have been changed are: - Magic string use of 'DEBUGFS' - Useless zero initialization of a global variable - Minor style fix with whitespace Signed-off-by: Daniel T. Lee --- Changes in v2: - Fix string concatenation from b

[RESEND][PATCH] Fix MACsec kernel panics, oopses and bugs

2019-05-23 Thread Andreas Steinmetz
MACsec causes oopses followed by a kernel panic when attached directly or indirectly to a bridge. It causes erroneous checksum messages when attached to vxlan. When I did investigate I did find skb leaks, apparent skb mis-handling and superfluous code. The attached patch fixes all MACsec misbehav

Re: [PATCH bpf] selftests: bpf: add zero extend checks for ALU32 and/or/xor

2019-05-23 Thread Björn Töpel
On Thu, 23 May 2019 at 08:39, Y Song wrote: > > On Wed, May 22, 2019 at 1:46 PM Björn Töpel wrote: > > > > On Wed, 22 May 2019 at 20:13, Y Song wrote: > > > > > > On Wed, May 22, 2019 at 2:25 AM Björn Töpel wrote: > > > > > > > > Add three tests to test_verifier/basic_instr that make sure that

Re: [PATCH net-next] selftests: pmtu: Simplify cleanup and namespace names

2019-05-23 Thread Stefano Brivio
Hi David, On Wed, 22 May 2019 12:11:06 -0700 David Ahern wrote: > From: David Ahern > > The point of the pause-on-fail argument is to leave the setup as is after > a test fails to allow a user to debug why it failed. Move the cleanup > after posting the result to the user to make it so. > > R

Re: [PATCH net,stable 1/1] net: fec: fix the clk mismatch in failed_reset path

2019-05-23 Thread Baruch Siach
Hi Andy, On Thu, May 23, 2019 at 01:55:28AM +, Andy Duan wrote: > Fix the clk mismatch in the error path "failed_reset" because > below error path will disable clk_ahb and clk_ipg directly, it > should use pm_runtime_put_noidle() instead of pm_runtime_put() > to avoid to call runtime resume ca

[patch net-next v2] devlink: add warning in case driver does not set port type

2019-05-23 Thread Jiri Pirko
From: Jiri Pirko Prevent misbehavior of drivers who would not set port type for longer period of time. Drivers should always set port type. Do WARN if that happens. Note that it is perfectly fine to temporarily not have the type set, during initialization and port type change. Signed-off-by: Ji

Re: [PATCH bpf-next 1/2] net: xdp: refactor XDP_QUERY_PROG{,_HW} to netdev

2019-05-23 Thread Toke Høiland-Jørgensen
Jakub Kicinski writes: > On Wed, 22 May 2019 22:54:44 +0200, Björn Töpel wrote: >> > > Now, the same commands give: >> > > >> > > # ip link set dev eth0 xdp obj foo.o sec main >> > > # ip link set dev eth0 xdpgeneric off >> > > Error: native and generic XDP can't be active at the same time.

[patch net-next 2/7] mlx5: Move firmware flash implementation to devlink

2019-05-23 Thread Jiri Pirko
From: Jiri Pirko Benefit from the devlink flash update implementation and ethtool fallback to it and move firmware flash implementation there. Signed-off-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 2 -- .../ethernet/mellanox/mlx5/core/en_ethtool.c | 35 ---

[patch net-next 0/7] expose flash update status to user

2019-05-23 Thread Jiri Pirko
From: Jiri Pirko When user is flashing device using devlink, he currenly does not see any information about what is going on, percentages, etc. Drivers, for example mlxsw and mlx5, have notion about the progress and what is happening. This patchset exposes this progress information to userspace.

[patch net-next 1/7] mlxsw: Move firmware flash implementation to devlink

2019-05-23 Thread Jiri Pirko
From: Jiri Pirko Benefit from the devlink flash update implementation and ethtool fallback to it and move firmware flash implementation there. Signed-off-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/core.c| 15 ++ drivers/net/ethernet/mellanox/mlxsw/core.h| 3 ++ .../net

[patch net-next 3/7] mlxfw: Propagate error messages through extack

2019-05-23 Thread Jiri Pirko
From: Jiri Pirko Currently the error messages are printed to dmesg. Propagate them also to directly to user doing the flashing through extack. Signed-off-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlx5/core/fw.c | 6 ++-- .../net/ethernet/mellanox/mlx5/core/main.c| 2 +- .../ether

[patch net-next 4/7] devlink: allow driver to update progress of flash update

2019-05-23 Thread Jiri Pirko
From: Jiri Pirko Introduce a function to be called from drivers during flash. It sends notification to userspace about flash update progress. Signed-off-by: Jiri Pirko --- include/net/devlink.h| 8 +++ include/uapi/linux/devlink.h | 5 ++ net/core/devlink.c | 102

[patch net-next 6/7] mlxsw: Implement flash update status notifications

2019-05-23 Thread Jiri Pirko
From: Jiri Pirko Implement mlxfw status_notify op by passing notification down to devlink. Also notify about flash update begin and end. Signed-off-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff -

[patch net-next 5/7] mlxfw: Introduce status_notify op and call it to notify about the status

2019-05-23 Thread Jiri Pirko
From: Jiri Pirko Add new op status_notify which is called to update the user about flashing status. Signed-off-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxfw/mlxfw.h | 4 .../net/ethernet/mellanox/mlxfw/mlxfw_fsm.c | 24 +++ 2 files changed, 28 insertions(+)

[patch net-next 7/7] netdevsim: implement fake flash updating with notifications

2019-05-23 Thread Jiri Pirko
From: Jiri Pirko Signed-off-by: Jiri Pirko --- drivers/net/netdevsim/dev.c | 35 +++ 1 file changed, 35 insertions(+) diff --git a/drivers/net/netdevsim/dev.c b/drivers/net/netdevsim/dev.c index b509b941d5ca..c15b86f9cd2b 100644 --- a/drivers/net/netdevsim/dev.c

[patch iproute2 2/3] devlink: implement flash update status monitoring

2019-05-23 Thread Jiri Pirko
From: Jiri Pirko Kernel sends notifications about flash update status, so implement these messages for monitoring. Signed-off-by: Jiri Pirko --- devlink/devlink.c | 43 +++ 1 file changed, 43 insertions(+) diff --git a/devlink/devlink.c b/devlink/devlin

[patch iproute2 3/3] devlink: implement flash status monitoring

2019-05-23 Thread Jiri Pirko
From: Jiri Pirko Listen to status notifications coming from kernel during flashing and put them on stdout to inform user about the status. Signed-off-by: Jiri Pirko --- devlink/devlink.c | 209 +- devlink/mnlg.c| 5 ++ devlink/mnlg.h| 1 +

[patch iproute2 1/3] header update

2019-05-23 Thread Jiri Pirko
From: Jiri Pirko Signed-off-by: Jiri Pirko --- include/uapi/linux/devlink.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/uapi/linux/devlink.h b/include/uapi/linux/devlink.h index 3b6a9e6be3ac..6544824a0b97 100644 --- a/include/uapi/linux/devlink.h +++ b/include/uapi/linux/de

[PATCH 2/8] dt-bindings: net: Add a YAML schemas for the generic PHY options

2019-05-23 Thread Maxime Ripard
The networking PHYs have a number of available device tree properties that can be used in their device tree node. Add a YAML schemas for those. Signed-off-by: Maxime Ripard --- Documentation/devicetree/bindings/net/ethernet-phy.yaml | 148 +- Documentation/devicetree/bindings/net/phy.txt

[PATCH 3/8] dt-bindings: net: phy: The interrupt property is not mandatory

2019-05-23 Thread Maxime Ripard
Unlike what was initially claimed in the PHY binding, the interrupt property of a PHY can be omitted, and the OS will turn to polling instead. Document that. Signed-off-by: Maxime Ripard --- Documentation/devicetree/bindings/net/ethernet-phy.yaml | 1 - 1 file changed, 1 deletion(-) diff --git

[PATCH 1/8] dt-bindings: net: Add YAML schemas for the generic Ethernet options

2019-05-23 Thread Maxime Ripard
The Ethernet controllers have a good number of generic options that can be needed in a device tree. Add a YAML schemas for those. Signed-off-by: Maxime Ripard --- Documentation/devicetree/bindings/net/ethernet-controller.yaml | 197 +++- Documentation/devicetree/bindings/net/ethernet.txt

[PATCH 4/8] dt-bindings: net: sun4i-emac: Convert the binding to a schemas

2019-05-23 Thread Maxime Ripard
Switch our Allwinner A10 EMAC controller binding to a YAML schema to enable the DT validation. Signed-off-by: Maxime Ripard --- Documentation/devicetree/bindings/net/allwinner,sun4i-a10-emac.yaml | 55 +++ Documentation/devicetree/bindings/net

[PATCH 5/8] dt-bindings: net: sun4i-mdio: Convert the binding to a schemas

2019-05-23 Thread Maxime Ripard
Switch our Allwinner A10 MDIO controller binding to a YAML schema to enable the DT validation. Signed-off-by: Maxime Ripard --- Documentation/devicetree/bindings/net/allwinner,sun4i-a10-mdio.yaml | 55 +++ Documentation/devicetree/bindings/net

[PATCH 6/8] dt-bindings: net: stmmac: Convert the binding to a schemas

2019-05-23 Thread Maxime Ripard
Switch the STMMAC / Synopsys DesignWare MAC controller binding to a YAML schema to enable the DT validation. Signed-off-by: Maxime Ripard --- Documentation/devicetree/bindings/net/snps,dwmac.yaml | 344 +++- Documentation/devicetree/bindings/net/stmmac.txt | 179 +-- 2 files cha

[PATCH 8/8] dt-bindings: net: sun8i-emac: Convert the binding to a schemas

2019-05-23 Thread Maxime Ripard
Switch our Allwinner H3 EMAC controller binding to a YAML schema to enable the DT validation. Since that controller is based on a Synopsys IP, let's add the validation to that schemas with a bunch of conditionals. Signed-off-by: Maxime Ripard --- Documentation/devicetree/bindings/net/dwmac-sun8i

[PATCH 7/8] dt-bindings: net: sun7i-gmac: Convert the binding to a schemas

2019-05-23 Thread Maxime Ripard
Switch our Allwinner A20 GMAC controller binding to a YAML schema to enable the DT validation. Since that controller is based on a Synopsys IP, let's add the validation to that schemas with a bunch of conditionals. Signed-off-by: Maxime Ripard --- Documentation/devicetree/bindings/net/allwinner,

RE: [PATCH 6/8] dt-bindings: net: stmmac: Convert the binding to a schemas

2019-05-23 Thread Jose Abreu
From: Maxime Ripard Date: Thu, May 23, 2019 at 10:56:49 > Switch the STMMAC / Synopsys DesignWare MAC controller binding to a YAML > schema to enable the DT validation. > > Signed-off-by: Maxime Ripard How exactly can I see the final results of this ? Do you have any link ? (I'm no expert in

[PATCH bpf-next v2 0/3] tools: bpftool: add an option for debug output from libbpf and verifier

2019-05-23 Thread Quentin Monnet
Hi, This series adds an option to bpftool to make it print additional information via libbpf and the kernel verifier when attempting to load programs. A new API function is added to libbpf in order to pass the log_level from bpftool with the bpf_object__* part of the API. Options for a finer cont

[PATCH bpf-next v2 1/3] tools: bpftool: add -d option to get debug output from libbpf

2019-05-23 Thread Quentin Monnet
libbpf has three levels of priority for output messages: warn, info, debug. By default, debug output is not printed to the console. Add a new "--debug" (short name: "-d") option to bpftool to print libbpf logs for all three levels. Internally, we simply use the function provided by libbpf to repl

[PATCH bpf-next v2 3/3] tools: bpftool: make -d option print debug output from verifier

2019-05-23 Thread Quentin Monnet
The "-d" option is used to require all logs available for bpftool. So far it meant telling libbpf to print even debug-level information. But there is another source of info that can be made more verbose: when we attemt to load programs with bpftool, we can pass a log_level parameter to the verifier

[PATCH bpf-next v2 2/3] libbpf: add bpf_object__load_xattr() API function to pass log_level

2019-05-23 Thread Quentin Monnet
libbpf was recently made aware of the log_level attribute for programs, used to specify the level of information expected to be dumped by the verifier. Create an API function to pass additional attributes when loading a bpf_object, so we can set this log_level value in programs when loading them,

[PATCH bpf-next 1/3] xdp: Add bulk XDP_TX queue

2019-05-23 Thread Toshiaki Makita
XDP_TX is similar to XDP_REDIRECT as it essentially redirects packets to the device itself. XDP_REDIRECT has bulk transmit mechanism to avoid the heavy cost of indirect call but it also reduces lock acquisition on the destination device that needs locks like veth and tun. XDP_TX does not use indir

[PATCH bpf-next 0/3] veth: Bulk XDP_TX

2019-05-23 Thread Toshiaki Makita
This adds an infrastructure for bulk XDP_TX and makes veth use it. Improves XDP_TX performance by approximately 8%. The detailed performance numbers are shown in patch 3. Signed-off-by: Toshiaki Makita Toshiaki Makita (3): xdp: Add bulk XDP_TX queue xdp: Add tracepoint for bulk XDP_TX veth

[PATCH bpf-next 2/3] xdp: Add tracepoint for bulk XDP_TX

2019-05-23 Thread Toshiaki Makita
This is introduced for admins to check what is happening on XDP_TX when bulk XDP_TX is in use. Signed-off-by: Toshiaki Makita --- include/trace/events/xdp.h | 25 + kernel/bpf/core.c | 1 + 2 files changed, 26 insertions(+) diff --git a/include/trace/events/xdp

[PATCH bpf-next 3/3] veth: Support bulk XDP_TX

2019-05-23 Thread Toshiaki Makita
This improves XDP_TX performance by about 8%. Here are single core XDP_TX test results. CPU consumptions are taken from "perf report --no-child". - Before: 7.26 Mpps _raw_spin_lock 7.83% veth_xdp_xmit 12.23% - After: 7.84 Mpps _raw_spin_lock 1.17% veth_xdp_xmit 6.45% Signed

Re: [PATCH 6/8] dt-bindings: net: stmmac: Convert the binding to a schemas

2019-05-23 Thread Maxime Ripard
Hi! On Thu, May 23, 2019 at 10:11:39AM +, Jose Abreu wrote: > From: Maxime Ripard > Date: Thu, May 23, 2019 at 10:56:49 > > > Switch the STMMAC / Synopsys DesignWare MAC controller binding to a YAML > > schema to enable the DT validation. > > > > Signed-off-by: Maxime Ripard > > How exactly

Re: [PATCH bpf-next 1/3] xdp: Add bulk XDP_TX queue

2019-05-23 Thread Toke Høiland-Jørgensen
Toshiaki Makita writes: > XDP_TX is similar to XDP_REDIRECT as it essentially redirects packets to > the device itself. XDP_REDIRECT has bulk transmit mechanism to avoid the > heavy cost of indirect call but it also reduces lock acquisition on the > destination device that needs locks like veth a

RE: [PATCH 6/8] dt-bindings: net: stmmac: Convert the binding to a schemas

2019-05-23 Thread Jose Abreu
From: Maxime Ripard Date: Thu, May 23, 2019 at 12:07:15 > You can then run make dtbs_check, and those YAML files will be used to > validate that any devicetree using those properties are doing it > properly. That implies having the right node names, properties, types, > ranges of values when rele

Re: [PATCH bpf-next 1/3] xdp: Add bulk XDP_TX queue

2019-05-23 Thread Toshiaki Makita
On 2019/05/23 20:11, Toke Høiland-Jørgensen wrote: > Toshiaki Makita writes: > >> XDP_TX is similar to XDP_REDIRECT as it essentially redirects packets to >> the device itself. XDP_REDIRECT has bulk transmit mechanism to avoid the >> heavy cost of indirect call but it also reduces lock acquisitio

Re: [PATCH bpf-next 3/3] veth: Support bulk XDP_TX

2019-05-23 Thread Toke Høiland-Jørgensen
Toshiaki Makita writes: > This improves XDP_TX performance by about 8%. > > Here are single core XDP_TX test results. CPU consumptions are taken > from "perf report --no-child". > > - Before: > > 7.26 Mpps > > _raw_spin_lock 7.83% > veth_xdp_xmit 12.23% > > - After: > > 7.84 Mpps > >

Re: [PATCH bpf-next 1/3] xdp: Add bulk XDP_TX queue

2019-05-23 Thread Toke Høiland-Jørgensen
Toshiaki Makita writes: > On 2019/05/23 20:11, Toke Høiland-Jørgensen wrote: >> Toshiaki Makita writes: >> >>> XDP_TX is similar to XDP_REDIRECT as it essentially redirects packets to >>> the device itself. XDP_REDIRECT has bulk transmit mechanism to avoid the >>> heavy cost of indirect call bu

Re: [PATCH bpf-next 3/3] veth: Support bulk XDP_TX

2019-05-23 Thread Toshiaki Makita
On 2019/05/23 20:25, Toke Høiland-Jørgensen wrote: > Toshiaki Makita writes: > >> This improves XDP_TX performance by about 8%. >> >> Here are single core XDP_TX test results. CPU consumptions are taken >> from "perf report --no-child". >> >> - Before: >> >> 7.26 Mpps >> >> _raw_spin_lock 7.

RE: [RFC PATCH net-next 5/9] net: phylink: Add phylink_create_raw

2019-05-23 Thread Ioana Ciornei
> Subject: Re: [RFC PATCH net-next 5/9] net: phylink: Add phylink_create_raw > > > > On 5/22/2019 7:25 PM, Florian Fainelli wrote: > > > > > > On 5/22/2019 6:20 PM, Ioana Ciornei wrote: > >> This adds a new entry point to PHYLINK that does not require a > >> net_device structure. > >> > >> The

Re: [PATCH bpf-next 3/3] veth: Support bulk XDP_TX

2019-05-23 Thread Toke Høiland-Jørgensen
Toshiaki Makita writes: > On 2019/05/23 20:25, Toke Høiland-Jørgensen wrote: >> Toshiaki Makita writes: >> >>> This improves XDP_TX performance by about 8%. >>> >>> Here are single core XDP_TX test results. CPU consumptions are taken >>> from "perf report --no-child". >>> >>> - Before: >>> >>>

Re: DSA setup IMX6ULL and Marvell 88E6390 with 2 Ethernet Phys - CPU Port is not working

2019-05-23 Thread Andrew Lunn
> thanks for your reply. You're right, both PHYs are 10/100. > > I already added a fixed-link like this: > > port@0 { > reg = <0>; > label = "cpu"; > ethernet = <&fec1>; >

Re: [PATCH 1/8] dt-bindings: net: Add YAML schemas for the generic Ethernet options

2019-05-23 Thread Rob Herring
On Thu, May 23, 2019 at 4:57 AM Maxime Ripard wrote: > > The Ethernet controllers have a good number of generic options that can be > needed in a device tree. Add a YAML schemas for those. > > Signed-off-by: Maxime Ripard > --- > Documentation/devicetree/bindings/net/ethernet-controller.yaml | 1

Re: [PATCH bpf-next 2/3] xdp: Add tracepoint for bulk XDP_TX

2019-05-23 Thread Jesper Dangaard Brouer
On Thu, 23 May 2019 19:56:47 +0900 Toshiaki Makita wrote: > This is introduced for admins to check what is happening on XDP_TX when > bulk XDP_TX is in use. > > Signed-off-by: Toshiaki Makita > --- > include/trace/events/xdp.h | 25 + > kernel/bpf/core.c | 1 +

Re: [PATCH v3 net-next 0/3] flow_offload: Re-add per-action statistics

2019-05-23 Thread Jamal Hadi Salim
On 2019-05-22 6:20 p.m., Jakub Kicinski wrote: On Wed, 22 May 2019 22:37:16 +0100, Edward Cree wrote: * removed RFC tags Why? There is still no upstream user for this (my previous objections of this being only partially correct aside). IIRC your point was to get the dumping to work with RT

[PATCH nf-next] netfilter: add support for matching IPv4 options

2019-05-23 Thread Stephen Suryaputra
This is the kernel change for the overall changes with this description: Add capability to have rules matching IPv4 options. This is developed mainly to support dropping of IP packets with loose and/or strict source route route options. Nevertheless, the implementation include others and ability to

Re: [PATCH bpf-next 3/3] veth: Support bulk XDP_TX

2019-05-23 Thread Jesper Dangaard Brouer
On Thu, 23 May 2019 20:35:50 +0900 Toshiaki Makita wrote: > On 2019/05/23 20:25, Toke Høiland-Jørgensen wrote: > > Toshiaki Makita writes: > > > >> This improves XDP_TX performance by about 8%. > >> > >> Here are single core XDP_TX test results. CPU consumptions are taken > >> from "perf repo

Re: [PATCH bpf-next 3/3] veth: Support bulk XDP_TX

2019-05-23 Thread Toshiaki Makita
On 19/05/23 (木) 21:18:25, Toke Høiland-Jørgensen wrote: Toshiaki Makita writes: On 2019/05/23 20:25, Toke Høiland-Jørgensen wrote: Toshiaki Makita writes: This improves XDP_TX performance by about 8%. Here are single core XDP_TX test results. CPU consumptions are taken from "perf report -

Re: [PATCH bpf-next 3/3] veth: Support bulk XDP_TX

2019-05-23 Thread Toshiaki Makita
On 19/05/23 (木) 22:29:27, Jesper Dangaard Brouer wrote: On Thu, 23 May 2019 20:35:50 +0900 Toshiaki Makita wrote: On 2019/05/23 20:25, Toke Høiland-Jørgensen wrote: Toshiaki Makita writes: This improves XDP_TX performance by about 8%. Here are single core XDP_TX test results. CPU consu

[PATCH net-next] cxgb4: use firmware API for validating filter spec

2019-05-23 Thread Raju Rangoju
Adds support for validating hardware filter spec configured in firmware before offloading exact match flows. Use the new fw api FW_PARAM_DEV_FILTER_MODE_MASK to read the filter mode and mask from firmware. If the api isn't supported, then fall-back to older way of reading just the mode from indire

Re: Question about IRQs during the .remove() of virtio-vsock driver

2019-05-23 Thread Stefano Garzarella
On Wed, May 22, 2019 at 11:44:26AM +0800, Jason Wang wrote: > > On 2019/5/21 下午9:56, Michael S. Tsirkin wrote: > > On Tue, May 21, 2019 at 03:49:20PM +0200, Stefano Garzarella wrote: > > > On Tue, May 21, 2019 at 06:05:31AM -0400, Michael S. Tsirkin wrote: > > > > On Tue, May 21, 2019 at 11:44:07A

Re: [PATCH bpf] bpf, riscv: clear target register high 32-bits for and/or/xor on ALU32

2019-05-23 Thread Daniel Borkmann
On 05/21/2019 04:12 PM, Björn Töpel wrote: > On Tue, 21 May 2019 at 16:02, Daniel Borkmann wrote: >> On 05/21/2019 03:46 PM, Björn Töpel wrote: >>> When using 32-bit subregisters (ALU32), the RISC-V JIT would not clear >>> the high 32-bits of the target register and therefore generate >>> incorrec

Re: [PATCH bpf] selftests: bpf: add zero extend checks for ALU32 and/or/xor

2019-05-23 Thread Daniel Borkmann
On 05/23/2019 08:38 AM, Y Song wrote: > On Wed, May 22, 2019 at 1:46 PM Björn Töpel wrote: >> On Wed, 22 May 2019 at 20:13, Y Song wrote: >>> On Wed, May 22, 2019 at 2:25 AM Björn Töpel wrote: Add three tests to test_verifier/basic_instr that make sure that the high 32-bits of the

Re: [bpf PATCH] bpf: sockmap, restore sk_write_space when psock gets dropped

2019-05-23 Thread Daniel Borkmann
On 05/22/2019 12:01 PM, Jakub Sitnicki wrote: > Once psock gets unlinked from its sock (sk_psock_drop), user-space can > still trigger a call to sk->sk_write_space by setting TCP_NOTSENT_LOWAT > socket option. This causes a null-ptr-deref because we try to read > psock->saved_write_space from sk_ps

Re: [PATCH v7 bpf-next 01/16] bpf: verifier: mark verified-insn with sub-register zext flag

2019-05-23 Thread Jiong Wang
> On 23 May 2019, at 03:07, Alexei Starovoitov > wrote: > > On Wed, May 22, 2019 at 07:54:57PM +0100, Jiong Wang wrote: >> eBPF ISA specification requires high 32-bit cleared when low 32-bit >> sub-register is written. This applies to destination register of ALU32 etc. >> JIT back-ends must gu

Re: [PATCH bpf] selftests: bpf: add zero extend checks for ALU32 and/or/xor

2019-05-23 Thread Jiong Wang
> On 23 May 2019, at 15:02, Daniel Borkmann wrote: > > On 05/23/2019 08:38 AM, Y Song wrote: >> On Wed, May 22, 2019 at 1:46 PM Björn Töpel wrote: >>> On Wed, 22 May 2019 at 20:13, Y Song wrote: On Wed, May 22, 2019 at 2:25 AM Björn Töpel wrote: > > Add three tests to test_veri

Re: [RFC PATCH net-next 5/9] net: phylink: Add phylink_create_raw

2019-05-23 Thread Florian Fainelli
On 5/23/2019 5:10 AM, Ioana Ciornei wrote: > >> Subject: Re: [RFC PATCH net-next 5/9] net: phylink: Add phylink_create_raw >> >> >> >> On 5/22/2019 7:25 PM, Florian Fainelli wrote: >>> >>> >>> On 5/22/2019 6:20 PM, Ioana Ciornei wrote: This adds a new entry point to PHYLINK that does not r

Re: [PATCH 2/8] dt-bindings: net: Add a YAML schemas for the generic PHY options

2019-05-23 Thread Andrew Lunn
On Thu, May 23, 2019 at 11:56:45AM +0200, Maxime Ripard wrote: > The networking PHYs have a number of available device tree properties that > can be used in their device tree node. Add a YAML schemas for those. > > Signed-off-by: Maxime Ripard > --- > Documentation/devicetree/bindings/net/ethern

[PATCH net-next] Revert "dpaa2-eth: configure the cache stashing amount on a queue"

2019-05-23 Thread Ioana Radulescu
This reverts commit f8b995853444aba9c16c1ccdccdd397527fde96d. The reverted change instructed the QMan hardware block to fetch RX frame annotation and beginning of frame data to cache before the core would read them. It turns out that in rare cases, it's possible that a QMan stashing transaction i

Re: [PATCH 1/8] dt-bindings: net: Add YAML schemas for the generic Ethernet options

2019-05-23 Thread Andrew Lunn
> > +link-gpios: > > + description: > > +GPIO to determine if the link is up > > Only 1? Hi Rob Yes, only one. Andrew

Re: [PATCH v2 bpf-next 0/3] bpf: increase jmp sequence limit

2019-05-23 Thread Daniel Borkmann
On 05/22/2019 05:14 AM, Alexei Starovoitov wrote: > Patch 1 - jmp sequence limit > Patch 2 - improve existing tests > Patch 3 - add pyperf-based realistic bpf program that takes advantage > of higher limit and use it as a stress test > > v1->v2: fixed nit in patch 3. added Andrii's acks > > Alexe

Re: [PATCH 2/8] dt-bindings: net: Add a YAML schemas for the generic PHY options

2019-05-23 Thread Rob Herring
On Thu, May 23, 2019 at 4:57 AM Maxime Ripard wrote: > > The networking PHYs have a number of available device tree properties that > can be used in their device tree node. Add a YAML schemas for those. > > Signed-off-by: Maxime Ripard > --- > Documentation/devicetree/bindings/net/ethernet-phy.y

Re: [PATCH 6/8] dt-bindings: net: stmmac: Convert the binding to a schemas

2019-05-23 Thread Maxime Ripard
On Thu, May 23, 2019 at 11:25:09AM +, Jose Abreu wrote: > From: Maxime Ripard > Date: Thu, May 23, 2019 at 12:07:15 > > > You can then run make dtbs_check, and those YAML files will be used to > > validate that any devicetree using those properties are doing it > > properly. That implies havin

Re: [PATCH 6/8] dt-bindings: net: stmmac: Convert the binding to a schemas

2019-05-23 Thread Alexandre Torgue
Hi Maxime On 5/23/19 11:56 AM, Maxime Ripard wrote: Switch the STMMAC / Synopsys DesignWare MAC controller binding to a YAML schema to enable the DT validation. Signed-off-by: Maxime Ripard --- First, thanks a lot for this patch. Just one question: We could add ranges for some properties in

[PATCH net] cxgb4: offload VLAN flows regardless of VLAN ethtype

2019-05-23 Thread Raju Rangoju
VLAN flows never get offloaded unless ivlan_vld is set in filter spec. It's not compulsory for vlan_ethtype to be set. So, always enable ivlan_vld bit for offloading VLAN flows regardless of vlan_ethtype is set or not. Fixes: ad9af3e09c (cxgb4: add tc flower match support for vlan) Signed-off-by:

Re: [RFC PATCH net-next 0/9] Decoupling PHYLINK from struct net_device

2019-05-23 Thread Maxime Chevallier
Hello Ioana, On Thu, 23 May 2019 01:20:36 + Ioana Ciornei wrote: >Following two separate discussion threads in: > https://www.spinics.net/lists/netdev/msg569087.html >and: > https://www.spinics.net/lists/netdev/msg570450.html > >PHYLINK was reworked in order to add a new "raw" interface, a

Re: Bug or mis configuration for mlx5e lag and multipath

2019-05-23 Thread Roi Dayan
On 20/05/2019 04:53, wenxu wrote: > Hi Roi & Saeed, > > I just test the mlx5e lag and mutipath feature. There are some suituation the > outgoing can't be offloaded. > > ovs configureation as following. > > # ovs-vsctl show > dfd71dfb-6e22-423e-b088-d2022103af6b >     Bridge "br0" >     Po

Re: [patch net-next 3/7] mlxfw: Propagate error messages through extack

2019-05-23 Thread David Ahern
On 5/23/19 3:45 AM, Jiri Pirko wrote: > @@ -57,11 +58,13 @@ static int mlxfw_fsm_state_wait(struct mlxfw_dev > *mlxfw_dev, u32 fwhandle, > if (fsm_state_err != MLXFW_FSM_STATE_ERR_OK) { > pr_err("Firmware flash failed: %s\n", > mlxfw_fsm_state_err_str[fsm_s

bonding-devel mail list?

2019-05-23 Thread Bill Carlson
Hello, Noted the old bonding-devel mail list at sourceforge is no more, is there an alternate? Chasing whether a bond of bonds has an issue my testing hasn't revealed. Thanks, -- Bill Carlson Anything is possible, given Time and Money.

Re: [PATCH 6/8] dt-bindings: net: stmmac: Convert the binding to a schemas

2019-05-23 Thread Rob Herring
On Thu, May 23, 2019 at 4:57 AM Maxime Ripard wrote: > > Switch the STMMAC / Synopsys DesignWare MAC controller binding to a YAML > schema to enable the DT validation. You picked an easy one. ;) > > Signed-off-by: Maxime Ripard > --- > Documentation/devicetree/bindings/net/snps,dwmac.yaml | 34

Re: [RFC] vsock: proposal to support multiple transports at runtime

2019-05-23 Thread Stefan Hajnoczi
On Tue, May 14, 2019 at 10:15:43AM +0200, Stefano Garzarella wrote: > Hi guys, > I'm currently interested on implement a multi-transport support for VSOCK in > order to handle nested VMs. > > As Stefan suggested me, I started to look at this discussion: > https://lkml.org/lkml/2017/8/17/551 > Belo

Re: [PATCH bpf-next v2 1/3] bpf: implement bpf_send_signal() helper

2019-05-23 Thread Daniel Borkmann
On 05/22/2019 07:39 AM, Yonghong Song wrote: > This patch tries to solve the following specific use case. > > Currently, bpf program can already collect stack traces > through kernel function get_perf_callchain() > when certain events happens (e.g., cache miss counter or > cpu clock counter overfl

Re: [PATCH net-next] selftests: pmtu: Simplify cleanup and namespace names

2019-05-23 Thread David Ahern
On 5/23/19 1:58 AM, Stefano Brivio wrote: > Hi David, > > On Wed, 22 May 2019 12:11:06 -0700 > David Ahern wrote: > >> From: David Ahern >> >> The point of the pause-on-fail argument is to leave the setup as is after >> a test fails to allow a user to debug why it failed. Move the cleanup >> af

[PATCH] bpf: sockmap, fix use after free from sleep in psock backlog workqueue

2019-05-23 Thread John Fastabend
Backlog work for psock (sk_psock_backlog) might sleep while waiting for memory to free up when sending packets. However, while sleeping the socket may be closed and removed from the map by the user space side. This breaks an assumption in sk_stream_wait_memory, which expects the wait queue to be s

Re: [PATCH 7/8] dt-bindings: net: sun7i-gmac: Convert the binding to a schemas

2019-05-23 Thread Rob Herring
On Thu, May 23, 2019 at 4:57 AM Maxime Ripard wrote: > > Switch our Allwinner A20 GMAC controller binding to a YAML schema to enable > the DT validation. Since that controller is based on a Synopsys IP, let's > add the validation to that schemas with a bunch of conditionals. > > Signed-off-by: Max

Re: [PATCH net] sk_msg: Keep reference on socket file while psock lives

2019-05-23 Thread John Fastabend
[...] > > Thanks for taking a look at it. Setting MSG_DONTWAIT works great for > me. No more crashes in sk_stream_wait_memory. I've tested it on top of > current bpf-next (f49aa1de9836). Here's my: > > Tested-by: Jakub Sitnicki > > The actual I've tested is below, for completeness. > > BTW.

Re: [PATCH bpf-next v2 1/3] bpf: implement bpf_send_signal() helper

2019-05-23 Thread Yonghong Song
On 5/23/19 8:41 AM, Daniel Borkmann wrote: > On 05/22/2019 07:39 AM, Yonghong Song wrote: >> This patch tries to solve the following specific use case. >> >> Currently, bpf program can already collect stack traces >> through kernel function get_perf_callchain() >> when certain events happens (e.g

Re: [PATCH bpf-next 06/12] selftests/bpf: add tests for libbpf's hashmap

2019-05-23 Thread Stanislav Fomichev
On 05/22, Andrii Nakryiko wrote: > On Wed, May 22, 2019 at 3:15 PM Andrii Nakryiko > wrote: > > > > On Wed, May 22, 2019 at 1:31 PM Stanislav Fomichev wrote: > > > > > > On 05/22, Andrii Nakryiko wrote: > > > > Test all APIs for internal hashmap implementation. > > > > > > > > Signed-off-by: Andr

Re: [PATCH bpf] selftests: bpf: add zero extend checks for ALU32 and/or/xor

2019-05-23 Thread Björn Töpel
On Thu, 23 May 2019 at 16:31, Jiong Wang wrote: > > > > On 23 May 2019, at 15:02, Daniel Borkmann wrote: > > > > On 05/23/2019 08:38 AM, Y Song wrote: > >> On Wed, May 22, 2019 at 1:46 PM Björn Töpel wrote: > >>> On Wed, 22 May 2019 at 20:13, Y Song wrote: > On Wed, May 22, 2019 at 2:25 AM

[PATCH net-next v4] net: sched: Introduce act_ctinfo action

2019-05-23 Thread Kevin 'ldir' Darbyshire-Bryant
ctinfo is a new tc filter action module. It is designed to restore information contained in conntrack marks to other places. At present it can restore DSCP values to IPv4/6 diffserv fields and also copy conntrack marks to skb marks. As such the 2nd function effectively replaces the existing act_

Re: [RESEND][PATCH] Fix MACsec kernel panics, oopses and bugs

2019-05-23 Thread David Miller
From: Andreas Steinmetz Date: Thu, 23 May 2019 09:46:15 +0200 > MACsec causes oopses followed by a kernel panic when attached directly or > indirectly to a bridge. It causes erroneous > checksum messages when attached to vxlan. When I did investigate I did find > skb leaks, apparent skb mis-han

Re: [PATCH v3 net-next 0/3] flow_offload: Re-add per-action statistics

2019-05-23 Thread Jakub Kicinski
On Thu, 23 May 2019 09:19:49 -0400, Jamal Hadi Salim wrote: > On 2019-05-22 6:20 p.m., Jakub Kicinski wrote: > > On Wed, 22 May 2019 22:37:16 +0100, Edward Cree wrote: > >> * removed RFC tags > > > > Why? There is still no upstream user for this (my previous > > objections of this being only

Re: [patch net-next v2] devlink: add warning in case driver does not set port type

2019-05-23 Thread David Miller
From: Jiri Pirko Date: Thu, 23 May 2019 10:43:35 +0200 > From: Jiri Pirko > > Prevent misbehavior of drivers who would not set port type for longer > period of time. Drivers should always set port type. Do WARN if that > happens. > > Note that it is perfectly fine to temporarily not have the t

Re: [PATCH v7 bpf-next 01/16] bpf: verifier: mark verified-insn with sub-register zext flag

2019-05-23 Thread Alexei Starovoitov
On Thu, May 23, 2019 at 03:28:15PM +0100, Jiong Wang wrote: > > > On 23 May 2019, at 03:07, Alexei Starovoitov > > wrote: > > > > On Wed, May 22, 2019 at 07:54:57PM +0100, Jiong Wang wrote: > >> eBPF ISA specification requires high 32-bit cleared when low 32-bit > >> sub-register is written. Th

Re: [PATCH net-next] selftests: pmtu: Simplify cleanup and namespace names

2019-05-23 Thread Stefano Brivio
On Thu, 23 May 2019 09:41:59 -0600 David Ahern wrote: > I have been using the namespace override for a while now. I did consider > impacts to the above, but my thinking is this: exceptions are per FIB > entry (per fib6_nh with my latest patch set, but point still holds), FIB > entries are per FIB

Re: [PATCH bpf-next v2 2/3] libbpf: add bpf_object__load_xattr() API function to pass log_level

2019-05-23 Thread Yonghong Song
On 5/23/19 3:54 AM, Quentin Monnet wrote: > libbpf was recently made aware of the log_level attribute for programs, > used to specify the level of information expected to be dumped by the > verifier. > > Create an API function to pass additional attributes when loading a > bpf_object, so we can

Re: [PATCH bpf-next v2 1/3] tools: bpftool: add -d option to get debug output from libbpf

2019-05-23 Thread Andrii Nakryiko
On Thu, May 23, 2019 at 3:54 AM Quentin Monnet wrote: > > libbpf has three levels of priority for output messages: warn, info, > debug. By default, debug output is not printed to the console. > > Add a new "--debug" (short name: "-d") option to bpftool to print libbpf > logs for all three levels.

Re: [PATCH v3 net-next 0/3] flow_offload: Re-add per-action statistics

2019-05-23 Thread Edward Cree
On 22/05/2019 23:20, Jakub Kicinski wrote: > On Wed, 22 May 2019 22:37:16 +0100, Edward Cree wrote: >> * removed RFC tags > Why? There is still no upstream user for this Well, patch #2 updates drivers to the changed API, which is kinda an  "upstream user" if you squint... admittedly patch #1 is a

Re: [PATCH bpf-next 10/12] bpftool: add C output format option to btf dump subcommand

2019-05-23 Thread Jakub Kicinski
On Wed, 22 May 2019 21:43:43 -0700, Andrii Nakryiko wrote: > On Wed, May 22, 2019 at 6:23 PM Jakub Kicinski wrote: > > On Wed, 22 May 2019 17:58:23 -0700, Andrii Nakryiko wrote: > > > On Wed, May 22, 2019 at 5:25 PM Jakub Kicinski wrote: > > > > On Wed, 22 May 2019 12:50:51 -0700, Andrii Nakryi

Re: [PATCH bpf-next v2 2/3] libbpf: add bpf_object__load_xattr() API function to pass log_level

2019-05-23 Thread Yonghong Song
On 5/23/19 9:19 AM, Yonghong Song wrote: > > > On 5/23/19 3:54 AM, Quentin Monnet wrote: >> libbpf was recently made aware of the log_level attribute for programs, >> used to specify the level of information expected to be dumped by the >> verifier. >> >> Create an API function to pass addition

Re: [PATCH v3 net-next 0/3] flow_offload: Re-add per-action statistics

2019-05-23 Thread Jakub Kicinski
On Thu, 23 May 2019 17:21:49 +0100, Edward Cree wrote: > On 22/05/2019 23:20, Jakub Kicinski wrote: > > On Wed, 22 May 2019 22:37:16 +0100, Edward Cree wrote: > >> * removed RFC tags > > Why? There is still no upstream user for this > Well, patch #2 updates drivers to the changed API, which

Re: [PATCH net-next] cxgb4: use firmware API for validating filter spec

2019-05-23 Thread David Miller
From: Raju Rangoju Date: Thu, 23 May 2019 19:21:21 +0530 > Adds support for validating hardware filter spec configured in firmware > before offloading exact match flows. > > Use the new fw api FW_PARAM_DEV_FILTER_MODE_MASK to read the filter mode > and mask from firmware. If the api isn't suppor

Re: [PATCH net-next] Revert "dpaa2-eth: configure the cache stashing amount on a queue"

2019-05-23 Thread David Miller
From: Ioana Radulescu Date: Thu, 23 May 2019 17:38:22 +0300 > This reverts commit f8b995853444aba9c16c1ccdccdd397527fde96d. > > The reverted change instructed the QMan hardware block to fetch > RX frame annotation and beginning of frame data to cache before > the core would read them. > > It tu

Re: [PATCH bpf-next v2 3/3] tools: bpftool: make -d option print debug output from verifier

2019-05-23 Thread Yonghong Song
On 5/23/19 3:54 AM, Quentin Monnet wrote: > The "-d" option is used to require all logs available for bpftool. So > far it meant telling libbpf to print even debug-level information. But > there is another source of info that can be made more verbose: when we > attemt to load programs with bpftoo

Re: [PATCH net] cxgb4: offload VLAN flows regardless of VLAN ethtype

2019-05-23 Thread David Miller
From: Raju Rangoju Date: Thu, 23 May 2019 20:41:44 +0530 > VLAN flows never get offloaded unless ivlan_vld is set in filter spec. > It's not compulsory for vlan_ethtype to be set. > > So, always enable ivlan_vld bit for offloading VLAN flows regardless of > vlan_ethtype is set or not. > > Fixes

Re: [PATCH v3 net-next 0/3] flow_offload: Re-add per-action statistics

2019-05-23 Thread Edward Cree
On 23/05/2019 17:11, Jakub Kicinski wrote: > On Thu, 23 May 2019 09:19:49 -0400, Jamal Hadi Salim wrote: >> That would still work here, no? There will be some latency >> based on the frequency of hardware->kernel stats updates. > I don't think so, I think the stats are only updated on classifier >

[PATCH net-next] selftests/net: SO_TXTIME with ETF and FQ

2019-05-23 Thread Willem de Bruijn
The SO_TXTIME API enables packet tranmission with delayed delivery. This is currently supported by the ETF and FQ packet schedulers. Evaluate the interface with both schedulers. Install the scheduler and send a variety of packets streams: without delay, with one delayed packet, with multiple order

  1   2   3   >