Hi Andy,
On Thu, May 23, 2019 at 01:55:28AM +0000, Andy Duan wrote:
> Fix the clk mismatch in the error path "failed_reset" because
> below error path will disable clk_ahb and clk_ipg directly, it
> should use pm_runtime_put_noidle() instead of pm_runtime_put()
> to avoid to call runtime resume callback.
>
> Reported-by: Baruch Siach <bar...@tkos.co.il>
> Signed-off-by: Fugang Duan <fugang.d...@nxp.com>
Tested-by: Baruch Siach <bar...@tkos.co.il>
Tested on SolidRun Hummingboard Pulse.
Thanks.
But please avoid sending patched in base64 encoded emails. Plaintext is much
easier when dealing with 'git am'.
baruch
> ---
> drivers/net/ethernet/freescale/fec_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/freescale/fec_main.c
> b/drivers/net/ethernet/freescale/fec_main.c
> index f63eb2b..848defa 100644
> --- a/drivers/net/ethernet/freescale/fec_main.c
> +++ b/drivers/net/ethernet/freescale/fec_main.c
> @@ -3555,7 +3555,7 @@ fec_probe(struct platform_device *pdev)
> if (fep->reg_phy)
> regulator_disable(fep->reg_phy);
> failed_reset:
> - pm_runtime_put(&pdev->dev);
> + pm_runtime_put_noidle(&pdev->dev);
> pm_runtime_disable(&pdev->dev);
> failed_regulator:
> clk_disable_unprepare(fep->clk_ahb);
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- bar...@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
