On Thu, 23 May 2019 17:21:49 +0100, Edward Cree wrote: > On 22/05/2019 23:20, Jakub Kicinski wrote: > > On Wed, 22 May 2019 22:37:16 +0100, Edward Cree wrote: > >> * removed RFC tags > > Why? There is still no upstream user for this > Well, patch #2 updates drivers to the changed API, which is kinda an > "upstream user" if you squint... admittedly patch #1 is a bit dubious > in that regard;
Both 1 and 2 are dubious if you ask me. Complexity added for no upstream gain. 3 is a good patch, perhaps worth posting it separately rather than keeping it hostage to the rest of the series? :) Side note - it's not clear why open code the loop in every driver rather than having flow_stats_update() handle the looping?