On Thu, May 23, 2019 at 11:56:45AM +0200, Maxime Ripard wrote:
> The networking PHYs have a number of available device tree properties that
> can be used in their device tree node. Add a YAML schemas for those.
>
> Signed-off-by: Maxime Ripard <maxime.rip...@bootlin.com>
> ---
> Documentation/devicetree/bindings/net/ethernet-phy.yaml | 148 +++++++++-
> Documentation/devicetree/bindings/net/phy.txt | 80 +-----
> 2 files changed, 149 insertions(+), 79 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/net/ethernet-phy.yaml
>
> diff --git a/Documentation/devicetree/bindings/net/ethernet-phy.yaml
> b/Documentation/devicetree/bindings/net/ethernet-phy.yaml
> new file mode 100644
> index 000000000000..eb79ee6db977
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/ethernet-phy.yaml
> @@ -0,0 +1,148 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/ethernet-phy.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Ethernet PHY Generic Binding
> +
> +maintainers:
> + - David S. Miller <da...@davemloft.net>
> +
> +properties:
> + $nodename:
> + pattern: "^ethernet-phy(@[a-f0-9])?$"
> +
> + compatible:
> + oneOf:
I don't know the language. It is valid to have both
ethernet-phy-ieee802.3-c45 and
ethernet-phy-id[a-f0-9]{4}\\.[a-f0-9]{4}$". Does this oneOf prevent
multiple compatible strings?
Also, the general case is no compatible at all.
> + - const: ethernet-phy-ieee802.3-c22
> + description: PHYs that implement IEEE802.3 clause 22
> + - const: ethernet-phy-ieee802.3-c45
> + description: PHYs that implement IEEE802.3 clause 45
> + - pattern: "^ethernet-phy-id[a-f0-9]{4}\\.[a-f0-9]{4}$"
> + description:
> + The first group of digits is the 16 bit Phy Identifier 1
> + register, this is the chip vendor OUI bits 3:18. The
> + second group of digits is the Phy Identifier 2 register,
> + this is the chip vendor OUI bits 19:24, followed by 10
> + bits of a vendor specific ID.
Could we try to retain:
> - If the PHY reports an incorrect ID (or none at all) then the
> - "compatible" list may contain an entry with the correct PHY ID in the
...
Using it is generally wrong, and that is not clear in the new text.
> +
> + reg:
> + maxItems: 1
> + minimum: 0
> + maximum: 31
> + description:
> + The ID number for the PHY.
> +
> + interrupts:
> + maxItems: 1
> +
> + max-speed:
> + enum:
> + - 10
> + - 100
> + - 1000
This is outdated in the text description. Any valid speed is
supported, currently 10 - 200000, as listed in phy_setting settings().
Andrew
