> -Original Message-
> From: David Miller
> Sent: Tuesday, April 23, 2019 10:57 PM
> To: f...@strlen.de
> Cc: Vakul Garg ; netdev@vger.kernel.org
> Subject: Re: ipsec tunnel performance degrade
>
> From: Florian Westphal
> Date: Tue, 23 Apr 2019 18:25:21 +0200
>
> > Vakul Garg wrote
On Tue 23 Apr 2019 at 19:52, Saeed Mahameed wrote:
> On Tue, 2019-04-23 at 07:43 +, Vlad Buslov wrote:
>> On Mon 22 Apr 2019 at 23:34, Saeed Mahameed
>> wrote:
>> > On Mon, 2019-04-22 at 10:21 +0300, Vlad Buslov wrote:
>> > > Recent changes that introduced unlocked flower did not properly
>>
On Tue 23 Apr 2019 at 19:51, Jakub Kicinski
wrote:
> On Tue, 23 Apr 2019 07:34:20 +, Vlad Buslov wrote:
>> >> @@ -382,6 +395,8 @@ static void fl_hw_destroy_filter(struct tcf_proto
>> >> *tp, struct cls_fl_filter *f,
>> >>
>> >> tc_setup_cb_call(block, TC_SETUP_CLSFLOWER, &cls_flower, fa
Hi Arnd,
On Tue, Apr 23, 2019 at 05:11:32PM +0200, Arnd Bergmann wrote:
> When isdn4linux came up in the context of another patch series, I
> remembered that we had discussed removing it a while ago.
>
> It turns out that the suggestion from Karsten Keil wa to remove I4L
> in 2018 after the last
2019-04-23 16:22 UTC-0700 ~ Stanislav Fomichev
Right now there is no way to query whether BPF flow_dissector program
is attached to a network namespace or not. In previous commit, I added
support for querying that info, show it when doing `bpftool net`:
$ bpftool prog loadall ./bpf_flow.o \
On Wed, Apr 24, 2019 at 9:56 AM Simon Horman wrote:
>
> Hi Arnd,
>
> On Tue, Apr 23, 2019 at 05:11:32PM +0200, Arnd Bergmann wrote:
> > When isdn4linux came up in the context of another patch series, I
> > remembered that we had discussed removing it a while ago.
> >
> > It turns out that the sugg
Eric Dumazet wrote:
> After commit 5271953cad31 ("rxrpc: Use the UDP encap_rcv hook"),
> rxrpc_input_packet() is directly called from lockless UDP receive
> path, under rcu_read_lock() protection.
>
> It must therefore use RCU rules :
>
> - udp_sk->sk_user_data can be cleared at any point in th
>> +static u32 aq_hwmon_temp_config[] = {
>> +HWMON_T_INPUT | HWMON_T_LABEL,
>> +0,
>
> It would be nice to also have
>
> HWMON_T_MAX | HWMON_T_MIN |
> HWMON_T_CRIT | HWMON_T_LCRIT |
>
> which the PHY probably has.
>
> At gives some degree of context. A temperature on i
>>
>> +int (*get_temp)(struct aq_hw_s *self, int *temp);
>> +
>
> We talked about renaming this get_phy_temp so you could later add
> get_mac_temp?
Lost that comment, sorry. Will do rename.
Hello Jakub,
> The split into patches is slightly imperfect here.
>
> Patch 10 "introduces" a mutex, which nothing is using, yet.
>
> Patch 11 starts some async work, which the mutex is needed for.
>
> Patches 12 and 13 wrap other FW call sites...
>
> Isn't it better to squash 12 and 13 into 1
On Wed, Apr 24, 2019 at 4:37 AM David Miller wrote:
>
> From: Arnd Bergmann
> Date: Tue, 23 Apr 2019 17:11:32 +0200
>
> > When isdn4linux came up in the context of another patch series, I
> > remembered that we had discussed removing it a while ago.
>
> This seems long overdue to me.
>
> Could yo
Arnd Bergmann schreef op di 23-04-2019 om 17:11 [+0200]:
> When isdn4linux came up in the context of another patch series, I
> remembered that we had discussed removing it a while ago.
>
> It turns out that the suggestion from Karsten Keil wa to remove I4L
> in 2018 after the last public ISDN netw
Arnd Bergmann schreef op di 23-04-2019 om 17:11 [+0200]:
> --- a/drivers/isdn/gigaset/Kconfig
> +++ b/drivers/isdn/gigaset/Kconfig
> @@ -1,6 +1,7 @@
> menuconfig ISDN_DRV_GIGASET
> tristate "Siemens Gigaset support"
> depends on TTY
> + depends on ISDN_CAPI
> select CRC_CCITT
On 2019/4/24 上午12:41, Cong Wang wrote:
On Mon, Apr 22, 2019 at 11:42 PM Jason Wang wrote:
On 2019/4/23 下午2:00, Cong Wang wrote:
On Mon, Apr 22, 2019 at 2:41 AM Jason Wang wrote:
On 2019/4/22 上午11:57, YueHaibing wrote:
We get a KASAN report as below, but don't have any reproducer.
Any co
On Wed, Apr 24, 2019 at 10:14:55AM +0200, Arnd Bergmann wrote:
> On Wed, Apr 24, 2019 at 9:56 AM Simon Horman wrote:
> >
> > Hi Arnd,
> >
> > On Tue, Apr 23, 2019 at 05:11:32PM +0200, Arnd Bergmann wrote:
> > > When isdn4linux came up in the context of another patch series, I
> > > remembered that
Hello Arnd,
You wrote on Tue, Apr 23, 2019 at 05:11:43PM +0200:
> I tried to find any indication of whether the capi drivers are
> still in use, and have not found anything from a long time ago.
>
> With public ISDN networks almost completely shut down over the past 12
> months, there is very li
On Tue, Apr 23, 2019 at 09:43:26AM -0700, Eric Dumazet wrote:
> Canonical way to fetch sk_user_data from an encap_rcv() handler called
> from UDP stack in rcu protected section is to use
> rcu_dereference_sk_user_data(),
> otherwise compiler might read it multiple times.
>
That reminds me the mor
Hi Arnd,
>>> When isdn4linux came up in the context of another patch series, I
>>> remembered that we had discussed removing it a while ago.
>>
>> This seems long overdue to me.
>>
>> Could you please respin against net-next and I'll just apply this?
>
> Ok. I'll send a pull request then, which
On Tue, Apr 16, 2019 at 04:44:36PM +0200, Florian Westphal wrote:
> This series removes three indirections from xfrm_afinfo_policy by
> folding them into their callers.
>
> 1. Tos is a one-liner only needed by ipv4
> 2. init_path is also small and only needed by ipv6
> 3. decode_session has no dep
On Wed, Apr 17, 2019 at 11:45:13AM +0200, Florian Westphal wrote:
> None of them have any external callers, make them static.
>
> Signed-off-by: Florian Westphal
Also applied, thanks a lot!
I'm not sure this is a good idea to begin with, refcount
is right next to state spinlock which is taken for both tx and rx ops,
plus this complicates debugging quite a bit.
Also expect UAF or refcount bugs, especially xfrm_states that won't get free'd.
In case someone wants to experiment with thi
On Wed, Apr 24, 2019 at 2:58 AM Guillaume Nault wrote:
>
> On Tue, Apr 23, 2019 at 09:43:26AM -0700, Eric Dumazet wrote:
> > Canonical way to fetch sk_user_data from an encap_rcv() handler called
> > from UDP stack in rcu protected section is to use
> > rcu_dereference_sk_user_data(),
> > otherwi
On 04/24/2019 03:40 AM, Florian Westphal wrote:
> I'm not sure this is a good idea to begin with, refcount
> is right next to state spinlock which is taken for both tx and rx ops,
> plus this complicates debugging quite a bit.
>
Why not simply using include/linux/percpu-refcount.h ?
> Also e
On Wed, Apr 24, 2019 at 10:48 AM Paul Bolle wrote:
>
> Arnd Bergmann schreef op di 23-04-2019 om 17:11 [+0200]:
> > When isdn4linux came up in the context of another patch series, I
> > remembered that we had discussed removing it a while ago.
> >
> > It turns out that the suggestion from Karsten
On 2019/4/24 17:11, Jason Wang wrote:
>
> On 2019/4/24 上午12:41, Cong Wang wrote:
>> On Mon, Apr 22, 2019 at 11:42 PM Jason Wang wrote:
>>>
>>> On 2019/4/23 下午2:00, Cong Wang wrote:
On Mon, Apr 22, 2019 at 2:41 AM Jason Wang wrote:
> On 2019/4/22 上午11:57, YueHaibing wrote:
>> We get
On Wed, Apr 24, 2019 at 11:24 AM Thomas Jarosch
wrote:
> You wrote on Tue, Apr 23, 2019 at 05:11:43PM +0200:
> > I tried to find any indication of whether the capi drivers are
> > still in use, and have not found anything from a long time ago.
> >
> > With public ISDN networks almost completely s
On Wed, Apr 24, 2019 at 08:28:46AM +, Igor Russkikh wrote:
>
> >> +static u32 aq_hwmon_temp_config[] = {
> >> + HWMON_T_INPUT | HWMON_T_LABEL,
> >> + 0,
> >
> > It would be nice to also have
> >
> > HWMON_T_MAX | HWMON_T_MIN |
> > HWMON_T_CRIT | HWMON_T_LCRIT |
> >
> > whi
On Wed, Apr 24, 2019 at 10:53 AM Paul Bolle wrote:
>
> Arnd Bergmann schreef op di 23-04-2019 om 17:11 [+0200]:
> > --- a/drivers/isdn/gigaset/Kconfig
> > +++ b/drivers/isdn/gigaset/Kconfig
> > @@ -1,6 +1,7 @@
> > menuconfig ISDN_DRV_GIGASET
> > tristate "Siemens Gigaset support"
> >
This patch adds a limit on the number of skbs that fuzzers can queue
into loopback_queue. 1000 packets for rose loopback seems more than enough.
Then, since we now have multiple cpus in most linux hosts,
we also need to limit the number of skbs rose_loopback_timer()
can dequeue at each round.
ros
> Looks like one more spin with small fixups and this will be ready.
Yes. And i wanted to give Florian time to review the patches he
suggested changes to. I will wait a couple more days before
re-submitting.
Andrew
On Wed, Apr 24, 2019 at 12:24 PM Marcel Holtmann wrote:
> >>> When isdn4linux came up in the context of another patch series, I
> >>> remembered that we had discussed removing it a while ago.
>
> NAK.
>
> I do not care about isdn4linux, but this is a purely CAPI based driver. So
> removing (or mo
On Sun, Mar 31, 2019 at 07:44:46PM +0300, Leon Romanovsky wrote:
> From: Ariel Levkovich
>
> This patch adds support for allocating, deallocating and registering
> a new device memory type, STEERING_SW_ICM.
> This memory can be allocated and used by a privileged user for direct
> rule insertion a
On Sun, Mar 31, 2019 at 07:44:42PM +0300, Leon Romanovsky wrote:
> From: Leon Romanovsky
>
> >From Ariel,
>
> This series of patches adds user space managed steering infrastructure
> to the mlx5_ib driver.
>
> User space managed steering requires the means to access a dedicated
> memory space t
On Wed, Apr 24, 2019 at 10:04:40AM -0300, Jason Gunthorpe wrote:
> On Sun, Mar 31, 2019 at 07:44:46PM +0300, Leon Romanovsky wrote:
> > From: Ariel Levkovich
> >
> > This patch adds support for allocating, deallocating and registering
> > a new device memory type, STEERING_SW_ICM.
> > This memory
On Wed, Apr 24, 2019 at 04:12:22PM +0300, Leon Romanovsky wrote:
> On Wed, Apr 24, 2019 at 10:04:40AM -0300, Jason Gunthorpe wrote:
> > On Sun, Mar 31, 2019 at 07:44:46PM +0300, Leon Romanovsky wrote:
> > > From: Ariel Levkovich
> > >
> > > This patch adds support for allocating, deallocating and
Hi Arnd,
> Ok, interesting. My understanding was that mISDN CAPI support
> was done purely in user space, on top of the mISDN interface.
>
> I don't see any interfaction between the two in the kernel code,
> but if the capi module is required for mISDN, we clearly have to
> keep it. We could still
On Wed, Apr 24, 2019 at 10:14:05AM -0300, Jason Gunthorpe wrote:
> On Wed, Apr 24, 2019 at 04:12:22PM +0300, Leon Romanovsky wrote:
> > On Wed, Apr 24, 2019 at 10:04:40AM -0300, Jason Gunthorpe wrote:
> > > On Sun, Mar 31, 2019 at 07:44:46PM +0300, Leon Romanovsky wrote:
> > > > From: Ariel Levkovi
On Wed, Apr 24, 2019 at 04:25:16PM +0300, Leon Romanovsky wrote:
> On Wed, Apr 24, 2019 at 10:14:05AM -0300, Jason Gunthorpe wrote:
> > On Wed, Apr 24, 2019 at 04:12:22PM +0300, Leon Romanovsky wrote:
> > > On Wed, Apr 24, 2019 at 10:04:40AM -0300, Jason Gunthorpe wrote:
> > > > On Sun, Mar 31, 201
On Wed, Apr 24, 2019 at 10:35:53AM -0300, Jason Gunthorpe wrote:
> On Wed, Apr 24, 2019 at 04:25:16PM +0300, Leon Romanovsky wrote:
> > On Wed, Apr 24, 2019 at 10:14:05AM -0300, Jason Gunthorpe wrote:
> > > On Wed, Apr 24, 2019 at 04:12:22PM +0300, Leon Romanovsky wrote:
> > > > On Wed, Apr 24, 201
On Wed, Apr 24, 2019 at 04:46:04PM +0300, Leon Romanovsky wrote:
> On Wed, Apr 24, 2019 at 10:35:53AM -0300, Jason Gunthorpe wrote:
> > On Wed, Apr 24, 2019 at 04:25:16PM +0300, Leon Romanovsky wrote:
> > > On Wed, Apr 24, 2019 at 10:14:05AM -0300, Jason Gunthorpe wrote:
> > > > On Wed, Apr 24, 201
On 06/02/2019 02:20, Jamal Hadi Salim wrote:
> The classifiers dont mod the packets. The actions do. And they
> maintain stats on the size on "entry" i.e pre-edit.
> Each action keeps its own counters. If you did something like:
>
> tc match using flower blah \
> action vlan push tag ... \
> action
I think I'm just going to ask netdev for an opinion on this. It could
be that we're just reading the code wrong...
I'm getting a lot of Smatch warning about buffer underflows. The
problem is that Smatch marks everything from nla_data() as unknown and
untrusted user data. In do_setvfinfo() we ge
On Wed, Apr 24, 2019 at 03:05:05PM +0100, Edward Cree wrote:
> On 06/02/2019 02:20, Jamal Hadi Salim wrote:
> > The classifiers dont mod the packets. The actions do. And they
> > maintain stats on the size on "entry" i.e pre-edit.
> > Each action keeps its own counters. If you did something like:
>
On Wed, Apr 24, 2019 at 05:08:20PM +0300, Dan Carpenter wrote:
> I think I'm just going to ask netdev for an opinion on this. It could
> be that we're just reading the code wrong...
I don't think you are reading it wrong.
Allowing the compiler to implicitly cast a user controlled u32 to an
int i
Hi Arnd,
> When isdn4linux came up in the context of another patch series, I
> remembered that we had discussed removing it a while ago.
>>
>> NAK.
>>
>> I do not care about isdn4linux, but this is a purely CAPI based driver. So
>> removing (or moving to staging)
>> CAPI support seems r
On Fri, Apr 19, 2019 at 7:23 AM Sudarsana Reddy Kalluru
wrote:
>
> Hi Ian,
> Thanks for your info. Mfw team already analyzed the "nig timer" related
> logs but can't infer anything. From the boot-code version, the device look to
> be from the older generation of Broadcom nics. Besides the
>
From: Sven Eckelmann
[ Upstream commit f131a56880d10932931e74773fb8702894a94a75 ]
The batadv_hash_remove is a function which searches the hashtable for an
entry using a needle, a hashtable bucket selection function and a compare
function. It will lock the bucket list and delete an entry when the
Письмо содержит вирус!
Heuristics.Phishing.Email.SpoofedDomain FOUND
<>
From: Aaro Koskinen
[ Upstream commit 057a0c5642a2ff2db7c421cdcde34294a23bf37b ]
This is log is harmful as it can trigger multiple times per packet. Delete
it.
Signed-off-by: Aaro Koskinen
Signed-off-by: David S. Miller
Signed-off-by: Sasha Levin
---
drivers/net/ethernet/stmicro/stmmac/norm
Hi Eric,
I'm seeing issues with this patch as well, not as regular as for
Richard but still (about up to one in 30-50 TCP sessions).
In my case I have a virtual machine (on VMWare) with this patch where
NGINX as reverse proxy misses part (end) of payload from its upstream
and times out on the ups
On 24/04/2019 15:11, Pablo Neira Ayuso wrote:
> On Wed, Apr 24, 2019 at 03:05:05PM +0100, Edward Cree wrote:
>> So, I had this working for a while, by calling tcf_action_stats_update()
>> directly on the correct element of tc->exts->actions[], instead of using
>> tcf_exts_stats_update(). And thi
Before calling __ip_options_compile(), we need to ensure the network
header is a an IPv4 one, and that it is already pulled in skb->head.
RAW sockets going through a tunnel can end up calling ipv4_link_failure()
with total garbage in the skb, or arbitrary lengthes.
syzbot report :
BUG: KASAN: st
On Wed, Apr 24, 2019 at 11:05 AM Eric Dumazet wrote:
>
> Before calling __ip_options_compile(), we need to ensure the network
> header is a an IPv4 one, and that it is already pulled in skb->head.
>
> RAW sockets going through a tunnel can end up calling ipv4_link_failure()
> with total garbage in
On 04/24, Quentin Monnet wrote:
> 2019-04-23 16:22 UTC-0700 ~ Stanislav Fomichev
> > Right now there is no way to query whether BPF flow_dissector program
> > is attached to a network namespace or not. In previous commit, I added
> > support for querying that info, show it when doing `bpftool net`
On Wed, Apr 24, 2019 at 7:51 AM Bruno Prémont wrote:
>
> Hi Eric,
>
> I'm seeing issues with this patch as well, not as regular as for
> Richard but still (about up to one in 30-50 TCP sessions).
>
> In my case I have a virtual machine (on VMWare) with this patch where
> NGINX as reverse proxy mis
On Wed, Apr 24, 2019 at 10:47:03AM -0300, Jason Gunthorpe wrote:
> On Wed, Apr 24, 2019 at 04:46:04PM +0300, Leon Romanovsky wrote:
> > On Wed, Apr 24, 2019 at 10:35:53AM -0300, Jason Gunthorpe wrote:
> > > On Wed, Apr 24, 2019 at 04:25:16PM +0300, Leon Romanovsky wrote:
> > > > On Wed, Apr 24, 201
On Wed, Apr 24, 2019 at 06:49:37PM +0300, Leon Romanovsky wrote:
> On Wed, Apr 24, 2019 at 10:47:03AM -0300, Jason Gunthorpe wrote:
> > On Wed, Apr 24, 2019 at 04:46:04PM +0300, Leon Romanovsky wrote:
> > > On Wed, Apr 24, 2019 at 10:35:53AM -0300, Jason Gunthorpe wrote:
> > > > On Wed, Apr 24, 201
target_fd is target namespace. If there is a flow dissector BPF program
attached to that namespace, its (single) id is returned.
v2:
* don't sleep in rcu critical section (Jakub Kicinski)
* check input prog_cnt (exit early)
Signed-off-by: Stanislav Fomichev
---
include/linux/skbuff.h| 8 ++
Right now there is no way to query whether BPF flow_dissector program
is attached to a network namespace or not. In previous commit, I added
support for querying that info, show it when doing `bpftool net`:
$ bpftool prog loadall ./bpf_flow.o \
/sys/fs/bpf/flow type flow_dissector \
On Wed, Apr 24, 2019 at 12:53:13PM -0300, Jason Gunthorpe wrote:
> On Wed, Apr 24, 2019 at 06:49:37PM +0300, Leon Romanovsky wrote:
> > On Wed, Apr 24, 2019 at 10:47:03AM -0300, Jason Gunthorpe wrote:
> > > On Wed, Apr 24, 2019 at 04:46:04PM +0300, Leon Romanovsky wrote:
> > > > On Wed, Apr 24, 201
In preparation to enabling -Wimplicit-fallthrough, mark switch
cases where we are expecting to fall through.
This patch fixes the following warning:
drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c: In function
‘fwevtq_handler’:
drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c:520:7: warni
sch_plug can be used to perform functional qdisc unit tests
controlling explicitly the queuing behaviour from user-space.
Plug support lacks since its introduction in 2012. This change
introduces basic support, to control the tc status.
Signed-off-by: Paolo Abeni
---
tc/Makefile | 1 +
tc/q_pl
Hi Jiong,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on bpf-next/master]
url:
https://github.com/0day-ci/linux/commits/Jiong-Wang/bpf-eliminate-zero-extensions-for-sub-register-writes/20190416-191711
base: https://git.kernel.org/pub/scm/linux/kernel/git
On Wed, Apr 24, 2019 at 07:27:36PM +0300, Leon Romanovsky wrote:
> On Wed, Apr 24, 2019 at 12:53:13PM -0300, Jason Gunthorpe wrote:
> > On Wed, Apr 24, 2019 at 06:49:37PM +0300, Leon Romanovsky wrote:
> > > On Wed, Apr 24, 2019 at 10:47:03AM -0300, Jason Gunthorpe wrote:
> > > > On Wed, Apr 24, 201
On 04/24/2019 01:27 AM, David Howells wrote:
>
> Acked-by: David Howells
>
A v4 is coming, since @local could be NULL in rxrpc_lookup_local()
as reported by kbuild test robot and Julia Lawall
diff --git a/net/rxrpc/local_object.c b/net/rxrpc/local_object.c
index
15cf42d5b53a56d8d19cab
On Wed, 2019-04-24 at 10:07 -0300, Jason Gunthorpe wrote:
> On Sun, Mar 31, 2019 at 07:44:42PM +0300, Leon Romanovsky wrote:
> > From: Leon Romanovsky
> >
> > > From Ariel,
> >
> > This series of patches adds user space managed steering
> > infrastructure
> > to the mlx5_ib driver.
> >
> > User
After commit 5271953cad31 ("rxrpc: Use the UDP encap_rcv hook"),
rxrpc_input_packet() is directly called from lockless UDP receive
path, under rcu_read_lock() protection.
It must therefore use RCU rules :
- udp_sk->sk_user_data can be cleared at any point in this function.
rcu_dereference_sk_us
On 4/23/2019 11:56 PM, Zhu Yanjun wrote:
Before the commit 490ea5967b0d ("RDS: IB: move FMR code to its own file"),
when the dirty_count is greater than 9/10 of max_items of 8K pool,
1M pool is used, Vice versa. After the commit 490ea5967b0d ("RDS: IB: move
FMR code to its own file"), the above i
On 4/23/19 10:22 PM, andrii.nakry...@gmail.com wrote:
> From: Andrii Nakryiko
>
> Document usage and sample output format for `btf dump` sub-command.
When applying the patch, I see a few trailing spaces.
===
p2.txt:113: trailing whitespace.
p2.txt:118: trailing whitespace.
p2.txt:120: trail
On Wed, Apr 24, 2019 at 11:13:42AM -0600, David Ahern wrote:
> seeing an RCU warning testing xdp with virtio net. net-next as of commit
> b2f97f7de2f6a4df8e431330cf467576486651c5. No obvious changes so hoping
> this rings a bell with someone else.
>
>
> [ 121.990304]
On 4/24/19 11:37 AM, Michael S. Tsirkin wrote:
> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> index 9010938e2d71..ccc1bdd1bb1f 100644
> --- a/drivers/net/virtio_net.c
> +++ b/drivers/net/virtio_net.c
> @@ -495,8 +495,8 @@ static struct send_queue *virtnet_xdp_sq(struct
> virt
From: David Ahern
fib6_result is not initialized in bpf_ipv6_fib_lookup and potentially
passses garbage to the fib lookup which triggers a KASAN warning:
[ 262.055450]
==
[ 262.057640] BUG: KASAN: user-memory-access in fib6_rule_
On 4/23/19 10:21 PM, andrii.nakry...@gmail.com wrote:
> From: Andrii Nakryiko
>
> Add new `btf dump` sub-command to bpftool. It allows to dump
> human-readable low-level BTF types representation of BTF types. BTF can
> be retrieved from few different sources:
>- from BTF object by ID;
>
On Tue, Apr 23, 2019 01:47AM, Daniel Borkmann wrote:
> On 04/22/2019 08:34 PM, Paul Chaignon wrote:
> > In case of a null check on a pointer inside a subprog, we should mark all
> > registers with this pointer as either safe or unknown, in both the current
> > and previous frames. Currently, only
seeing an RCU warning testing xdp with virtio net. net-next as of commit
b2f97f7de2f6a4df8e431330cf467576486651c5. No obvious changes so hoping
this rings a bell with someone else.
[ 121.990304] =
[ 121.991488] WARNING: suspicious RCU usage
[ 121.992392] 5.1.0-rc5+
On 4/23/19 10:21 PM, andrii.nakry...@gmail.com wrote:
> From: Andrii Nakryiko
>
> Add new `btf dump` sub-command to bpftool. It allows to dump
> human-readable low-level BTF types representation of BTF types. BTF can
> be retrieved from few different sources:
>- from BTF object by ID;
>
Adding device entries found in vendor modified versions of this
driver. Function maps for some of the devices follow:
WNC D16Q1, D16Q5, D18Q1 LTE CAT3 module (1435:0918)
MI_00 Qualcomm HS-USB Diagnostics
MI_01 Android Debug interface
MI_02 Qualcomm HS-USB Modem
MI_03 Qualcomm Wireless HS-USB Eth
On Wed, Apr 24, 2019 at 10:12 AM Yonghong Song wrote:
>
>
>
> On 4/23/19 10:21 PM, andrii.nakry...@gmail.com wrote:
> > From: Andrii Nakryiko
> >
> > Add new `btf dump` sub-command to bpftool. It allows to dump
> > human-readable low-level BTF types representation of BTF types. BTF can
> > be ret
On Wed, Apr 24, 2019 at 10:17 AM Yonghong Song wrote:
>
>
>
> On 4/23/19 10:21 PM, andrii.nakry...@gmail.com wrote:
> > From: Andrii Nakryiko
> >
> > Add new `btf dump` sub-command to bpftool. It allows to dump
> > human-readable low-level BTF types representation of BTF types. BTF can
> > be ret
On Wed, Apr 24, 2019 at 04:33:47AM -0700, Eric Dumazet wrote:
> On Wed, Apr 24, 2019 at 2:58 AM Guillaume Nault wrote:
> >
> > On Tue, Apr 23, 2019 at 09:43:26AM -0700, Eric Dumazet wrote:
> > > Canonical way to fetch sk_user_data from an encap_rcv() handler called
> > > from UDP stack in rcu prot
On Wed, Apr 24, 2019 at 11:21 AM Guillaume Nault wrote:
> It seems that callers of rcu_assign_sk_user_data() can indeed sleep.
>
> But I think we have more problems. Not all code paths treat
> ->sk_user_data as RCU pointers (IIUC that's why we created the
> __sk_user_data() macro, instead of just
On 4/24/19 11:16 AM, Andrii Nakryiko wrote:
> On Wed, Apr 24, 2019 at 10:17 AM Yonghong Song wrote:
>>
>>
>>
>> On 4/23/19 10:21 PM, andrii.nakry...@gmail.com wrote:
>>> From: Andrii Nakryiko
>>>
>>> Add new `btf dump` sub-command to bpftool. It allows to dump
>>> human-readable low-level BTF t
On Wed, 2019-04-24 at 09:53 +0300, Vlad Buslov wrote:
> Recent changes that introduced unlocked flower did not properly
> account for
> case when reoffload is initiated concurrently with filter updates. To
> fix
> the issue, extend flower with 'hw_filters' list that is used to store
> filters that
From: Eric Dumazet
Date: Tue, 23 Apr 2019 09:24:46 -0700
> First thing tipc_udp_recv() does is to use rcu_dereference_sk_user_data(),
> and this is really hinting we already own rcu_read_lock() from the caller
> (UDP stack).
>
> No need to add another rcu_read_lock()/rcu_read_unlock() pair.
>
>
Hi Stanislav,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on bpf-next/master]
url:
https://github.com/0day-ci/linux/commits/Stanislav-Fomichev/bpf-support-BPF_PROG_QUERY-for-BPF_FLOW_DISSECTOR-attach_type/20190424-235216
base: https://git.kernel.org/pub/scm
From: Rosen Penev
Date: Tue, 23 Apr 2019 13:46:03 -0700
> It allows some of the code to be simplified.
>
> Tested on Turris Omnia.
>
> Signed-off-by: Rosen Penev
This is just a cleanup/simplification, so applied to net-next.
Please properly annotate your Subject lines in the future to indica
Right now there is no way to query whether BPF flow_dissector program
is attached to a network namespace or not. In previous commit, I added
support for querying that info, show it when doing `bpftool net`:
$ bpftool prog loadall ./bpf_flow.o \
/sys/fs/bpf/flow type flow_dissector \
target_fd is target namespace. If there is a flow dissector BPF program
attached to that namespace, its (single) id is returned.
v3:
* add missing inline to skb_flow_dissector_prog_query static def
(kbuild test robot )
v2:
* don't sleep in rcu critical section (Jakub Kicinski)
* check input pro
From: Vlad Buslov
Date: Wed, 24 Apr 2019 09:53:31 +0300
> Recent changes that introduced unlocked flower did not properly account for
> case when reoffload is initiated concurrently with filter updates. To fix
> the issue, extend flower with 'hw_filters' list that is used to store
> filters that
On Wed, Apr 24, 2019 at 10:21 AM Yonghong Song wrote:
>
>
>
> On 4/23/19 10:22 PM, andrii.nakry...@gmail.com wrote:
> > From: Andrii Nakryiko
> >
> > Document usage and sample output format for `btf dump` sub-command.
>
> When applying the patch, I see a few trailing spaces.
>
> ===
> p2.txt:113:
2019-04-24 11:52 UTC-0700 ~ Stanislav Fomichev
Right now there is no way to query whether BPF flow_dissector program
is attached to a network namespace or not. In previous commit, I added
support for querying that info, show it when doing `bpftool net`:
$ bpftool prog loadall ./bpf_flow.o \
On Wed, Apr 24, 2019 at 04:40:54PM +, Saeed Mahameed wrote:
> On Wed, 2019-04-24 at 10:07 -0300, Jason Gunthorpe wrote:
> > On Sun, Mar 31, 2019 at 07:44:42PM +0300, Leon Romanovsky wrote:
> > > From: Leon Romanovsky
> > >
> > > > From Ariel,
> > >
> > > This series of patches adds user spac
On Wed, Apr 24, 2019 at 11:29:25AM -0700, Eric Dumazet wrote:
> On Wed, Apr 24, 2019 at 11:21 AM Guillaume Nault wrote:
>
> >
> > And then, we'd need to make sure that ->sk_user_data is in sync with
> > the encap_rcv() callback (or whatever actually uses the data pointed
> > to). Otherwise a modu
From: Willem de Bruijn
Packet sockets in datagram mode take a link layer destination address
in sockaddr_ll.sll_addr. For some device types, address length exceeds
this field size, extending beyond the struct.
This addr argument is then passed to dev_hard_header without length
and assumed to be
From: Zhu Yanjun
Date: Wed, 24 Apr 2019 02:56:42 -0400
> Before the commit 490ea5967b0d ("RDS: IB: move FMR code to its own file"),
> when the dirty_count is greater than 9/10 of max_items of 8K pool,
> 1M pool is used, Vice versa. After the commit 490ea5967b0d ("RDS: IB: move
> FMR code to its o
This adds BPF_PROG_TYPE_RAW_TRACEPOINT_WRITABLE, and fixes up the
error: enumeration value ‘BPF_PROG_TYPE_RAW_TRACEPOINT_WRITABLE’ not
handled in switch [-Werror=switch-enum]
build errors it would otherwise cause in libbpf.
Signed-off-by: Matt Mullins
---
tools/include/uapi/linux/bpf.
On Tue, Apr 23, 2019 at 2:21 PM Willem de Bruijn
wrote:
>
> On Tue, Apr 23, 2019 at 1:21 PM Willem de Bruijn
> wrote:
> >
> > On Tue, Apr 23, 2019 at 1:04 PM Willem de Bruijn
> > wrote:
> > >
> > > On Tue, Apr 23, 2019 at 11:52 AM David Laight
> > > wrote:
> > > >
> > > > From: Willem de Bruij
It is possible (via shutdown()) for TCP socks to go through TCP_CLOSE
state via tcp_disconnect() without calling into close callback. This
would allow a kTLS enabled socket to exist outside of ESTABLISHED
state which is not supported.
Solve this the same way we solved the sock{map|hash} case by ad
In tcp bpf remove we free the cork list and purge the ingress msg
list. However we do this before the ref count reaches zero so it
could be possible some other access is in progress. In this case
(tcp close and/or tcp_unhash) we happen to also hold the sock
lock so no path exists but lets fix it ot
Series of fixes for sockmap and ktls, see patches for descriptions.
---
John Fastabend (3):
bpf: tls, implement unhash to avoid transition out of ESTABLISHED
bpf: sockmap remove duplicate queue free
bpf: sockmap fix msg->sg.size account on ingress skb
include/net/tls.h | 1
1 - 100 of 160 matches
Mail list logo
