Hi Stanislav,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on bpf-next/master]

url:    
https://github.com/0day-ci/linux/commits/Stanislav-Fomichev/bpf-support-BPF_PROG_QUERY-for-BPF_FLOW_DISSECTOR-attach_type/20190424-235216
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
config: sparc64-allnoconfig (attached as .config)
compiler: sparc64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget 
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O 
~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.2.0 make.cross ARCH=sparc64 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <l...@intel.com>
All errors (new ones prefixed by >>):

   In file included from include/net/net_namespace.h:37:0,
                    from include/linux/inet.h:46,
                    from include/linux/sunrpc/msg_prot.h:204,
                    from include/linux/sunrpc/auth.h:16,
                    from include/linux/nfs_fs.h:31,
                    from arch/sparc//kernel/sys_sparc32.c:25:
>> include/linux/skbuff.h:1268:12: error: 'skb_flow_dissector_prog_query' 
>> defined but not used [-Werror=unused-function]
    static int skb_flow_dissector_prog_query(const union bpf_attr *attr,
               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   cc1: all warnings being treated as errors

vim +/skb_flow_dissector_prog_query +1268 include/linux/skbuff.h

  1255  
  1256  void skb_flow_dissector_init(struct flow_dissector *flow_dissector,
  1257                               const struct flow_dissector_key *key,
  1258                               unsigned int key_count);
  1259  
  1260  #ifdef CONFIG_NET
  1261  int skb_flow_dissector_prog_query(const union bpf_attr *attr,
  1262                                    union bpf_attr __user *uattr);
  1263  int skb_flow_dissector_bpf_prog_attach(const union bpf_attr *attr,
  1264                                         struct bpf_prog *prog);
  1265  
  1266  int skb_flow_dissector_bpf_prog_detach(const union bpf_attr *attr);
  1267  #else
> 1268  static int skb_flow_dissector_prog_query(const union bpf_attr *attr,
  1269                                           union bpf_attr __user *uattr)
  1270  {
  1271          return -EOPNOTSUPP;
  1272  }
  1273  

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip

Reply via email to