>> +static u32 aq_hwmon_temp_config[] = {
>> +    HWMON_T_INPUT | HWMON_T_LABEL,
>> +    0,
> 
> It would be nice to also have
> 
>         HWMON_T_MAX | HWMON_T_MIN |
>         HWMON_T_CRIT | HWMON_T_LCRIT |
> 
> which the PHY probably has.
> 
> At gives some degree of context. A temperature on its own of say 65C
> is hard to interpret. Is it too hot?  But if we have a critical of 85C
> and a max of 95C we know we are O.K.

I can give here only suggested constants, since we don't have now any interface
on reading/configuring these.

Do you think that will be ok?

Regards,
  Igor

Reply via email to