Re: [PATCH net] ipv6: make ip6_create_rt_rcu return ip6_null_entry instead of NULL

2019-03-19 Thread Paolo Abeni
Hi, On Mon, 2019-03-18 at 14:30 -0700, Wei Wang wrote: > On Mon, Mar 18, 2019 at 12:48 PM David Ahern wrote: > > On 3/18/19 12:36 PM, Xin Long wrote: > > > diff --git a/net/ipv6/route.c b/net/ipv6/route.c > > > index 4ef4bbd..754777d 100644 > > > --- a/net/ipv6/route.c > > > +++ b/net/ipv6/route.

bpf-next is OPEN

2019-03-19 Thread Daniel Borkmann
Merge window is closed, so new round begins. Thanks everyone, Daniel

[PATCH mlx5-next 3/4] net/mlx5: Decrease default mr cache size

2019-03-19 Thread Leon Romanovsky
From: Artemy Kovalyov Delete initialization of high order entries in mr cache to decrease initial memory footprint. When required, the administrator can populate the entries with memory keys via the /sys interface. Signed-off-by: Artemy Kovalyov Signed-off-by: Moni Shoua Signed-off-by: Leon Ro

[PATCH rdma-next 0/4] Small set of mlx5 related fixes

2019-03-19 Thread Leon Romanovsky
From: Leon Romanovsky Hi, Despite one change in mlx5_core, all those changes are for mlx5_ib. The change in mlx5_core is related to MR cache initialization that is not used in mlx5_core at all. Thanks Artemy Kovalyov (3): IB/mlx5: WQE dump jumps over first 16 bytes net/mlx5: Decrease defau

[PATCH rdma-next 4/4] IB/mlx5: Compare only index part of a memory window rkey

2019-03-19 Thread Leon Romanovsky
From: Artemy Kovalyov The InfiniBand Architecture Specification section 10.6.7.2.4 TYPE 2 MEMORY WINDOWS says that if the CI supports the Base Memory Management Extensions defined in this specification, the R_Key format for a Type 2 Memory Window must consist of: * 24 bit index in the most signif

[PATCH rdma-next 1/4] IB/mlx5: Reset access mask when looping inside page fault handler

2019-03-19 Thread Leon Romanovsky
From: Moni Shoua If page-fault handler spans multiple MRs then the access mask needs to be reset before each MR handling or otherwise write access will be granted to mapped pages instead of read-only. Cc: # 3.19 Fixes: 7bdf65d411c1 ("IB/mlx5: Handle page faults") Reported-by: Jerome Glisse Sig

[PATCH rdma-next 2/4] IB/mlx5: WQE dump jumps over first 16 bytes

2019-03-19 Thread Leon Romanovsky
From: Artemy Kovalyov Move index increment after its is used or otherwise it will start the dump of the WQE from second WQE BB. Fixes: 34f4c9554d8b ("IB/mlx5: Use fragmented QP's buffer for in-kernel users") Signed-off-by: Artemy Kovalyov Signed-off-by: Moni Shoua Signed-off-by: Leon Romanovsk

waiting your response

2019-03-19 Thread Mr Li-chien Weng
Hi I have an amazing recommendation for you, mercifully recognize receipt of this email by sending me an email with your own email address; wangtao...@163.com further details will be given of this worthwhile business proposition. Respects. Mr Li-chien Weng

Re: [PATCH v2 01/13] enc28j60: Use device_get_mac_address()

2019-03-19 Thread Andy Shevchenko
On Mon, Mar 18, 2019 at 10:23:21PM -0700, David Miller wrote: > > Especially for a patch series this big, you must provide an > appropriate cover posting explaining at a high level what this series > is doing, how it is doing it, and why it is doing it that way. Should I resend with cover letter

Re: [RFC PATCH net-next 1/3] net: rtnetlink: Add link-down reason to RTNL messages

2019-03-19 Thread Petr Machata
Stephen Hemminger writes: > On Mon, 18 Mar 2019 15:02:53 +0100 > Andrew Lunn wrote: > >> On Mon, Mar 18, 2019 at 01:15:41PM +, Petr Machata wrote: >> > >> > Andrew Lunn writes: >> > >> > >> +enum rtnl_link_down_reason_major { >> > >> + RTNL_LDR_OTHER, >> > > >> > > Does 'other' make

[PATCH v2 2/8] bpf: allow helpers to return PTR_TO_SOCK_COMMON

2019-03-19 Thread Lorenz Bauer
It's currently not possible to access timewait or request sockets from eBPF, since there is no way to return a PTR_TO_SOCK_COMMON from a helper. Introduce RET_PTR_TO_SOCK_COMMON to enable this behaviour. Signed-off-by: Lorenz Bauer --- include/linux/bpf.h | 1 + kernel/bpf/verifier.c | 4

[PATCH v2 1/8] bpf: track references based on is_acquire_func

2019-03-19 Thread Lorenz Bauer
So far, the verifier only acquires reference tracking state for RET_PTR_TO_SOCKET_OR_NULL. Instead of extending this for every new return type which desires these semantics, acquire reference tracking state iff the called helper is an acquire function. Signed-off-by: Lorenz Bauer --- kernel/bpf/

[PATCH v2 4/8] bpf: add helper to check for a valid SYN cookie

2019-03-19 Thread Lorenz Bauer
Using bpf_skc_lookup_tcp it's possible to ascertain whether a packet belongs to a known connection. However, there is one corner case: no sockets are created if SYN cookies are active. This means that the final ACK in the 3WHS is misclassified. Using the helper, we can look up the listening socket

[PATCH v2 0/8] Allow checking SYN cookies from XDP and tc cls act

2019-03-19 Thread Lorenz Bauer
This series adds the necessary helpers to determine wheter a given (encapsulated) TCP packet belongs to a connection known to the network stack. * bpf_skc_lookup_tcp gives access to request and timewait sockets * bpf_tcp_check_syncookie identifies the final 3WHS ACK when syncookies are enabled

[PATCH v2 8/8] selftests/bpf: add tests for bpf_tcp_check_syncookie and bpf_skc_lookup_tcp

2019-03-19 Thread Lorenz Bauer
Add tests which verify that the new helpers work for both IPv4 and IPv6, by forcing SYN cookies to always on. Use a new network namespace to avoid clobbering the global SYN cookie settings. Signed-off-by: Lorenz Bauer --- tools/testing/selftests/bpf/.gitignore| 1 + tools/testing/selft

[PATCH v2 5/8] tools: update include/uapi/linux/bpf.h

2019-03-19 Thread Lorenz Bauer
Pull definitions for bpf_skc_lookup_tcp and bpf_sk_check_syncookie. Signed-off-by: Lorenz Bauer --- tools/include/uapi/linux/bpf.h | 36 +- 1 file changed, 35 insertions(+), 1 deletion(-) diff --git a/tools/include/uapi/linux/bpf.h b/tools/include/uapi/linux/bpf.

[PATCH v2 7/8] selftests/bpf: test references to sock_common

2019-03-19 Thread Lorenz Bauer
Make sure that returning a struct sock_common * reference invokes the reference tracking machinery in the verifier. Signed-off-by: Lorenz Bauer --- .../selftests/bpf/verifier/ref_tracking.c | 48 +++ 1 file changed, 48 insertions(+) diff --git a/tools/testing/selftests/bpf/v

[PATCH v2 3/8] bpf: add skc_lookup_tcp helper

2019-03-19 Thread Lorenz Bauer
Allow looking up a sock_common. This gives eBPF programs access to timewait and request sockets. Signed-off-by: Lorenz Bauer --- include/uapi/linux/bpf.h | 20 ++- kernel/bpf/verifier.c| 3 +- net/core/filter.c| 113 +++ 3 files changed, 124

[PATCH v2 6/8] selftests/bpf: allow specifying helper for BPF_SK_LOOKUP

2019-03-19 Thread Lorenz Bauer
Make the BPF_SK_LOOKUP macro take a helper function, to ease writing tests for new helpers. Signed-off-by: Lorenz Bauer --- tools/testing/selftests/bpf/test_verifier.c | 6 +- .../selftests/bpf/verifier/ref_tracking.c | 78 +-- tools/testing/selftests/bpf/verifier/unpriv.c

Re: [PATCHv2 net] sctp: get sctphdr by offset in sctp_compute_cksum

2019-03-19 Thread Neil Horman
On Mon, Mar 18, 2019 at 07:47:00PM +0800, Xin Long wrote: > sctp_hdr(skb) only works when skb->transport_header is set properly. > > But in Netfilter, skb->transport_header for ipv6 is not guaranteed > to be right value for sctphdr. It would cause to fail to check the > checksum for sctp packets.

Re: [PATCH net] sctp: not copy sctp_sock pd_lobby in sctp_copy_descendant

2019-03-19 Thread Neil Horman
On Mon, Mar 18, 2019 at 07:58:29PM +0800, Xin Long wrote: > Now sctp_copy_descendant() copies pd_lobby from old sctp scok to new > sctp sock. If sctp_sock_migrate() returns error, it will panic when > releasing new sock and trying to purge pd_lobby due to the incorrect > pointers in pd_lobby. > >

Re: [RFC PATCH net-next 1/3] net: rtnetlink: Add link-down reason to RTNL messages

2019-03-19 Thread Michal Kubecek
On Tue, Mar 19, 2019 at 10:18:00AM +, Petr Machata wrote: > Stephen Hemminger writes: > > Gut feel is that enumerated values are going to grow and grow and be > > long term API headache. > > > > Would it be possible to use a string like the external ack error > > message? > > It would, but th

[PATCH net] tcp: do not use ipv6 header for ipv4 flow

2019-03-19 Thread Eric Dumazet
When a dual stack tcp listener accepts an ipv4 flow, it should not attempt to use an ipv6 header or tcp_v6_iif() helper. Fixes: 1397ed35f22d ("ipv6: add flowinfo for tcp6 pkt_options for all cases") Fixes: df3687ffc665 ("ipv6: add the IPV6_FL_F_REFLECT flag to IPV6_FL_A_GET") Fixes: 1da177e4c3f4 (

[PATCH net-next] ipv6: Add icmp_echo_ignore_multicast support for ICMPv6

2019-03-19 Thread Stephen Suryaputra
IPv4 has icmp_echo_ignore_broadcast to prevent responding to broadcast pings. IPv6 needs a similar mechanism. Signed-off-by: Stephen Suryaputra --- Documentation/networking/ip-sysctl.txt | 5 + include/net/netns/ipv6.h | 1 + include/uapi/linux/sysctl.h| 3 ++- n

[PATCH net] dccp: do not use ipv6 header for ipv4 flow

2019-03-19 Thread Eric Dumazet
When a dual stack dccp listener accepts an ipv4 flow, it should not attempt to use an ipv6 header or inet6_iif() helper. Fixes: 3df80d9320bc ("[DCCP]: Introduce DCCPv6") Signed-off-by: Eric Dumazet --- net/dccp/ipv6.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/dc

Re: [PATCH net-next] ipv6: Add icmp_echo_ignore_multicast support for ICMPv6

2019-03-19 Thread Eric Dumazet
On 03/19/2019 05:45 AM, Stephen Suryaputra wrote: > IPv4 has icmp_echo_ignore_broadcast to prevent responding to broadcast pings. > IPv6 needs a similar mechanism. > ... > diff --git a/include/uapi/linux/sysctl.h b/include/uapi/linux/sysctl.h > index 87aa2a6d9125..bd83ddedc014 100644 > --- a

[PATCH net-next 0/2] net: refactor ndo_select_queue()

2019-03-19 Thread Paolo Abeni
Currently, on most devices implementing ndo_select_queue(), we get 2 indirect calls per xmit packet, at least in some scenarios. We can avoid one of such indirect calls refactoring the ndo_select_queue() usage so that we don't need anymore the 'fallback' argument. The first patch changes the af p

[PATCH net-next 1/2] packet: rework packet_pick_tx_queue() to use common code selection

2019-03-19 Thread Paolo Abeni
Currently packet_pick_tx_queue() is the only caller of ndo_select_queue() using a fallback argument other than __netdev_pick_tx. Leveraging rx queue, we can obtain a similar queue selection behavior using core helpers. After this change, ndo_select_queue() is always invoked with __netdev_pick_tx()

[PATCH net-next 2/2] net: remove 'fallback' argument from dev->ndo_select_queue()

2019-03-19 Thread Paolo Abeni
After the previous patch, all the callers of ndo_select_queue() provide as a 'fallback' argument __netdev_pick_tx. The only exceptions are nested calls to ndo_select_queue(), which pass down the 'fallback' available in the current scope - still __netdev_pick_tx. We can drop such argument and repla

[PATCH net-next] ibmvnic: Report actual backing device speed and duplex values

2019-03-19 Thread Murilo Fossa Vicentini
The ibmvnic driver currently reports a fixed value for both speed and duplex settings regardless of the actual backing device that is being used. By adding support to the QUERY_PHYS_PARMS command defined by the PAPR+ we can query the current physical port state and report the proper values for thes

Re: [PATCH net-next 1/2] packet: rework packet_pick_tx_queue() to use common code selection

2019-03-19 Thread Eric Dumazet
On 03/19/2019 06:25 AM, Paolo Abeni wrote: > +u16 __netdev_pick_tx(struct net_device *dev, struct sk_buff *skb, > + struct net_device *sb_dev) > { > struct sock *sk = skb->sk; > int queue_index = sk_tx_queue_get(sk); > @@ -3729,6 +3729,7 @@ static u16 __netdev_pick

[PATCH net-next] tcp: add tcp_inet6_sk() helper

2019-03-19 Thread Eric Dumazet
TCP ipv6 fast path dereferences a pointer to get to the inet6 part of a tcp socket, but given the fixed memory placement, we can do better and avoid a possible cache line miss. This also reduces register pressure, since we let the compiler know about this memory placement. Signed-off-by: Eric Dum

Re: [PATCH net] ipv6: make ip6_create_rt_rcu return ip6_null_entry instead of NULL

2019-03-19 Thread David Ahern
On 3/19/19 9:19 AM, Paolo Abeni wrote: > Hi, > > On Mon, 2019-03-18 at 14:30 -0700, Wei Wang wrote: >> On Mon, Mar 18, 2019 at 12:48 PM David Ahern >> wrote: >>> On 3/18/19 12:36 PM, Xin Long wrote: diff --git a/net/ipv6/route.c b/net/ipv6/route.c index 4ef4bbd..754777d 100644 ---

Re: [PATCH net-next] ipv6: Add icmp_echo_ignore_multicast support for ICMPv6

2019-03-19 Thread Stephen Suryaputra
I wondered why NET_IPV6_ICMP_ECHO_IGNORE_ALL isn't being referenced. Your comment made me probe further. Apparently, commit e6f86b0f7ae473969a3301b74bf98af9e42ecd0e didn't add it to: static const struct bin_table bin_net_ipv6_icmp_table[] = { { CTL_INT, NET_IPV6_ICMP_RATELIMIT,"ratelimit

Re: [PATCH net-next] ibmvnic: Report actual backing device speed and duplex values

2019-03-19 Thread Mauro Rodrigues
On Tue, Mar 19, 2019 at 10:28:51AM -0300, Murilo Fossa Vicentini wrote: > The ibmvnic driver currently reports a fixed value for both speed and > duplex settings regardless of the actual backing device that is being > used. By adding support to the QUERY_PHYS_PARMS command defined by the > PAPR+ we

[PATCH net-next] tcp: free request sock directly upon TFO or syncookies error

2019-03-19 Thread Guillaume Nault
Since the request socket is created locally, it'd make more sense to use reqsk_free() instead of reqsk_put() in TFO and syncookies' error path. However, tcp_get_cookie_sock() may set ->rsk_refcnt before freeing the socket; tcp_conn_request() may also have non-null ->rsk_refcnt because of tcp_try_f

Re: [PATCH net v2 1/2] vti4: ipip tunnel deregistration fixes.

2019-03-19 Thread Steffen Klassert
On Sat, Mar 16, 2019 at 08:43:28AM +, Jeremy Sowden wrote: > If tunnel registration failed during module initialization, the module > would fail to deregister the IPPROTO_COMP protocol and would attempt to > deregister the tunnel. > > The tunnel was not deregistered during module-exit. > > Fi

[PATCH] rtl8723ae: Make rtl8723e_dm_refresh_rate_adaptive_mask static

2019-03-19 Thread Yue Haibing
From: YueHaibing Fix sparse warning: drivers/net/wireless/realtek/rtlwifi/rtl8723ae/dm.c:666:6: warning: symbol 'rtl8723e_dm_refresh_rate_adaptive_mask' was not declared. Should it be static? Signed-off-by: YueHaibing --- drivers/net/wireless/realtek/rtlwifi/rtl8723ae/dm.c | 2 +- 1 file ch

[PATCH net v3 0/2] vti4: ipip tunnel fixes

2019-03-19 Thread Jeremy Sowden
Some fixes for the initialization and clean-up of the ipip tunnel. Jeremy Sowden (2): vti4: ipip tunnel deregistration fixes. vti4: removed duplicate log message. Since v2: * corrected the commit ID in the "Fixes:" tags. * cc'ed the author of the original patch. Since v1: * submitted bo

[PATCH net v3 1/2] vti4: ipip tunnel deregistration fixes.

2019-03-19 Thread Jeremy Sowden
If tunnel registration failed during module initialization, the module would fail to deregister the IPPROTO_COMP protocol and would attempt to deregister the tunnel. The tunnel was not deregistered during module-exit. Fixes: dd9ee3444014e ("vti4: Fix a ipip packet processing bug in 'IPCOMP' virt

[PATCH net v3 2/2] vti4: removed duplicate log message.

2019-03-19 Thread Jeremy Sowden
Removed info log-message if ipip tunnel registration fails during module-initialization: it adds nothing to the error message that is written on all failures. Fixes: dd9ee3444014e ("vti4: Fix a ipip packet processing bug in 'IPCOMP' virtual tunnel") Signed-off-by: Jeremy Sowden --- net/ipv4/ip_

Re: [RFC PATCH net-next 1/3] net: rtnetlink: Add link-down reason to RTNL messages

2019-03-19 Thread Stephen Hemminger
On Tue, 19 Mar 2019 10:18:00 + Petr Machata wrote: > Stephen Hemminger writes: > > > On Mon, 18 Mar 2019 15:02:53 +0100 > > Andrew Lunn wrote: > > > >> On Mon, Mar 18, 2019 at 01:15:41PM +, Petr Machata wrote: > >> > > >> > Andrew Lunn writes: > >> > > >> > >> +enum rtnl_link_do

Re: [PATCH net-next] ipv6: Add icmp_echo_ignore_multicast support for ICMPv6

2019-03-19 Thread Eric Dumazet
On 03/19/2019 07:10 AM, Stephen Suryaputra wrote: > I wondered why NET_IPV6_ICMP_ECHO_IGNORE_ALL isn't being referenced. > Your comment made me probe further. Apparently, commit > e6f86b0f7ae473969a3301b74bf98af9e42ecd0e didn't add it to: > > static const struct bin_table bin_net_ipv6_icmp_tabl

Re: [RFC PATCH net-next 1/3] net: rtnetlink: Add link-down reason to RTNL messages

2019-03-19 Thread Petr Machata
Stephen Hemminger writes: > On Tue, 19 Mar 2019 10:18:00 + > Petr Machata wrote: > >> Stephen Hemminger writes: >> >> > On Mon, 18 Mar 2019 15:02:53 +0100 >> > Andrew Lunn wrote: >> > >> >> On Mon, Mar 18, 2019 at 01:15:41PM +, Petr Machata wrote: >> >> > >> >> > Andrew Lunn wr

Re: [PATCH] bpf, tests: tweak endianness selection

2019-03-19 Thread Stanislav Fomichev
On 03/19, Sergey Senozhatsky wrote: > Not all compilers have __builtin_bswap16() and __builtin_bswap32(), > thus not all compilers are able to compile the following code > (bpf_htons): > > (__builtin_constant_p(x) ? \ > ___constant_swab16(x) : __builtin_bswap16(x)) > > That's

pull-request: ieee802154 for net 2019-03-19

2019-03-19 Thread Stefan Schmidt
Hello Dave. An update from ieee802154 for your *net* tree. Kangjie Lu fixed a potential NULL pointer deref in the adf7242 driver and Li RongQing make sure we propagate a netlink return code to the caller. If there are any problems let me know. regards Stefan Schmidt The following changes since

Re: [PATCH net-next] tcp: free request sock directly upon TFO or syncookies error

2019-03-19 Thread Eric Dumazet
On 03/19/2019 08:05 AM, Guillaume Nault wrote: > Since the request socket is created locally, it'd make more sense to > use reqsk_free() instead of reqsk_put() in TFO and syncookies' error > path. > > However, tcp_get_cookie_sock() may set ->rsk_refcnt before freeing the > socket; tcp_conn_requ

[PATCH net-next,v2] ipv6: Add icmp_echo_ignore_multicast support for ICMPv6

2019-03-19 Thread Stephen Suryaputra
IPv4 has icmp_echo_ignore_broadcast to prevent responding to broadcast pings. IPv6 needs a similar mechanism. v1->v2: - Remove NET_IPV6_ICMP_ECHO_IGNORE_MULTICAST. Signed-off-by: Stephen Suryaputra --- Documentation/networking/ip-sysctl.txt | 5 + include/net/netns/ipv6.h |

Re: regression from: net: phy: marvell: Avoid unnecessary soft reset

2019-03-19 Thread Florian Fainelli
On 3/18/19 6:32 PM, Phil Reid wrote: > On 19/03/2019 1:09 am, Florian Fainelli wrote: >> On 3/17/19 7:11 PM, Phil Reid wrote: >>> On 16/03/2019 5:58 am, Florian Fainelli wrote: On 3/15/19 1:52 AM, Phil Reid wrote: > G'day All, > > I've just update from kernel 4.19 to 5.0 on a custo

Re: bpf-next is OPEN

2019-03-19 Thread Alban Crequy
On Tue, 19 Mar 2019 at 09:56, Daniel Borkmann wrote: > > Merge window is closed, so new round begins. > > Thanks everyone, > Daniel Thanks! I see that the bpf tree is more recent than the bpf-next tree: https://git.kernel.org/?q=BPF+Group Does it need to be updated, or do I miss something? Chee

Re: [PATCH net-next] net/tls: Add support of AES128-CCM based ciphers

2019-03-19 Thread Boris Pismenny
On 3/19/2019 7:15 AM, Vakul Garg wrote: > Added support for AES128-CCM based record encryption. AES128-CCM is > similar to AES128-GCM. Both of them have same salt/iv/mac size. The > notable difference between the two is that while invoking AES128-CCM > operation, the salt||nonce (which is passed a

[PATCH] v2 Check for SKBTX_HW_TSTAMP in macb driver

2019-03-19 Thread Paul Thomas
Make sure SKBTX_HW_TSTAMP (i.e. SOF_TIMESTAMPING_TX_HARDWARE) has been enabled for this skb It does fix the issue where normal socks that aren't expecting a timestamp will not wake up on select. And when a user does want a SOF_TIMESTAMPING_TX_HARDWARE this does work. Signed-off-by: Paul Thomas --

RE: [PATCH net-next] net/tls: Add support of AES128-CCM based ciphers

2019-03-19 Thread Vakul Garg
> -Original Message- > From: Boris Pismenny > Sent: Tuesday, March 19, 2019 10:36 PM > To: Vakul Garg ; netdev@vger.kernel.org > Cc: Aviad Yehezkel ; davejwat...@fb.com; > da...@davemloft.net; doro...@fb.com > Subject: Re: [PATCH net-next] net/tls: Add support of AES128-CCM based > ciphe

Re: [PATCH] v2 Check for SKBTX_HW_TSTAMP in macb driver

2019-03-19 Thread Paul Thomas
Oh I notice that this is in the xilnx github repo so if it makes it in from there that works too. -Paul

Re: [PATCH v2 01/13] enc28j60: Use device_get_mac_address()

2019-03-19 Thread David Miller
From: Andy Shevchenko Date: Tue, 19 Mar 2019 12:17:53 +0200 > On Mon, Mar 18, 2019 at 10:23:21PM -0700, David Miller wrote: >> >> Especially for a patch series this big, you must provide an >> appropriate cover posting explaining at a high level what this series >> is doing, how it is doing it,

Re: pull-request: ieee802154 for net 2019-03-19

2019-03-19 Thread David Miller
From: Stefan Schmidt Date: Tue, 19 Mar 2019 17:24:35 +0100 > An update from ieee802154 for your *net* tree. > > Kangjie Lu fixed a potential NULL pointer deref in the adf7242 driver and Li > RongQing make sure we propagate a netlink return code to the caller. > > If there are any problems let m

Re: [PATCH rfc v3 bpf-next 8/9] bpf, selftest: test {rd,wr}only flags and direct value access

2019-03-19 Thread Andrii Nakryiko
On Mon, Mar 11, 2019 at 2:51 PM Daniel Borkmann wrote: > > Extend test_verifier with various test cases around the two kernel > extensions, that is, {rd,wr}only map support as well as direct map > value access. All passing, one skipped due to xskmap not present > on test machine: It would be good

Re: [PATCH net] ipv6: make ip6_create_rt_rcu return ip6_null_entry instead of NULL

2019-03-19 Thread Xin Long
On Tue, Mar 19, 2019 at 10:04 PM David Ahern wrote: > > On 3/19/19 9:19 AM, Paolo Abeni wrote: > > Hi, > > > > On Mon, 2019-03-18 at 14:30 -0700, Wei Wang wrote: > >> On Mon, Mar 18, 2019 at 12:48 PM David Ahern > >> wrote: > >>> On 3/18/19 12:36 PM, Xin Long wrote: > diff --git a/net/ipv6/

Re: [PATCH rfc v3 bpf-next 9/9] bpf, selftest: test global data/bss/rodata sections

2019-03-19 Thread Andrii Nakryiko
On Mon, Mar 11, 2019 at 2:51 PM Daniel Borkmann wrote: > > From: Joe Stringer > > Add tests for libbpf relocation of static variable references > into the .data, .rodata and .bss sections of the ELF, also add > read-only test for .rodata. All passing: > > # ./test_progs > [...] > test_globa

[PATCH v2 07/13] enc28j60: Switch to dev_ from pr_

2019-03-19 Thread Andy Shevchenko
Instead of using open coded printk(KERN_) switch the driver to use dev_ macros. Note, the device name will be printed in full, which is beneficial when more than one card installed on the system. Signed-off-by: Andy Shevchenko --- drivers/net/ethernet/microchip/enc28j60.c | 29 +

[PATCH v2 00/13] enc28j60: messaging clean up and ACPI improvements

2019-03-19 Thread Andy Shevchenko
Most of the patches in the series dedicated to update messaging to use modern APIs, such as netdev, with a benefit to distinguish devices, if more than one installed on the system. Besides that, patch 1 targeting ACPI enabled systems when MAC address provided there via properties. And few clean u

[PATCH v2 02/13] enc28j60: Remove duplicate messaging

2019-03-19 Thread Andy Shevchenko
The ->probe() and ->remove() stages can be easily debugged with initcall_debug or function tracer. There is no need to repeat the same explicitly in the driver. Signed-off-by: Andy Shevchenko --- drivers/net/ethernet/microchip/enc28j60.c | 20 1 file changed, 20 deletions(-)

[PATCH v2 01/13] enc28j60: Use device_get_mac_address()

2019-03-19 Thread Andy Shevchenko
Replace the DT-specific of_get_mac_address() function with device_get_mac_address, which works on both DT and ACPI platforms. This change makes it easier to add ACPI support. Signed-off-by: Andy Shevchenko --- drivers/net/ethernet/microchip/enc28j60.c | 7 +++ 1 file changed, 3 insertions(+)

[PATCH v2 05/13] enc28j60: Switch to use module_spi_driver() macro

2019-03-19 Thread Andy Shevchenko
Eliminate some boilerplate code by using module_spi_driver() instead of ->init() / ->exit(), moving the salient bits from ->init() into ->probe(). Signed-off-by: Andy Shevchenko --- drivers/net/ethernet/microchip/enc28j60.c | 21 ++--- 1 file changed, 2 insertions(+), 19 deletion

[PATCH v2 12/13] enc28j60: Fix indentation splats

2019-03-19 Thread Andy Shevchenko
Fix few indentation splats. No functional change intended. Signed-off-by: Andy Shevchenko --- drivers/net/ethernet/microchip/enc28j60.c | 58 --- 1 file changed, 21 insertions(+), 37 deletions(-) diff --git a/drivers/net/ethernet/microchip/enc28j60.c b/drivers/net/ethernet/

[PATCH v2 10/13] enc28j60: Remove linux/init.h

2019-03-19 Thread Andy Shevchenko
There is no need to include linux/init.h when at the same time we include linux/module.h. Remove redundant inclusion. Signed-off-by: Andy Shevchenko --- drivers/net/ethernet/microchip/enc28j60.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/microchip/enc28j60.c b/driv

Re: [PATCH v2 01/13] enc28j60: Use device_get_mac_address()

2019-03-19 Thread Andy Shevchenko
On Tue, Mar 19, 2019 at 10:55:06AM -0700, David Miller wrote: > From: Andy Shevchenko > Date: Tue, 19 Mar 2019 12:17:53 +0200 > > > On Mon, Mar 18, 2019 at 10:23:21PM -0700, David Miller wrote: > >> > >> Especially for a patch series this big, you must provide an > >> appropriate cover posting e

[PATCH v2 03/13] enc28j60: Replace dev_*(&netdev->dev, ...) with netdev_*()

2019-03-19 Thread Andy Shevchenko
Replace open coded netdev_() macros. Signed-off-by: Andy Shevchenko --- drivers/net/ethernet/microchip/enc28j60.c | 42 ++- 1 file changed, 18 insertions(+), 24 deletions(-) diff --git a/drivers/net/ethernet/microchip/enc28j60.c b/drivers/net/ethernet/microchip/enc28j60.c i

[PATCH v2 13/13] enc28j60: Convert to use SPDX identifier

2019-03-19 Thread Andy Shevchenko
Reduce size of duplicated comments by switching to use SPDX identifier. No functional change. Signed-off-by: Andy Shevchenko --- drivers/net/ethernet/microchip/enc28j60.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/net/ethernet/microchip/enc28j60.c b/driver

[PATCH v2 06/13] enc28j60: Use ether_addr_copy() in enc28j60_set_mac_address()

2019-03-19 Thread Andy Shevchenko
Use ether_addr_copy() instead of memcpy() to copy the mac address. Signed-off-by: Andy Shevchenko --- drivers/net/ethernet/microchip/enc28j60.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/microchip/enc28j60.c b/drivers/net/ethernet/microchip/enc28j60

[PATCH v2 11/13] enc28j60: Amend comments by fixing typos, adding periods, etc

2019-03-19 Thread Andy Shevchenko
Amend comments in the code: - adding periods to the multi-line comments - fixing typos - capitalize first word in the sentences - etc Signed-off-by: Andy Shevchenko --- drivers/net/ethernet/microchip/enc28j60.c | 31 --- 1 file changed, 16 insertions(+), 15 deletions(-)

[PATCH v2 09/13] enc28j60: Convert printk() to netdev_printk()

2019-03-19 Thread Andy Shevchenko
The debug prints of network operations will look better if network device name is printed. The benefit of that is a possibility to distinguish the actual hardware when more than one is installed on the system. Convert appropriate printk(KERN_DEBUG) to netdev_print(KERN_DEBUG, ndev). Signed-off-by

[PATCH v2 08/13] enc28j60: Convert HW related printk() to dev_printk()

2019-03-19 Thread Andy Shevchenko
The debug prints of hardware status and operations will look better if SPI device name is printed. The benefit of that is a possibility to distinguish the actual hardware when more than one is installed on the system. Convert appropriate printk(KERN_DEBUG) to dev_print(KERN_DEBUG, &spi->dev). Sig

[PATCH v2 04/13] enc28j60: Drop driver name duplication from messages

2019-03-19 Thread Andy Shevchenko
When dev_() macros are used against SPI device, the driver's name is printed as well. No need to duplicate this explicitly. Signed-off-by: Andy Shevchenko --- drivers/net/ethernet/microchip/enc28j60.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/net/e

[PATCH net-next] net: phy: improve handling link_change_notify callback

2019-03-19 Thread Heiner Kallweit
Currently the Phy driver's link_change_notify callback is called whenever the state machine is run (every second if polling), no matter whether the state changed or not. This isn't needed and may confuse users considering the name of the callback. Actually it contradicts its kernel-doc description.

hello dear

2019-03-19 Thread Asha Gadafi
Assalamu Alaikum Wa Rahmatullahi Wa Barakatuh, hello dear I came across your contact during my private search. Mrs Aisha Al- Qaddafi is my name, the only daughter of late Libyan president, am a single Mother and a Widow with three Children.I have funds the sum of $27.5 million USD for, investme

[RFC PATCH 0/1 net-next] net: sched: Introduce conndscp action

2019-03-19 Thread Kevin 'ldir' Darbyshire-Bryant
With nervousness and trepidation I'm submitting the attached RFC patch for 'conndscp'. Conndscp is a new tc filter action module. It is designed to copy DSCPs to conntrack marks and the reverse operation of conntrack mark contained DSCPs to the diffserv field of suitable skbs. The feature is int

[PATCH 1/1] net: sched: Introduce conndscp action

2019-03-19 Thread Kevin 'ldir' Darbyshire-Bryant
Conndscp is a new tc filter action module. It is designed to copy DSCPs to conntrack marks and the reverse operation of conntrack mark contained DSCPs to the diffserv field of suitable skbs. The feature is intended for use and has been found useful for restoring ingress classifications based on e

[PATCH v3 1/3] dt-bindings: net: dsa: qca8k: fix example

2019-03-19 Thread Christian Lamparter
In the example, the phy at phy@0 is clashing with the switch0@0 at the same address. Usually, the switches are accessible through pseudo PHYs which in case of the qca8k are located at 0x10 - 0x18. Signed-off-by: Christian Lamparter --- Documentation/devicetree/bindings/net/dsa/qca8k.txt | 4 ++--

[PATCH v3 2/3] dt-bindings: net: dsa: qca8k: support internal mdio-bus

2019-03-19 Thread Christian Lamparter
This patch updates the qca8k's binding to document to the approach for using the internal mdio-bus of the supported qca8k switches. Signed-off-by: Christian Lamparter --- .../devicetree/bindings/net/dsa/qca8k.txt | 69 +-- 1 file changed, 64 insertions(+), 5 deletions(-) dif

[PATCH v3 3/3] net: dsa: qca8k: extend slave-bus implementations

2019-03-19 Thread Christian Lamparter
This patch implements accessors for the QCA8337 MDIO access through the MDIO_MASTER register, which makes it possible to access the PHYs on slave-bus through the switch. In cases where the switch ports are already mapped via external "phy-phandles", the internal mdio-bus is disabled in order to pre

Re: [PATCH net] mpls: Fix 6PE forwarding

2019-03-19 Thread David Miller
From: Vinay K Nallamothu Date: Mon, 18 Mar 2019 19:31:54 + > Acknowledgements: > > We thank Avinash Lingala who brought up this usecase and > for having this fix verified in a large scale datacenter deployment. > > Aravind Srinivas Srinivasa Prabhakar helped us validate > the fix. Please

Re: [Patch net] xfrm: unify xfrm protocol checks

2019-03-19 Thread Cong Wang
On Mon, Mar 18, 2019 at 10:17 PM Herbert Xu wrote: > > On Mon, Mar 18, 2019 at 10:08:24PM -0700, Cong Wang wrote: > > > > +static inline bool xfrm_id_proto_valid(u8 proto) > > +{ > > + switch (proto) { > > + case IPPROTO_AH: > > + case IPPROTO_ESP: > > + case IPPROTO_COMP: > > +#if

Re: [PATCH net-next] net/tls: Add support of AES128-CCM based ciphers

2019-03-19 Thread David Miller
From: Vakul Garg Date: Tue, 19 Mar 2019 05:15:20 + > @@ -479,11 +477,18 @@ static int tls_do_encryption(struct sock *sk, > struct tls_rec *rec = ctx->open_rec; > struct sk_msg *msg_en = &rec->msg_encrypted; > struct scatterlist *sge = sk_msg_elem(msg_en, start); > - int

[PATCH] net: mvneta: Switch to using devm_alloc_etherdev_mqs

2019-03-19 Thread Rosen Penev
It allows some of the code to be simplified. Signed-off-by: Rosen Penev --- drivers/net/ethernet/marvell/mvneta.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c index a78a39244b79..8

Re: [PATCH net] tcp: do not use ipv6 header for ipv4 flow

2019-03-19 Thread David Miller
From: Eric Dumazet Date: Tue, 19 Mar 2019 05:45:35 -0700 > When a dual stack tcp listener accepts an ipv4 flow, > it should not attempt to use an ipv6 header or tcp_v6_iif() helper. > > Fixes: 1397ed35f22d ("ipv6: add flowinfo for tcp6 pkt_options for all cases") > Fixes: df3687ffc665 ("ipv6: ad

Re: [PATCH net] dccp: do not use ipv6 header for ipv4 flow

2019-03-19 Thread David Miller
From: Eric Dumazet Date: Tue, 19 Mar 2019 05:46:18 -0700 > When a dual stack dccp listener accepts an ipv4 flow, > it should not attempt to use an ipv6 header or > inet6_iif() helper. > > Fixes: 3df80d9320bc ("[DCCP]: Introduce DCCPv6") > Signed-off-by: Eric Dumazet Applied and queued up for -

[PATCH bpf-next] tools/bpf: generate pkg-config file for libbpf

2019-03-19 Thread Luca Boccassi
Generate a libbpf.pc file at build time so that users can rely on pkg-config to find the library, its CFLAGS and LDFLAGS. Signed-off-by: Luca Boccassi --- tools/lib/bpf/.gitignore | 1 + tools/lib/bpf/Makefile | 18 +++--- tools/lib/bpf/libbpf.pc.template | 11

Re: [PATCH net-next 1/2] packet: rework packet_pick_tx_queue() to use common code selection

2019-03-19 Thread David Miller
From: Paolo Abeni Date: Tue, 19 Mar 2019 14:25:01 +0100 > Currently packet_pick_tx_queue() is the only caller of > ndo_select_queue() using a fallback argument other than > __netdev_pick_tx. > > Leveraging rx queue, we can obtain a similar queue selection > behavior using core helpers. After thi

Re: [summary] virtio network device failover writeup

2019-03-19 Thread Michael S. Tsirkin
On Tue, Mar 19, 2019 at 02:38:06PM +0200, Liran Alon wrote: > Hi Michael, > > Great blog-post which summarise everything very well! > > Some comments I have: Thanks! I'll try to update everything in the post when I'm not so jet-lagged. > 1) I think that when we are using the term “1-netdev mode

Re: [PATCH net-next] ibmvnic: Report actual backing device speed and duplex values

2019-03-19 Thread David Miller
From: Murilo Fossa Vicentini Date: Tue, 19 Mar 2019 10:28:51 -0300 > The ibmvnic driver currently reports a fixed value for both speed and > duplex settings regardless of the actual backing device that is being > used. By adding support to the QUERY_PHYS_PARMS command defined by the > PAPR+ we ca

mgmt-tx issues with off-channel neighbor response on channel 100

2019-03-19 Thread Ben Greear
Hello, I'm not sure if the fault is hostapd or the wireless stack (or something else), but this is what I see: I put an AP on channel 100, configured for RRM. STA associates to it and sends a channel report request. hostapd reports tx of the response frame failed with EBUSY (-16). Debugging i

Re: [PATCH net-next] tcp: add tcp_inet6_sk() helper

2019-03-19 Thread David Miller
From: Eric Dumazet Date: Tue, 19 Mar 2019 07:01:08 -0700 > TCP ipv6 fast path dereferences a pointer to get to the inet6 > part of a tcp socket, but given the fixed memory placement, > we can do better and avoid a possible cache line miss. > > This also reduces register pressure, since we let th

Re: bpf-next is OPEN

2019-03-19 Thread Daniel Borkmann
On 03/19/2019 06:01 PM, Alban Crequy wrote: > On Tue, 19 Mar 2019 at 09:56, Daniel Borkmann wrote: >> >> Merge window is closed, so new round begins. >> >> Thanks everyone, >> Daniel > > Thanks! I see that the bpf tree is more recent than the bpf-next tree: > https://git.kernel.org/?q=BPF+Group >

Re: [PATCH net-next] net: hns3: Make hclgevf_update_link_mode static

2019-03-19 Thread David Miller
From: Yue Haibing Date: Tue, 19 Mar 2019 22:46:41 +0800 > From: YueHaibing > > Fix sparse warning: > > drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c:407:6: > warning: symbol 'hclgevf_update_link_mode' was not declared. Should it be > static? > > Signed-off-by: YueHaibing Appli

Re: [PATCH net-next] tcp: free request sock directly upon TFO or syncookies error

2019-03-19 Thread David Miller
From: Guillaume Nault Date: Tue, 19 Mar 2019 16:05:44 +0100 > Since the request socket is created locally, it'd make more sense to > use reqsk_free() instead of reqsk_put() in TFO and syncookies' error > path. > > However, tcp_get_cookie_sock() may set ->rsk_refcnt before freeing the > socket; t

Re: [PATCH net] ipv6: make ip6_create_rt_rcu return ip6_null_entry instead of NULL

2019-03-19 Thread David Ahern
On 3/19/19 7:21 PM, Xin Long wrote: > I will post v2 by moving down 'fallback:': > > { ... > if (!fib6_info_hold_safe(rt)) > goto fallback; > > nrt = ip6_dst_alloc(dev_net(dev), dev, flags); > if (!nrt) { > fib6_info_release(rt); >

Re: [PATCH bpf-next] tools/bpf: generate pkg-config file for libbpf

2019-03-19 Thread Stanislav Fomichev
On 03/19, Luca Boccassi wrote: > Generate a libbpf.pc file at build time so that users can rely > on pkg-config to find the library, its CFLAGS and LDFLAGS. > > Signed-off-by: Luca Boccassi > --- > tools/lib/bpf/.gitignore | 1 + > tools/lib/bpf/Makefile | 18 +++--

Re: [PATCH net-next,v2] ipv6: Add icmp_echo_ignore_multicast support for ICMPv6

2019-03-19 Thread David Miller
From: Stephen Suryaputra Date: Tue, 19 Mar 2019 12:37:12 -0400 > IPv4 has icmp_echo_ignore_broadcast to prevent responding to broadcast pings. > IPv6 needs a similar mechanism. > > v1->v2: > - Remove NET_IPV6_ICMP_ECHO_IGNORE_MULTICAST. > > Signed-off-by: Stephen Suryaputra Applied.

Re: [PATCH v2 3/8] bpf: add skc_lookup_tcp helper

2019-03-19 Thread Alexei Starovoitov
On Tue, Mar 19, 2019 at 10:20:58AM +, Lorenz Bauer wrote: > Allow looking up a sock_common. This gives eBPF programs > access to timewait and request sockets. > > Signed-off-by: Lorenz Bauer > --- > include/uapi/linux/bpf.h | 20 ++- > kernel/bpf/verifier.c| 3 +- > net/core/filte

  1   2   >