From: Paolo Abeni <pab...@redhat.com> Date: Tue, 19 Mar 2019 14:25:01 +0100
> Currently packet_pick_tx_queue() is the only caller of > ndo_select_queue() using a fallback argument other than > __netdev_pick_tx. > > Leveraging rx queue, we can obtain a similar queue selection > behavior using core helpers. After this change, ndo_select_queue() > is always invoked with __netdev_pick_tx() as fallback. > We can change ndo_select_queue() signature in a followup patch, > dropping an indirect call per transmitted packet in some scenarios > (e.g. TCP syn and XDP generic xmit) > > This changes slightly how af packet queue selection happens when > PACKET_QDISC_BYPASS is set. It's now more similar to plan dev_queue_xmit() > tacking in account both XPS and TC mapping. > > RFC -> v1: > - initialize sender_cpu to the expected value > > Signed-off-by: Paolo Abeni <pab...@redhat.com> To reply indirectly to Eric's feedback. I agree with him that maybe these should have different names. But having a global symbol for networking be core_*() doesn't sit right with me. netdev_core_*() might be better.
