Re: regression from: net: phy: marvell: Avoid unnecessary soft reset

2019-03-21 Thread Phil Reid
On 21/03/2019 2:16 pm, liweihang wrote: On 3/19/2019 7:34 PM, liweihang wrote: Hi all, I've met a similar issue and sent an email to discuss about it before: Question about setting speed and duplex failed after auto-negotiation disabled on marvell phy d6ab93364734 net: phy: marvell: Avoid u

RE: regression from: net: phy: marvell: Avoid unnecessary soft reset

2019-03-20 Thread liweihang
com; > cphe...@gmail.com; clemens.gru...@pqgruber.com; n...@nbd.name; > harini.kata...@xilinx.com > Subject: Re: regression from: net: phy: marvell: Avoid unnecessary soft reset > > On 20.03.2019 13:22, liweihang wrote: > > > > > >> -Original Message- > &g

Re: regression from: net: phy: marvell: Avoid unnecessary soft reset

2019-03-20 Thread Maxim Uvarov
t;> cphe...@gmail.com; clemens.gru...@pqgruber.com; hkallwe...@gmail.com; > >> n...@nbd.name; harini.kata...@xilinx.com > >> Subject: Re: regression from: net: phy: marvell: Avoid unnecessary soft > >> reset > >> > >> > >> > >> On 3/1

Re: regression from: net: phy: marvell: Avoid unnecessary soft reset

2019-03-20 Thread Heiner Kallweit
; David S. Miller >> ; dongsheng.w...@hxt-semitech.com; >> cphe...@gmail.com; clemens.gru...@pqgruber.com; hkallwe...@gmail.com; >> n...@nbd.name; harini.kata...@xilinx.com >> Subject: Re: regression from: net: phy: marvell: Avoid unnecessary soft reset >> >> >&

RE: regression from: net: phy: marvell: Avoid unnecessary soft reset

2019-03-20 Thread liweihang
.@gmail.com; clemens.gru...@pqgruber.com; hkallwe...@gmail.com; > n...@nbd.name; harini.kata...@xilinx.com > Subject: Re: regression from: net: phy: marvell: Avoid unnecessary soft reset > > > > On 3/19/2019 7:34 PM, liweihang wrote: > > Hi all, > > > > I've

Re: regression from: net: phy: marvell: Avoid unnecessary soft reset

2019-03-20 Thread Phil Reid
On 20/03/2019 2:39 pm, Heiner Kallweit wrote: On 20.03.2019 06:16, Phil Reid wrote: On 20/03/2019 11:37 am, Florian Fainelli wrote: On 3/19/2019 7:34 PM, liweihang wrote: Hi all, I've met a similar issue and sent an email to discuss about it before: Question about setting speed and duplex f

Re: regression from: net: phy: marvell: Avoid unnecessary soft reset

2019-03-19 Thread Heiner Kallweit
On 20.03.2019 06:16, Phil Reid wrote: > On 20/03/2019 11:37 am, Florian Fainelli wrote: >> >> >> On 3/19/2019 7:34 PM, liweihang wrote: >>> Hi all, >>> >>> I've met a similar issue and sent an email to discuss about it before: >>> Question about setting speed and duplex failed after auto-negotiatio

Re: regression from: net: phy: marvell: Avoid unnecessary soft reset

2019-03-19 Thread Phil Reid
On 20/03/2019 11:37 am, Florian Fainelli wrote: On 3/19/2019 7:34 PM, liweihang wrote: Hi all, I've met a similar issue and sent an email to discuss about it before: Question about setting speed and duplex failed after auto-negotiation disabled on marvell phy d6ab93364734 net: phy: marvell:

Re: regression from: net: phy: marvell: Avoid unnecessary soft reset

2019-03-19 Thread Florian Fainelli
hkallwe...@gmail.com; >> n...@nbd.name; harini.kata...@xilinx.com >> Subject: Re: regression from: net: phy: marvell: Avoid unnecessary soft reset >> >> On 20/03/2019 12:53 am, Florian Fainelli wrote: >>> On 3/18/19 6:32 PM, Phil Reid wrote: >>>> On 19/03/20

RE: regression from: net: phy: marvell: Avoid unnecessary soft reset

2019-03-19 Thread liweihang
vger.kernel.org > Cc: Andrew Lunn ; David S. Miller > ; dongsheng.w...@hxt-semitech.com; > cphe...@gmail.com; clemens.gru...@pqgruber.com; hkallwe...@gmail.com; > n...@nbd.name; harini.kata...@xilinx.com > Subject: Re: regression from: net: phy: marvell: Avoid unnecessary soft reset &

Re: regression from: net: phy: marvell: Avoid unnecessary soft reset

2019-03-19 Thread Phil Reid
On 20/03/2019 12:53 am, Florian Fainelli wrote: On 3/18/19 6:32 PM, Phil Reid wrote: On 19/03/2019 1:09 am, Florian Fainelli wrote: On 3/17/19 7:11 PM, Phil Reid wrote: On 16/03/2019 5:58 am, Florian Fainelli wrote: On 3/15/19 1:52 AM, Phil Reid wrote: G'day All, I've just update from kerne

Re: regression from: net: phy: marvell: Avoid unnecessary soft reset

2019-03-19 Thread Florian Fainelli
On 3/18/19 6:32 PM, Phil Reid wrote: > On 19/03/2019 1:09 am, Florian Fainelli wrote: >> On 3/17/19 7:11 PM, Phil Reid wrote: >>> On 16/03/2019 5:58 am, Florian Fainelli wrote: On 3/15/19 1:52 AM, Phil Reid wrote: > G'day All, > > I've just update from kernel 4.19 to 5.0 on a custo

Re: regression from: net: phy: marvell: Avoid unnecessary soft reset

2019-03-18 Thread Phil Reid
On 19/03/2019 1:09 am, Florian Fainelli wrote: On 3/17/19 7:11 PM, Phil Reid wrote: On 16/03/2019 5:58 am, Florian Fainelli wrote: On 3/15/19 1:52 AM, Phil Reid wrote: G'day All, I've just update from kernel 4.19 to 5.0 on a custom board that has a marvell dsa mv88e6085 and the phy on the mv8

Re: regression from: net: phy: marvell: Avoid unnecessary soft reset

2019-03-18 Thread Andrew Lunn
> I'm using a Marvell 88E6161 with 5.0.1 and I get the following output > which I think indicates that the 6161 does not use the 1540 PHY: Correct. Maybe it is the 6172? I know it is one of the devices i have. Yes, i mv88e6172 uses 88E1540. Andrew

Re: regression from: net: phy: marvell: Avoid unnecessary soft reset

2019-03-18 Thread Chris Healy
> Some of the older Marvell switches use the 1540 for its internal > PHYs. Same OUI as the external PHY. I don't remember which > switches. Maybe the mv88e6161 in the RDU1? > I'm using a Marvell 88E6161 with 5.0.1 and I get the following output which I think indicates that the 6161 does not use th

Re: regression from: net: phy: marvell: Avoid unnecessary soft reset

2019-03-18 Thread Andrew Lunn
> Thanks, you mentioned a mv88e6085 but that chip is a 10/100 switch, did > you mean that the mv88e6085 compatible string is used in Device Tree to > designate that chip? While the 88E1540 driver is picked up, that driver > is originally for external PHY packages (AFAICT), so there could be some >

Re: regression from: net: phy: marvell: Avoid unnecessary soft reset

2019-03-18 Thread Florian Fainelli
On 3/17/19 7:11 PM, Phil Reid wrote: > On 16/03/2019 5:58 am, Florian Fainelli wrote: >> On 3/15/19 1:52 AM, Phil Reid wrote: >>> G'day All, >>> >>> I've just update from kernel 4.19 to 5.0 on a custom board that has a >>> marvell >>> dsa mv88e6085 and the phy on the mv88e6085 will only connect at

Re: regression from: net: phy: marvell: Avoid unnecessary soft reset

2019-03-17 Thread Phil Reid
On 16/03/2019 5:58 am, Florian Fainelli wrote: On 3/15/19 1:52 AM, Phil Reid wrote: G'day All, I've just update from kernel 4.19 to 5.0 on a custom board that has a marvell dsa mv88e6085 and the phy on the mv88e6085 will only connect at 10Mb/s with the above mentioned patch applied. Bisecting

Re: regression from: net: phy: marvell: Avoid unnecessary soft reset

2019-03-15 Thread Florian Fainelli
On 3/15/19 1:52 AM, Phil Reid wrote: > G'day All, > > I've just update from kernel 4.19 to 5.0 on a custom board that has a > marvell > dsa mv88e6085 and the phy on the mv88e6085 will only connect at 10Mb/s with > the above mentioned patch applied. > > Bisecting the issue lead me to the following