On 3/17/19 7:11 PM, Phil Reid wrote: > On 16/03/2019 5:58 am, Florian Fainelli wrote: >> On 3/15/19 1:52 AM, Phil Reid wrote: >>> G'day All, >>> >>> I've just update from kernel 4.19 to 5.0 on a custom board that has a >>> marvell >>> dsa mv88e6085 and the phy on the mv88e6085 will only connect at >>> 10Mb/s with >>> the above mentioned patch applied. >>> >>> Bisecting the issue lead me to the following patch. >>> >>> d6ab93364734bd (net: phy: marvell: Avoid unnecessary soft reset) >>> >>> Revert the patch, and the associated build fix >>> 4b1bd6976945417 (net: phy: marvell: Fix build.) >>> restores connections to 1Gb/s. >>> >>> Anyone have any thoughts as to the correct fix? >> >> What is the PHY OUI (MII_PHYSID1/ID2) for that PHY? We may need to add a >> specific entry in drivers/net/phy/marvell.c to restore the software >> reset to commit changes to the register. >> > G'day Florian, > > OUI is 0x005043 > Model is 101011 > > Phy1ID: 0x0141 > Phy2ID: 0x0eb1 > > The running phy driver is "Marvell 88E1540"
Thanks, you mentioned a mv88e6085 but that chip is a 10/100 switch, did you mean that the mv88e6085 compatible string is used in Device Tree to designate that chip? While the 88E1540 driver is picked up, that driver is originally for external PHY packages (AFAICT), so there could be some switch-specific integration of this PHY that makes it behave differently, having the OUI helps narrow down what might be necessary to accomplish. FWIW, the changes were originally tested with a 88e6352. -- Florian
