On Tue, 23 Jun 2020 03:13:35 + Kirsher, Jeffrey T wrote:
> In patch 8, the functions are not so small and simple. Are you sure
> the compiler would inline them if we did not explicitly 'inline'
> them? I want to make sure before making that change.
I'm not, but why are they supposed to be in
> Subject: Re: [net-next 4/9] i40e: detect and log info about pre-recovery mode
>
> On Mon, 22 Jun 2020 15:18:12 -0700 Jeff Kirsher wrote:
> > +static inline bool i40e_check_fw_empr(struct i40e_pf *pf) {
>
> > +}
>
> > +static inline i40e_status i40e_handle_r
> Subject: Re: [net-next 4/9] i40e: detect and log info about pre-recovery mode
>
> On Tue, 23 Jun 2020 00:18:08 + Kirsher, Jeffrey T wrote:
> > > There is no need to use the inline keyword in C sources. Compiler
> > > will inline small static functions, anyway.
>
On Tue, 23 Jun 2020 00:18:08 + Kirsher, Jeffrey T wrote:
> > There is no need to use the inline keyword in C sources. Compiler will
> > inline
> > small static functions, anyway.
> >
> > Same thing in patch 8.
>
> I am prepping a v2, are these the only issues? Want to make sure
> before s
> Subject: Re: [net-next 4/9] i40e: detect and log info about pre-recovery mode
>
> On Mon, 22 Jun 2020 15:18:12 -0700 Jeff Kirsher wrote:
> > +static inline bool i40e_check_fw_empr(struct i40e_pf *pf) {
>
> > +}
>
> > +static inline i40e_status i40e_handle_r
On Mon, 22 Jun 2020 15:18:12 -0700 Jeff Kirsher wrote:
> +static inline bool i40e_check_fw_empr(struct i40e_pf *pf)
> +{
> +}
> +static inline i40e_status i40e_handle_resets(struct i40e_pf *pf)
> +{
> + const i40e_status pfr = i40e_pf_loop_reset(pf);
> +
> + return is_empr ? I40E_ERR_RES
