> -----Original Message-----
> From: Jakub Kicinski <k...@kernel.org>
> Sent: Monday, June 22, 2020 16:56
> To: Kirsher, Jeffrey T <jeffrey.t.kirs...@intel.com>
> Cc: da...@davemloft.net; Kwapulinski, Piotr <piotr.kwapulin...@intel.com>;
> netdev@vger.kernel.org; nhor...@redhat.com; sassm...@redhat.com;
> Loktionov, Aleksandr <aleksandr.loktio...@intel.com>; Bowers, AndrewX
> <andrewx.bow...@intel.com>
> Subject: Re: [net-next 4/9] i40e: detect and log info about pre-recovery mode
>
> On Mon, 22 Jun 2020 15:18:12 -0700 Jeff Kirsher wrote:
> > +static inline bool i40e_check_fw_empr(struct i40e_pf *pf) {
>
> > +}
>
> > +static inline i40e_status i40e_handle_resets(struct i40e_pf *pf) {
> > + const i40e_status pfr = i40e_pf_loop_reset(pf);
>
> > +
> > + return is_empr ? I40E_ERR_RESET_FAILED : pfr; }
>
> There is no need to use the inline keyword in C sources. Compiler will inline
> small static functions, anyway.
>
> Same thing in patch 8.
[Kirsher, Jeffrey T]
In patch 8, the functions are not so small and simple. Are you sure the
compiler would inline them if we did not explicitly 'inline' them? I want to
make sure before making that change.
