> -----Original Message----- > From: Jakub Kicinski <k...@kernel.org> > Sent: Monday, June 22, 2020 17:29 > To: Kirsher, Jeffrey T <jeffrey.t.kirs...@intel.com> > Cc: da...@davemloft.net; Kwapulinski, Piotr <piotr.kwapulin...@intel.com>; > netdev@vger.kernel.org; nhor...@redhat.com; sassm...@redhat.com; > Loktionov, Aleksandr <aleksandr.loktio...@intel.com>; Bowers, AndrewX > <andrewx.bow...@intel.com> > Subject: Re: [net-next 4/9] i40e: detect and log info about pre-recovery mode > > On Tue, 23 Jun 2020 00:18:08 +0000 Kirsher, Jeffrey T wrote: > > > There is no need to use the inline keyword in C sources. Compiler > > > will inline small static functions, anyway. > > > > > > Same thing in patch 8. > > > > I am prepping a v2, are these the only issues? Want to make sure > > before send out a v2 and thank you Jakub! > > Since you asked :)
Your right, I did. I am a gluten for criticism. 😊 > - I couldn't really grasp what the 8th patch does. > Quite a bit of code gets moved around in a way that doesn't clearly address > any locking issues. Perhaps the commit message could be improved (or even > patch split into two - move code, change code)? Ok, I will work with Alek to improve patch 8.
