On Mon, 22 Jun 2020 15:18:12 -0700 Jeff Kirsher wrote: > +static inline bool i40e_check_fw_empr(struct i40e_pf *pf) > +{
> +} > +static inline i40e_status i40e_handle_resets(struct i40e_pf *pf) > +{ > + const i40e_status pfr = i40e_pf_loop_reset(pf); > + > + return is_empr ? I40E_ERR_RESET_FAILED : pfr; > +} There is no need to use the inline keyword in C sources. Compiler will inline small static functions, anyway. Same thing in patch 8.