://bugs.debian.org/983591
Reported-by: Axel Scheepers
Signed-off-by: Luca Boccassi
---
ip/iproute.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/ip/iproute.c b/ip/iproute.c
index 291f1a58..5853f026 100644
--- a/ip/iproute.c
+++ b/ip/iproute.c
@@ -796,9 +796,10 @@ int print_route
On Sun, 24 Jan 2021 at 17:26, David Ahern wrote:
>
> On 1/24/21 8:53 AM, Luca Boccassi wrote:
> > Since NETLINK_GET_STRICT_CHK was enabled, the kernel rejects commands
> > that pass a prefix length, eg:
> >
> > ip route get `1.0.0.0/1
> > Error: ipv4: In
;s no point in setting a rtm_dst_len that we know is going
to be rejected, just force it to the right value if it's passed on
the command line. Print a warning to stderr to notify users.
Bug-Debian: https://bugs.debian.org/944730
Reported-By: Clément 'wxcafé' Hertling
Signed-off-by: L
;s no point in setting a rtm_dst_len that we know is going
to be rejected, just force it to the right value if it's passed on
the command line.
Bug-Debian: https://bugs.debian.org/944730
Reported-By: Clément 'wxcafé' Hertling
Signed-off-by: Luca Boccassi
---
As mentioned
last insn is not an exit or jmp
processed 0 insns (limit 100) max_states_per_insn 0 total_states 0
peak_states 0 mark_read 0
Kernel compiled with CGROUP_BPF enabled?
https://bugs.debian.org/980046
Reported-by: Emmanuel DECAEN
Signed-off-by: Luca Boccassi
---
lib/bpf_glue.c | 3 ++-
1 file
Necessary to understand what is going on when bpf_program_load fails
Signed-off-by: Luca Boccassi
---
ip/ipvrf.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ip/ipvrf.c b/ip/ipvrf.c
index 42779e5c..91578031 100644
--- a/ip/ipvrf.c
+++ b/ip/ipvrf.c
@@ -278,8 +278,8
On Wed, 2020-12-02 at 09:42 -0700, David Ahern wrote:
> On 11/28/20 11:30 AM, Luca Boccassi wrote:
> > @@ -287,9 +293,9 @@ static int mqprio_print_opt(struct qdisc_util *qu, FILE
> > *f, struct rtattr *opt)
> > return -1;
> >
From: Luca Boccassi
As reported by a Debian user, mqprio output in json mode is
invalid:
{
"kind": "mqprio",
"handle": "8021:",
"dev": "enp1s0f0",
"root": true,
"options": { tc 2 map 0 0
On Sat, 2020-11-28 at 09:34 -0800, Stephen Hemminger wrote:
> On Sat, 28 Nov 2020 12:17:00 +
> Luca Boccassi wrote:
>
> > On Fri, 2020-11-27 at 21:21 -0800, Stephen Hemminger wrote:
> > > On Fri, 27 Nov 2020 15:26:25 +
> > > Luca Boccassi wrote:
> &g
On Sat, 2020-11-28 at 12:21 +, Luca Boccassi wrote:
> As reported by a Debian user, mqprio output in json mode is
> invalid:
>
> {
> "kind": "mqprio",
> "handle": "8021:",
> "dev": "enp1s0f0",
ot;options": {
"tc": 2,
"map": [ 0, 0, 0, 1, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 ],
"queues": [ [ 0, 3 ], [ 4, 7 ] ],
"mode": "channel",
"shaper": "dcb"
}
}
https://bugs.debian.org/
On Fri, 2020-11-27 at 21:21 -0800, Stephen Hemminger wrote:
> On Fri, 27 Nov 2020 15:26:25 +
> Luca Boccassi wrote:
>
> > As reported by a Debian user, mqprio output in json mode is
> > invalid:
> >
> > {
> > "kind": "mqprio&q
0 0 0 0
queues:(0:3) (4:7)
mode:channel
shaper:dcb}
}
json-ify it, while trying to maintain the same formatting
for standard output.
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=972784
Reported-by: Roméo GINON
Signed-off-by: Luca Boccassi
---
v1: I do not ha
eproduces, to add an
artificial synchronization point after the first mount().
Reported-by: Etienne Dechamps
Signed-off-by: Luca Boccassi
---
ip/ipnetns.c | 35 +++
1 file changed, 35 insertions(+)
diff --git a/ip/ipnetns.c b/ip/ipnetns.c
index 14e8e087..3e96d267 100
Signed-off-by: Luca Boccassi
---
dcb/.gitignore | 1 +
1 file changed, 1 insertion(+)
create mode 100644 dcb/.gitignore
diff --git a/dcb/.gitignore b/dcb/.gitignore
new file mode 100644
index ..3f26856c
--- /dev/null
+++ b/dcb/.gitignore
@@ -0,0 +1 @@
+dcb
--
2.29.2
0 0 0 0
queues:(0:3) (4:7)
mode:channel
shaper:dcb}
}
json-ify it, while trying to maintain the same formatting
for standard output.
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=972784
Signed-off-by: Luca Boccassi
---
I do not have hardware where I can configure mq
s done.
> Luca,
> could you please rebase on bpf-next and resubmit your patch?
Just sent v8:
https://patchwork.ozlabs.org/patch/1068045/
Thanks for the heads-up!
--
Kind regards,
Luca Boccassi
From: Luca Boccassi
Generate a libbpf.pc file at build time so that users can rely
on pkg-config to find the library, its CFLAGS and LDFLAGS.
Signed-off-by: Luca Boccassi
Acked-by: Andrey Ignatov
---
v2: use QUIET_GEN instead of QUIET_LINK to generate pc file,
save kernel version in its
On Tue, 2019-03-26 at 13:12 -0700, Alexei Starovoitov wrote:
> On Thu, Mar 21, 2019 at 4:09 PM <
> luca.bocca...@gmail.com
> > wrote:
> > From: Luca Boccassi <
> > bl...@debian.org
> > >
> >
> > Generate a libbpf.pc file at build time so that u
On Thu, 2019-03-21 at 15:43 -0700, Alexei Starovoitov wrote:
> On Thu, Mar 21, 2019 at 10:33:17PM +, luca.bocca...@gmail.com
> wrote:
> > From: Luca Boccassi
> >
> > Generate a libbpf.pc file at build time so that users can rely
> > on pkg-config to find the l
From: Luca Boccassi
Generate a libbpf.pc file at build time so that users can rely
on pkg-config to find the library, its CFLAGS and LDFLAGS.
Signed-off-by: Luca Boccassi
Acked-by: Andrey Ignatov
---
v2: use QUIET_GEN instead of QUIET_LINK to generate pc file,
save kernel version in its
On Thu, 2019-03-21 at 23:19 +0100, Daniel Borkmann wrote:
> On 03/21/2019 11:01 PM, Alexei Starovoitov wrote:
> > On Thu, Mar 21, 2019 at 04:00:46PM +, Andrey Ignatov wrote:
> > > luca.bocca...@gmail.com [Thu, 2019-03-
> > > 21 03:26 -0700]:
From: Luca Boccassi
Generate a libbpf.pc file at build time so that users can rely
on pkg-config to find the library, its CFLAGS and LDFLAGS.
Signed-off-by: Luca Boccassi
Acked-by: Andrey Ignatov
---
v2: use QUIET_GEN instead of QUIET_LINK to generate pc file,
save kernel version in its
From: Luca Boccassi
Generate a libbpf.pc file at build time so that users can rely
on pkg-config to find the library, its CFLAGS and LDFLAGS.
Signed-off-by: Luca Boccassi
Acked-by: Andrey Ignatov
---
v2: use QUIET_GEN instead of QUIET_LINK to generate pc file,
save kernel version in its
On Thu, 2019-03-21 at 15:01 -0700, Alexei Starovoitov wrote:
> On Thu, Mar 21, 2019 at 04:00:46PM +, Andrey Ignatov wrote:
> > luca.bocca...@gmail.com [Thu, 2019-03-21
> > 03:26 -0700]:
> > > From: Luca Boccassi
> > >
> > > Generate a libbpf.pc
On Wed, 2019-03-20 at 23:58 +, Andrey Ignatov wrote:
> luca.bocca...@gmail.com [Wed, 2019-03-20
> 06:28 -0700]:
> > From: Luca Boccassi
> >
> > Generate a libbpf.pc file at build time so that users can rely
> > on pkg-config to find the library, its CFLAGS an
From: Luca Boccassi
Generate a libbpf.pc file at build time so that users can rely
on pkg-config to find the library, its CFLAGS and LDFLAGS.
Signed-off-by: Luca Boccassi
---
v2: use QUIET_GEN instead of QUIET_LINK to generate pc file,
save kernel version in its own variable instead of
On Wed, 2019-03-20 at 10:21 -0700, Stanislav Fomichev wrote:
> On 03/20, Luca Boccassi wrote:
> > On Wed, 2019-03-20 at 13:22 +0000, Luca Boccassi wrote:
> > > On Tue, 2019-03-19 at 16:17 -0700, Stanislav Fomichev wrote:
> > > > On 03/19, Luca Boccassi wrote:
> >
On Wed, 2019-03-20 at 13:22 +, Luca Boccassi wrote:
> On Tue, 2019-03-19 at 16:17 -0700, Stanislav Fomichev wrote:
> > On 03/19, Luca Boccassi wrote:
> > > Generate a libbpf.pc file at build time so that users can rely
> > > on pkg-config to find the libr
From: Luca Boccassi
Generate a libbpf.pc file at build time so that users can rely
on pkg-config to find the library, its CFLAGS and LDFLAGS.
Signed-off-by: Luca Boccassi
---
v2: use QUIET_GEN instead of QUIET_LINK to generate pc file,
save kernel version in its own variable instead of
On Tue, 2019-03-19 at 16:17 -0700, Stanislav Fomichev wrote:
> On 03/19, Luca Boccassi wrote:
> > Generate a libbpf.pc file at build time so that users can rely
> > on pkg-config to find the library, its CFLAGS and LDFLAGS.
> >
> > Signed-off-by: Luca Boccassi
&g
On Tue, 2019-03-19 at 14:23 -0700, Stanislav Fomichev wrote:
> On 03/19, Luca Boccassi wrote:
> > Generate a libbpf.pc file at build time so that users can rely
> > on pkg-config to find the library, its CFLAGS and LDFLAGS.
> >
> > Signed-off-by: Luca Boccassi
Generate a libbpf.pc file at build time so that users can rely
on pkg-config to find the library, its CFLAGS and LDFLAGS.
Signed-off-by: Luca Boccassi
---
v2: use QUIET_GEN instead of QUIET_LINK to generate pc file,
save kernel version in its own variable instead of calling
make inline
Generate a libbpf.pc file at build time so that users can rely
on pkg-config to find the library, its CFLAGS and LDFLAGS.
Signed-off-by: Luca Boccassi
---
tools/lib/bpf/.gitignore | 1 +
tools/lib/bpf/Makefile | 18 +++---
tools/lib/bpf/libbpf.pc.template | 11
1.0.0.0/0
1.0.0.0 via 192.168.1.1 dev eth0 src 192.168.1.91 uid 1000
cache
Reported-by: Clément Hertling
Signed-off-by: Luca Boccassi
---
v2: changed the check instead of removing it, so that "ip route get"
fails since the address is a mandatory parameter according to the
manpage
ed-by: Clément Hertling
Signed-off-by: Luca Boccassi
---
Stephen et al, this was reported by a Debian user:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=921737
It makes sense to me at a cursory glance, but sending as RFC as I'm
not 100% familiar with the route get function.
ip/ipr
groff stiff complains about unbreakable lines:
96: warning [p 2, 3.0i]: can't break line
Indent it some more.
Fixes: 7f5047524c99 ("man: ss.8: break and indent long line")
Signed-off-by: Luca Boccassi
---
man/man8/ss.8 | 10 --
1 file changed, 8 insertions(+), 2 del
Pass the same parameters Lintian uses in Debian.
$ make check
<...>
Checking manpages for syntax errors...
:48: warning: macro `Q' not defined
Error in tc-taprio.8
Makefile:27: recipe for target 'check' failed
Signed-off-by: Luca Boccassi
---
As far as I can see all th
.Q does not exist so groff complains and the "queues" word is actually
not displayed.
Fixes: 579acb4bc52f ("taprio: Add manpage for tc-taprio(8)")
Signed-off-by: Luca Boccassi
---
man/man8/tc-taprio.8 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ma
> BTW Maintenance was reason why I didn't like duplicity in modules you
> had in v1.
>
> > +# unload kernel modules to remove dummy interfaces only if they
> > were not in use beforehand
> > +KMODS_REMOVE=
>
> As a side effect, this could be lower case (showi
purposes.
Signed-off-by: Luca Boccassi
Reviewed-by: Petr Vorel
---
v2: applied suggestions from Petr to simplify the modules parsing/unloading
v3: ditto, added reviewed-by tag
testsuite/tests/ip/tunnel/add_tunnel.t | 13 +
1 file changed, 13 insertions(+)
diff --git a/testsuite/tests/ip
vf_rate.t] Error 127
CC generate_nlmsg
Makefile:123: recipe for target 'check' failed
make: *** [check] Error 2
Add an explicit dependency in testuite/Makefile's $(TESTS) rule so
that the tool correctly gets compiled before any test runs.
Fixes: 3537633dcf44 ("testsuite:
Signed-off-by: Luca Boccassi
Reviewed-by: Petr Vorel
---
v2: fixed copypasta in log message
v3: added reviewed-by tag
testsuite/tests/ip/route/add_default_route.t | 2 ++
1 file changed, 2 insertions(+)
diff --git a/testsuite/tests/ip/route/add_default_route.t
b/testsuite/tests/ip/route
../../config.mk: No such file or directory
make[2]: *** No rule to make target '../../config.mk'. Stop.
Fixes: 8804a8c0d387 ("Makefile: Add check target")
Signed-off-by: Luca Boccassi
Reviewed-by: Petr Vorel
Tested-by: Petr Vorel
---
v2: added reviewed/tested-by tags, removed Cc
On Sat, 2018-12-15 at 17:32 +0100, Petr Vorel wrote:
> Hi Luca,
>
> > Signed-off-by: Luca Boccassi
>
> Reviewed-by: Petr Vorel
> > ---
> > testsuite/tests/ip/route/add_default_route.t | 2 ++
> > 1 file changed, 2 insertions(+)
> > diff --git a/te
> > gre 16384 2 ip6_gre,ip_gre
> > Check beforehand if the gre kernel module is loaded, and if not
> > unload
> > them all at the end of the test. This should avoid causing problems
> > if
> > a user is already using GRE for other p
Signed-off-by: Luca Boccassi
---
v2: fixed copypasta in log message
testsuite/tests/ip/route/add_default_route.t | 2 ++
1 file changed, 2 insertions(+)
diff --git a/testsuite/tests/ip/route/add_default_route.t
b/testsuite/tests/ip/route/add_default_route.t
index 569ba1f8..ded4edc3 100755
../../config.mk: No such file or directory
make[2]: *** No rule to make target '../../config.mk'. Stop.
Fixes: 8804a8c0d387 ("Makefile: Add check target")
Signed-off-by: Luca Boccassi
Reviewed-by: Petr Vorel
Tested-by: Petr Vorel
---
v2: added reviewed/tested-by tags, removed Cc
purposes.
Signed-off-by: Luca Boccassi
Reviewed-by: Petr Vorel
---
v2: applied suggestions from Petr to simplify the modules parsing/unloading
testsuite/tests/ip/tunnel/add_tunnel.t | 13 +
1 file changed, 13 insertions(+)
diff --git a/testsuite/tests/ip/tunnel/add_tunnel.t
b/testsuite
vf_rate.t] Error 127
CC generate_nlmsg
Makefile:123: recipe for target 'check' failed
make: *** [check] Error 2
Add an explicit dependency in testuite/Makefile's $(TESTS) rule so
that the tool correctly gets compiled before any test runs.
Fixes: 3537633dcf44 ("testsuite:
purposes.
Signed-off-by: Luca Boccassi
---
testsuite/tests/ip/tunnel/add_tunnel.t | 24
1 file changed, 24 insertions(+)
diff --git a/testsuite/tests/ip/tunnel/add_tunnel.t
b/testsuite/tests/ip/tunnel/add_tunnel.t
index 3f5a9d3c..76f8b011 100755
--- a/testsuite/tests/ip
vf_rate.t] Error 127
CC generate_nlmsg
Makefile:123: recipe for target 'check' failed
make: *** [check] Error 2
Add an explicit dependency in testuite/Makefile's $(TESTS) rule so
that the tool correctly gets compiled before any test runs.
Fixes: 3537633dcf44 ("tes
Signed-off-by: Luca Boccassi
---
testsuite/tests/ip/route/add_default_route.t | 2 ++
1 file changed, 2 insertions(+)
diff --git a/testsuite/tests/ip/route/add_default_route.t
b/testsuite/tests/ip/route/add_default_route.t
index 569ba1f8..c536e35f 100755
--- a/testsuite/tests/ip/route
../../config.mk: No such file or directory
make[2]: *** No rule to make target '../../config.mk'. Stop.
Fixes: 8804a8c0d387 ("Makefile: Add check target")
Cc: petr.vo...@gmail.com
Signed-off-by: Luca Boccassi
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
It's $(QUIET_CC)$(CC) not $(QUIET_CC), copy-paste error. CI does
verbose build so it slipped through.
Fixes: 6e7d347aabbb ("testsuite: build generate_nlmsg with QUIET_CC")
Signed-off-by: Luca Boccassi
---
testsuite/tools/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 de
". If" gets interpreted as a macro, so move the period to the previous
line:
33: warning: macro `If' not defined
Fixes: 141b55f8544e ("Add SKB Priority qdisc support in tc(8)")
Signed-off-by: Luca Boccassi
---
v2: remove extra space to avoid making the full-stop bold
On Fri, 2018-11-02 at 15:19 +, Edward Cree wrote:
> On 02/11/18 10:57, Luca Boccassi wrote:
> > ". If" gets interpreted as a macro, so move the period to the
> > previous
> > line:
> >
> > 33: warning: macro `If' not defined
> >
>
Fixes groff warning:
ss.8 92: warning [p 2, 2.8i]: can't break line
And makes the line also more readable.
Signed-off-by: Luca Boccassi
---
This line is the example of an output, so you might not want to break it.
Let me know if you prefer a different solution.
man/man8/ss.8 | 8 ++
Follow the standard pattern, and respect user's verbosity setting.
Signed-off-by: Luca Boccassi
---
testsuite/tools/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/testsuite/tools/Makefile b/testsuite/tools/Makefile
index e1d9bfef..85df69ec 100644
--- a/test
When building Debian packages pre-processor flags are passed via
CPPFLAGS, as the convention indicates. Specifically, the hardening
-D_FORTIFY_SOURCE=2 flag is used.
Pass CPPFLAGS to all calls of QUIET_CC together with CFLAGS.
Signed-off-by: Luca Boccassi
---
configure | 2 +-
misc/Makefile
". If" gets interpreted as a macro, so move the period to the previous
line:
33: warning: macro `If' not defined
Fixes: 141b55f8544e ("Add SKB Priority qdisc support in tc(8)")
Signed-off-by: Luca Boccassi
---
man/man8/tc-skbprio.8 | 4 ++--
1 file changed, 2 i
lable")
Signed-off-by: Luca Boccassi
---
genl/ctrl.c | 3 ---
include/utils.h | 4
ip/iplink.c | 3 ---
ip/ipnetns.c | 3 ---
ip/iproute_lwtunnel.c | 3 ---
ip/ipvrf.c| 3 ---
ip/ipxfrm.c | 3 ---
ip/tunnel.c | 3 ---
ip/xf
If libc does not provide strlcpy check for libbsd with pkg-config to
avoid relying on inline version.
Signed-off-by: Luca Boccassi
---
Changed from -include /usr/include/bsd/string.h hack to HAVE_LIBBSD
and proper includes in each file that uses strlcpy.
The hack causes a compiler warning as ip
On Wed, 2018-10-31 at 08:09 -0700, Stephen Hemminger wrote:
> On Mon, 29 Oct 2018 10:46:50 +
> Luca Boccassi wrote:
>
> > If libc does not provide strlcpy check for libbsd with pkg-config
> > to
> > avoid relying on inline version.
> >
> > Signed-
On Mon, 2018-10-29 at 09:27 -0600, David Ahern wrote:
> On 10/29/18 4:46 AM, Luca Boccassi wrote:
> > If libc does not provide strlcpy check for libbsd with pkg-config
> > to
> > avoid relying on inline version.
> >
> > Signed-off-by: Luca Boccassi
> > --
If libc does not provide strlcpy check for libbsd with pkg-config to
avoid relying on inline version.
Signed-off-by: Luca Boccassi
---
This allows distro maintainers to be able to choose to reduce
duplication and let this code be maintained in one place, in the
external library.
configure | 12
te generate_nlmsg when needed
> testsuite: Warn about empty $(IPVERS)
>
> testsuite/Makefile | 21 ++---
> 1 file changed, 14 insertions(+), 7 deletions(-)
Series-tested-by: Luca Boccassi
--
Kind regards,
Luca Boccassi
signature.asc
Description: This is a digitally signed message part
ot;, NULL);
> print_color_string(PRINT_ANY, ifa_family_color(frh-
> >family),
> - "dst", "%s ", dst);
> + "dst", "%s", dst);
> if (frh->dst_len != host_len)
>
On Thu, 2018-08-23 at 09:07 +0200, Stefan Bader wrote:
> On 22.08.2018 20:09, Luca Boccassi wrote:
> > Some generated test files were not removed, including one
> > executable in
> > the testsuite/tools directory.
> > Ensure make clean from the top level directory
Some distributions like Debian nowadays restrict the dmesg command to
root-only. Run it with sudo in the testsuite.
Signed-off-by: Luca Boccassi
---
testsuite/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/testsuite/Makefile b/testsuite/Makefile
index 5e269877
The generate_nlmsg binary is required but make -C testsuite compile
does not build it. Add the necessary includes and C*FLAGS to the tools
Makefile and have the compile target build it.
Signed-off-by: Luca Boccassi
---
testsuite/Makefile | 1 +
testsuite/tools/Makefile | 4 +++-
2 files
Some generated test files were not removed, including one executable in
the testsuite/tools directory.
Ensure make clean from the top level directory works for the testsuite
subdirs too, and that all the files are removed.
Signed-off-by: Luca Boccassi
---
Makefile | 2
file | 16 +++-
> 1 file changed, 11 insertions(+), 5 deletions(-)
>
> diff --git a/testsuite/Makefile b/testsuite/Makefile
> index 8fcbc55..f9f3b19 100644
Acked-by: Luca Boccassi
Looks good to me, thanks.
--
Kind regards,
Luca Boccassi
signature.asc
Description: This is a digitally signed message part
On Wed, 2018-05-16 at 16:53 +0200, Michal Kubecek wrote:
> On Wed, May 16, 2018 at 02:42:24PM +0100, Luca Boccassi wrote:
> > Hans reported a regression in v4.16.0, ip route now requires -6 to
> > be
> > manually added when using v6 addresses while up to 4.15 it didn't,
&
y introduced the
problem:
93fa12418dc6f5943692250244be303bb162175b
utils: Always specify family and ->bytelen in get_prefix_1()
Could you please have a look when you have a moment? It's very easy to
reproduce, and it breaks existing scripts and so on.
Thanks!
--
Kind regards,
Luca Boccassi
signature.asc
Description: This is a digitally signed message part
ng ip exec vrf with libcap")
Signed-off-by: Luca Boccassi
---
Reported on Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=898015
The reporter tested this patch and verified it solves the issue.
lib/utils.c | 15 ---
man/man8/ip-vrf.8 | 4
2 files c
capabilities on start if not
invoked with "vrf exec".
Update the manpage with the requirements.
Signed-off-by: Luca Boccassi
---
Changes since RFC: moved drop_cap to lib/util.c to call it from
ipvrf.c after vrf_switch, which is the function that requires the
additional permissions, ha
On Tue, 2018-03-27 at 10:15 -0700, Stephen Hemminger wrote:
> On Tue, 27 Mar 2018 17:24:19 +0100
> Luca Boccassi wrote:
>
> > ip vrf exec requires root or CAP_NET_ADMIN, CAP_SYS_ADMIN and
> > CAP_DAC_OVERRIDE. It is not possible to run unprivileged commands
> > like
On Tue, 2018-03-27 at 10:40 -0600, David Ahern wrote:
> On 3/27/18 10:24 AM, Luca Boccassi wrote:
> > ip vrf exec requires root or CAP_NET_ADMIN, CAP_SYS_ADMIN and
> > CAP_DAC_OVERRIDE. It is not possible to run unprivileged commands
> > like
> > ping as non-root or
capabilities on start if not
invoked with "vrf exec".
Update the manpage with the requirements.
Signed-off-by: Luca Boccassi
---
I'd like to be able to run ip vrf exec as a normal user, does this approach
sound sensible? Any concerns? Are there any other alternatives?
It would be up to
f "default" prefix parameter was corrected. But
> at
> the same time behaviour of "all"/"any" was altered too, because they
> were the same branch of the code. As those parameters mean different,
> they need to be treated differently in code too. This patc
y about 4.15 - Stephen's revert will be enough for
now. I'm going to push 4.16 as soon as it's out anyway, so you can just
do the changes for master if you wish.
> On 13.03.2018 13:02, Luca Boccassi wrote:
> > On Tue, 2018-03-13 at 12:05 +0100, Alexander Zubkov wrote:
> >
> behaves? My original concern was about "default" only. I agree too,
> > that "all" or "any" should work for all routes. But not for the
> > default.
> >
> > 12.03.2018, 22:37, "Luca Boccassi" :
> > > On Mon, 2018-03-12 a
ions. It no longer flushed all IPv4 routes.
>
> Reported-by: Luca Boccassi
> Signed-off-by: Stephen Hemminger
> ---
> ip/iproute.c | 65 ++--
>
> lib/utils.c | 13
> 2 files changed, 32 insertions(+),
51487814431958&w=2
Patchwork:
https://patchwork.ozlabs.org/patch/854412/
https://patchwork.ozlabs.org/patch/854410/
Thanks
--
Kind regards,
Luca Boccassi
signature.asc
Description: This is a digitally signed message part
sign),
not a macro.
Signed-off-by: Luca Boccassi
---
man/man8/devlink-sb.8 | 2 +-
man/man8/ip-link.8.in | 2 +-
man/man8/tc-u32.8 | 6 ++
3 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/man/man8/devlink-sb.8 b/man/man8/devlink-sb.8
index ffb5553e..1882833a 100644
--- a/m
testsuite/lib/generic.sh | 6 +-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
Series acked-by: Luca Boccassi
--
Kind regards,
Luca Boccassi
signature.asc
Description: This is a digitally signed message part
On Fri, 2017-12-29 at 20:04 -0800, Stephen Hemminger wrote:
> On Fri, 29 Dec 2017 23:01:24 +0100
> Luca Boccassi wrote:
>
> > Trying to set a label longer than 15 characters returns an error:
> > RTNETLINK answers: Numerical result out of range
> >
> >
d-off-by: Luca Boccassi
---
man/man8/routel.8 | 5 -
1 file changed, 5 deletions(-)
diff --git a/man/man8/routel.8 b/man/man8/routel.8
index 82d580fb..2270eacb 100644
--- a/man/man8/routel.8
+++ b/man/man8/routel.8
@@ -17,11 +17,6 @@ The routel script will list routes in a format that some
Trying to set a label longer than 15 characters returns an error:
RTNETLINK answers: Numerical result out of range
Document the limit in the manpage.
Originally reported as a Debian bug:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=661886
Reported-by: Gabor Kiss
Signed-off-by: Luca
: Luca Boccassi
---
man/man8/ip.8 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/man/man8/ip.8 b/man/man8/ip.8
index ae018fdf..7f26582d 100644
--- a/man/man8/ip.8
+++ b/man/man8/ip.8
@@ -1,6 +1,6 @@
.TH IP 8 "20 Dec 2011" "iproute2" "Linux"
.SH
On Fri, 2017-12-29 at 20:02 -0800, Stephen Hemminger wrote:
> On Fri, 29 Dec 2017 23:01:23 +0100
> Luca Boccassi wrote:
>
> > A Debian user suggested adding more network-related keywords to the
> > ip manpage, so that manpage-scraping and indexing software like
> > apr
Documentation should be distribution-agnostic - any specific quirks
should be handled by downstream maintainers, if necessary.
Remove mentions of Debian paths and package names.
Signed-off-by: Luca Boccassi
---
man/man8/lnstat.8 | 3 +--
man/man8/ss.8 | 3 +--
2 files changed, 2 insertions
: Luca Boccassi
---
man/man8/ip.8 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/man/man8/ip.8 b/man/man8/ip.8
index ae018fdf..94e64319 100644
--- a/man/man8/ip.8
+++ b/man/man8/ip.8
@@ -1,6 +1,6 @@
.TH IP 8 "20 Dec 2011" "iproute2" "Linux"
.SH
Trying to set a label longer than 15 characters returns an error:
RTNETLINK answers: Numerical result out of range
Document the limit in the manpage.
Originally reported as a Debian bug:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=661886
Reported-by: Gabor Kiss
Signed-off-by: Luca
d-off-by: Luca Boccassi
---
man/man8/routel.8 | 5 -
1 file changed, 5 deletions(-)
diff --git a/man/man8/routel.8 b/man/man8/routel.8
index 82d580fb..2270eacb 100644
--- a/man/man8/routel.8
+++ b/man/man8/routel.8
@@ -17,11 +17,6 @@ The routel script will list routes in a format that some
Documentation should be distribution-agnostic - any specific quirks
should be handled by downstream maintainers, if necessary.
Remove mentions of Debian paths and package names.
Signed-off-by: Luca Boccassi
---
man/man8/lnstat.8 | 3 +--
man/man8/ss.8 | 3 +--
2 files changed, 2 insertions
97 matches
Mail list logo
