On Sun, 2018-12-16 at 21:21 +0100, Petr Vorel wrote: > Hi Luca, > > Reviewed-by: Petr Vorel <pvo...@suse.cz> > LGTM, but I'd suggest 2 small changes (see bellow). > > > +++ b/testsuite/tests/ip/tunnel/add_tunnel.t > > TUNNEL_NAME="tunnel_test_ip" > > I'd put KMODS here: > KMODS="ip6_gre ip6_tunnel ip_gre ip_tunnel gre" > > The reason is maintenance of this script - maybe one day there will > be other > modules needed to be added, take this list as a configuration (which > is usually > in shell scripts in the top). > BTW Maintenance was reason why I didn't like duplicity in modules you > had in v1. > > > +# unload kernel modules to remove dummy interfaces only if they > > were not in use beforehand > > +KMODS_REMOVE= > > As a side effect, this could be lower case (showing it's not a > configuration > variable, but just normal variable).
Ok, thanks, done both in v3. -- Kind regards, Luca Boccassi
signature.asc
Description: This is a digitally signed message part
