On Tue, 2018-03-13 at 21:12 +0100, Alexander Zubkov wrote: > Hi, > > I just realized that you need patch for v4.15.0, which is easier to > do. > I'll send it as separate message now. I will make patch for the > master > branch, but later.
Thanks but don't worry about 4.15 - Stephen's revert will be enough for now. I'm going to push 4.16 as soon as it's out anyway, so you can just do the changes for master if you wish. > On 13.03.2018 13:02, Luca Boccassi wrote: > > On Tue, 2018-03-13 at 12:05 +0100, Alexander Zubkov wrote: > > > Hello again, > > > > > > The fun thing is that before the commit "ip route ls all" showed > > > all > > > routes, but "ip -[4|6] route ls all" showed only default. So it > > > was > > > broken too, but in other way. > > > I see parsing of prefix was changed since my patch. So I need > > > several > > > days to propose fix. I think if "ip route ls [all|any]" shows all > > > routes and "ip route ls default" shows only default, everybody > > > will > > > be happy with that? > > > > Hi, > > > > My only concern is that behaviour of existing commands that have > > been > > in releases is not changed, otherwise I get bugs raised :-) > > > > Thank you for your work! > > > > > 13.03.2018, 09:46, "Alexander Zubkov" <gr...@msu.ru>: > > > > Hello. > > > > > > > > May be the better way would be to change how "all"/"any" > > > > argument > > > > behaves? My original concern was about "default" only. I agree > > > > too, > > > > that "all" or "any" should work for all routes. But not for the > > > > default. > > > > > > > > 12.03.2018, 22:37, "Luca Boccassi" <bl...@debian.org>: > > > > > On Mon, 2018-03-12 at 14:03 -0700, Stephen Hemminger wrote: > > > > > > This reverts commit > > > > > > 9135c4d6037ff9f1818507bac0049fc44db8c3d2. > > > > > > > > > > > > Debian maintainer found that basic command: > > > > > > # ip route flush all > > > > > > No longer worked as expected which breaks user scripts > > > > > > and > > > > > > expectations. It no longer flushed all IPv4 routes. > > > > > > > > > > > > Reported-by: Luca Boccassi <bl...@debian.org> > > > > > > Signed-off-by: Stephen Hemminger <stephen@networkplumber > > > > > > .org> > > > > > > --- > > > > > > ip/iproute.c | 65 ++++++++++++++++++------------------- > > > > > > --- > > > > > > -------- > > > > > > ------------ > > > > > > lib/utils.c | 13 ++++++++++++ > > > > > > 2 files changed, 32 insertions(+), 46 deletions(-) > > > > > > > > > > Tested-by: Luca Boccassi <bl...@debian.org> > > > > > > > > > > Thanks, solves the problem. I'll backport it to Debian. > > > > > > > > > > Alexander, reproducing the issue is quite simple - before > > > > > that > > > > > commit, > > > > > ip route ls all showed all routes, but with the change it > > > > > started > > > > > showing only the default table. Same for ip route flush. > > > > > > > > > > -- > > > > > Kind regards, > > > > > Luca Boccassi > > -- Kind regards, Luca Boccassi
signature.asc
Description: This is a digitally signed message part
