Hello!
On 17.04.2021 16:23, Adam Ford wrote:
The call to clk_disable_unprepare() can happen before priv is
initialized.
Mhm, how's that? :-/
This means moving clk_disable_unprepare out of
out_release into a new label.
Fixes: 8ef7adc6beb2("net: ethernet: ravb: Enable optional refclk")
Si
On 16.04.2021 16:35, Thomas Bogendoerfer wrote:
On Fri, Apr 16, 2021 at 12:29:46PM +0300, Sergei Shtylyov wrote:
On 16.04.2021 11:52, Thomas Bogendoerfer wrote:
Add device tree bindings for ethernet controller integrated into
IDT 79RC3243x SoCs.
Signed-off-by: Thomas Bogendoerfer
On 16.04.2021 11:52, Thomas Bogendoerfer wrote:
Add device tree bindings for ethernet controller integrated into
IDT 79RC3243x SoCs.
Signed-off-by: Thomas Bogendoerfer
---
.../bindings/net/idt,3243x-emac.yaml | 74 +++
1 file changed, 74 insertions(+)
create mode
Hello!
On 16.04.2021 11:47, Thomas Bogendoerfer wrote:
If there is no mac address passed via platform data try to get it via > device
tree and fall back to a random mac address, if all fail.
Signed-off-by: Thomas Bogendoerfer
---
drivers/net/ethernet/korina.c | 24 ++--
On 18.03.2021 15:44, Adam Ford wrote:
The AVB refererence clock assumes an external clock that runs
reference
automatically. Because the Versaclock is wired to provide the
AVB refclock, the device tree needs to reference it in order for the
driver to start the clock.
Signed-off-by: Adam Fo
clock, there is no
> clock-names list either.
>
> Update bindings to add the additional optional clock, and explicitly
> name both of them.
>
> Signed-off-by: Adam Ford
> Reviewed-by: Geert Uytterhoeven
> Acked-by: Rob Herring
Reviewed-by: Sergei Shtylyov
[...]
PS: S
_put_sync(), as
> there is no reason to do a synchronous power down.
>
> Fixes: 7fa2955ff70ce453 ("sh_eth: Fix sleeping function called from invalid
> context")
> Signed-off-by: Geert Uytterhoeven
Reviewed-by: Sergei Shtylyov
[...]
MBR, Sergei
Hello!
On 15.01.2021 23:19, Adam Ford wrote:
For devices that use a programmable clock for the avb reference clock,
AVB.
the driver may need to enable them. Add code to find the optional clock
and enable it when available.
Signed-off-by: Adam Ford
[...]
diff --git a/drivers/net/ethe
Hello!
On 13.01.2021 13:57, Tiezhu Yang wrote:
When make M=samples/bpf on the Loongson 3A3000 platform which
belongs to MIPS arch, there exists many similar build errors
about 'asm/rwonce.h' file not found, so include it only under
CONFIG_ARM64 and CONFIG_ALPHA due to it exists only in arm64
an
On 29.12.2020 0:31, Adam Ford wrote:
The bindings have been updated to support two clocks, but the
original clock now requires the name fck. Add a clock-names
list in the device tree with fck in it.
Hopefully this won't break RPM...
Signed-off-by: Adam Ford
[...]
MBR, Sergei
On 29.12.2020 0:31, Adam Ford wrote:
The bindings have been updated to support two clocks, but the
original clock now requires the name fck to distinguish it
from the other.
Signed-off-by: Adam Ford
Reviewed-by: Sergei Shtylyov
MBR, Sergei
Hello!
On 29.12.2020 0:31, Adam Ford wrote:
The AVB driver assumes there is an external clock, but it could
be driven by an external clock.
Driver can be driven by external clock? :-)
In order to enable a programmable
clock, it needs to be added to the clocks list and enabled in the
dri
Hello!
On 12.12.2020 19:56, Adam Ford wrote:
The SoC expects the txv_refclk is provided, but if it is provided
by a programmable clock, there needs to be a way to get and enable
this clock to operate. It needs to be optional since it's only
necessary for those with programmable clocks.
Signed
Hello!
On 19.11.2020 20:24, Yves-Alexis Perez wrote:
Starting with iOS 14 released in September 2020, connectivity using the
personal hotspot USB tethering function of iOS devices is broken.
Communication between the host and the device (for example ICMP traffic
or DNS resolution using the DNS
tamp_config eth0
> flags = 0
> tx_type = OFF
> rx_filter = PTP_V2_L2_EVENT
>
> Correct this by converting if-else's to switch.
>
> Fixes: c156633f1353 ("Renesas Ethernet AVB driver proper")
> Reported-by: Julia Lawall
> Signed-off-by: Andrew Gabbasov
Reviewed-by: Sergei Shtylyov
[...]
MBR, Sergei
Hello!
On 10/19/20 10:32 AM, Andrew Gabbasov wrote:
Sorry for the delay again, I keep forgetting about the mails I' couldn't
reply
quickly. :-|
[...]
>>The patch was set to the "Changes Requested" state -- most probably
>> because of this
>> mail. Though unintentionally, it served to th
Hello!
On 10/1/20 10:13 AM, Andrew Gabbasov wrote:
The patch was set to the "Changes Requested" state -- most probably because
of this
mail. Though unintentionally, it served to throttle actions on this patch. I
did only
remember about this patch yesterday... :-)
[...]
>> In the function ra
Hello!
On 05.10.2020 0:24, Pavel Machek wrote:
It seems
commit fb3a780e7a76cf8efb055f8322ec039923cee41f
Author: Yuusuke Ashizuka
Date: Thu Aug 20 18:43:07 2020 +0900
ravb: Fixed to be able to unload modules
causes problems in at least -cip-rt kernels. (I'd have to verify it is
presen
LES=n case.
Signed-off-by: Geert Uytterhoeven
Cc: sta...@vger.kernel.org
Reviewed-by: Sergei Shtylyov
---
Commit 1838d6c62f578366 ("ravb: Fixed to be able to unload modules") was
already backported to stable v4.4, v4.9, v4.14, v4.19, v5.4, and v5.8),
and thus needs to be reverted
On 9/14/20 5:44 PM, Christoph Hellwig wrote:
> DMA_ATTR_NON_CONSISTENT is a no-op except on PARISC and some mips
> configs, so don't set it in this ARM specific driver.
Hm, PARICS and ARM capitalized but mips in lower case? :-)
> Signed-off-by: Christoph Hellwig
[...]
MBR, Sergei
Hello!
On 27.08.2020 9:53, Himadri Pandya wrote:
The buffer size is 2 Bytes and we expect to receive the same amount of
data. But sometimes we receive less data and run into uninit-was-stored
issue upon read. Hence modify the error check on the return value to match
with the buffer size as a pr
On 8/20/20 3:29 PM, Sergei Shtylyov wrote:
>Also, s/Fixed/fix/ in the subject. Nearly missed it. :-)
And overall, I'd call the patch "ravb: fix module unloading".
MBR, Sergei
Also, s/Fixed/fix/ in the subject. Nearly missed it. :-)
ditionalProperties: false".
>
> Signed-off-by: Geert Uytterhoeven
> Reviewed-by: Rob Herring
[...]
Reviewed-by: Sergei Shtylyov
MBR, Sergei
in use
Call ravb_mdio_init() at open and free_mdio_bitbang() at close, thereby
rmmod is possible in the ifdown state.
Fixes: c156633f1353 ("Renesas Ethernet AVB driver proper")
Signed-off-by: Yuusuke Ashizuka
Reviewed-by: Sergei Shtylyov
[...]
MBR, Sergei
On 03.08.2020 9:51, yzc...@netease.com wrote:
From: carl
Prefrrably a full name, matching that one in the signoff tag.
When QMUX enabled, the 'dl-datagram-max-size' can be 4KB/16KB/31KB depend
on QUALCOMM's chipsets.
No indentation here please, start at column 1 and respect th
possible in the ifdown state.
Fixes: c156633f1353 ("Renesas Ethernet AVB driver proper")
> Signed-off-by: Yuusuke Ashizuka
Reviewed-by: Sergei Shtylyov
[...]
> diff --git a/drivers/net/ethernet/renesas/ravb_main.c
> b/drivers/net/ethernet/renesas/ravb_main.c
> index 99f7aae
Hello!
On 7/31/20 9:43 AM, Yoshihiro Shimoda wrote:
From: Yuusuke Ashizuka, Sent: Thursday, July 30, 2020 7:02 PM
Subject: [PATCH v2] ravb: Fixed the problem that rmmod can not be done
>>>
>>> Thank you for the patch! I found a similar patch for another driver [1].
>>
>>It's not th
Hello!
On 7/31/20 1:18 PM, ashid...@fujitsu.com wrote:
> I understand that the commit log needs to be corrected.
The subject also could be more concise...
> (Shimoda-san's point is also correct)
>
> If there is anything else that needs to be corrected, please point it out.
OK, I'll try
Hello!
On 7/30/20 2:37 PM, Yoshihiro Shimoda wrote:
>> From: Yuusuke Ashizuka, Sent: Thursday, July 30, 2020 7:02 PM
>> Subject: [PATCH v2] ravb: Fixed the problem that rmmod can not be done
>
> Thank you for the patch! I found a similar patch for another driver [1].
It's not the same case -
Hello!
On 7/30/20 1:01 PM, Yuusuke Ashizuka wrote:
> ravb is a module driver, but I cannot rmmod it after insmod it.
Modular. And "insmod'ing it".
> ravb does mdio_init() at the time of probe, and module->refcnt is incremented
> by alloc_mdio_bitbang() called after that.
That seems a com
k.be...@de.bosch.com/
Reported-by: Dirk Behme
Signed-off-by: Yoshihiro Shimoda
Reviewed-by: Sergei Shtylyov
ACK, this tag is still good for v3.
---
Changes from RFC v2:
- Check the return value of ravb_init_dmac() too.
- Update the subject and description.
- Fix the comment
2.2390-1-dirk.be...@de.bosch.com/
>
> Reported-by: Dirk Behme
> Signed-off-by: Yoshihiro Shimoda
Assuming the comment below is fixed:
Reviewed-by: Sergei Shtylyov
> ---
> Changes from RFC v1:
> - Check the return value of ravb_stop_dma() and exit if the hardwa
Hello!
Sorry about another late reply, was having h/w issues on the new work...
On 07/06/2020 12:25 PM, Yoshihiro Shimoda wrote:
> From: Yoshihiro Shimoda, Sent: Tuesday, May 26, 2020 6:47 PM
>
> According to the report of [1], this driver is possible to cause
Hello!
On 15.07.2020 18:56, Wxcafé wrote:
From 352445fcbac243b8f10e1840726d67b41a45853d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Miguel Rodr=C3=ADguez P=C3=A9rez?
Something went wrong
Date: Tue, 14 Jul 2020 18:10:34 -0400
Subject: [PATCH 3/4] cdc_ncm: replace the way cdc_ncm hooks into
Hello!
On 14.07.2020 0:35, Lad Prabhakar wrote:
From: Marian-Cristian Rotariu
Document RZ/G2H (R8A774E1) SoC bindings.
Signed-off-by: Marian-Cristian Rotariu
Signed-off-by: Lad Prabhakar
Reviewed-by: Sergei Shtylyov
[...]
MBR, Sergei
On 08.07.2020 13:03, Sergei Shtylyov wrote:
Some EtherAVB variants support internal clock delay configuration, which
can add larger delays than the delays that are typically supported by
the PHY (using an "rgmii-*id" PHY mode, and/or "[rt]xc-skew-ps"
properties).
Add proper
Add properties for configuring the internal MAC delays.
These properties are mandatory, even when specified as zero, to
distinguish between old and new DTBs.
Update the (bogus) example accordingly.
Signed-off-by: Geert Uytterhoeven
Reviewed-by: Sergei Shtylyov
[...]
MBR, Sergei
Hello!
On 30.06.2020 8:22, Yoshihiro Shimoda wrote:
From: Yoshihiro Shimoda, Sent: Tuesday, May 26, 2020 6:47 PM
According to the report of [1], this driver is possible to cause
the following error in ravb_tx_timeout_work().
ravb e680.ethernet ethernet: failed to switch device to config m
Hello!
On 29.06.2020 8:24, Yoshihiro Shimoda wrote:
From: Yoshihiro Shimoda, Sent: Tuesday, May 26, 2020 6:47 PM
According to the report of [1], this driver is possible to cause
the following error in ravb_tx_timeout_work().
ravb e680.ethernet ethernet: failed to switch device to config m
s I'm only seeing the formatting issues, here's my:
Reviewed-by: Sergei Shtylyov
> diff --git a/Documentation/devicetree/bindings/net/renesas,etheravb.yaml
> b/Documentation/devicetree/bindings/net/renesas,etheravb.yaml
> new file mode 100644
> index 000
rel: add phy-mode support for
> the KSZ9031 PHY")
> [2] Commit 9b23203c32ee02cd ("ravb: Mask PHY mode to avoid inserting
> delays twice").
>
> Signed-off-by: Geert Uytterhoeven
Reviewed-by: Sergei Shtylyov
> ---
> drivers/net/ethernet/renesas/ravb.h
On 06/19/2020 10:15 PM, Geert Uytterhoeven wrote:
> Currently, full delay handling is done in both the probe and resume
> paths. Split it in two parts, so the resume path doesn't have to redo
> the parsing part over and over again.
>
> Signed-off-by: Geert Uytterhoeven
Hello!
On 06/19/2020 10:15 PM, Geert Uytterhoeven wrote:
> Some EtherAVB variants support internal clock delay configuration, which
> can add larger delays than the delays that are typically supported by
> the PHY (using an "rgmii-*id" PHY mode, and/or "[rt]xc-skew-ps"
> properties).
>
> Add pro
Hello!
On 15.06.2020 8:58, Yoshihiro Shimoda wrote:
From: Yoshihiro Shimoda, Sent: Tuesday, May 26, 2020 6:47 PM
According to the report of [1], this driver is possible to cause
the following error in ravb_tx_timeout_work().
ravb e680.ethernet ethernet: failed to switch device to config m
ff-by: Sergei Shtylyov
---
The patch is against the DaveM's 'net.git' repo.
MAINTAINERS |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: net/MAINTAINERS
===
--- net.orig/MAINTAINERS
+++ net/MAINTAINERS
@@ -1
On 06/01/2020 11:03 PM, Vladimir Oltean wrote:
> Hi Sergei,
>
> On Mon, 1 Jun 2020 at 21:48, Sergei Shtylyov
> wrote:
>>
>> On 06/01/2020 12:58 PM, Vladimir Oltean wrote:
>>
>>> From: Vladimir Oltean
>>>
>>> Sometimes debugging a device
On 06/01/2020 12:58 PM, Vladimir Oltean wrote:
> From: Vladimir Oltean
>
> Sometimes debugging a device is easiest using devmem on its register
> map, and that can be seen with /proc/iomem. But some device drivers have
> many memory regions. Take for example a networking switch. Its memory
> map
Hello!
On 31.05.2020 21:07, Vladimir Oltean wrote:
From: Vladimir Oltean
Sometimes debugging a device is easiest using devmem on its register
map, and that can be seen with /proc/iomem. But some device drivers have
many memory regions. Take for example a networking switch. Its memory
map used
Hello!
On 31.05.2020 7:51, David Miller wrote:
Until recently, the Micrel KSZ9031 PHY driver ignored any PHY mode
("RGMII-*ID") settings, but used the hardware defaults, augmented by
explicit configuration of individual skew values using the "*-skew-ps"
DT properties. The lack of PHY mode supp
Hello!
On 18.05.2020 15:27, Lad, Prabhakar wrote:
Add a device node for the Watchdog Timer (RWDT) controller on the Renesas
RZ/G1H (r8a7742) SoC.
Signed-off-by: Lad Prabhakar
Reviewed-by: Marian-Cristian Rotariu
Thanks for your patch!
--- a/arch/arm/boot/dts/r8a7742.dtsi
+++ b/arch/arm/b
Hello!
On 11.05.2020 14:59, Christoph Hellwig wrote:
Add a variant of CMSG_DATA that operates on user pointer to avoid
sparse warnings about casting to/from user pointers. Also fix up
CMSG_DATA to rely on the gcc extension that allows void pointer
arithmetics to cut down on the amount of casts
Hello!
On 12.05.2020 0:22, Rob Herring wrote:
Sort the items in the compatible string list in increasing number of SoC.
Signed-off-by: Lad Prabhakar
---
Documentation/devicetree/bindings/net/renesas,ether.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks!
M
Hello!
On 01.05.2020 16:43, Colin King wrote:
From: Colin Ian King
The current logic for speed checking will never set the speed to 10 MBPS
because bmcr & BMCR_SPEED10 is always 0 since BMCR_SPEED10 is 0. Also
the erroneous setting where BMCR_SPEED1000 and BMCR_SPEED100 are both
set causes th
Hello!
On 21.10.2019 15:18, Krzysztof Hałasa wrote:
Fix a bug where the mac80211 RX aggregation code sets a new aggregation
"session" at the remote station's request, but the head_seq_num
(the sequence number the receiver expects to receive) isn't reset.
Spotted on a pair of AR9580 in IBSS mod
Hello!
On 10/11/2019 08:15 PM, Sebastian Andrzej Siewior wrote:
> From: Marc Kleine-Budde
>
> With threaded interrupts enabled, the interrupt thread runs as SCHED_RR
> with priority 50. If a user application with a higher priority preempts
> the interrupt thread and tries to shutdown the networ
Hello!
On 09.10.2019 17:15, Peter Fink wrote:
From: Peter Fink
When the MAC address is supplied via device tree or a random
MAC is generated it has to be written to the asix chip in
order to receive any data.
In the previous commit (9fb137a) this line was omitted
It's not how you should
is because the PTP_RISING_EDGE and
> PTP_FALLING_EDGE flags have unclear semantics and each driver seems to
> have interpreted them slightly differently.
>
> Cc: Sergei Shtylyov
> Signed-off-by: Jacob Keller
Reviewed-by: Sergei Shtylyov
[...]
MBR, Sergei
Hello!
On 28.08.2019 19:41, Vlad Buslov wrote:
New local variable "struct flow_block_offload *f" was added to
mlx5e_setup_tc() in recent rtnl lock removal patches. The variable is used
in code that is only compiled when CONFIG_MLX5_ESWITCH is enabled. This
results compilation warning about unus
On 27.08.2019 5:47, Jian Shen wrote:
Some ethernet drivers may call phy_start() and phy_stop() from
ndo_open and ndo_close() respectively.
ndo_open() for consistency.
When network cable is unconnected, and operate like below:
step 1: ifconfig ethX up -> ndo_open -> phy_start ->start
auton
Hello!
On 25.08.2019 1:34, Andrew Lunn wrote:
Russell king
King, with capital K. :-)
maintains phylink, as part of the SFP module support.
However, much of the review work is about drivers swapping from phylib
to phylink. Such changes don't make changes to the phylink core, and
so the F:
Hello!
On 11.08.2019 18:08, Marek Behún wrote:
The mv88e6xxx_port_setup_mac looks if one of the {link, speed, duplex}
parameters is being changed from the current setting, and if not, does
not do anything. This test is wrong in some situations: this method also
has the mode argument, which can
Hello!
Just noticed a comment typo...
On 11.08.2019 6:18, Marek Behún wrote:
Commit 88d6272acaaa ("net: phy: avoid unneeded MDIO reads in
genphy_read_status") broke fixed link DSA port registration in
dsa_port_fixed_link_register_of: the genphy_read_status does not do what
it is supposed to
Hello!
On 07/11/2019 05:27 PM, Oliver Neukum wrote:
> In case no firmware was found, the system would happily read
> and try to load garbage. Terminate the table properly.
>
> Signed-off-by: Oliver Neukum
> Fixes: ce84bb69f50e6 ("libertas USB: convert to asynchronous firmware
> loading")
T
Hello!
On 25.06.2019 11:19, Jose Abreu wrote:
Some DT bindings do not have the PHY handle. Let's fallback to manually
discovery in case phylink_of_phy_connect() fails.
Reported-by: Katsuhiro Suzuki
Fixes: 74371272f97f ("net: stmmac: Convert to phylink and remove phylib logic")
Signed-off-by:
On 19.06.2019 20:40, Vedang Patel wrote:
Currently, etf expects a socket with SO_TXTIME option set for each packet
it encounters. So, it will drop all other packets. But, in the future
commits we are planning to add functionality which where tstamp value will
One of "which" and "where", not
Hello!
On 17.06.2019 22:31, Vedang Patel wrote:
Currently, etf expects a socket with SO_TXTIME option set for each packet
it encounters. So, it will drop all other packets. But, in the future
commits we are planning to add functionality which where tstamp value will
be set by another qdisc. Als
On 06/14/2019 12:36 PM, Sergei Shtylyov wrote:
>> From: "Gustavo A. R. Silva"
>>
>> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
>> where we are expecting to fall through.
>>
>> This patch fixes the following warning:
>&g
Hello!
On 13.06.2019 21:53, Jeff Kirsher wrote:
From: Piotr Marczak
Driver did not check response on LLDP flag change and always returned
SUCCESS.
This patch now checks for an error and returns an error code and has
additional information in the log.
Signed-off-by: Piotr Marczak
Tested-by:
On 13.06.2019 21:53, Jeff Kirsher wrote:
From: "Gustavo A. R. Silva"
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
This patch fixes the following warning:
drivers/net/ethernet/intel/i40e/i40e_xsk.c: In function ‘i40e_run_xdp_zc’:
Hello!
On 31.05.2019 22:18, Robert Hancock wrote:
Some copper SFP modules support both SGMII and 1000BaseX, but some
drivers/devices only support the 1000BaseX mode. Currently SGMII mode is
always being selected as the desired mode for such modules, and this
fails if the controller doesn't supp
Hello!
On 30.05.2019 1:15, Sebastian Andrzej Siewior wrote:
tg3_alloc_rx_data() uses netdev_alloc_frag() for sbk allocation. All
^^^ skb?
callers of tg3_alloc_rx_data() either hold the tp->lock lock (which is
Hello!
On 24.05.2019 23:00, Andrew Lunn wrote:
In order to probe this ethernet interface from the device tree
all physical MMIO regions must be passed as resources. Begin
this rewrite by first passing the port base address as a
resource for all platforms using this driver, remap it in
the drive
Hello!
On 17.05.2019 11:21, we...@ucloud.cn wrote:
From: wenxu
The mlx5e support the lag mode. When add mlx_p0 and mlx_p1 to bond0.
packet received from mlx_p0 or mlx_p1 and in the ingress tc flower
forward to vf0. The tc rule can't be offloaded for the non indr
rejistor block for the bonding
Hello!
It's not "some SoCs", it's only R-Car gen2 and RZ/G1 SoCs.
On 05/15/2019 08:36 AM, Yoshihiro Shimoda wrote:
> The sh_eth_close() resets the MAC and then calls phy_stop()
> so that mdio read access result is incorrect without any error
> according to kernel trace like below:
>
> ifconf
Hello!
On 05/13/2019 04:06 PM, Corentin Labbe wrote:
> When adding more MAC address to a dwmac-sun8i interface, the device goes
Addresses?
> directly in promiscuous mode.
> This is due to IFF_UNICAST_FLT missing flag.
>
> So since the hardware support unicast filtering, let's add IFF_UNICAS
Hello!
On 04/25/2019 04:59 PM, Jiri Pirko wrote:
> From: Jiri Pirko
>
> In order to bus probing to work correctly, register a simple netdevsim
"In order for", perhaps?
> driver implementation.
>
> Signed-off-by: Jiri Pirko
[...]
MBR, Sergei
Hello!
On 25.04.2019 1:33, Andrew Lunn wrote:
marvell_get_sset_count() returns how many statistics counters there
are. If the PHY supports fibre, there are 3, otherwise two.
marvell_get_strings() does not make this distinction, and always
returns 3 strings. This then often results in writing p
On 04/18/2019 04:19 PM, Andrew Lunn wrote:
>>> Let the tag drivers register themselves with the DSA core, keeping
>>> them in a linked list.
>>>
>>> Signed-off-by: Andrew Lunn
>>> ---
>>> include/net/dsa.h | 2 ++
>>> net/dsa/dsa.c | 35 ++-
>>> 2 files chang
On 18.04.2019 5:31, Andrew Lunn wrote:
Let the tag drivers register themselves with the DSA core, keeping
them in a linked list.
Signed-off-by: Andrew Lunn
---
include/net/dsa.h | 2 ++
net/dsa/dsa.c | 35 ++-
2 files changed, 36 insertions(+), 1 deleti
On 17.04.2019 1:57, Jeff Kirsher wrote:
From: Grzegorz Siwik
Removed misleading messages when untrusted VF tries to
add more addresses than NIC limit
Signed-off-by: Grzegorz Siwik
Tested-by: Andrew Bowers
Signed-off-by: Jeff Kirsher
---
drivers/net/ethernet/intel/i40e/i40e_main.c | 21 ++
Hello!
On 02.04.2019 9:16, Steffen Klassert wrote:
Currently we may merge incorrectly a received GSO packet
or a packet with frag_list into a packet sitting in the
gro_hash list. skb_segment() may crash in this case because
the assumptions on the skb layout are not met in this case.
"In th
Hello!
On 03/07/2019 01:24 PM, Simon Horman wrote:
> From: Masaru Nagai
>
> Hardware has the CBS (Credit Based Shaper) which affects only Q3
> and Q2. When updating the CBS settings,
We seem to only write the defaults into TCG, not update them below...
Do we really use TX queues 2/3? I thou
Hello!
On 04.03.2019 8:46, Su Yanjun wrote:
For rcu protected pointers, we'd bettter add '__rcu' for them.
2 t's were enough. :-)
No functional change.
Signed-off-by: Su Yanjun
[...]
MBR, Sergei
Hello!
On 02.03.2019 21:37, Pablo Neira Ayuso wrote:
From: Li RongQing
CONNTRACK_LOCKS is divisor when computer array index, if it is power of
Computing?
2, compiler will optimize modulo operation as bitwise AND, or else
modulo will lower performance.
Suggested-by: Florian Westphal
S
Hello!
On 02.03.2019 0:05, Daniel Borkmann wrote:
Marek reported that he saw an issue with the below snippet in that
timing measurements where off when loaded as unpriv while results
Were?
were reasonable when loaded as privileged:
[...]
uint64_t a = bpf_ktime_get_ns();
u
Hello!
On 01.03.2019 8:56, Su Yanjun wrote:
From: Su Yanjun
Because nf_conntrack_helper_unregister maybe used in an unloadable module,
it uses 'synchronize_rcu' which may cause kernel panic.
According to the artical:
Article?
RCU and Unloadable Modules
https://lwn.net/Articles/217484/
Hello!
On 22.02.2019 6:52, we...@ucloud.cn wrote:
From: wenxu
Current fib_multipath_hash_policy can make hash based on the L3 or
L4. But it only work on the outer IP. So a specific tunnel always
has the same hash value. But a specific tunnel may contain so many
inner connection. However there
Hello!
On 21.02.2019 15:12, Eran Ben Elisha wrote:
From: Aya Levin
Rename devlink health attributes for better reflect the attributes use.
s/for/to/.
Add COUNT prefix on error counter attribute and recovery counter
attribute.
Fixes: 7afe335a8bed ("devlink: Add health get command")
Sig
On 16.02.2019 0:20, Alexey Khoroshilov wrote:
If mv643xx_eth_shared_of_probe() fails, mv643xx_eth_shared_probe()
leaves clk undisabled.
Enabled, that is? :-)
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Alexey Khoroshilov
[...]
MBR, Sergei
Hello!
On 14.02.2019 9:42, Huang Zijiang wrote:
The skb should be freed by dev_consume_skb_any() efx_tx_tso_fallback()
^ in?
when skb is still used. The skb is be replaced by segments, so the
^^ will?
orig
Hello!
On 12.02.2019 10:09, Parav Pandit wrote:
While finding the devlink device during region reading,
devlink device list is accessed and devlink device is
returned without holding a lock. This could lead to user-after-free
Use-after-free, perhaps?
accesses.
While at it, add lockdep a
Hello!
On 11.02.2019 5:13, Ryder Lee wrote:
There is no need to retun 0 in mt76_dma_attach(), so switch it to void.
^ r missing :-)
Signed-off-by: Ryder Lee
[...]
MBR, Sergei
On 02/08/2019 09:55 PM, Sergei Shtylyov wrote:
>> In preparation to enabling -Wimplicit-fallthrough, mark switch
>> cases where we are expecting to fall through.
>>
>> Notice that, in this particular case, the /* fall through */
>> comments are placed at the botto
Hello!
On 02/08/2019 09:44 PM, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch
> cases where we are expecting to fall through.
>
> Notice that, in this particular case, the /* fall through */
> comments are placed at the bottom of the case statement, w
On 05.02.2019 0:31, David Miller wrote:
Here's a set of 7 patches against DaveM's 'net-next.git' repo. I'm implemeting
the simple RX checksum offload (like was done for the 'ravb' driver by Simon
Horman); it has been only tested on the R8A7740 and R8A77980 SoCs, the other
SoCs should just work (
The SH7763 SoC manual describes the Ether MAC's RX checksum offload
the same way as it's implemented in the EtherAVB MACs...
Signed-off-by: Sergei Shtylyov
---
drivers/net/ethernet/renesas/sh_eth.c |1 +
1 file changed, 1 insertion(+)
Index: renesas/drivers/net/ethernet/renesa
The SH7734 SoC manual describes the Ether MAC's RX checksum offload
the same way as it's implemented in the EtherAVB MACs...
Signed-off-by: Sergei Shtylyov
---
drivers/net/ethernet/renesas/sh_eth.c |1 +
1 file changed, 1 insertion(+)
Index: renesas/drivers/net/ethernet/renesa
The R-Car V3H (R8A77980) SoC manual describes the Ether MAC's RX checksum
offload the same way as it's implemented in the EtherAVB MAC...
Signed-off-by: Sergei Shtylyov
---
drivers/net/ethernet/renesas/sh_eth.c |1 +
1 file changed, 1 insertion(+)
Index: renesas/drivers/ne
The R-Mobile A1 (R8A7740) SoC manual describes the Ether MAC's RX checksum
offload the same way as it's implemented in the EtherAVB MAC...
Signed-off-by: Sergei Shtylyov
Tested-by: Geert Uytterhoeven
---
Changes in version 2:
- added Geert's tag.
drivers/net/ethernet/renesas/
1 - 100 of 1466 matches
Mail list logo
