Re: [PATCH/RFC 1/5] dt-bindings: net: renesas,ravb: Document internal clock delay properties

[Sergei Shtylyov]

Hello!

On 06/19/2020 10:15 PM, Geert Uytterhoeven wrote:

> Some EtherAVB variants support internal clock delay configuration, which
> can add larger delays than the delays that are typically supported by
> the PHY (using an "rgmii-*id" PHY mode, and/or "[rt]xc-skew-ps"
> properties).
> 
> Add properties for configuring the internal MAC delays.
> These properties are mandatory, even when specified as zero, to
> distinguish between old and new DTBs.
> 
> Update the example accordingly.
> 
> Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be>
> ---
>  .../devicetree/bindings/net/renesas,ravb.txt  | 29 ++++++++++---------
>  1 file changed, 16 insertions(+), 13 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/renesas,ravb.txt 
> b/Documentation/devicetree/bindings/net/renesas,ravb.txt
> index 032b76f14f4fdb38..488ada78b6169b8e 100644
> --- a/Documentation/devicetree/bindings/net/renesas,ravb.txt
> +++ b/Documentation/devicetree/bindings/net/renesas,ravb.txt
> @@ -64,6 +64,18 @@ Optional properties:
>                        AVB_LINK signal.
>  - renesas,ether-link-active-low: boolean, specify when the AVB_LINK signal is
>                                active-low instead of normal active-high.
> +- renesas,rxc-delay-ps: Internal RX clock delay.
> +                     This property is mandatory and valid only on R-Car Gen3
> +                     and RZ/G2 SoCs.
> +                     Valid values are 0 and 1800.
> +                     A non-zero value is allowed only if phy-mode = "rgmii".
> +                     Zero is not supported on R-Car D3.

   Hm, where did you see about the D3 limitation?

> +- renesas,txc-delay-ps: Internal TX clock delay.
> +                     This property is mandatory and valid only on R-Car H3,
> +                     M3-W, M3-W+, M3-N, V3M, and V3H, and RZ/G2M and RZ/G2N.
> +                     Valid values are 0 and 2000.
> +                     A non-zero value is allowed only if phy-mode = "rgmii".
> +                     Zero is not supported on R-Car V3H.

  Same question about V3H here...

[...]
> @@ -105,8 +117,10 @@ Example:
>                                 "ch24";
>               clocks = <&cpg CPG_MOD 812>;
>               power-domains = <&cpg>;
> -             phy-mode = "rgmii-id";
> +             phy-mode = "rgmii";
>               phy-handle = <&phy0>;
> +             renesas,rxc-delay-ps = <0>;

   Mhm, zero RX delay in RGMII-ID mode?

> +             renesas,txc-delay-ps = <2000>;
>  
>               pinctrl-0 = <&ether_pins>;
>               pinctrl-names = "default";
> @@ -115,18 +129,7 @@ Example:
>               #size-cells = <0>;
>  
>               phy0: ethernet-phy@0 {
> -                     rxc-skew-ps = <900>;
> -                     rxdv-skew-ps = <0>;
> -                     rxd0-skew-ps = <0>;
> -                     rxd1-skew-ps = <0>;
> -                     rxd2-skew-ps = <0>;
> -                     rxd3-skew-ps = <0>;
> -                     txc-skew-ps = <900>;
> -                     txen-skew-ps = <0>;
> -                     txd0-skew-ps = <0>;
> -                     txd1-skew-ps = <0>;
> -                     txd2-skew-ps = <0>;
> -                     txd3-skew-ps = <0>;
> +                     rxc-skew-ps = <1500>;

   Ah, you're relying on a PHY?

[...]

MBR, Sergei