On 06.03, Nicholas Krause wrote:
> This adds the proper snprintf and break statement for formatting
> the vlan_net structure pointer, vn's name using snprintf for if
> the switch case, VLAN_NAME_TYPE_PLUS_VID occurs for this particular
> switch statement inside the function, register_vlan_device.
>
On 30.01, Lucas Tanure wrote:
> As suggested by checkpatch.pl:
> CHECK: Prefer kernel type 'uX' over 'uintX_t'
You might have noticed we have literally hundreds of them spread over 100
files in the netfilter code. We'll gradually change them when the code is
touched anyways.
> net/ipv4/netfilter
On 10.11, Pablo Neira Ayuso wrote:
> On Tue, Nov 10, 2015 at 06:58:05PM +0000, Patrick McHardy wrote:
> > On 10.11, Pablo Neira Ayuso wrote:
> > > On Tue, Nov 10, 2015 at 06:30:34PM +0000, Patrick McHardy wrote:
> > > > > __module_get(src->ops->type-&
On 10.11, Pablo Neira Ayuso wrote:
> On Tue, Nov 10, 2015 at 06:30:34PM +0000, Patrick McHardy wrote:
> > > __module_get(src->ops->type->owner);
> > > - memcpy(dst, src, src->ops->size);
> > > + if (src->ops->clone) {
> > > + m
On 10.11, Pablo Neira Ayuso wrote:
> With the conversion of the counter expressions to make it percpu, we
> need to clone the percpu memory area, otherwise we crash when using
> counters from flow tables.
>
> Signed-off-by: Pablo Neira Ayuso
> ---
> include/net/netfilter/nf_tables.h | 16 +++
On 06.11, Jarno Rajahalme wrote:
> There is no need to help connections that are not confirmed, so we can
> delay helping new connections to the time when they are confirmed.
> This change is needed for NAT support, and having this as a separate
> patch will make the following NAT patch a bit easie
On 06.11, Jarno Rajahalme wrote:
> This series adds NAT support to openvswitch kernel module. A few
> changes are needed to the netfilter code to facilitate this (patches
> 1-3/8). Patches 4-7 make the openvswitch kernel module ready for the
> patch 8 that adds the NAT support for calling into ne
On 09.08, Phil Sutter wrote:
> This is the identical fix as "netfilter: ipt_SYNPROXY: fix sending
> window update to client" but for the IPv6 variant which obviously
> suffers from the same issue.
Looks fine to me.
Acked-by: Patrick McHardy
(Also for the IPv4 version, whic
On 09.08, Phil Sutter wrote:
> This happens when networking namespaces are enabled.
>
> Suggested-by: Patrick McHardy
> Signed-off-by: Phil Sutter
Acked-by: Patrick McHardy
> ---
> Changes since v1:
> - Moved snet param to first place.
> - Constify snet param.
>
On 06.08, Phil Sutter wrote:
> This happens when networking namespaces are enabled.
Thanks, just one minor request:
> synproxy_send_tcp(const struct sk_buff *skb, struct sk_buff *nskb,
> struct nf_conntrack *nfct, enum ip_conntrack_info ctinfo,
> struct ipv6hdr *n
On 28.07, Phil Sutter wrote:
> Hi,
>
> When synproxy_send_server_ack() calls synproxy_send_tcp(), it passes
> NULL as third parameter (struct nf_conntrack *nfct). And the first thing
> synproxy_send_tcp() does, is dereference it:
>
> | struct net *net = nf_ct_net((struct nf_conn *)nfct);
>
> I c
On 30.06, Li Zhijian wrote:
> |ping...
>
> and i have another question:
> can i add a new |||nf_ct_ext_id simply without touching the exiting kernel
> code?|
No, the kernel needs to know the highest extension ID in order to
allocate space for the offsets.
> in order to support COLO-Proxy, i need
On 20.06, Eric W. Biederman wrote:
> Patrick McHardy writes:
>
> > On 20.06, Pablo Neira Ayuso wrote:
> >> On Fri, Jun 19, 2015 at 02:03:39PM -0500, Eric W. Biederman wrote:
> >> >
> >> > Add code to nf_unregister_hook to flush the nf_queue when a
On 20.06, Pablo Neira Ayuso wrote:
> On Fri, Jun 19, 2015 at 02:03:39PM -0500, Eric W. Biederman wrote:
> >
> > Add code to nf_unregister_hook to flush the nf_queue when a hook is
> > unregistered. This guarantees that the pointer that the nf_queue code
> > retains into the nf_hook list will rema
On 17.06, Eric W. Biederman wrote:
> From: Eric W Biederman
>
> Signed-off-by: "Eric W. Biederman"
> ---
> net/netfilter/core.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/net/netfilter/core.c b/net/netfilter/core.c
> index 95456c09cf69..1b4eadc9c030 100644
> --
On 25.05, Pablo Neira Ayuso wrote:
> diff --git a/include/rule.h b/include/rule.h
> index 97959f7..06ec2ff 100644
> --- a/include/rule.h
> +++ b/include/rule.h
> @@ -72,6 +72,7 @@ enum table_flags {
> *
> * @list:list node
> * @handle: table handle
> + * @dev: network device name (on
On 30.04, Daniel Borkmann wrote:
> On 04/30/2015 02:37 AM, Patrick McHardy wrote:
> >On 30.04, Pablo Neira Ayuso wrote:
> >>On the bugfix front, the illegal mangling of shared skb from actions
> >>like stateless nat and bpf look also important to be addressed to me.
>
On 30.04, Daniel Borkmann wrote:
> >
> >I can also see there were also intentions to support userspace
> >queueing at some point since TC_ACT_QUEUED has been there since the
> >beginning. That should be possible at some point using this
> >infrastructure (once there are no further concerns on the
On 29.04, Cong Wang wrote:
> On Wed, Apr 29, 2015 at 11:53 AM, Pablo Neira Ayuso
> wrote:
> > diff --git a/net/sched/Kconfig b/net/sched/Kconfig
> > index 2274e72..23b57da 100644
> > --- a/net/sched/Kconfig
> > +++ b/net/sched/Kconfig
> > @@ -312,6 +312,7 @@ config NET_SCH_PIE
> > config NET_SCH
On 17.04, Hannes Frederic Sowa wrote:
>
>
> On Thu, Apr 16, 2015, at 22:56, Patrick McHardy wrote:
> > On 17.04, Herbert Xu wrote:
> > > On Thu, Apr 16, 2015 at 06:13:25PM +0200, Hannes Frederic Sowa wrote:
> > > >
> > > > So currently we have o
On 17.04, Herbert Xu wrote:
> On Thu, Apr 16, 2015 at 06:13:25PM +0200, Hannes Frederic Sowa wrote:
> >
> > So currently we have one fast path, that is: we are not fragmented, we
> > get out non-fragmented, none of this code is ever touched and no
> > problem.
> >
> > We don't want to mak this mor
On 16.04, David Miller wrote:
> > Netfilter may change the contents of the packet, even change its size.
> > It is *really* hard to do this while keeping the original fragments
> > intact.
>
> I keep hearing a lot of "it's hard" as the only reason we shouldn't do
> this properly, and that frankly
Am 16. April 2015 17:43:23 MESZ, schrieb David Miller :
>From: Hannes Frederic Sowa
>Date: Thu, 16 Apr 2015 14:11:42 +0200
>
>> On Thu, Apr 16, 2015, at 07:29, Herbert Xu wrote:
>>> On Thu, Apr 16, 2015 at 06:24:00AM +0100, Patrick McHardy wrote:
>>> >
>&g
On 15.04, Jesper Dangaard Brouer wrote:
> > Out of curiosity, what is actually the performance impact on all
> > of this? We were just arguing on a different matter on two more
> > instructions in the fast-path, here it's refactoring the whole
> > function into several ones, I presume gcc won't inl
On 16.04, Herbert Xu wrote:
> On Thu, Apr 16, 2015 at 06:24:00AM +0100, Patrick McHardy wrote:
> >
> > Netfilter may change the contents of the packet, even change its size.
> > It is *really* hard to do this while keeping the original fragments
> > intact.
>
>
On 16.04, Herbert Xu wrote:
> David Miller wrote:
> >
> > Because then there is no ambiguity at all, you preserve on output
> > exactly what you had on input. The same geometry, the same
> > everything. No special checks, no max frag len, none of this crap.
> > Those are all hacks trying to wor
[MACVLAN]: Update Kconfig to refer to iproute
Since the macvlan release I had at least 5 users asking how to configure
it since the old userspace tool doesn't work with the version in the
kernel. Add a pointer to the Kconfig help.
Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]>
d
Alexey Dobriyan wrote:
Patch splits creation of /proc/net/nf_conntrack, /proc/net/stat/nf_conntrack
and net.netfilter hierarchy into their own functions with dummy ones
if PROC_FS or SYSCTL is not set. Also, remove dead "ret = 0" write
while I'm at it.
Queued for 2.6.26, thanks.
--
To unsubscri
David Woodhouse wrote:
On Mon, 2008-02-25 at 13:20 +0100, Patrick McHardy wrote:
Right, I missed that. In that case the current headers should match
the kernel headers (with the compiler.h part removed).
They don't. When you run 'make headers_install' there are some missing.
David Woodhouse wrote:
On Mon, 2008-02-25 at 13:12 +0100, Patrick McHardy wrote:
Yes, the kernel headers need to be fixed as well to not include
linux/compiler.h outside of #ifdef __KERNEL__. I'll take care
of that.
No. When you run 'make headers_install' that's a
David Woodhouse wrote:
On Fri, 2008-02-22 at 16:44 +0100, Patrick McHardy wrote:
Pablo Neira Ayuso wrote:
Patrick McHardy wrote:
Yes, that was a bug in the lastest release. We need to
release a 1.4.1 version or something like that, but I'm
not too familiar with the release process,
David Miller wrote:
From: Patrick McHardy <[EMAIL PROTECTED]>
Date: Thu, 21 Feb 2008 19:00:03 +0100
And adds back the overhead of two completely unnecessary
function calls to the VLAN fastpath. How about just
stopping this idiocy and reverting the appropriate patches
to bring back M
Pablo Neira Ayuso wrote:
Patrick McHardy wrote:
Pablo Neira Ayuso wrote:
Patrick McHardy wrote:
Yes, that was a bug in the lastest release. We need to
release a 1.4.1 version or something like that, but I'm
not too familiar with the release process, so I haven't
done this so f
Pablo Neira Ayuso wrote:
Patrick McHardy wrote:
Yes, that was a bug in the lastest release. We need to
release a 1.4.1 version or something like that, but I'm
not too familiar with the release process, so I haven't
done this so far.
I can schedule one for this weekend, just send
David Woodhouse wrote:
On Tue, 2008-02-19 at 15:45 +0100, Patrick McHardy wrote:
That would break iptables compilation, which already includes
linux/in.h in some files. I guess the best fix for now is to
include netinet/in.h in busybox and long-term clean this up
properly.
It looks like
David Woodhouse wrote:
On Fri, 2008-02-22 at 16:52 +0900, David Woodhouse wrote:
It looks like iptables is fairly broken anyway:
make[1]: Entering directory
`/home/dwmw2/working/extras/iptables/devel/iptables-1.4.0'
Unable to resolve dependency on linux/compiler.h. Try 'make clean'.
And if I
Thomas Graf wrote:
RTM_NEWLINK allows for already existing links to be modified. For this
purpose do_setlink() is called which expects address attributes with a
payload length of at least dev->addr_len. This patch adds the necessary
validation for the RTM_NEWLINK case.
The address length for lin
Phil Oester wrote:
In commit 56addd6eeeb4e11f5a0af7093ca078e0f29140e0 the VLAN multicast list
handling was reworked. Unfortunately, a variable initialization was missed,
and multicast over vlan devices has been broken since 2.6.23-rc1 (apparently
not too many people use this). Trivial fix below
Patrick McHardy wrote:
Joe Perches wrote:
This removes the __pure from print_mac, so reject as appropriate...
Add some type safety to print_mac by using struct print_mac_buf *
instead of char *.
And adds back the overhead of two completely unnecessary
function calls to the VLAN fastpath
Joe Perches wrote:
On Thu, 2008-02-21 at 11:17 +0100, Johannes Berg wrote:
Yeah, I saw that discussion. I think it's fine, it's just something we
need to be aware of. In fact, I Joe had a patch (that seems to have
gotten lost?) to make DECLARE_MAC_BUF() declare a structure with the u8
pointer
David Miller wrote:
From: Harvey Harrison <[EMAIL PROTECTED]>
Date: Thu, 21 Feb 2008 02:01:19 -0800
In this case, it's being passed to a debugfs create function, could it
instead use sysfs_format_mac?
Just assigning print_mac() to a local variable then passing that to
debugfs_create_dir() wil
Stephen Hemminger wrote:
On Thu, 21 Feb 2008 12:28:50 +0100
Patrick McHardy <[EMAIL PROTECTED]> wrote:
diff --git a/net/netfilter/nf_conntrack_core.c
b/net/netfilter/nf_conntrack_core.c
index 327e847..b77eb56 100644
--- a/net/netfilter/nf_conntrack_core.c
+++ b/net/net
Pavel Emelyanov wrote:
Patrick McHardy wrote:
Pavel Emelyanov wrote:
Patrick McHardy wrote:
It would be nicer to replace the entire hand-made name
allocation to remove the 100 device limit.
Actually, I thought the same, but fixing % in names looks like a
BUG-fix for 2.6.25, while removing
Pavel Emelyanov wrote:
Patrick McHardy wrote:
It would be nicer to replace the entire hand-made name
allocation to remove the 100 device limit.
Actually, I thought the same, but fixing % in names looks like a
BUG-fix for 2.6.25, while removing the hand-made name allocation
looks like an
Pavel Emelyanov wrote:
Four tunnel drivers (ip_gre, ipip, ip6_tunnel and sit) can
receive a pre-defined name for a device from the userspace.
Since these drivers call the register_netdevice() after this
(rtnl_lock is held), the device's name may contain a '%'
character.
Not sure how bad is th
David Woodhouse wrote:
On Tue, 2008-02-19 at 15:45 +0100, Patrick McHardy wrote:
That would break iptables compilation, which already includes
linux/in.h in some files. I guess the best fix for now is to
include netinet/in.h in busybox and long-term clean this up
properly.
Yeah, that makes
736b33102292be0d75be1e950ca9bcd5361db7dd
Author: Patrick McHardy <[EMAIL PROTECTED]>
Date: Thu Feb 21 12:26:01 2008 +0100
[NETFILTER]: nf_conntrack: fix smp_processor_id() in preemptible code
warning
Since we're using RCU for the conntrack hash now, we need to avoid
n just signoff on this and I can
put it directly into my tree.
Good catch indeed, thanks.
Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
David Miller wrote:
From: Patrick McHardy <[EMAIL PROTECTED]>
Date: Thu, 21 Feb 2008 00:15:13 +0100
I missed those discussions, but this has already been agreed on,
fine by me. It would still be preferable to use queue_mapping
instead of priority IMO, even if its activated by a
David Miller wrote:
From: Patrick McHardy <[EMAIL PROTECTED]>
Date: Thu, 21 Feb 2008 00:08:52 +0100
Ramkrishna Vepa wrote:
Sreenivasa Honnur wrote:
- Resubmit #2
- Transmit fifo selection based on TCP/UDP ports.
- Added tx_steering_type loadable parameter for tr
Ramkrishna Vepa wrote:
Sreenivasa Honnur wrote:
- Resubmit #2
- Transmit fifo selection based on TCP/UDP ports.
- Added tx_steering_type loadable parameter for transmit fifo
selection.
0x0 NO_STEERING: Default FIFO is selected.
0x1 TX_PRIORITY_STEERING: FIFO is selected base
Sreenivasa Honnur wrote:
- Resubmit #2
- Transmit fifo selection based on TCP/UDP ports.
- Added tx_steering_type loadable parameter for transmit fifo selection.
0x0 NO_STEERING: Default FIFO is selected.
0x1 TX_PRIORITY_STEERING: FIFO is selected based on skb->priority.
0x2 TX_DEFAULT_STEE
Tilman Schmidt wrote:
Still, X came up fine, I could log in (Gnome feeling subjectively
a bit sluggish), call up a web page from the Internet in Firefox,
and start perusing the logs, when the whole system froze: neither
mouse nor keyboard would react anymore, and only the Wind^Wreset
button would
Jan Engelhardt wrote:
On Feb 20 2008 15:47, Ilpo Järvinen wrote:
-23668 392 funcs, 104 +, 23772 -, diff: -23668 --- dev_alloc_skb
-static inline struct sk_buff *dev_alloc_skb(unsigned int length)
-{
- return __dev_alloc_skb(length, GFP_ATOMIC);
-}
+extern struct sk_buff *dev_alloc_skb(un
Joe Perches wrote:
On Wed, 2008-02-20 at 07:29 -0800, Joe Perches wrote:
fs/nfsd/nfsproc.c: char buf[RPC_MAX_ADDRBUFLEN];
Perhaps there should be a DECLARE_RPC_BUF(buf) macro?
#define DECLARE_RPC_BUF(var) char var[MAC_BUF_SIZE] __maybe_unused
Make that:
#define DECLARE_RP
Ilpo Järvinen wrote:
~500 files changed
...
kernel/uninlined.c:
skb_put | +104
1 function changed, 104 bytes added, diff: +104
vmlinux.o:
869 functions changed, 198 bytes added, 111003 bytes removed, diff: -110805
This change is INCOMPLETE, I think that the call to cur
Ben Greear wrote:
Stephen Anderson wrote:
Hello,
To help increase throughput and bypass the backlog queue, I changed the
netif_rx() to netif_receive_skb() in vlan_skb_recv(). What's the
argument for using netif_rx() other than legacy maintenance? At this
point, interrupt context should not be
Signed-off-by: Jorge Boncompte [DTI2] <[EMAIL PROTECTED]>
Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]>
diff --git a/net/core/dev.c b/net/core/dev.c
index 6cfc123..9516105 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -2900,7 +2900,7 @@ int __dev_addr_add(stru
Reither Robert wrote:
Visit AVD on prolight+sound in Frankfurt from 12.-15. March 2008 - Hall 8.0,
Stand G16
Hurray, your patch does the trick for me !!!
Now join/leave und receiving of multicasts work like it should !!
David Woodhouse wrote:
On Tue, 2008-02-19 at 15:01 +0100, Patrick McHardy wrote:
David Woodhouse wrote:
+union nf_inet_addr {
+ u_int32_t all[4];
+ __be32 ip;
+ __be32 ip6[4];
+};
+
#ifdef __KERNEL__
#ifdef CONFIG_NETFILTER
This breaks the busybox
ul's suggestion and added a new scheduler
(DRR) for this with more flexible limits.
I'll rediff against net-2.6.26 within the next days and send
a final version for review (anyone interested is welcome to
already review this version of course :).
commit 13d0cc64d0f7fed945c357cf4ca4333
Denis V. Lunev wrote:
They do exactly the same job.
Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]>
---
net/ipv4/netfilter/ipt_MASQUERADE.c | 14 ++
1 files changed, 2 insertions(+), 12 deletions(-)
Looks fine.
--
To unsubscribe from this list: send the line "unsubscribe netde
TECTED]>
Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]>
diff --git a/net/core/dev.c b/net/core/dev.c
index 6cfc123..9516105 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -2900,7 +2900,7 @@ int __dev_addr_add(struct dev_addr_list **list, int
*count,
}
ian busybox source.
How is this supposed to be used in userspace? Or is it even supposed to
be exposed?
Yes, its meant to replace many self-made "AF-independant" address
representations.
commit 6f2e68f81457d72bdb14a7ead305a1da06e78893
Author: Patrick McHardy <[EMAIL PROTECTED]
David Miller wrote:
From: Joonwoo Park <[EMAIL PROTECTED]>
Date: Tue, 19 Feb 2008 11:53:24 +0900
[PATCH] netfilter: fix incorrect use of skb_make_writable
http://bugzilla.kernel.org/show_bug.cgi?id=9920
The function skb_make_writable returns true or false.
Signed-off-by: Joonwoo Park <[EMAIL
David Miller wrote:
From: David Miller <[EMAIL PROTECTED]>
Date: Mon, 18 Feb 2008 16:43:05 -0800 (PST)
I think we can fix this easily by using __attribute_const_
on the print_mac() declaration. Let me play with that.
Actually it seems the 'pure' attribute is more important
here. Although it
Joe Perches wrote:
On Mon, 2008-02-18 at 16:19 +0100, Patrick McHardy wrote:
@@ -404,11 +405,8 @@ static int vlan_dev_hard_start_xmit(struct sk_buff *skb,
struct net_device *dev)
pr_debug("%s: about to send skb: %p to dev: %s\n",
__FUNCTION__, skb, skb-
David Miller wrote:
From: Patrick McHardy <[EMAIL PROTECTED]>
Date: Mon, 18 Feb 2008 16:19:40 +0100
Joe Perches wrote:
We specifically removed this sort of thing, please don't
add it back.
Why?
We converted the entire tree over the print_mac(), and since
Joe Perches wrote:
On Fri, 2008-02-15 at 02:58 -0800, David Miller wrote:
From: Bruno Randolf <[EMAIL PROTECTED]>
Date: Fri, 15 Feb 2008 19:48:05 +0900
is there any chance to include a macro like this for printing mac
addresses?
its advantage is that it can be used without the need to declare
Adrian Bunk wrote:
This patch removes the no longer used include/linux/netfilter_ipv4/ipt_SAME.h
We kept it around because old iptables binaries need it to build.
The kernel no longer supports it, but people might still wish to
use a distributor-built iptables binary with old kernels. It will
David Miller wrote:
From: Jan Engelhardt <[EMAIL PROTECTED]>
Date: Sun, 10 Feb 2008 22:02:35 +0100 (CET)
I have been unable to reach the netfilter and net maintainers the past
week regarding inclusion of patches, but most importantly a group of
fixes at [0]-[3]. I am kind of at a loss here but
commit dad61a4af7d23146ce67ec2f069f6ba9b75a578d
Author: Patrick McHardy <[EMAIL PROTECTED]>
Date: Wed Feb 6 14:35:11 2008 +0100
[IPV4]: route: fix crash ip_route_input
ip_route_me_harder() may call ip_route_input() with skbs that don't
have skb->dev set for sk
commit 94e9cba778cb97d77d9146dc3bd38ff195bc2c8a
Author: Patrick McHardy <[EMAIL PROTECTED]>
Date: Sat Feb 2 18:22:16 2008 +0100
[IPROUTE]: cls_flow: add vlan-tag support
Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]>
diff --git a/include/linux/pkt_cls.h b/i
[NET_SCHED]: cls_flow: support classification based on VLAN tag
Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]>
---
commit 104092e6d90cba5fa00902a3154155872d693f42
tree 0e3fd5871a861fa022bbc2f34d314bb8672b556a
parent 03faf81b8195be455c3c7592d76d712ea9d80b13
author Patrick McHardy &
[VLAN]: Constify skb argument to vlan_get_tag()
Required by next patch to use it from the flow classifier.
Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]>
---
commit 03faf81b8195be455c3c7592d76d712ea9d80b13
tree 9da377d2bd44421494a4c4d7cf6c705d199c26ce
[NET_SCHED]: em_meta: fix compile warning
net/sched/em_meta.c: In function 'meta_int_vlan_tag':
net/sched/em_meta.c:179: warning: 'tag' may be used uninitialized in this
function
Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]>
---
commit adfab462c5e0a32
[NET_SCHED]: cls_flow: fix key mask validity check
Since we're using fls(), we need to check whether the value is non-zero first.
Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]>
---
commit 2e5915ef51e55135522e59e041bb176432857d82
tree 9a42fac3d1646a378acdc91b55642b68c9d9
/em_meta.c |2 +-
4 files changed, 21 insertions(+), 6 deletions(-)
Patrick McHardy (4):
[NET_SCHED]: em_meta: fix compile warning
[NET_SCHED]: cls_flow: fix key mask validity check
[VLAN]: Constify skb argument to vlan_get_tag()
[NET_SCHED]: cls_flow: support
David Miller wrote:
From: Stephen Hemminger <[EMAIL PROTECTED]>
Date: Thu, 31 Jan 2008 21:50:25 -0800
On Fri, 01 Feb 2008 06:34:34 +0100
Patrick McHardy <[EMAIL PROTECTED]> wrote:
Stephen Hemminger wrote:
Provide a way to use tc filters on vlan tag even if tag is buried i
Corey Hickey wrote:
Patrick McHardy wrote:
These patches add support for external classifiers to SFQ and add a
new "flow" classifier, which can do hashing based on user-specified
keys or deterministic mapping of keys to classes. Additionally there
is a patch to make the SFQ queues v
Chuck Ebbert wrote:
On 01/31/2008 01:03 PM, Chuck Ebbert wrote:
On 01/29/2008 12:18 PM, Patrick McHardy wrote:
Chuck Ebbert wrote:
nf_nat_move_storage():
/usr/src/debug/kernel-2.6.23/linux-2.6.23.i686/net/ipv4/netfilter/nf_nat_core.c:612
87: f7 47 64 80 01 00 00testl
Chuck Ebbert wrote:
On 01/31/2008 01:03 PM, Chuck Ebbert wrote:
On 01/29/2008 12:18 PM, Patrick McHardy wrote:
Chuck Ebbert wrote:
nf_nat_move_storage():
/usr/src/debug/kernel-2.6.23/linux-2.6.23.i686/net/ipv4/netfilter/nf_nat_core.c:612
87: f7 47 64 80 01 00 00testl
Waskiewicz Jr, Peter P wrote:
Indeed. As an example of an unknowing user, this discussion
made me check whether my cablemodem device (on which I'm
using HFSC) uses TSO :)
The TSO defer logic is based on your congestion window and current
window size. So the actual frame sizes hitting your NIC
Andi Kleen wrote:
The problem with ethtool is that it's a non-obvious nerd knob. At
the least the ethtool documentation should be updated to indicate that
activating TSO effects tc accuracy.
TSO tends to be activated by default in the driver; very few people who use it
do even know that ethto
David Miller wrote:
From: Patrick McHardy <[EMAIL PROTECTED]>
Date: Wed, 30 Jan 2008 21:04:33 +0100
Adrian Bunk wrote:
This patch #if 0's the following no longer used functions:
- rtattr_parse()
- rtattr_strlcpy()
- __rtattr_parse_nested_compat()
Please remove them instea
Glen Turner wrote:
On Thu, 2008-01-31 at 20:34 +0100, Andi Kleen wrote:
The philosophical problem I have with this suggestion is that I expect
that the large majority of users will be more happy with disabled TSO
if they use non standard qdiscs and defaults that do not fit
the majority use cas
Stephen Hemminger wrote:
Provide a way to use tc filters on vlan tag even if tag is buried in
skb due to hardware acceleration.
Looks reasonable. Would you like to add the same feature to the
flow classifier?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a
Waskiewicz Jr, Peter P wrote:
Well, it could be just that when using such qdiscs TSO would be
disabled, but the user could override this by using ethtool after
loading the qdiscs.
I still disagree with this. The qdisc should not cause anything to happen to
feature flags on the device. It's th
Andi Kleen wrote:
On Thu, Jan 31, 2008 at 07:21:20PM +0100, Patrick McHardy wrote:
Andi Kleen wrote:
Then change TBF to use skb_gso_segment? Be careful, the fact that
That doesn't help because it wants to interleave packets
>from different streams to get everything fair and smooth.
Patrick McHardy wrote:
Andi Kleen wrote:
Can you please try with the above config?
I'll give it a try later.
I took all options from that config that seemed possibly
related (qdiscs, no hrtimers, no nohz, slab, ...), but
still can't reproduce it.
Does it also crash if yo
Andi Kleen wrote:
Then change TBF to use skb_gso_segment? Be careful, the fact that
That doesn't help because it wants to interleave packets
from different streams to get everything fair and smooth. The only
good way to handle that is to split it up and the simplest way to do
this is to just
Stephen Hemminger wrote:
On Thu, 31 Jan 2008 19:37:35 +0100
Andi Kleen <[EMAIL PROTECTED]> wrote:
On Thu, Jan 31, 2008 at 07:01:00PM +0100, Patrick McHardy wrote:
Andi Kleen wrote:
Fix the broken qdisc instead.
What do you mean? I don't think the qdiscs are broken.
I cannot think
[IPROUTE]: Add flow classifier support
Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]>
---
commit ac3df2d7e37826b06cc9093f50d829a9da1873a4
tree b33a2b29abdcea0267fe7a357d282a4c2f67124b
parent 196870f762ee393438c42115425f4af69e5b5186
author Patrick McHardy <[EMAIL PROTECTED]> Thu,
Andi Kleen wrote:
Fix the broken qdisc instead.
What do you mean? I don't think the qdiscs are broken.
I cannot think of any way how e.g. TBF can do anything useful
with large TSO packets.
Someone posted a patch some time ago to calculate the amount
of tokens needed in max_size portions and
[IPROUTE]: Add support for SFQ xstats
Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]>
---
commit 196870f762ee393438c42115425f4af69e5b5186
tree 5650c1f93cc58886f8f97a0e55e374c157b96e2e
parent 54bb35c69cec6c730a4ac95530a1d2ca6670f73b
author Patrick McHardy <[EMAIL PROTECTED]> Thu,
. flow map \
key dst and 0xff
- similar, but reverse ordered:
tc filter add ... flow map \
key dst and 0xff xor 0xff
Perturbation is currently not supported because we can't reliable kill the
timer on destruction.
Signed-off-by: Patrick McHardy <[EMAIL PROTE
[NET_SCHED]: sch_sfq: add support for external classifiers
Add support for external classifiers to allow using different flow hash
functions similar to ESFQ. When no classifier is attached the built-in
hash is used as before.
Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]>
---
[NET_SCHED]: sch_sfq: make internal queues visible as classes
Add support for dumping statistics and make internal queues visible
as classes.
Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]>
---
commit 7a281f8ef334a35d699682315e9f80a3e006376c
tree 0a2cbd55e22f1913e9cf0cc28da2956952
/cls_u32.c |2 +-
net/sched/sch_sfq.c | 134 +-
13 files changed, 868 insertions(+), 15 deletions(-)
create mode 100644 net/sched/cls_flow.c
Patrick McHardy (4):
[NET_SCHED]: Constify struct tcf_ext_map
[NET_SCHED]: sch_sfq: add support for external classifiers
[NET_SCHED]: Constify struct tcf_ext_map
Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]>
---
commit 12e33ddf57910b685501df10bd92223ea9b98fd6
tree 1ce47c7b6b6b968940f3dc28f9d7839e78c85089
parent 8af03e782cae1e0a0f530ddd22301cdd12cf9dc0
author Patrick McHardy <[EMAIL PROTECTED]>
1 - 100 of 1911 matches
Mail list logo
