[PATCH] Fix tcp_v4_send_synack() comment

Hey everyone, I've attached a patch that fixes the comment above tcp_v4_send_synack() in ipv4/tcp_ipv4.c. Signed-off-by: Kris Katterjohn <[EMAIL PROTECTED]> Thanks, Kris Katterjohn --- net/ipv4/tcp_ipv4.c 2008-02-10 23:51:11.0 -0600 +++ net/ipv4/tcp_ipv4.c 2008-

[PATCH] Reorder ACK/RST checking in LISTEN state

CK and RST checking is reversed, __kfree_skb() is called in tcp_rcv_state_process() because of the RST and the function returns 0, which skips that other useless stuff. This is the order specified on page 65 of RFC 793 anyway. Signed-off-by: Kris Katterjohn <[EMAIL PROTECTED]> Thanks, Kris Ka

[PATCH (final?)] Additional options for resetting packet statistics

Okay, it's probably now or never for this patch :) Signed-off-by: Kris Katterjohn <[EMAIL PROTECTED]> Signed-off-by: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> --- x/net/packet/af_packet.c2006-01-25 22:18:41.0 -0600 +++ y/net/packet/af_packet.c2006-01-25 22:18:5

Re: [PATCH (ready to apply?)] Additional options forresettingpacket statistics

From: YOSHIFUJI Hideaki Sent: 1/25/2006 7:50:55 PM > In article <[EMAIL PROTECTED]> (at Wed, 25 Jan 2006 19:46:07 -0800), "Kris > Katterjohn" <[EMAIL PROTECTED]> says: > > > @@ -1399,6 +1423,17 @@ static int packet_getsockopt(struc

Re: [PATCH (ready to apply?)] Additional options for resettingpacket statistics

From: Herbert Xu Sent: 1/25/2006 6:45:50 PM > Kris Katterjohn <[EMAIL PROTECTED]> wrote: > > > > @@ -1021,6 +1025,7 @@ static int packet_create(struct socket * > >po = pkt_sk(sk); > >sk->sk_family = PF_PACKET; > >po->num = p

[PATCH (ready to apply?)] Additional options for resetting packet statistics

From: YOSHIFUJI Hideaki Sent: 1/25/2006 1:34:19 PM > Hello. > > In article <[EMAIL PROTECTED]> (at Wed, 25 Jan 2006 09:13:26 -0800), "Kris > Katterjohn" <[EMAIL PROTECTED]> says: > > > > + > > + case PACKET_ACCUMULATE_STATISTICS: > &g

Re: [PATCH] Additional options for resetting packet statistics

From: YOSHIFUJI Hideaki Sent: 1/25/2006 7:32:09 AM > Hello. > > In article <[EMAIL PROTECTED]> (at Tue, 24 Jan 2006 16:38:26 -0800), "Kris > Katterjohn" <[EMAIL PROTECTED]> says: > > > + if (optlen != sizeof val) >

Re: [PATCH] Additional options for resetting packet statistics

ease provide getsockopt side. Thanks. > > --yoshfuji This compiled fine, but is untested do to -rc1-git4 totally screwing up. It let me do almost nothing. I could test it on an earlier version (say -rc1) if it would be useful. I wasn't exactly sure what to do when writing the getso

Re: [PATCH] Additional options for resetting packet statistics

From: Kris Katterjohn Sent: 1/24/2006 4:38:26 PM > --- x/include/linux/if_packet.h 2006-01-24 18:27:41.0 -0600 > +++ y/include/linux/if_packet.h 2006-01-24 17:50:02.0 -0600 > @@ -37,8 +37,9 @@ struct sockaddr_ll > #define PACKET_RECV_OUTPUT 3 >

Re: [PATCH] Fix some whitespace issues in af_packet.c

From: Herbert Xu Sent: 1/20/2006 8:04:08 PM > Kris Katterjohn <[EMAIL PROTECTED]> wrote: > > This fixes some whitespace issues in af_packet.c > > > > Signed-off-by: Kris Katterjohn <[EMAIL PROTECTED]> > > > > Thanks. > > > > --- x/net/

[PATCH] Add KERN_INFO to printk()s in pktgen.c

This adds KERN_INFO to bare printk()s in pktgen.c Signed-off-by: Kris Katterjohn <[EMAIL PROTECTED]> Thanks. --- x/net/core/pktgen.c 2006-01-20 21:51:08.0 -0600 +++ y/net/core/pktgen.c 2006-01-20 21:51:03.0 -0600 @@ -415,7 +415,7 @@ static inline __u64 tv_to_us(const

Re: [PATCH] Fix some whitespace issues in af_packet.c

From: Joe Perches Sent: 1/20/2006 7:21:59 PM > On Fri, 2006-01-20 at 17:44 -0800, Ben Greear wrote: > > Kris Katterjohn wrote: > > > This fixes some whitespace issues in af_packet.c > > Perhaps this instead? > > Whitespace > comment wrapping to < 80 columns &

[PATCH] Fix some whitespace issues in af_packet.c

This fixes some whitespace issues in af_packet.c Signed-off-by: Kris Katterjohn <[EMAIL PROTECTED]> Thanks. --- x/net/packet/af_packet.c2006-01-18 15:16:05.0 -0600 +++ y/net/packet/af_packet.c2006-01-20 18:53:18.0 -0600 @@ -365,7 +365,7 @@ static int packet_sendms

[PATCH] Fix more whitespace issues in net/core/filter.c

This fixes some whitespace issues in net/core/filter.c Signed-off-by: Kris Katterjohn <[EMAIL PROTECTED]> Thanks. --- x/net/core/filter.c 2006-01-20 18:15:19.0 -0600 +++ y/net/core/filter.c 2006-01-20 18:48:48.0 -0600 @@ -64,7 +64,7 @@ static inline void *load_pointer(

Re: [PATCH] Put SKF_* definitions inside '#ifdef __KERNEL__' in linux/filter.h

From: Herbert Xu Sent: 1/20/2006 1:51:56 AM > Kris Katterjohn <[EMAIL PROTECTED]> wrote: > > This wraps '#ifdef __KERNEL__' around the definitions for SKF_* in > > linux/filter.h > > Why? The whole point these macros are here is so that user-space can >

[PATCH] Put SKF_* definitions inside '#ifdef __KERNEL__' in linux/filter.h

This wraps '#ifdef __KERNEL__' around the definitions for SKF_* in linux/filter.h Signed-off-by: Kris Katterjohn <[EMAIL PROTECTED]> Thanks. --- x/include/linux/filter.h2006-01-18 15:16:02.0 -0600 +++ y/include/linux/filter.h2006-01-19 20:44:06.0 -0600

Re: [PATCH] Remove MANY unneeded header files in net/core/filter.c

From: Herbert Xu Sent: 1/18/2006 4:02:18 PM > On Wed, Jan 18, 2006 at 02:15:37PM -0800, Kris Katterjohn wrote: > > > > #include > > #include > > -#include > > OK. > > > -#include > > Needed for GFP_*. Replace this with gfp.h if you want

Re: [PATCH] Remove MANY unneeded header files in net/core/filter.c

From: Herbert Xu Sent: 1/18/2006 12:26:12 PM > On Wed, Jan 18, 2006 at 06:42:06AM -0800, Kris Katterjohn wrote: > > > > Since it can't be a module and is always built in, we can just remove the > > EXPORT_SYMBOL()s, right? > > No, these are there so that othe

Re: [PATCH] Remove MANY unneeded header files in net/core/filter.c

From: Herbert Xu Sent: 1/18/2006 1:28:38 AM > Kris Katterjohn <[EMAIL PROTECTED]> wrote: > > > > -#include > > Well I decided to double-check your patch. It seems that the very first > removal is bogus. This file is needed for EXPORT_SYMBOL. > > Please re

Re: [PATCH] Remove MANY unneeded header files in net/core/filter.c

From: David S. Miller Sent: 1/17/2006 3:18:08 PM > From: "Kris Katterjohn" <[EMAIL PROTECTED]> > Date: Tue, 17 Jan 2006 09:03:22 -0800 > > > Are there any headers I'm deleting that _should_ be there, but not > > necessarily required for a clean compila

[PATCH] Use is_zero_ether_addr() in net/core/netpoll.c

This replaces a memcmp() with is_zero_ether_addr(). Signed-off-by: Kris Katterjohn <[EMAIL PROTECTED]> Thanks! --- x/net/core/netpoll.c2006-01-17 08:25:32.0 -0600 +++ y/net/core/netpoll.c2006-01-17 15:45:01.0 -0600 @@ -703,7 +703,7 @@ int netpoll_setup(

[PATCH] Remove MANY unneeded header files in net/core/filter.c

This removes many unneeded header files in net/core/filter.c Signed-off-by: Kris Katterjohn <[EMAIL PROTECTED]> This is a diff against -rc1. This compiles fine with no warnings and seems to run perfectly fine. Are there any headers I'm deleting that _should_ be there, but not

[PATCH] Replacing with (compare|is_zero)_ether_addr() and ETH_ALEN in pktgen.c

This replaces some tests with is_zero_ether_addr(), memcmp(one, two, 6) with compare_ether_addr(one, two), and 6 with ETH_ALEN where appropriate. Signed-off-by: Kris Katterjohn <[EMAIL PROTECTED]> Thanks! --- x/net/core/pktgen.c 2006-01-15 21:29:21.0 -0600 +++ y/net/core/pktgen.

Re: [PATCH] "signed long" -> "long"

From: Al Viro Sent: 1/14/2006 10:25:34 AM > On Sat, Jan 14, 2006 at 09:38:44AM -0800, Kris Katterjohn wrote: > > From: Lennert Buytenhek > > Sent: 1/14/2006 9:23:19 AM > > > Hmmm, is 'long' guaranteed to be signed? > > > > > > --L > > >

Re: [PATCH] "signed long" -> "long"

From: Lennert Buytenhek Sent: 1/14/2006 9:23:19 AM > On Sat, Jan 14, 2006 at 08:23:41AM -0800, Kris Katterjohn wrote: > > > This changes "signed long" to "long". > > Hmmm, is 'long' guaranteed to be signed? > > --L All integral types are

[PATCH] Fix whitespace issues in net/core/filter.c

This fixes some whitespace issues in net/core/filter.c Signed-off-by: Kris Katterjohn <[EMAIL PROTECTED]> Thanks! --- x/net/core/filter.c 2006-01-14 10:06:40.0 -0600 +++ y/net/core/filter.c 2006-01-14 10:33:16.0 -0600 @@ -74,7 +74,6 @@ static inline void *load_pointer(

[PATCH] "signed long" -> "long"

This changes "signed long" to "long". Signed-off-by: Kris Katterjohn <[EMAIL PROTECTED]> Thanks! --- x/net/dccp/ackvec.c 2006-01-14 09:58:35.0 -0600 +++ y/net/dccp/ackvec.c 2006-01-14 10:17:24.0 -0600 @@ -144,7 +144,7 @@ static inline

[PATCH] Clean up comments for sk_chk_filter()

This removes redundant comments, and moves one comment to a better location. Signed-off-by: Kris Katterjohn <[EMAIL PROTECTED]> We all ready know the filter must end with a RET instruction because it says so in the header comment for sk_chk_filter(). And I think the header comment is a

[PATCH] Remove more unneeded typecasts on *malloc()

This removes more unneeded casts on the return value for kmalloc(), sock_kmalloc(), and vmalloc(). Signed-off-by: Kris Katterjohn <[EMAIL PROTECTED]> This is a diff against 2.6.15-git7. Thanks! --- x/net/atm/lec.c 2006-01-11 07:08:52.0 -0600 +++ y/net/atm/lec.c 2006-01-11

[PATCH] Fix grammar for comment for compare_ether_addr()

This fixes the wording in the comment for compare_ether_addr(). Signed-off-by: Kris Katterjohn <[EMAIL PROTECTED]> This is a diff from 2.6.15-git5. Thanks! --- x/include/linux/etherdevice.h 2006-01-09 12:16:58.0 -0600 +++ y/include/linux/etherdevice.h 2006-01-09

[PATCH] Fix spelling error in debug message

This fixes the misspelling of the word "receive" in a debugging message. Signed-off-by: Kris Katterjohn <[EMAIL PROTECTED]> This is a diff from 2.6.15-git5. Thanks! --- x/net/ieee80211/ieee80211_rx.c 2006-01-09 17:28:34.0 -0600 +++ y/net/ieee80211/ieee80211_rx.c

Re: [PATCH] sk_chk_filter() filter length should be unsigned

From: Patrick McHardy Sent: 1/9/2006 4:24:18 PM > Kris Katterjohn wrote: > > This makes the filter length in sk_chk_filter() unsigned as it should be. > > > > Signed-off-by: Kris Katterjohn <[EMAIL PROTECTED]> > > > > This is a diff from 2.6.15. > >

Re: [PATCH] sk_chk_filter() filter length should be unsigned

From: Kris Katterjohn Sent: 1/9/2006 1:36:49 PM > This makes the filter length in sk_chk_filter() unsigned as it should be. > > Signed-off-by: Kris Katterjohn <[EMAIL PROTECTED]> > > This is a diff from 2.6.15. Here's a new patch against 2.6.15-git5: --- x/net/core

Re: [PATCH] Change memcmp(,,ETH_ALEN) to compare_ether_addr()

From: David S. Miller Sent: 1/9/2006 3:02:35 PM > From: "Kris Katterjohn" <[EMAIL PROTECTED]> > Date: Mon, 9 Jan 2006 11:48:49 -0800 > > > This changes some memcmp(one,two,ETH_ALEN) to compare_ether_addr(one,two). > > > > Signed-off-by: Kris Katter

[PATCH] sk_chk_filter() filter length should be unsigned

This makes the filter length in sk_chk_filter() unsigned as it should be. Signed-off-by: Kris Katterjohn <[EMAIL PROTECTED]> This is a diff from 2.6.15. The length should never be negative, and if the length were negative, the for loop would fail. Thanks! --- x/net/core/filter.c 2006-01

[PATCH] Change memcmp(,,ETH_ALEN) to compare_ether_addr()

This changes some memcmp(one,two,ETH_ALEN) to compare_ether_addr(one,two). Signed-off-by: Kris Katterjohn <[EMAIL PROTECTED]> This is a diff from 2.6.15. It compiles fine and seems to work fine. Thanks! --- x/net/8021q/vlan_dev.c 2006-01-02 21:21:10.0 -0600 +++ y/net

[PATCH] Change some "if (x) BUG();" to "BUG_ON(x);"

This changes some simple "if (x) BUG();" statements to "BUG_ON(x);" Signed-off-by: Kris Katterjohn <[EMAIL PROTECTED]> This is a diff from 2.6.15. Obviously I wasn't able to test these changes per se, but is there a reason they wouldn't work correctly? Than

[PATCH] Additional options for resetting packet statistics

This adds some setsockopt(SOL_PACKET) options for changing the behavior when getting packet statistics from the kernel. Signed-off-by: Kris Katterjohn <[EMAIL PROTECTED]> This is a diff from 2.6.15 and I AM subscribed to netdev, so you dont' need to CC me anymore. I sent this t

Re: [PATCH] Localizing a variable in net/core/filter.c

From: David S. Miller Sent: 1/6/2006 5:29:20 PM > From: "Kris Katterjohn" <[EMAIL PROTECTED]> > Date: Fri, 6 Jan 2006 17:25:32 -0800 > > > So the whole thing is wrong? If so, I guess I understand why it was > > done the way it was before. > > It's

Re: [PATCH] Localizing a variable in net/core/filter.c

From: Patrick McHardy Sent: 1/6/2006 5:20:44 PM > > -static inline void *load_pointer(struct sk_buff *skb, int k, > > - unsigned int size, void *buffer) > > +static inline void *load_pointer(struct sk_buff *skb, int k, unsigned int > > size) > > { > > - if (k >=

Re: [PATCH] Localizing a variable in net/core/filter.c

From: Patrick McHardy Sent: 1/6/2006 5:12:33 PM > > -static inline void *load_pointer(struct sk_buff *skb, int k, > > - unsigned int size, void *buffer) > > +static inline void *load_pointer(struct sk_buff *skb, int k, unsigned int > > size) > > { > > - if (k >=

[PATCH] Localizing a variable in net/core/filter.c

This localizes a variable to the function it's used in. Signed-off-by: Kris Katterjohn <[EMAIL PROTECTED]> I assume tmp was used for a reason instead of using a variable local to the if() in load_pointer(), but I can't figure out why. So I wrote this patch changing it in ca

Re: [PATCH] Remove old comments and code in net/ethernet/eth.c

From: David S. Miller Sent: 1/6/2006 4:08:33 PM > From: "Kris Katterjohn" <[EMAIL PROTECTED]> > Date: Fri, 6 Jan 2006 16:05:36 -0800 > > > This removes an old comment and old commented-out code that's been there > > since > > at least as far back a

[PATCH] Remove old comments and code in net/ethernet/eth.c

This removes an old comment and old commented-out code that's been there since at least as far back as 2.4.0. Signed-off-by: Kris Katterjohn <[EMAIL PROTECTED]> Thanks! --- x/net/ethernet/eth.c2006-01-06 12:49:27.0 -0600 +++ y/net/ethernet/eth.c2006-

Re: [PATCH] Use newer is_multicast_ether_addr() in some files

From: Patrick McHardy Sent: 1/6/2006 12:52:34 PM > Randy.Dunlap wrote: > > On Fri, 6 Jan 2006, Patrick McHardy wrote: > > > >>>--- x/net/atm/br2684.c 2006-01-02 21:21:10.0 -0600 > >>>+++ y/net/atm/br2684.c 2006-01-06 12:34:47.0 -0600 > >>>@@ -295,7 +295,7 @@ static inline

[PATCH] Use newer is_multicast_ether_addr() in some files

This uses is_multicast_ether_addr() because it has recently been changed to do the same thing these seperate tests are doing. Signed-off-by: Kris Katterjohn <[EMAIL PROTECTED]> Thanks! --- x/net/atm/br2684.c 2006-01-02 21:21:10.0 -0600 +++ y/net/atm/br2684.c 2006-01-06

Re: [PATCH] Change sk_run_filter()'s return type in net/core/filter.c

From: Patrick McHardy Sent: 1/6/2006 1:36:24 AM > Please use unsigned int not just unsigned. Ta-da! --- x/net/core/filter.c 2006-01-05 12:27:17.0 -0600 +++ y/net/core/filter.c 2006-01-05 17:02:32.0 -0600 @@ -75,7 +75,7 @@ static inline void *load_pointer(struct * len is the num

Re: [PATCH] Change sk_run_filter()'s return type in net/core/filter.c

> Whoops! Here you go: Whoops again. Screwed that last patch up. I gotta stop doing this stuff when I'm tired and I need to check myself :) Sorry. Again. --- x/net/core/filter.c 2006-01-05 12:27:17.0 -0600 +++ y/net/core/filter.c 2006-01-05 17:02:32.0 -0600 @@ -75,7 +75,7 @@ stat

Re: [PATCH] Change sk_run_filter()'s return type in net/core/filter.c

From: David S. Miller Sent: 1/5/2006 4:31:32 PM > sk_filter() thinks the return value is an int, and applies that > signed value to skb_trim(), yikes! > > Can you fix that up too and respin your patch? > > Thanks. Whoops! Here you go: --- x/net/core/filter.c 2006-01-05 12:27:17.0 -0600

[PATCH] Change sk_run_filter()'s return type in net/core/filter.c

This changes sk_run_filter()'s return type from int to unsigned. Signed-off-by: Kris Katterjohn <[EMAIL PROTECTED]> Zero all ready gets returned if an error occurs, and net/packet/af_packet.c treats the return type as unsigned anyway. For some reason, under the BPF RET statements, fe

[PATCH] Change 1500 to ETH_DATA_LEN in some files

These patches add the header linux/if_ether.h and change 1500 to ETH_DATA_LEN in some files. Signed-off-by: Kris Katterjohn <[EMAIL PROTECTED]> At first I wasn't going to change anything under net/ipv[46], but I then saw that ipv6/ip6_tunnel.c used ETH_DATA_LEN, so I went ahead and c

[PATCH] Remove unneeded variable in net/packet/af_packet.c

This removes an unneeded "ret" variable and returns directly. Signed-off-by: Kris Katterjohn <[EMAIL PROTECTED]> I am now subscribed to the list, so there's no need to CC me anymore. Thanks! --- x/net/packet/af_packet.c2006-01-02 21:21:10.0 -0600 +++ y/n

Re: [PATCH (should be ready to apply)] More instruction checks fornet/core/filter.c

From: David S. Miller > From: "Kris Katterjohn" <[EMAIL PROTECTED]> > Your email client has corrupted the patch spacing and tabbing. > Please fix this. Really? Have my other patches been screwed up, too? My email client has "upgraded" recently (although I&#x

Re: [PATCH (should be ready to apply)] More instruction checks for net/core/filter.c

I changed the sk_chk_filter() comment slightly, but that is the only change since the patch I posted earlier today. This should now be ready to be applied, unless any new reason is seen not to. Signed-off-by: Kris Katterjohn <[EMAIL PROTECTED]> Sorry to send a whole new email, but I t

Re: [PATCH] More instruction checks for net/core/filter.c

>From : Patrick McHardy >Kris Katterjohn wrote: >> So keep the return statement, then? > >Lets agree on adding WARN_ON(1) before the return statement. Sounds good to me. >> After some googling, I found this OpenBSD kernel code which does a lot of >> what m

Re: [PATCH] More instruction checks for net/core/filter.c

From: Patrick McHardy > Kris Katterjohn wrote: > > From: Patrick McHardy > > > >>Thats even worse, it will fall through to the second switch statement. > >>Just call BUG(), since it means you forgot to check something. > > > > > > I'm 99

Re: [PATCH] More instruction checks for net/core/filter.c

From: Patrick McHardy > Kris Katterjohn wrote: > > From: Patrick McHardy > > > >>Kris Katterjohn wrote: > >> > >>>--- x/net/core/filter.c2005-12-28 16:51:35.0 -0600 > >>>+++ y/net/core/filter.c2005-12-28

Re: [PATCH] More instruction checks for net/core/filter.c

From: Patrick McHardy > Kris Katterjohn wrote: > > --- x/net/core/filter.c 2005-12-28 16:51:35.0 -0600 > > +++ y/net/core/filter.c 2005-12-28 16:53:32.0 -0600 > > @@ -250,7 +250,7 @@ load_b: > > mem[fentry->k] = X; &g

[PATCH] More instruction checks for net/core/filter.c

This only allows valid filter instructions to be passed to the kernel. Signed-off by: Kris Katterjohn <[EMAIL PROTECTED]> --- This is a diff from 2.6.15-rc7 and I'm not subscribed so please CC me on replies. I know I've sent a few patches for net/core/filter.c recently, and t

Re: [PATCH] Remove needless variables in net/core/sock.c

From: David S. Miller > From: "Kris Katterjohn" <[EMAIL PROTECTED]> > Date: Wed, 28 Dec 2005 13:38:02 -0800 > > > Unless you mean sk_filter could get set to NULL after the test, but > > before it's used. > > That's exactly what I mean. Okey-d

Re: Re: [PATCH] Remove needless variables in net/core/sock.c

From: David S. Miller > > Removes needless "filter" variables. > > > > Signed-off by: Kris Katterjohn <[EMAIL PROTECTED]> > > I think we need to use a local variable here, since sk->sk_filter can > be set to NULL asynchronously to the tests. That m

[PATCH] Remove needless variables in net/core/sock.c

Removes needless "filter" variables. Signed-off by: Kris Katterjohn <[EMAIL PROTECTED]> --- This is a diff from 2.6.15-rc7 and I'm not subscribed so please CC me on any replies. Thanks! --- x/net/core/sock.c 2005-12-28 15:10:33.0 -0600 +++ y/net/core/sock

[PATCH] Socket filter instruction limit validation

This patch checks to make sure that the number of instructions doesn't surpass BPF_MAXINSNS in sk_chk_filter(). Signed-off-by: Kris Katterjohn <[EMAIL PROTECTED]> --- This is a diff from 2.6.15-rc5. And I am not subscribed, so please CC me on any replies. The previous check in sk