From: Herbert Xu Sent: 1/18/2006 4:02:18 PM > On Wed, Jan 18, 2006 at 02:15:37PM -0800, Kris Katterjohn wrote: > > > > #include <linux/module.h> > > #include <linux/types.h> > > -#include <linux/sched.h> > > OK. > > > -#include <linux/mm.h> > > Needed for GFP_*. Replace this with gfp.h if you want. > > > -#include <linux/fcntl.h> > > -#include <linux/socket.h> > > -#include <linux/in.h> > > -#include <linux/inet.h> > > OK. > > > -#include <linux/netdevice.h> > > We need this for skb->dev->ifindex.
But we know we have struct net_device because it's used in linux/skbuff.h (for skb->dev of course). I'm not saying it doesn't make sense, just that it seems to me that it's probably not needed. No matter, though. > > -#include <linux/if_packet.h> > > -#include <net/ip.h> > > -#include <net/protocol.h> > > OK. > > > -#include <linux/timer.h> > > OK, but you should add linux/spinlock.h. > > > -#include <asm/system.h> > > +#include <asm/atomic.h> > > +#include <asm/bug.h> > > +#include <asm/byteorder.h> > > Looks good. > > Thanks, All righty then. Signed-off-by: Kris Katterjohn <[EMAIL PROTECTED]> --- x/net/core/filter.c 2006-01-18 18:28:44.000000000 -0600 +++ y/net/core/filter.c 2006-01-18 18:28:33.000000000 -0600 @@ -18,21 +18,15 @@ #include <linux/module.h> #include <linux/types.h> -#include <linux/sched.h> -#include <linux/mm.h> -#include <linux/fcntl.h> -#include <linux/socket.h> -#include <linux/in.h> -#include <linux/inet.h> #include <linux/netdevice.h> -#include <linux/if_packet.h> -#include <net/ip.h> -#include <net/protocol.h> #include <linux/skbuff.h> +#include <linux/gfp.h> #include <net/sock.h> #include <linux/errno.h> -#include <linux/timer.h> -#include <asm/system.h> +#include <linux/spinlock.h> +#include <asm/atomic.h> +#include <asm/bug.h> +#include <asm/byteorder.h> #include <asm/uaccess.h> #include <linux/filter.h> - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
