From: David S. Miller
> > Removes needless "filter" variables.
> > 
> > Signed-off by: Kris Katterjohn <[EMAIL PROTECTED]>
> 
> I think we need to use a local variable here, since sk->sk_filter can
> be set to NULL asynchronously to the tests.

That makes sense, but the local filter variables are assigned to sk_filter
immediately before the tests. If there's a possibility of sk_filter being set to
NULL, shouldn't the local variables be assigned to sk_filter earlier than the
tests? And if not then what would be the difference between before and after my
patch? That part I don't think I'm fully understanding. Unless you mean 
sk_filter
could get set to NULL after the test, but before it's used.

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to