Re: [PATCH 1/2] mm: Fix struct page layout on 32-bit systems

2021-04-20 Thread Geert Uytterhoeven
dr(struct page *page, dma_addr_t addr) > +{ > + page->dma_addr[0] = addr; > + if (sizeof(dma_addr_t) > sizeof(unsigned long)) > + page->dma_addr[1] = addr >> 16 >> 16; ... but we do have upper_32_bits() for a 32-bi

Re: [PATCH V3 5/5] arm64: dts: renesas: beacon kits: Setup AVB refclk

2021-04-19 Thread Geert Uytterhoeven
Hi Adam, On Sat, Apr 17, 2021 at 3:54 PM Adam Ford wrote: > On Thu, Mar 4, 2021 at 2:04 AM Geert Uytterhoeven > wrote: > > On Wed, Feb 24, 2021 at 12:52 PM Adam Ford wrote: > > > The AVB refererence clock assumes an external clock that runs > > > > reference

Re: [PATCH V3 3/5] arm64: dts: renesas: Add fck to etheravb-rcar-gen3 clock-names list

2021-04-19 Thread Geert Uytterhoeven
On Wed, Feb 24, 2021 at 12:52 PM Adam Ford wrote: > The bindings have been updated to support two clocks, but the > original clock now requires the name fck. Add a clock-names > list in the device tree with fck in it. > > Signed-off-by: Adam Ford > Reviewed-by: Geert Uytterho

Re: [RFC v1 PATCH 3/3] driver: update all the code that use soc_device_match

2021-04-19 Thread Geert Uytterhoeven
me drivers may be used on multiple platforms, some of them registering an SoC device, some of them not registering an SoC device. So there is no way to know the difference between "SoC device not registered, intentionally", and "SoC device not yet registered". soc_device_match()

Re: [RFC v1 PATCH 1/3] drivers: soc: add support for soc_device_match returning -EPROBE_DEFER

2021-04-19 Thread Geert Uytterhoeven
c_bus_type.p && !early_soc_dev_attr) > + return ERR_PTR(-EPROBE_DEFER); > + > while (!ret) { > if (!(matches->machine || matches->family || > matches->revision || matches->soc_id)) Gr{oetje,eeting}s,

Re: [PATCH] net: ethernet: ravb: Fix release of refclk

2021-04-19 Thread Geert Uytterhoeven
lk") > Signed-off-by: Adam Ford Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I&#x

Re: [PATCH v2 5/6] kunit: mptcp: adhear to KUNIT formatting standard

2021-04-19 Thread Geert Uytterhoeven
est config patch when all other parts have entered mainline. Note that I would have made the same changes myself anyway, on -rc1 defconfig refresh. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In perso

Re: [PATCH V4 2/2] net: ethernet: ravb: Enable optional refclk

2021-04-14 Thread Geert Uytterhoeven
Hi Adam, On Wed, Apr 14, 2021 at 3:08 PM Adam Ford wrote: > On Tue, Apr 13, 2021 at 2:33 AM Geert Uytterhoeven > wrote: > > On Mon, Apr 12, 2021 at 3:27 PM Adam Ford wrote: > > > For devices that use a programmable clock for the AVB reference clock, > > > the

Re: [PATCH V4 2/2] net: ethernet: ravb: Enable optional refclk

2021-04-13 Thread Geert Uytterhoeven
dev); > out_release: > + clk_disable_unprepare(priv->refclk); > free_netdev(ndev); > > pm_runtime_put(&pdev->dev); Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Li

Re: [PATCH V3 4/5] net: ethernet: ravb: Enable optional refclk

2021-03-29 Thread Geert Uytterhoeven
Hi Adam, On Mon, Mar 29, 2021 at 2:45 PM Adam Ford wrote: > On Thu, Mar 4, 2021 at 2:08 AM Geert Uytterhoeven > wrote: > > On Wed, Feb 24, 2021 at 12:52 PM Adam Ford wrote: > > > For devices that use a programmable clock for the AVB reference clock, > > > the

Re: [PATCH net 1/4] virtchnl: Fix layout of RSS structures

2021-03-27 Thread Geert Uytterhoeven
Hi Samudrala, On Fri, Mar 26, 2021 at 11:45 PM Samudrala, Sridhar wrote: > On 3/26/2021 1:06 AM, Geert Uytterhoeven wrote: > > On Thu, Mar 25, 2021 at 11:29 PM Tony Nguyen > > wrote: > > From: Norbert Ciosek > > > > Remove padding from RSS structures.

Re: [PATCH net 1/4] virtchnl: Fix layout of RSS structures

2021-03-26 Thread Geert Uytterhoeven
; - u8 pad[1]; > }; If you use a flexible array member, it should be declared without a size, i.e. u8 key[]; Everything else is (trying to) fool the compiler, and leading to undefined behavior, and people (re)adding explicit padding. -- Gr{oetje,eeting}s, G

Re: [PATCH V3 5/5] arm64: dts: renesas: beacon kits: Setup AVB refclk

2021-03-18 Thread Geert Uytterhoeven
Hi Adam, On Thu, Mar 18, 2021 at 1:44 PM Adam Ford wrote: > On Thu, Mar 4, 2021 at 2:04 AM Geert Uytterhoeven > wrote: > > On Wed, Feb 24, 2021 at 12:52 PM Adam Ford wrote: > > > The AVB refererence clock assumes an external clock that runs > > > > reference

[PATCH v2] net: broadcom: BCM4908_ENET should not default to y, unconditionally

2021-03-16 Thread Geert Uytterhoeven
Merely enabling compile-testing should not enable additional code. To fix this, restrict the automatic enabling of BCM4908_ENET to ARCH_BCM4908. Fixes: 4feffeadbcb2e5b1 ("net: broadcom: bcm4908enet: add BCM4908 controller driver") Signed-off-by: Geert Uytterhoeven --- v2: - Enable

[PATCH] net: broadcom: BCM4908_ENET should not default to y, unconditionally

2021-03-16 Thread Geert Uytterhoeven
Merely enabling CONFIG_COMPILE_TEST should not enable additional code. To fix this, drop the automatic enabling of BCM4908_ENET. Fixes: 4feffeadbcb2e5b1 ("net: broadcom: bcm4908enet: add BCM4908 controller driver") Signed-off-by: Geert Uytterhoeven --- Feel free to change to &qu

Re: [PATCH net 3/3] sh_eth: fix TRSCER mask for R7S9210

2021-03-04 Thread Geert Uytterhoeven
:: > trscer_err_mask for R7S9210. > > Fixes: 6e0bb04d0e4f ("sh_eth: Add R7S9210 support") > Signed-off-by: Sergey Shtylyov Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- g

Re: [PATCH net 2/3] sh_eth: fix TRSCER mask for R7S72100

2021-03-04 Thread Geert Uytterhoeven
er for > sh_eth_cpu_data::trscer_err_mask for R7S72100. > > Fixes: db893473d313 ("sh_eth: Add support for r7s72100") > Signed-off-by: Sergey Shtylyov Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Lin

Re: [PATCH net 1/3] sh_eth: fix TRSCER mask for SH771x

2021-03-04 Thread Geert Uytterhoeven
SuperH Ethernet") > Signed-off-by: Sergey Shtylyov Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself

Re: [PATCH V3 4/5] net: ethernet: ravb: Enable optional refclk

2021-03-04 Thread Geert Uytterhoeven
gt; ravb_ptp_stop(ndev); > > + if (priv->refclk) > + clk_disable_unprepare(priv->refclk); > + > dma_free_coherent(ndev->dev.parent, priv->desc_bat_size, > priv->desc_bat, > priv->desc_bat_

Re: [PATCH V3 5/5] arm64: dts: renesas: beacon kits: Setup AVB refclk

2021-03-04 Thread Geert Uytterhoeven
rt the clock. > > Signed-off-by: Adam Ford Reviewed-by: Geert Uytterhoeven i.e. will queue in renesas-devel (with the typo fixed) once the DT bindings have been accepted. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- g

Re: [PATCH net 0/3] Fix TRSCER masks in the Ether driver

2021-03-02 Thread Geert Uytterhoeven
nd as they're queued in net, not net-next, they missed today's renesas-drivers release, and all related testing... I applied them manually, and boot-tested rskrza1 (R7S72100) and rza2mevb (R7S9210) using nfsroot. Worked fine. Tested-by: Geert Uytterhoeven Review will take a bit longer...

Re: [PATCH V3 2/5] ARM: dts: renesas: Add fck to etheravb-rcar-gen2 clock-names list

2021-02-24 Thread Geert Uytterhoeven
plan to merge this whole patchset via netdev? If so, you need > to repost anyway, once netdev reopens. So maybe you can change the > wording? The DTS patches should go in through the renesas and soc trees. I can apply them as soon as the DT binding patch has been accepted. Thanks! Gr{oetje,e

Re: [PATCH] net: dsa: sja1105: Remove unneeded cast in sja1105_crc32()

2021-02-24 Thread Geert Uytterhoeven
Hi Vladimir, On Wed, Feb 24, 2021 at 11:44 PM Vladimir Oltean wrote: > On Tue, Feb 23, 2021 at 12:20:03PM +0100, Geert Uytterhoeven wrote: > > sja1105_unpack() takes a "const void *buf" as its first parameter, so > > there is no need to cast away the "const

[PATCH] net: dsa: sja1105: Remove unneeded cast in sja1105_crc32()

2021-02-23 Thread Geert Uytterhoeven
sja1105_unpack() takes a "const void *buf" as its first parameter, so there is no need to cast away the "const" of the "buf" variable before calling it. Drop the cast, as it prevents the compiler performing some checks. Signed-off-by: Geert Uytterhoeven

Re: [PATCH net-next v2 2/3] net: ethernet: rmnet: Support for downlink MAPv5 checksum offload

2021-02-23 Thread Geert Uytterhoeven
ualcomm/rmnet/rmnet_map.h:7, > from > drivers/net/ethernet/qualcomm/rmnet/rmnet_handlers.c:14: >include/linux/if_rmnet.h: At top level: > >> include/linux/if_rmnet.h:66:2: error: expected ',', ';' or '}' before 'u8

[PATCH] ath11k: qmi: use %pad to format dma_addr_t

2021-02-21 Thread Geert Uytterhoeven
long long unsigned int | %x Fixes: d5395a5486596308 ("ath11k: qmi: add debug message for allocated memory segment addresses and sizes") Signed-off-by: Geert Uytterhoeven --- drivers/net/wireless/ath/ath11k/qmi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH] net: dsa: mv88e6xxx: NET_DSA_MV88E6XXX_PTP should depend on NET_DSA_MV88E6XXX

2021-02-10 Thread Geert Uytterhoeven
, even if the latter support is not enabled. Fix this by reinstating the dependency. Fixes: 63368a7416df144b ("net: dsa: mv88e6xxx: Make global2 support mandatory") Signed-off-by: Geert Uytterhoeven --- drivers/net/dsa/mv88e6xxx/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletio

[PATCH] dt-bindings: can: rcar_canfd: Group tuples in pin control properties

2021-02-04 Thread Geert Uytterhoeven
To improve human readability and enable automatic validation, the tuples in "pinctrl-*" properties should be grouped using angle brackets. Signed-off-by: Geert Uytterhoeven --- Documentation/devicetree/bindings/net/can/rcar_canfd.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletio

[PATCH] net: fec: Silence M5272 build warnings

2021-02-02 Thread Geert Uytterhoeven
clarations inside the existing #ifdef blocks. Signed-off-by: Geert Uytterhoeven --- drivers/net/ethernet/freescale/fec_main.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_ma

RE: [Intel-wired-lan] [PATCH net v1] virtchnl: Fix layout of RSS structures

2021-01-27 Thread Geert Uytterhoeven
intended recipient, please contact the sender and delete all copies; any review or distribution by others is strictly prohibited. ___ Intel-wired-lan mailing list intel-wired-...@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan ???

[PATCH net v2 1/2] mdio-bitbang: Export mdiobb_{read,write}()

2021-01-18 Thread Geert Uytterhoeven
Export mdiobb_read() and mdiobb_write(), so Ethernet controller drivers can call them from their MDIO read/write wrappers. Signed-off-by: Geert Uytterhoeven --- v2: - New. --- drivers/net/mdio/mdio-bitbang.c | 6 -- include/linux/mdio-bitbang.h| 3 +++ 2 files changed, 7 insertions

[PATCH net v2 2/2] sh_eth: Make PHY access aware of Runtime PM to fix reboot crash

2021-01-18 Thread Geert Uytterhoeven
d, causing undefined behavior, which may crash the system. Fix this by wrapping the PHY bitbang accessors in the sh_eth driver by wrappers that take care of Runtime PM, to resume the device when needed. Reported-by: Wolfram Sang Suggested-by: Andrew Lunn Signed-off-by: Geert Uytterhoeven --- v2

[PATCH] net: smsc911x: Make Runtime PM handling more fine-grained

2021-01-18 Thread Geert Uytterhoeven
) when it is opened (closed), 3. Make sure the device is powered during PHY access. Signed-off-by: Geert Uytterhoeven --- Tested on r8a73a4/ape6evm, where the LAN9220 is connected to a power-managed bus, and any attempt to access a device register while the device is suspended will trigger an

[PATCH] sh_eth: Fix power down vs. is_opened flag ordering

2021-01-18 Thread Geert Uytterhoeven
: 7fa2955ff70ce453 ("sh_eth: Fix sleeping function called from invalid context") Signed-off-by: Geert Uytterhoeven --- drivers/net/ethernet/renesas/sh_eth.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethern

[PATCH net v2 0/2] sh_eth: Fix reboot crash

2021-01-18 Thread Geert Uytterhoeven
iver probe and driver unbind, and changing that seems to be non-trivial). Thanks for your comments! Geert Uytterhoeven (2): net: mdio-bitbang: Export mdiobb_{read,write}() sh_eth: Make PHY access aware of Runtime PM to fix reboot crash drivers/net/ethernet/renesas/sh_

[PATCH v5 trivial/resend] dt-bindings: net: btusb: DT fix s/interrupt-name/interrupt-names/

2021-01-14 Thread Geert Uytterhoeven
The standard DT property name is "interrupt-names". Fixes: fd913ef7ce619467 ("Bluetooth: btusb: Add out-of-band wakeup support") Signed-off-by: Geert Uytterhoeven Acked-by: Rob Herring Reviewed-by: Brian Norris Acked-by: Rajat Jain --- Who takes this patch, before i

[PATCH] nt: usb: USB_RTL8153_ECM should not default to y

2021-01-13 Thread Geert Uytterhoeven
In general, device drivers should not be enabled by default. Fixes: 657bc1d10bfc23ac ("r8153_ecm: avoid to be prior to r8152 driver") Signed-off-by: Geert Uytterhoeven --- drivers/net/usb/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/usb/Kconfig b/drive

Re: [PATCH] [RFC] net: phy: Fix reboot crash if CONFIG_IP_PNP is not set

2021-01-13 Thread Geert Uytterhoeven
. But that is more difficult to reproduce, as I don't have any arm32 boards that use RAVB, and on arm64 register access while a device is suspended doesn't cause a crash, but continues silently without any effect. Gr{oetje,eeting}s, Geer

Re: [PATCH 3/4] arm64: dts: renesas: Add fck to etheravb-rcar-gen3 clock-names list

2021-01-08 Thread Geert Uytterhoeven
On Mon, Dec 28, 2020 at 10:32 PM Adam Ford wrote: > The bindings have been updated to support two clocks, but the > original clock now requires the name fck. Add a clock-names > list in the device tree with fck in it. > > Signed-off-by: Adam Ford Reviewed-by: Geert Uytterho

Re: [PATCH 1/4] dt-bindings: net: renesas,etheravb: Add additional clocks

2021-01-08 Thread Geert Uytterhoeven
Hi Adam, On Fri, Jan 8, 2021 at 3:11 PM Geert Uytterhoeven wrote: > On Mon, Dec 28, 2020 at 10:32 PM Adam Ford wrote: > > The AVB driver assumes there is an external clock, but it could > > be driven by an external clock. In order to enable a programmable > > clock, it nee

Re: [PATCH 4/4] net: ethernet: ravb: Name the AVB functional clock fck

2021-01-08 Thread Geert Uytterhoeven
Hi Adam, On Tue, Jan 5, 2021 at 1:53 PM Adam Ford wrote: > On Mon, Jan 4, 2021 at 4:41 AM Geert Uytterhoeven > wrote: > > On Mon, Dec 28, 2020 at 10:32 PM Adam Ford wrote: > > > The bindings have been updated to support two clocks, but the > > > original cloc

Re: [PATCH 2/4] ARM: dts: renesas: Add fck to etheravb-rcar-gen2 clock-names list

2021-01-08 Thread Geert Uytterhoeven
On Mon, Dec 28, 2020 at 10:32 PM Adam Ford wrote: > The bindings have been updated to support two clocks, but the > original clock now requires the name fck. Add a clock-names > list in the device tree with fck in it. > > Signed-off-by: Adam Ford Reviewed-by: Geert Uytterho

Re: [PATCH 1/4] dt-bindings: net: renesas,etheravb: Add additional clocks

2021-01-08 Thread Geert Uytterhoeven
tly only one clock, there is no > clock-names list either. > > Update bindings to add the additional optional clock, and explicitly > name both of them. > > Signed-off-by: Adam Ford Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert U

Re: [PATCH net-next 1/2] ravb: remove APSR_DM

2021-01-07 Thread Geert Uytterhoeven
1fccb2d6274 ("ravb: Add tx and rx clock internal delays mode of APSR") > Signed-off-by: Sergey Shtylyov Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In persona

Re: [PATCH 00/10] Remove support for TX49xx

2021-01-07 Thread Geert Uytterhoeven
Hi Nemoto-san, On Thu, Jan 7, 2021 at 2:18 AM Atsushi Nemoto wrote: > On Wed, 6 Jan 2021 21:41:24 +0100, Geert Uytterhoeven > wrote: > >> > Is that sufficient to keep it? > >> > >> for me it is. But now we probaly need some reverts then... > > >

Re: [PATCH 00/10] Remove support for TX49xx

2021-01-06 Thread Geert Uytterhoeven
Hi Thomas, On Wed, Jan 6, 2021 at 7:49 PM Thomas Bogendoerfer wrote: > On Wed, Jan 06, 2021 at 09:37:11AM +0100, Geert Uytterhoeven wrote: > > On Tue, Jan 5, 2021 at 3:03 PM Thomas Bogendoerfer > > wrote: > > > I couldn't find any buyable product other than refere

Re: [PATCH 00/10] Remove support for TX49xx

2021-01-06 Thread Geert Uytterhoeven
on TX4927 ;-) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something

[PATCH] dt-bindings: net: renesas,etheravb: RZ/G2H needs tx-internal-delay-ps

2021-01-05 Thread Geert Uytterhoeven
a required property on RZ/G2H. Fixes: 8b0308fe319b8002 ("Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net") Signed-off-by: Geert Uytterhoeven --- Documentation/devicetree/bindings/net/renesas,etheravb.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devic

Re: [PATCH 1/5] dt-bindings: net: renesas,etheravb: Add r8a779a0 support

2021-01-05 Thread Geert Uytterhoeven
l Delay Mode bit in the APSR register, so its compatible value should be added to the list of SoCs where tx-internal-delay-ps is required. With that fixed: Reviewed-by: Geert Uytterhoeven The various Counter Registers starting at offset 0x700 are limited to 16-bit values, like on R-Car Gen2, while t

Re: [PATCH] [RFC] net: phy: Fix reboot crash if CONFIG_IP_PNP is not set

2021-01-05 Thread Geert Uytterhoeven
2d0...@gmail.com/ From b3cc15e56bddbe65e0196ce04604e5e6c78abd7a Mon Sep 17 00:00:00 2001 From: Geert Uytterhoeven Date: Tue, 5 Jan 2021 10:29:22 +0100 Subject: [PATCH] [RFC] sh_eth: Make PHY access aware of Runtime PM to fix reboot crash Wolfram reports that his R-Car H2-based Lager board can no

Re: [PATCH] [RFC] net: phy: Fix reboot crash if CONFIG_IP_PNP is not set

2021-01-04 Thread Geert Uytterhoeven
Hi Ioana, On Mon, Jan 4, 2021 at 3:53 PM Ioana Ciornei wrote: > On Mon, Jan 04, 2021 at 01:24:15PM +0100, Geert Uytterhoeven wrote: > > Wolfram reports that his R-Car H2-based Lager board can no longer be > > rebooted in v5.11-rc1, as it crashes with an imprecise external abort

Re: [PATCH] can: rcar: Update help description for CAN_RCAR_CANFD config

2021-01-04 Thread Geert Uytterhoeven
Hi Prabhakar, On Mon, Jan 4, 2021 at 2:38 PM Lad, Prabhakar wrote: > On Mon, Jan 4, 2021 at 10:51 AM Geert Uytterhoeven > wrote: > > On Thu, Dec 31, 2020 at 5:00 PM Lad Prabhakar > > wrote: > > > The rcar_canfd driver supports R-Car Gen3 and RZ/G2 SoC's,

[PATCH] [RFC] net: phy: Fix reboot crash if CONFIG_IP_PNP is not set

2021-01-04 Thread Geert Uytterhoeven
Fixes: e2f016cf775129c0 ("net: phy: add a shutdown procedure") Signed-off-by: Geert Uytterhoeven --- Marked RFC as I do not know if this change breaks the use case fixed by the faulty commit. Alternatively, the device may have to be started explicitly first. --- drivers/net/phy/phy_de

Re: [PATCH v2] can: rcar: Update help description for CAN_RCAR config

2021-01-04 Thread Geert Uytterhoeven
On Mon, Jan 4, 2021 at 10:03 AM Lad Prabhakar wrote: > The rcar_can driver also supports RZ/G SoC's, update the description to > reflect this. > > Signed-off-by: Lad Prabhakar Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytter

Re: [PATCH] can: rcar: Update help description for CAN_RCAR_CANFD config

2021-01-04 Thread Geert Uytterhoeven
Hi Prabhakar, On Thu, Dec 31, 2020 at 5:00 PM Lad Prabhakar wrote: > The rcar_canfd driver supports R-Car Gen3 and RZ/G2 SoC's, update the > description to reflect this. > > Signed-off-by: Lad Prabhakar Reviewed-by: Geert Uytterhoeven > --- a/drivers/net/can/rcar/Kconfig

Re: [PATCH 4/4] net: ethernet: ravb: Name the AVB functional clock fck

2021-01-04 Thread Geert Uytterhoeven
d. > if (IS_ERR(priv->clk)) { > error = PTR_ERR(priv->clk); > goto out_release; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with te

Re: [RFC] ravb: Add support for optional txc_refclk

2020-12-28 Thread Geert Uytterhoeven
Hi Adam, CC devicetree On Mon, Dec 28, 2020 at 2:49 PM Adam Ford wrote: > On Mon, Dec 14, 2020 at 4:05 AM Geert Uytterhoeven > wrote: > > On Sun, Dec 13, 2020 at 5:18 PM Adam Ford wrote: > > > The SoC expects the txv_refclk is provided, but if it is provided > >

Re: [RFC] ravb: Add support for optional txc_refclk

2020-12-14 Thread Geert Uytterhoeven
(void)clk_prepare_enable(priv->ref_clk); This can fail. Does this clock need to be enabled all the time? At least it should be disabled in the probe failure path, and in ravb_remove(). [1] Documentation/devicetree/bindings/net/renesas,etheravb.yaml Gr{oetje,eeting}s,

[PATCH] mwifiex: pcie: Drop bogus __refdata annotation

2020-12-11 Thread Geert Uytterhoeven
As the Marvell PCIE WiFi-Ex driver does not have any code or data located in initmem, there is no need to annotate the mwifiex_pcie structure with __refdata. Drop the annotation, to avoid suppressing future section warnings. Signed-off-by: Geert Uytterhoeven --- drivers/net/wireless/marvell

Re: [PATCH] powerpc: fix the allyesconfig build

2020-11-30 Thread Geert Uytterhoeven
bad relocations > ce56510b R_PPC64_UADDR64 .rodata+0x01c72378 > ce565126 R_PPC64_UADDR64 .rodata+0x01c723c0 > > They are not drivers that are used on PowerPC (I assume), so mark them > to not be built on PPC64 when CONFIG_RELOCATABLE is enabled. &g

Re: [PATCH v3 1/2] PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter

2020-11-27 Thread Geert Uytterhoeven
dev, RPM_GET_PUT); > + if (ret < 0) { > + pm_runtime_put_noidle(dev); > + return ret; > + } > + > + return 0; > +} > + > /** > * pm_runtime_put - Drop device usage counter and queue up "idle check" if 0. >

Re: [PATCH 2/2] powerpc/ps3: make system bus's remove and shutdown callbacks return void

2020-11-27 Thread Geert Uytterhoeven
ave > accordingly. > > Signed-off-by: Uwe Kleine-König Thanks for your patch! Reviewed-by: Geert Uytterhoeven Note that the same can be done for ps3_vuart_port_driver.remove(). Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyon

Re: [PATCH 1/2] ALSA: ppc: drop if block with always false condition

2020-11-27 Thread Geert Uytterhoeven
> check this here. > > Signed-off-by: Uwe Kleine-König Thanks for your patch! Reviewed-by: Geert Uytterhoeven Note that there are similar checks in snd_ps3_driver_probe(), which can be removed, too: if (WARN_ON(!firmware_has_feature(FW_FEATURE_PS3_LV1))) return -E

Re: [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-26 Thread Geert Uytterhoeven
sed uninitialized" warnings thrown up by gcc-4.1, until (a bit later than) support for that compiler was removed... Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal con

[PATCH trivial v5] dt-bindings: net: btusb: DT fix s/interrupt-name/interrupt-names/

2020-11-10 Thread Geert Uytterhoeven
The standard DT property name is "interrupt-names". Fixes: fd913ef7ce619467 ("Bluetooth: btusb: Add out-of-band wakeup support") Signed-off-by: Geert Uytterhoeven Acked-by: Rob Herring Reviewed-by: Brian Norris Acked-by: Rajat Jain --- Who takes this patch, before i

Re: [PATCH v2 1/2] bpf: don't rely on GCC __attribute__((optimize)) to disable GCSE

2020-10-29 Thread Geert Uytterhoeven
d Biesheuvel (probably you missed by tag on v1 due to kernel.org hickups) Thanks, this gets rid of the following warning, which you may want to quote in the patch description: aarch64-linux-gnu-ld: warning: orphan section `.eh_frame' from `kernel/bpf/core.o' being placed i

Re: [PATCH] bpf: don't rely on GCC __attribute__((optimize)) to disable GCSE

2020-10-28 Thread Geert Uytterhoeven
reverts commit 3193c0836f203, and instead, it disables the -fgcse > optimization for the entire source file, but only when building for > X86. > > Cc: Nick Desaulniers > Cc: Arvind Sankar > Cc: Randy Dunlap > Cc: Josh Poimboeuf > Cc: Thomas Gleixner > Cc: Alexei Starovoito

Re: [PATCH] mptcp: MPTCP_IPV6 should depend on IPV6 instead of selecting it

2020-10-21 Thread Geert Uytterhoeven
Hi Matthieu, On Wed, Oct 21, 2020 at 11:47 AM Matthieu Baerts wrote: > On 21/10/2020 11:43, Geert Uytterhoeven wrote: > > On Wed, Oct 21, 2020 at 5:56 AM Jakub Kicinski wrote: > >> On Tue, 20 Oct 2020 11:26:34 +0200 Matthieu Baerts wrote: > >>> On 20/10/2020 0

Re: [PATCH] mptcp: MPTCP_IPV6 should depend on IPV6 instead of selecting it

2020-10-21 Thread Geert Uytterhoeven
Hi Jakub, On Wed, Oct 21, 2020 at 5:56 AM Jakub Kicinski wrote: > On Tue, 20 Oct 2020 11:26:34 +0200 Matthieu Baerts wrote: > > On 20/10/2020 09:38, Geert Uytterhoeven wrote: > > > MPTCP_IPV6 selects IPV6, thus enabling an optional feature the user may > > > not w

Re: [PATCH] mptcp: MPTCP_KUNIT_TESTS should depend on MPTCP instead of selecting it

2020-10-20 Thread Geert Uytterhoeven
On Mon, Oct 19, 2020 at 10:38 PM Geert Uytterhoeven wrote: > On Mon, Oct 19, 2020 at 5:47 PM Matthieu Baerts > wrote: > > On 19/10/2020 13:32, Geert Uytterhoeven wrote: > > > MPTCP_KUNIT_TESTS selects MPTCP, thus enabling an optional feature the > > > user may no

[PATCH] mptcp: MPTCP_IPV6 should depend on IPV6 instead of selecting it

2020-10-20 Thread Geert Uytterhoeven
MPTCP_IPV6 selects IPV6, thus enabling an optional feature the user may not want to enable. Fix this by making MPTCP_IPV6 depend on IPV6, like is done for all other IPv6 features. Fixes: f870fa0b5768842c ("mptcp: Add MPTCP socket stubs") Signed-off-by: Geert Uytterhoeven --- net/mpt

Re: [PATCH] mptcp: MPTCP_KUNIT_TESTS should depend on MPTCP instead of selecting it

2020-10-19 Thread Geert Uytterhoeven
Hi Matthieu, On Mon, Oct 19, 2020 at 5:47 PM Matthieu Baerts wrote: > On 19/10/2020 13:32, Geert Uytterhoeven wrote: > > MPTCP_KUNIT_TESTS selects MPTCP, thus enabling an optional feature the > > user may not want to enable. Fix this by making the test depend on > > MPTCP

[PATCH] mptcp: MPTCP_KUNIT_TESTS should depend on MPTCP instead of selecting it

2020-10-19 Thread Geert Uytterhoeven
MPTCP_KUNIT_TESTS selects MPTCP, thus enabling an optional feature the user may not want to enable. Fix this by making the test depend on MPTCP instead. Fixes: a00a582203dbc43e ("mptcp: move crypto test to KUNIT") Signed-off-by: Geert Uytterhoeven --- net/mptcp/Kconfig | 4 +--- 1 fi

[PATCH] can: Explain PDU in CAN_ISOTP help text

2020-10-13 Thread Geert Uytterhoeven
The help text for the CAN_ISOTP config symbol uses the acronym "PDU". However, this acronym is not explained here, nor in Documentation/networking/can.rst. Expand the acronym to make it easier for users to decide if they need to enable the CAN_ISOTP option or not. Signed-off

Re: linux-next: manual merge of the net-next tree with the net tree

2020-10-02 Thread Geert Uytterhoeven
ing > tree to minimise any particularly complex conflicts. > > From: Stephen Rothwell > Date: Fri, 2 Oct 2020 12:57:33 +1000 > Subject: [PATCH] fix up for "dt-bindings: net: renesas,ravb: Add support for > r8a774e1 SoC" > > Signed-off-by: Stephen Rothwell Thank

[PATCH net-next v4 resend 3/5] dt-bindings: net: renesas,etheravb: Convert to json-schema

2020-10-01 Thread Geert Uytterhoeven
Convert the Renesas Ethernet AVB (EthernetAVB-IF) Device Tree binding documentation to json-schema. Add missing properties. Update the example to match reality. Signed-off-by: Geert Uytterhoeven Reviewed-by: Sergei Shtylyov Reviewed-by: Rob Herring Reviewed-by: Florian Fainelli --- v4

[PATCH net-next v4 resend 0/5] net/ravb: Add support for explicit internal clock delay configuration

2020-10-01 Thread Geert Uytterhoeven
H55G0GqPG9HwH3XUd=8hzxprfdmgqe...@mail.gmail.com/ [4] https://lore.kernel.org/linux-devicetree/20200819134344.27813-1-geert+rene...@glider.be/ [5] https://lore.kernel.org/linux-devicetree/20200706143529.18306-1-geert+rene...@glider.be/ [6] https://lore.kernel.org/linux-devicetree/202006191915

[PATCH net-next v4 resend 4/5] ravb: Split delay handling in parsing and applying

2020-10-01 Thread Geert Uytterhoeven
Currently, full delay handling is done in both the probe and resume paths. Split it in two parts, so the resume path doesn't have to redo the parsing part over and over again. Signed-off-by: Geert Uytterhoeven Reviewed-by: Sergei Shtylyov Reviewed-by: Florian Fainelli --- v4: - Add Rev

[PATCH net-next v4 resend 5/5] ravb: Add support for explicit internal clock delay configuration

2020-10-01 Thread Geert Uytterhoeven
e new "[rt]x-internal-delay-ps" properties. Fall back to the old handling if none of these properties is present. [1] Commit bcf3440c6dd78bfe ("net: phy: micrel: add phy-mode support for the KSZ9031 PHY") [2] Commit 9b23203c32ee02cd ("ravb: Mask PHY mode to av

[PATCH net-next v4 resend 2/5] dt-bindings: net: renesas,ravb: Document internal clock delay properties

2020-10-01 Thread Geert Uytterhoeven
These properties are mandatory, even when specified as zero, to distinguish between old and new DTBs. Update the (bogus) example accordingly. Signed-off-by: Geert Uytterhoeven Reviewed-by: Sergei Shtylyov Reviewed-by: Rob Herring Reviewed-by: Florian Fainelli --- v4: - Add Reviewed-by, v3:

[PATCH net-next v4 resend 1/5] dt-bindings: net: ethernet-controller: Add internal delay properties

2020-10-01 Thread Geert Uytterhoeven
commit 9150069bf5fc0e86 ("dt-bindings: net: Add tx and rx internal delays"), which applies to the PHY. Signed-off-by: Geert Uytterhoeven Reviewed-by: Rob Herring Reviewed-by: Florian Fainelli --- v4: - Add Reviewed-by, v3: - Add Reviewed-by, v2: - New. --- .../bindings/ne

Re: [PATCH net-next v4 0/5] net/ravb: Add support for explicit internal clock delay configuration

2020-09-30 Thread Geert Uytterhoeven
Hi David, Jakub, On Thu, Sep 17, 2020 at 3:57 PM Geert Uytterhoeven wrote: > Some Renesas EtherAVB variants support internal clock delay > configuration, which can add larger delays than the delays that are > typically supported by the PHY (using an "rgmii-*id" PHY mode, and/o

Re: [PATCH net] Revert "ravb: Fixed to be able to unload modules"

2020-09-24 Thread Geert Uytterhoeven
Hi David, On Thu, Sep 24, 2020 at 2:40 AM David Miller wrote: > From: Geert Uytterhoeven > Date: Tue, 22 Sep 2020 09:29:31 +0200 > > > This reverts commit 1838d6c62f57836639bd3d83e7855e0ee4f6defc. > > > > This commit moved the ravb_mdio_init() call (and thus the >

[PATCH net] Revert "ravb: Fixed to be able to unload modules"

2020-09-22 Thread Geert Uytterhoeven
phy_request_driver_module(), like was done for -ENOENT in commit 21e194425abd65b5 ("net: phy: fix issue with loading PHY driver w/o initramfs"), would makes it fall back to the Generic PHY, like in the CONFIG_MODULES=n case. Signed-off-by: Geert Uytterhoeven Cc: sta...@vger.kernel.org

Re: [PATCH v3] ravb: Fixed to be able to unload modules

2020-09-21 Thread Geert Uytterhoeven
On Wed, Sep 16, 2020 at 11:31 AM Geert Uytterhoeven wrote: > On Thu, Aug 20, 2020 at 2:55 PM Yuusuke Ashizuka wrote: > > When this driver is built as a module, I cannot rmmod it after insmoding > > it. > > This is because that this driver calls ravb_mdio_init() at the t

Re: [PATCH net-next v4 5/5] ravb: Add support for explicit internal clock delay configuration

2020-09-18 Thread Geert Uytterhoeven
Hi Dan, On Thu, Sep 17, 2020 at 8:50 PM Dan Murphy wrote: > On 9/17/20 8:57 AM, Geert Uytterhoeven wrote: > > Some EtherAVB variants support internal clock delay configuration, which > > can add larger delays than the delays that are typically supported by > > the PHY (usi

[PATCH net-next v4 5/5] ravb: Add support for explicit internal clock delay configuration

2020-09-17 Thread Geert Uytterhoeven
e new "[rt]x-internal-delay-ps" properties. Fall back to the old handling if none of these properties is present. [1] Commit bcf3440c6dd78bfe ("net: phy: micrel: add phy-mode support for the KSZ9031 PHY") [2] Commit 9b23203c32ee02cd ("ravb: Mask PHY mode to av

[PATCH net-next v4 2/5] dt-bindings: net: renesas,ravb: Document internal clock delay properties

2020-09-17 Thread Geert Uytterhoeven
These properties are mandatory, even when specified as zero, to distinguish between old and new DTBs. Update the (bogus) example accordingly. Signed-off-by: Geert Uytterhoeven Reviewed-by: Sergei Shtylyov Reviewed-by: Rob Herring Reviewed-by: Florian Fainelli --- v4: - Add Reviewed-by, v3:

[PATCH net-next v4 1/5] dt-bindings: net: ethernet-controller: Add internal delay properties

2020-09-17 Thread Geert Uytterhoeven
commit 9150069bf5fc0e86 ("dt-bindings: net: Add tx and rx internal delays"), which applies to the PHY. Signed-off-by: Geert Uytterhoeven Reviewed-by: Rob Herring Reviewed-by: Florian Fainelli --- v4: - Add Reviewed-by, v3: - Add Reviewed-by, v2: - New. --- .../bindings/ne

[PATCH net-next v4 3/5] dt-bindings: net: renesas,etheravb: Convert to json-schema

2020-09-17 Thread Geert Uytterhoeven
Convert the Renesas Ethernet AVB (EthernetAVB-IF) Device Tree binding documentation to json-schema. Add missing properties. Update the example to match reality. Signed-off-by: Geert Uytterhoeven Reviewed-by: Sergei Shtylyov Reviewed-by: Rob Herring Reviewed-by: Florian Fainelli --- v4

[PATCH net-next v4 0/5] net/ravb: Add support for explicit internal clock delay configuration

2020-09-17 Thread Geert Uytterhoeven
H55G0GqPG9HwH3XUd=8hzxprfdmgqe...@mail.gmail.com/ [4] https://lore.kernel.org/linux-devicetree/20200819134344.27813-1-geert+rene...@glider.be/ [5] https://lore.kernel.org/linux-devicetree/20200706143529.18306-1-geert+rene...@glider.be/ [6] https://lore.kernel.org/linux-devicetree/202006191915

[PATCH net-next v4 4/5] ravb: Split delay handling in parsing and applying

2020-09-17 Thread Geert Uytterhoeven
Currently, full delay handling is done in both the probe and resume paths. Split it in two parts, so the resume path doesn't have to redo the parsing part over and over again. Signed-off-by: Geert Uytterhoeven Reviewed-by: Sergei Shtylyov Reviewed-by: Florian Fainelli --- v4: - Add Rev

Re: [PATCH v3] ravb: Fixed to be able to unload modules

2020-09-16 Thread Geert Uytterhoeven
request_driver_module(), like was done for -ENOENT in commit 21e194425abd65b5 ("net: phy: fix issue with loading PHY driver w/o initramfs"), makes it fall back to the Generic PHY, cfr. case A. For case A, I haven't found out yet why it falls back to the Generic PHY. Thanks for yo

[PATCH] chelsio/chtls: Re-add dependencies on CHELSIO_T4 to fix modular CHELSIO_T4

2020-09-15 Thread Geert Uytterhoeven
re-adding dependencies on CHELSIO_T4 to tristate symbols. The dependency of CHELSIO_INLINE_CRYPTO on CHELSIO_T4 is kept to avoid asking the user. Fixes: 6bd860ac1c2a0ec2 ("chelsio/chtls: CHELSIO_INLINE_CRYPTO should depend on CHELSIO_T4") Reported-by: kernel test robot Signed-off-by: Geert Uytter

Re: [PATCH] Revert "net: linkwatch: add check for netdevice being present to linkwatch_do_dev"

2020-09-14 Thread Geert Uytterhoeven
Hi David, CC bridge On Sun, Sep 13, 2020 at 3:34 AM David Miller wrote: > From: Geert Uytterhoeven > Date: Sat, 12 Sep 2020 14:33:59 +0200 > > > "dev" is not the bridge device, but the physical Ethernet interface, which > > may already be suspended during s2ram.

Re: [PATCH] Revert "net: linkwatch: add check for netdevice being present to linkwatch_do_dev"

2020-09-12 Thread Geert Uytterhoeven
Hi David, On Sat, Sep 12, 2020 at 2:44 AM David Miller wrote: > From: Geert Uytterhoeven > Date: Fri, 11 Sep 2020 08:32:55 +0200 > > > On Thu, Sep 10, 2020 at 9:20 PM David Miller wrote: > >> From: Geert Uytterhoeven > >> Date: Tue, 1 Sep 2020 17:02:37 +020

Re: [PATCH] Revert "net: linkwatch: add check for netdevice being present to linkwatch_do_dev"

2020-09-10 Thread Geert Uytterhoeven
Hi David, On Thu, Sep 10, 2020 at 9:20 PM David Miller wrote: > From: Geert Uytterhoeven > Date: Tue, 1 Sep 2020 17:02:37 +0200 > > > This reverts commit 124eee3f6955f7aa19b9e6ff5c9b6d37cb3d1e2c. > > > > Inami-san reported that this commit breaks bridge support in

[PATCH] Revert "net: linkwatch: add check for netdevice being present to linkwatch_do_dev"

2020-09-01 Thread Geert Uytterhoeven
/kzm9g works fine before/after this revert. Reported-by Gaku Inami Signed-off-by: Geert Uytterhoeven --- net/core/link_watch.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/link_watch.c b/net/core/link_watch.c index 75431ca9300fb9c4..c24574493ecf95e6 100644 --- a/net

[PATCH] chelsio/chtls: CHELSIO_INLINE_CRYPTO should depend on CHELSIO_T4

2020-09-01 Thread Geert Uytterhoeven
when CONFIG_CHELSIO_T4 is disabled. Fix this by moving the dependency from the individual config options to the guard symbol. Fixes: 44fd1c1fd8219551 ("chelsio/chtls: separate chelsio tls driver from crypto driver") Signed-off-by: Geert Uytterhoeven --- drivers/net/ethernet/chelsio/inline_crypto/Kco

Re: [PATCH 1/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-08-26 Thread Geert Uytterhoeven
, *(tx_skb->data + loop)); > > + > > + netdev_info(ndev, "\n"); > > This no longer works as far as i remember. Lines are terminate by > default even if they don't have a \n. > > Please you should not be using netdev_info(). netdev_

  1   2   3   4   5   6   7   8   >