Hi Kernel Test Robot, On Mon, Feb 22, 2021 at 10:02 PM kernel test robot <l...@intel.com> wrote: > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on net-next/master] > > url: > https://github.com/0day-ci/linux/commits/Sharath-Chandra-Vurukala/net-qualcomm-rmnet-Enable-Mapv5/20210223-010109 > base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git > d310ec03a34e92a77302edb804f7d68ee4f01ba0 > config: m68k-allmodconfig (attached as .config) > compiler: m68k-linux-gcc (GCC) 9.3.0 > reproduce (this is a W=1 build): > wget > https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O > ~/bin/make.cross > chmod +x ~/bin/make.cross > # > https://github.com/0day-ci/linux/commit/a96da20e1028049cc3824b52bb5293376c0868ce > git remote add linux-review https://github.com/0day-ci/linux > git fetch --no-tags linux-review > Sharath-Chandra-Vurukala/net-qualcomm-rmnet-Enable-Mapv5/20210223-010109 > git checkout a96da20e1028049cc3824b52bb5293376c0868ce > # save the attached .config to linux build tree > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross > ARCH=m68k > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot <l...@intel.com> > > All errors (new ones prefixed by >>): > > In file included from include/linux/kernel.h:10, > from include/linux/list.h:9, > from include/linux/timer.h:5, > from include/linux/netdevice.h:24, > from > drivers/net/ethernet/qualcomm/rmnet/rmnet_handlers.c:7: > include/linux/scatterlist.h: In function 'sg_set_buf': > arch/m68k/include/asm/page_mm.h:174:49: warning: ordered comparison of > pointer with null pointer [-Wextra] > 174 | #define virt_addr_valid(kaddr) ((void *)(kaddr) >= (void > *)PAGE_OFFSET && (void *)(kaddr) < high_memory) > | ^~ > include/linux/compiler.h:78:42: note: in definition of macro 'unlikely' > 78 | # define unlikely(x) __builtin_expect(!!(x), 0) > | ^ > include/linux/scatterlist.h:137:2: note: in expansion of macro 'BUG_ON' > 137 | BUG_ON(!virt_addr_valid(buf)); > | ^~~~~~ > include/linux/scatterlist.h:137:10: note: in expansion of macro > 'virt_addr_valid' > 137 | BUG_ON(!virt_addr_valid(buf)); > | ^~~~~~~~~~~~~~~
Note that the warning is unrelated. I've sent a patch to quiten it. [PATCH] m68k: Fix virt_addr_valid() W=1 compiler warnings https://lore.kernel.org/linux-m68k/20210223104957.2209219-1-ge...@linux-m68k.org/ > In file included from drivers/net/ethernet/qualcomm/rmnet/rmnet_map.h:7, > from > drivers/net/ethernet/qualcomm/rmnet/rmnet_handlers.c:14: > include/linux/if_rmnet.h: At top level: > >> include/linux/if_rmnet.h:66:2: error: expected ',', ';' or '}' before 'u8' > 66 | u8 hw_reserved:7; > | ^~ That's a real one, though. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
