Re: [PATCH net] net: marvell: prestera: fix port event handling on init

2021-04-20 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Tue, 20 Apr 2021 16:31:51 +0300 you wrote: > From: Vadym Kochan > > For some reason there might be a crash during ports creation if port > events are handling at the same time because fw may send initial > port event with

Re: [PATCH] net: davinci_emac: Fix incorrect masking of tx and rx error channel

2021-04-20 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Tue, 20 Apr 2021 18:16:14 +0100 you wrote: > From: Colin Ian King > > The bit-masks used for the TXERRCH and RXERRCH (tx and rx error channels) > are incorrect and always lead to a zero result. The mask values are > current

Re: [PATCH net-next] net: wwan: mhi_wwan_ctrl: Fix RX buffer starvation

2021-04-20 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Tue, 20 Apr 2021 11:36:22 +0200 you wrote: > The mhi_wwan_rx_budget_dec function is supposed to return true if > RX buffer budget has been successfully decremented, allowing to queue > a new RX buffer for transfer. Howev

Re: [PATCH][next] net: mana: remove redundant initialization of variable err

2021-04-20 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Tue, 20 Apr 2021 13:27:30 +0100 you wrote: > From: Colin Ian King > > The variable err is being initialized with a value that is > never read and it is being updated later with a new value. The > initialization is red

Re: [PATCH net-next v2] net: phy: at803x: fix probe error if copper page is selected

2021-04-20 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Tue, 20 Apr 2021 12:29:29 +0200 you wrote: > The commit c329e5afb42f ("net: phy: at803x: select correct page on > config init") selects the copper page during probe. This fails if the > copper page was already selected.

Re: [PATCH net] vsock/virtio: free queued packets when closing socket

2021-04-20 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Tue, 20 Apr 2021 13:07:27 +0200 you wrote: > As reported by syzbot [1], there is a memory leak while closing the > socket. We partially solved this issue with commit ac03046ece2b > ("vsock/virtio: free packets during the sock

Re: [PATCH net 0/3] sfc: fix TXQ lookups

2021-04-20 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net.git (refs/heads/master): On Tue, 20 Apr 2021 13:24:54 +0100 you wrote: > The TXQ handling changes in 12804793b17c ("sfc: decouple TXQ type from label") > which were made as part of the support for encap offloads on EF10 caused some > breakage on Sien

Re: [PATCH net-next] virtio-net: restrict build_skb() use to some arches

2021-04-20 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Tue, 20 Apr 2021 13:01:44 -0700 you wrote: > From: Eric Dumazet > > build_skb() is supposed to be followed by > skb_reserve(skb, NET_IP_ALIGN), so that IP headers are word-aligned. > (Best practice is to reserve NET_IP

Re: [PATCH] phy: nxp-c45-tja11xx: fix phase offset calculation

2021-04-20 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Tue, 20 Apr 2021 16:11:33 +0300 you wrote: > Fix phase offset calculation. > > Signed-off-by: Radu Pirea (NXP OSS) > --- > drivers/net/phy/nxp-c45-tja11xx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

Re: [PATCH net-next] net: enetc: automatically select IERB module

2021-04-20 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Tue, 20 Apr 2021 16:28:21 +0200 you wrote: > Now that enetc supports flow control we have to make sure the settings in > the IERB are correct. Therefore, we actually depend on the enetc-ierb > module. Previously it was p

Re: [PATCH net-next] net: wwan: Fix bit ops double shift

2021-04-20 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Tue, 20 Apr 2021 21:09:57 +0200 you wrote: > bit operation helpers such as test_bit, clear_bit, etc take bit > position as parameter and not value. Current usage causes double > shift => BIT(BIT(0)). Fix that in wwan_cor

Re: [PATCH v3 net-next 0/5] net: dsa: Allow default tag protocol to be overridden from DT

2021-04-20 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Tue, 20 Apr 2021 20:53:06 +0200 you wrote: > This is a continuation of the work started in this patch: > https://lore.kernel.org/netdev/20210323102326.3677940-1-tob...@waldekranz.com/ > > In addition to the mv88e6xxx s

Re: [PATCH net-next v2 0/5] net: phy: marvell: some HWMON updates

2021-04-20 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Tue, 20 Apr 2021 09:53:58 +0200 you wrote: > Here are some updates for Marvell PHY HWMON, mainly > - refactoring for code deduplication > - Amethyst PHY support > > Changes since v1: > - addressed Andrew's comments > -

Re: pull-request: mac80211-next 2021-04-20

2021-04-20 Thread patchwork-bot+netdevbpf
Hello: This pull request was applied to netdev/net-next.git (refs/heads/master): On Tue, 20 Apr 2021 17:00:30 +0200 you wrote: > Hi, > > We have a bunch more things for next, now that we got another > week "for free" ;-) Pretty much all over the map, see the tag > description and shortlog below.

Re: [PATCH V2 02/16] net: iosm: irq handling

2021-04-20 Thread David Miller
From: M Chetan Kumar Date: Tue, 20 Apr 2021 21:42:56 +0530 > 1) Request interrupt vector, frees allocated resource. > 2) Registers IRQ handler. > > Signed-off-by: M Chetan Kumar > --- > v2: Streamline multiple returns using goto. > --- > drivers/net/wwan/iosm/iosm_ipc_irq.c | 91 ++

Re: [PATCHv2 RFC bpf-next 0/7] bpf: Add support for ftrace probe

2021-04-20 Thread Alexei Starovoitov
On Tue, Apr 20, 2021 at 9:52 AM Jiri Olsa wrote: > > On Tue, Apr 20, 2021 at 08:33:43AM -0700, Alexei Starovoitov wrote: > > On Tue, Apr 20, 2021 at 5:51 AM Jiri Olsa wrote: > > > > > > On Fri, Apr 16, 2021 at 12:48:34PM -0400, Steven Rostedt wrote: > > > > On Sat, 17 Apr 2021 00:03:04 +0900 > >

Re: [PATCH net-next] korina: Fix conflict with global symbol desc_empty on x86.

2021-04-20 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Tue, 20 Apr 2021 16:26:27 -0700 (PDT) you wrote: > Signed-off-by: David S. Miller > --- > drivers/net/ethernet/korina.c | 16 > 1 file changed, 8 insertions(+), 8 deletions(-) Here is the summary with

Re: [net-next 01/15] net/mlx5e: Fix lost changes during code movements

2021-04-20 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Mon, 19 Apr 2021 20:20:04 -0700 you wrote: > From: Tariq Toukan > > The changes done in commit [1] were missed by the code movements > done in [2], as they were developed in ~parallel. > Here we re-apply them. > > [1

[PATCH net-next] korina: Fix conflict with global symbol desc_empty on x86.

2021-04-20 Thread David Miller
Signed-off-by: David S. Miller --- drivers/net/ethernet/korina.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/net/ethernet/korina.c b/drivers/net/ethernet/korina.c index 4878e527e3c8..4613bc21130b 100644 --- a/drivers/net/ethernet/korina.c +++ b/d

Re: [PATCHv8 bpf-next 1/4] bpf: run devmap xdp_prog on flush instead of bulk enqueue

2021-04-20 Thread Martin KaFai Lau
On Tue, Apr 20, 2021 at 10:56:56PM +0200, Toke Høiland-Jørgensen wrote: > Martin KaFai Lau writes: > > > On Thu, Apr 15, 2021 at 09:53:17PM +0800, Hangbin Liu wrote: > >> From: Jesper Dangaard Brouer > >> > >> This changes the devmap XDP program support to run the program when the > >> bulk que

Re: [net-next] net: dsa: felix: disable always guard band bit for TAS config

2021-04-20 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Mon, 19 Apr 2021 18:25:30 +0800 you wrote: > ALWAYS_GUARD_BAND_SCH_Q bit in TAS config register is descripted as > this: > 0: Guard band is implemented for nonschedule queues to schedule > queues transitio

Re: [PATCH v3 net-next 4/5] net: dsa: Allow default tag protocol to be overridden from DT

2021-04-20 Thread Vladimir Oltean
On Tue, Apr 20, 2021 at 08:53:10PM +0200, Tobias Waldekranz wrote: > Some combinations of tag protocols and Ethernet controllers are > incompatible, and it is hard for the driver to keep track of these. > > Therefore, allow the device tree author (typically the board vendor) > to inform the driver

Re: [PATCH v3 bpf-next 11/11] bpf: Test BPF_SK_REUSEPORT_SELECT_OR_MIGRATE.

2021-04-20 Thread Andrii Nakryiko
On Tue, Apr 20, 2021 at 8:45 AM Kuniyuki Iwashima wrote: > > This patch adds a test for BPF_SK_REUSEPORT_SELECT_OR_MIGRATE and > removes 'static' from settimeo() in network_helpers.c. > > Signed-off-by: Kuniyuki Iwashima > --- Almost everything in prog_tests/migrate_reuseport.c should be static,

Re: [PATCH] ice: set the value of global config lock timeout longer

2021-04-20 Thread Nguyen, Anthony L
On Mon, 2021-04-19 at 17:31 +0800, Liwei Song wrote: > It may need hold Global Config Lock a longer time when download DDP > package file, extend the timeout value to 5000ms to ensure that > download can be finished before other AQ command got time to run, > this will fix the issue below when probe

[PATCH] netfilter: nf_conntrack: Add conntrack helper for ESP/IPsec

2021-04-20 Thread Cole Dishington
Introduce changes to add ESP connection tracking helper to netfilter conntrack. The connection tracking of ESP is based on IPsec SPIs. The underlying motivation for this patch was to allow multiple VPN ESP clients to be distinguished when using NAT. Added config flag CONFIG_NF_CT_PROTO_ESP to enab

Re: [PATCH bpf-next] selftests/bpf: Add docs target as all dependency

2021-04-20 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to bpf/bpf-next.git (refs/heads/master): On Tue, 20 Apr 2021 15:24:28 +0200 you wrote: > Currently docs target is make dependency for TEST_GEN_FILES, > which makes tests to be rebuilt every time you run make. > > Adding docs as all target dependency, so when running

Re: [PATCH net-next] virtio-net: restrict build_skb() use to some arches

2021-04-20 Thread Guenter Roeck
On Tue, Apr 20, 2021 at 01:01:44PM -0700, Eric Dumazet wrote: > From: Eric Dumazet > > build_skb() is supposed to be followed by > skb_reserve(skb, NET_IP_ALIGN), so that IP headers are word-aligned. > (Best practice is to reserve NET_IP_ALIGN+NET_SKB_PAD, but the NET_SKB_PAD > part is only a per

Re: [PATCH V2 net] ibmvnic: Continue with reset if set link down failed

2021-04-20 Thread Lijun Pan
> On Apr 20, 2021, at 4:35 PM, Dany Madden wrote: > > When ibmvnic gets a FATAL error message from the vnicserver, it marks > the Command Respond Queue (CRQ) inactive and resets the adapter. If this > FATAL reset fails and a transmission timeout reset follows, the CRQ is > still inactive, ibmv

[PATCH V2 net] ibmvnic: Continue with reset if set link down failed

2021-04-20 Thread Dany Madden
When ibmvnic gets a FATAL error message from the vnicserver, it marks the Command Respond Queue (CRQ) inactive and resets the adapter. If this FATAL reset fails and a transmission timeout reset follows, the CRQ is still inactive, ibmvnic's attempt to set link down will also fail. If ibmvnic abandon

RE: [Intel-wired-lan] [PATCH V2 net] ice: Re-organizes reqstd/avail {R, T}XQ check/code for efficiency+readability

2021-04-20 Thread Salil Mehta
> From: Brelinski, TonyX [mailto:tonyx.brelin...@intel.com] > Sent: Tuesday, April 20, 2021 9:26 PM > > > From: Intel-wired-lan On Behalf Of > > Salil Mehta > > Sent: Tuesday, April 13, 2021 3:45 PM > > To: da...@davemloft.net; k...@kernel.org > > Cc: salil.me...@huawei.com; linux...@openeuler.or

Re: [PATCH 1/3] arm64: armv8_deprecated: Fix swp_handler() signal generation

2021-04-20 Thread kernel test robot
Hi Liam, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on arm64/for-next/core] [also build test WARNING on arm-perf/for-next/perf xlnx/master arm/for-next soc/for-next kvmarm/next linus/master v5.12-rc8 next-20210420] [If your patch is applied to the wrong git

Re: [PATCH 1/2] mm: Fix struct page layout on 32-bit systems

2021-04-20 Thread Arnd Bergmann
On Tue, Apr 20, 2021 at 11:14 PM Vineet Gupta wrote: > On 4/20/21 12:07 AM, Arnd Bergmann wrote: > > > > which means that half the 32-bit architectures do this. This may > > cause more problems when arc and/or microblaze want to support > > 64-bit kernels and compat mode in the future on their la

Re: [PATCH 1/2] mm: Fix struct page layout on 32-bit systems

2021-04-20 Thread Vineet Gupta
On 4/20/21 12:07 AM, Arnd Bergmann wrote: > On Tue, Apr 20, 2021 at 5:10 AM Matthew Wilcox wrote: >> On Tue, Apr 20, 2021 at 02:48:17AM +, Vineet Gupta wrote: 32-bit architectures which expect 8-byte alignment for 8-byte integers and need 64-bit DMA addresses (arc, arm, mips, ppc) ha

Re: [PATCH RESEND][next] rds: Fix fall-through warnings for Clang

2021-04-20 Thread Gustavo A. R. Silva
Hi all, Friendly ping: who can take this, please? Thanks -- Gustavo On 3/5/21 03:06, Gustavo A. R. Silva wrote: > In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple > warnings by explicitly adding multiple break statements instead of > letting the code fall through to the ne

Re: [PATCH RESEND][next] sctp: Fix fall-through warnings for Clang

2021-04-20 Thread Gustavo A. R. Silva
Hi all, Friendly ping: who can take this, please? Thanks -- Gustavo On 3/5/21 03:07, Gustavo A. R. Silva wrote: > In preparation to enable -Wimplicit-fallthrough for Clang, fix a couple > of warnings by explicitly adding a break statement and replacing a > comment with a goto statement instead o

Re: [PATCH RESEND][next] rxrpc: Fix fall-through warnings for Clang

2021-04-20 Thread Gustavo A. R. Silva
Hi all, Friendly ping: who can take this, please? Thanks -- Gustavo On 3/5/21 03:19, Gustavo A. R. Silva wrote: > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning > by explicitly adding a break statement instead of letting the code fall > through to the next case. > > Li

Re: [PATCHv8 bpf-next 1/4] bpf: run devmap xdp_prog on flush instead of bulk enqueue

2021-04-20 Thread Toke Høiland-Jørgensen
Martin KaFai Lau writes: > On Thu, Apr 15, 2021 at 09:53:17PM +0800, Hangbin Liu wrote: >> From: Jesper Dangaard Brouer >> >> This changes the devmap XDP program support to run the program when the >> bulk queue is flushed instead of before the frame is enqueued. This has >> a couple of benefit

Re: [PATCH RESEND][next] vxge: Fix fall-through warnings for Clang

2021-04-20 Thread Gustavo A. R. Silva
Hi all, Friendly ping: who can take this, please? Thanks -- Gustavo On 3/5/21 03:47, Gustavo A. R. Silva wrote: > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning > by explicitly adding a return statement instead of letting the code fall > through to the next case. > > L

Re: [PATCH RESEND][next] net/mlx4: Fix fall-through warnings for Clang

2021-04-20 Thread Gustavo A. R. Silva
Hi all, Friendly ping: who can take this, please? Thanks -- Gustavo On 3/5/21 02:48, Gustavo A. R. Silva wrote: > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning > by explicitly adding a break statement instead of just letting the code > fall through to the next case. >

Re: [PATCH RESEND][next] net: netrom: Fix fall-through warnings for Clang

2021-04-20 Thread Gustavo A. R. Silva
Hi all, Friendly ping: who can take this, please? Thanks -- Gustavo On 3/5/21 03:22, Gustavo A. R. Silva wrote: > In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple > warnings by explicitly adding multiple break statements instead of > letting the code fall through to the ne

Re: [PATCH net-next 00/18] devlink: rate objects API

2021-04-20 Thread Jakub Kicinski
On Tue, 20 Apr 2021 14:33:36 +0300 dlin...@nvidia.com wrote: > From: Dmytro Linkin > > Currently kernel provides a way to change tx rate of single VF in > switchdev mode via tc-police action. When lots of VFs are configured > management of theirs rates becomes non-trivial task and some grouping >

Re: [PATCH net v4 1/2] net: sched: fix packet stuck problem for lockless qdisc

2021-04-20 Thread Michal Kubecek
On Tue, Apr 20, 2021 at 01:55:03AM +0200, Michal Kubecek wrote: > On Mon, Apr 19, 2021 at 05:29:46PM +0200, Michal Kubecek wrote: > > > > As pointed out in the discussion on v3, this patch may result in > > significantly higher CPU consumption with multiple threads competing on > > a saturated out

Re: [PATCH RESEND][next] net/packet: Fix fall-through warnings for Clang

2021-04-20 Thread Gustavo A. R. Silva
Hi all, Friendly ping: who can take this, please? Thanks -- Gustavo On 3/5/21 03:44, Gustavo A. R. Silva wrote: > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning > by explicitly adding a break statement instead of letting the code fall > through to the next case. > > Li

Re: [PATCH RESEND][next] tipc: Fix fall-through warnings for Clang

2021-04-20 Thread Gustavo A. R. Silva
Hi all, Friendly ping: who can take this, please? Thanks -- Gustavo On 3/5/21 03:25, Gustavo A. R. Silva wrote: > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning > by explicitly adding a break statement instead of letting the code fall > through to the next case. > > Li

Re: [PATCH RESEND][next] xfrm: Fix fall-through warnings for Clang

2021-04-20 Thread Gustavo A. R. Silva
Hi all, Friendly ping: who can take this, please? Thanks -- Gustavo On 3/5/21 03:23, Gustavo A. R. Silva wrote: > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning > by explicitly adding a break statement instead of letting the code fall > through to the next case. > > Li

Re: [PATCH RESEND][next] ipv4: Fix fall-through warnings for Clang

2021-04-20 Thread Gustavo A. R. Silva
Hi all, Friendly ping: who can take this, please? Thanks -- Gustavo On 3/5/21 03:02, Gustavo A. R. Silva wrote: > In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple > warnings by explicitly adding multiple break statements instead of just > letting the code fall through to t

Re: [PATCH RESEND][next] qlcnic: Fix fall-through warnings for Clang

2021-04-20 Thread Gustavo A. R. Silva
Hi all, Friendly ping: who can take this, please? Thanks -- Gustavo On 3/5/21 03:17, Gustavo A. R. Silva wrote: > In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple > warnings by explicitly adding a break and a goto statements instead of > just letting the code fall through

Re: [PATCH RESEND][next] bnxt_en: Fix fall-through warnings for Clang

2021-04-20 Thread Gustavo A. R. Silva
Hi all, Friendly ping: who can take this, please? Thanks -- Gustavo On 3/5/21 03:50, Gustavo A. R. Silva wrote: > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning > by explicitly adding a break statement instead of just letting the code > fall through to the next case. >

RE: [Intel-wired-lan] [PATCH V2 net] ice: Re-organizes reqstd/avail {R, T}XQ check/code for efficiency+readability

2021-04-20 Thread Brelinski, TonyX
> -Original Message- > From: Intel-wired-lan On Behalf Of > Salil Mehta > Sent: Tuesday, April 13, 2021 3:45 PM > To: da...@davemloft.net; k...@kernel.org > Cc: salil.me...@huawei.com; linux...@openeuler.org; > netdev@vger.kernel.org; linux...@huawei.com; linux- > ker...@vger.kernel.org; J

Re: [PATCH RESEND][next] netxen_nic: Fix fall-through warnings for Clang

2021-04-20 Thread Gustavo A. R. Silva
Hi all, Friendly ping: who can take this, please? Thanks -- Gustavo On 3/5/21 03:45, Gustavo A. R. Silva wrote: > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning > by explicitly adding a goto statement instead of just letting the code > fall through to the next case. >

Re: [PATCH RESEND][next] nfp: Fix fall-through warnings for Clang

2021-04-20 Thread Gustavo A. R. Silva
Hi all, Friendly ping: who can take this, please? Thanks -- Gustavo On 3/5/21 06:19, Simon Horman wrote: > On Fri, Mar 05, 2021 at 03:49:37AM -0600, Gustavo A. R. Silva wrote: >> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning >> by explicitly adding a break statement in

Re: [PATCH RESEND][next] sctp: Fix fall-through warnings for Clang

2021-04-20 Thread Marcelo Ricardo Leitner
On Tue, Apr 20, 2021 at 03:09:24PM -0500, Gustavo A. R. Silva wrote: > Hi all, > > Friendly ping: who can take this, please? It would go via net/net-next tree, but I can't find this one on patchwork. Just the previous version. http://patchwork.ozlabs.org/project/netdev/list/?series=&submitter=&s

Re: [PATCH 070/141] atm: fore200e: Fix fall-through warnings for Clang

2021-04-20 Thread Gustavo A. R. Silva
Hi all, Friendly ping: who can take this, please? Thanks -- Gustavo On 11/20/20 12:34, Gustavo A. R. Silva wrote: > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning > by explicitly adding a fallthrough pseudo-keyword. > > Link: https://github.com/KSPP/linux/issues/115 >

[PATCH] net: sfc: Fix kernel panic introduced by commit 044588b96372 ("sfc: define inner/outer csum offload TXQ types")

2021-04-20 Thread Yury Vostrikov
NIC has EFX_MAX_CHANNELS channels: struct efx_nic { [...] struct efx_channel *channel[EFX_MAX_CHANNELS]; [...] } Each channel has EFX_MAX_TXQ_PER_CHANNEL TX queues; There a reverse mapping from type to TX queue, holding at most EFX_TXQ_TYPES entries. This mapping is a bitse

[PATCH net-next] virtio-net: restrict build_skb() use to some arches

2021-04-20 Thread Eric Dumazet
From: Eric Dumazet build_skb() is supposed to be followed by skb_reserve(skb, NET_IP_ALIGN), so that IP headers are word-aligned. (Best practice is to reserve NET_IP_ALIGN+NET_SKB_PAD, but the NET_SKB_PAD part is only a performance optimization if tunnel encaps are added.) Unfortunately virtio_n

Re: [PATCH net-next v2 2/2] net: ethernet: mediatek: support custom GMAC label

2021-04-20 Thread Ilya Lipnitskiy
On Tue, Apr 20, 2021 at 12:51 PM Rob Herring wrote: > > On Mon, Apr 19, 2021 at 08:46:59AM -0700, Ilya Lipnitskiy wrote: > > The MAC device name can now be set within DTS file instead of always > > being "ethX". This is helpful for DSA to clearly label the DSA master > > device and distinguish it

Re: [PATCH net-next v2 2/2] net: ethernet: mediatek: support custom GMAC label

2021-04-20 Thread Rob Herring
On Mon, Apr 19, 2021 at 08:46:59AM -0700, Ilya Lipnitskiy wrote: > The MAC device name can now be set within DTS file instead of always > being "ethX". This is helpful for DSA to clearly label the DSA master > device and distinguish it from DSA slave ports. > > For example, some devices, such as t

[PATCH bpf-next v3 3/3] libbpf: add selftests for TC-BPF API

2021-04-20 Thread Kumar Kartikeya Dwivedi
This adds some basic tests for the low level bpf_tc_* API. Reviewed-by: Toke Høiland-Jørgensen Signed-off-by: Kumar Kartikeya Dwivedi --- .../selftests/bpf/prog_tests/test_tc_bpf.c| 169 ++ .../selftests/bpf/progs/test_tc_bpf_kern.c| 12 ++ 2 files changed, 181 insertio

[PATCH bpf-next v3 2/3] libbpf: add low level TC-BPF API

2021-04-20 Thread Kumar Kartikeya Dwivedi
This adds functions that wrap the netlink API used for adding, manipulating, and removing traffic control filters. These functions operate directly on the loaded prog's fd, and return a handle to the filter using an out parameter named id. The basic featureset is covered to allow for attaching and

[PATCH bpf-next v3 1/3] libbpf: add helpers for preparing netlink attributes

2021-04-20 Thread Kumar Kartikeya Dwivedi
This change introduces a few helpers to wrap open coded attribute preparation in netlink.c. Every nested attribute's closure must happen using the helper nlattr_end_nested, which sets its length properly. NLA_F_NESTED is enforeced using nlattr_begin_nested helper. Other simple attributes can be ad

[PATCH bpf-next v3 0/3] Add TC-BPF API

2021-04-20 Thread Kumar Kartikeya Dwivedi
This is the third version of the TC-BPF series. It adds a simple API that uses netlink to attach the tc filter and its bpf classifier. Currently, a user needs to shell out to the tc command line to be able to create filters and attach SCHED_CLS programs as classifiers. With the help of this API, i

Re: [PATCH net 2/2] net/sched: sch_frag: fix stack OOB read while fragmenting IPv4 packets

2021-04-20 Thread Cong Wang
On Mon, Apr 19, 2021 at 8:24 AM Davide Caratti wrote: > > when 'act_mirred' tries to fragment IPv4 packets that had been previously > re-assembled using 'act_ct', splats like the following can be observed on > kernels built with KASAN: [...] > for IPv4 packets, sch_fragment() uses a temporary stru

Re: [PATCH] net: called rtnl_unlock() before runpm resumes devices

2021-04-20 Thread Jakub Kicinski
On Tue, 20 Apr 2021 10:34:17 +0200 Eric Dumazet wrote: > On Tue, Apr 20, 2021 at 9:54 AM AceLan Kao wrote: > > > > From: "Chia-Lin Kao (AceLan)" > > > > The rtnl_lock() has been called in rtnetlink_rcv_msg(), and then in > > __dev_open() it calls pm_runtime_resume() to resume devices, and in > >

Re: [PATCH net 2/2] net/sched: sch_frag: fix stack OOB read while fragmenting IPv4 packets

2021-04-20 Thread Cong Wang
On Tue, Apr 20, 2021 at 1:59 AM Davide Caratti wrote: > > hello Cong, thanks for looking at this! > > On Mon, 2021-04-19 at 11:46 -0700, Cong Wang wrote: > > On Mon, Apr 19, 2021 at 8:24 AM Davide Caratti wrote: > > > diff --git a/net/sched/sch_frag.c b/net/sched/sch_frag.c > > > index e1e77d3fb6

[PATCH] can: add a note that RECV_OWN_MSGS frames are subject to filtering

2021-04-20 Thread Erik Flodin
Some parts of the documentation may lead the reader to think that the socket's own frames are always received when CAN_RAW_RECV_OWN_MSGS is enabled, but all frames are subject to filtering. As explained by Marc Kleine-Budde: On TX complete of a CAN frame it's pushed into the RX path of the networ

Re: [PATCH rdma-next 0/2] Two fixes to -next

2021-04-20 Thread Jason Gunthorpe
On Sun, Apr 18, 2021 at 04:49:38PM +0300, Leon Romanovsky wrote: > From: Leon Romanovsky > > The two fixes are targeted to the -next. Maor's change fixes DM code > that was accepted in this cycle and Parav's change doesn't qualify > urgency of -rc8. > > Thanks > > Maor Gottlieb (1): > RDMA/ml

[PATCH net-next] net: wwan: Fix bit ops double shift

2021-04-20 Thread Loic Poulain
bit operation helpers such as test_bit, clear_bit, etc take bit position as parameter and not value. Current usage causes double shift => BIT(BIT(0)). Fix that in wwan_core and mhi_wwan_ctrl. Fixes: 9a44c1cc6388 ("net: Add a WWAN subsystem") Reported-by: Dan Carpenter Signed-off-by: Loic Poulain

[PATCH v3 net-next 1/5] net: dsa: mv88e6xxx: Mark chips with undocumented EDSA tag support

2021-04-20 Thread Tobias Waldekranz
All devices are capable of using regular DSA tags. Support for Ethertyped DSA tags sort into three categories: 1. No support. Older chips fall into this category. 2. Full support. Datasheet explicitly supports configuring the CPU port to receive FORWARDs with a DSA tag. 3. Undocumented suppor

[PATCH v3 net-next 5/5] dt-bindings: net: dsa: Document dsa-tag-protocol property

2021-04-20 Thread Tobias Waldekranz
The 'dsa-tag-protocol' is used to force a switch tree to use a particular tag protocol, typically because the Ethernet controller that it is connected to is not compatible with the default one. Signed-off-by: Tobias Waldekranz --- Documentation/devicetree/bindings/net/dsa/dsa.yaml | 9 +

[PATCH v3 net-next 4/5] net: dsa: Allow default tag protocol to be overridden from DT

2021-04-20 Thread Tobias Waldekranz
Some combinations of tag protocols and Ethernet controllers are incompatible, and it is hard for the driver to keep track of these. Therefore, allow the device tree author (typically the board vendor) to inform the driver of this fact by selecting an alternate protocol that is known to work. Sign

[PATCH v3 net-next 2/5] net: dsa: mv88e6xxx: Allow dynamic reconfiguration of tag protocol

2021-04-20 Thread Tobias Waldekranz
For devices that supports both regular and Ethertyped DSA tags, allow the user to change the protocol. Additionally, because there are ethernet controllers that do not handle regular DSA tags in all cases, also allow the protocol to be changed on devices with undocumented support for EDSA. But, in

[PATCH v3 net-next 3/5] net: dsa: Only notify CPU ports of changes to the tag protocol

2021-04-20 Thread Tobias Waldekranz
Previously DSA ports were also included, on the assumption that the protocol used by the CPU port had to the matched throughout the entire tree. As there is not yet any consumer in need of this, drop the call. Signed-off-by: Tobias Waldekranz Reviewed-by: Vladimir Oltean Reviewed-by: Florian Fa

[PATCH v3 net-next 0/5] net: dsa: Allow default tag protocol to be overridden from DT

2021-04-20 Thread Tobias Waldekranz
This is a continuation of the work started in this patch: https://lore.kernel.org/netdev/20210323102326.3677940-1-tob...@waldekranz.com/ In addition to the mv88e6xxx support to dynamically change the protocol, it is now possible to override the protocol from the device tree. This means that when a

Re: [PATCH net-next 4/6] r8152: support new chips

2021-04-20 Thread Jakub Kicinski
On Tue, 20 Apr 2021 07:00:39 + Hayes Wang wrote: > > > @@ -6878,7 +8942,11 @@ static int rtl8152_probe(struct usb_interface > > > *intf, > > > set_ethernet_addr(tp); > > > > > > usb_set_intfdata(intf, tp); > > > - netif_napi_add(netdev, &tp->napi, r8152_poll, RTL8152_NAPI_WEIGHT); > > >

Re: [PATCHv8 bpf-next 1/4] bpf: run devmap xdp_prog on flush instead of bulk enqueue

2021-04-20 Thread Martin KaFai Lau
On Thu, Apr 15, 2021 at 09:53:17PM +0800, Hangbin Liu wrote: > From: Jesper Dangaard Brouer > > This changes the devmap XDP program support to run the program when the > bulk queue is flushed instead of before the frame is enqueued. This has > a couple of benefits: > > - It "sorts" the packets b

Re: [PATCH net-next v2 5/6] sfc: ef10: implement ethtool::get_fec_stats

2021-04-20 Thread Jakub Kicinski
On Tue, 20 Apr 2021 16:13:21 +0100 Edward Cree wrote: > On 15/04/2021 23:53, Jakub Kicinski wrote: > > Report what appears to be the standard block counts: > > - 30.5.1.1.17 aFECCorrectedBlocks > > - 30.5.1.1.18 aFECUncorrectableBlocks > > > > Don't report the per-lane symbol counts, if those re

Re: [PATCHv8 bpf-next 2/4] xdp: extend xdp_redirect_map with broadcast support

2021-04-20 Thread Martin KaFai Lau
On Thu, Apr 15, 2021 at 09:53:18PM +0800, Hangbin Liu wrote: > This patch adds two flags BPF_F_BROADCAST and BPF_F_EXCLUDE_INGRESS to > extend xdp_redirect_map for broadcast support. > > With BPF_F_BROADCAST the packet will be broadcasted to all the interfaces > in the map. with BPF_F_EXCLUDE_INGR

Re: [PATCH net-next] net: enetc: automatically select IERB module

2021-04-20 Thread Vladimir Oltean
On Tue, Apr 20, 2021 at 04:28:21PM +0200, Michael Walle wrote: > Now that enetc supports flow control we have to make sure the settings in > the IERB are correct. Therefore, we actually depend on the enetc-ierb > module. Previously it was possible that this module was disabled while the > enetc was

Re: [PATCH net-next] virtio-net: fix use-after-free in page_to_skb()

2021-04-20 Thread Eric Dumazet
On 4/20/21 7:51 PM, Guenter Roeck wrote: > > sh does indeed fail, with the same symptoms as before, but so far I was not > able to track it down to a specific commit. The alpha failure is different, > though. It is a NULL pointer access. > > Anyway, testing ... > > The patch below does indee

Re: [PATCH V2 16/16] net: iosm: infrastructure

2021-04-20 Thread Randy Dunlap
Hi-- On 4/20/21 9:13 AM, M Chetan Kumar wrote: > diff --git a/drivers/net/wwan/Kconfig b/drivers/net/wwan/Kconfig > new file mode 100644 > index ..6507970653d2 > --- /dev/null > +++ b/drivers/net/wwan/Kconfig > @@ -0,0 +1,19 @@ > +# SPDX-License-Identifier: GPL-2.0-only > +# > +# Wire

Re: [PATCH v2] docs: proc.rst: meminfo: briefly describe gaps in memory accounting

2021-04-20 Thread Alexey Dobriyan
On Tue, Apr 20, 2021 at 03:57:07PM +0200, Michal Hocko wrote: > On Tue 20-04-21 14:24:30, Matthew Wilcox wrote: > > On Tue, Apr 20, 2021 at 03:13:54PM +0300, Mike Rapoport wrote: > > > Add a paragraph that explains that it may happen that the counters in > > > /proc/meminfo do not add up to the ove

Re: [PATCH net-next] virtio-net: fix use-after-free in page_to_skb()

2021-04-20 Thread Guenter Roeck
On 4/20/21 9:31 AM, Eric Dumazet wrote: > On Tue, Apr 20, 2021 at 5:42 PM Guenter Roeck wrote: >> >> On Tue, Apr 20, 2021 at 04:00:07PM +0200, Eric Dumazet wrote: >>> On Tue, Apr 20, 2021 at 3:48 PM Guenter Roeck wrote: On 4/20/21 2:43 AM, Eric Dumazet wrote: >>> > Unfortu

[PATCH] net: davinci_emac: Fix incorrect masking of tx and rx error channel

2021-04-20 Thread Colin King
From: Colin Ian King The bit-masks used for the TXERRCH and RXERRCH (tx and rx error channels) are incorrect and always lead to a zero result. The mask values are currently the incorrect post-right shifted values, fix this by setting them to the currect values. (I double checked these against th

Re: [PATCH] SUNRPC: Add a check for gss_release_msg

2021-04-20 Thread J. Bruce Fields
On Tue, Apr 20, 2021 at 09:15:23AM +0200, Greg KH wrote: > If you look at the code, this is impossible to have happen. > > Please stop submitting known-invalid patches. Your professor is playing > around with the review process in order to achieve a paper in some > strange and bizarre way. > > T

Re: [PATCH v3 bpf-next] cpumap: bulk skb using netif_receive_skb_list

2021-04-20 Thread Lorenzo Bianconi
[...] > > + TP_ARGS(map_id, processed, sched, xdp_stats), > > > > TP_STRUCT__entry( > > __field(int, map_id) > > __field(u32, act) > > __field(int, cpu) > > - __field(unsigned int, drops) > > __field(unsigned int, processed) > > So,

Re: [net-next 07/15] net/mlx5: mlx5_ifc updates for flex parser

2021-04-20 Thread Yevgeny Kliteynik
On 20-Apr-21 07:54, Samudrala, Sridhar wrote: External email: Use caution opening links or attachments On 4/19/2021 8:20 PM, Saeed Mahameed wrote: From: Yevgeny Kliteynik Added the required definitions for supporting more protocols by flex parsers (GTP-U, Geneve TLV options), and for usi

Re: [PATCH v3 bpf-next] cpumap: bulk skb using netif_receive_skb_list

2021-04-20 Thread Jesper Dangaard Brouer
On Tue, 20 Apr 2021 16:05:14 +0200 Lorenzo Bianconi wrote: > Rely on netif_receive_skb_list routine to send skbs converted from > xdp_frames in cpu_map_kthread_run in order to improve i-cache usage. > The proposed patch has been tested running xdp_redirect_cpu bpf sample > available in the kernel

Re: [PATCH net-next 03/10] net: sparx5: add hostmode with phylink support

2021-04-20 Thread Steen.Hegelund
Hi Jacub, On Fri, 2021-04-16 at 14:22 -0700, Jakub Kicinski wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Fri, 16 Apr 2021 15:16:50 +0200 Steen Hegelund wrote: > > +static int sparx5_set_mac_address(struct net_device *dev, void *p)

Re: [PATCH net-next 09/10] net: sparx5: add ethtool configuration and statistics support

2021-04-20 Thread Steen.Hegelund
Hi Jacub, On Fri, 2021-04-16 at 14:26 -0700, Jakub Kicinski wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Fri, 16 Apr 2021 15:16:56 +0200 Steen Hegelund wrote: > > + "rx_in_bytes", > > + "rx_symbol_err", > > + "rx_pause",

Re: [PATCHv2 RFC bpf-next 0/7] bpf: Add support for ftrace probe

2021-04-20 Thread Jiri Olsa
On Tue, Apr 20, 2021 at 08:33:43AM -0700, Alexei Starovoitov wrote: > On Tue, Apr 20, 2021 at 5:51 AM Jiri Olsa wrote: > > > > On Fri, Apr 16, 2021 at 12:48:34PM -0400, Steven Rostedt wrote: > > > On Sat, 17 Apr 2021 00:03:04 +0900 > > > Masami Hiramatsu wrote: > > > > > > > > Anyway, IIRC, Masam

[PATCH 1/3] arm64: armv8_deprecated: Fix swp_handler() signal generation

2021-04-20 Thread Liam Howlett
arm64_notify_segfault() was written to decide on the si_code from the assembly emulation of the swp_handler(), but was also used for the signal generation from failed access_ok() and unaligned instructions. When access_ok() fails, there is no need to search for the offending address in the VMA spa

[PATCH 3/3] arch/arm64/kernel/traps: Use find_vma_intersection() in traps for setting si_code

2021-04-20 Thread Liam Howlett
find_vma() will continue to search upwards until the end of the virtual memory space. This means the si_code would almost never be set to SEGV_MAPERR even when the address falls outside of any VMA. The result is that the si_code is not reliable as it may or may not be set to the correct result, d

[PATCH 2/3] arm64: signal: sigreturn() and rt_sigreturn() sometime returns the wrong signals

2021-04-20 Thread Liam Howlett
arm64_notify_segfault() was used to force a SIGSEGV in all error cases in sigreturn() and rt_sigreturn() to avoid writing a new sig handler. There is now a better sig handler to use which does not search the VMA address space and return a slightly incorrect error code. Restore the older and correc

Re: [PATCH v3 bpf-next 00/11] Socket migration for SO_REUSEPORT.

2021-04-20 Thread Eric Dumazet
On 4/20/21 5:41 PM, Kuniyuki Iwashima wrote: > The SO_REUSEPORT option allows sockets to listen on the same port and to > accept connections evenly. However, there is a defect in the current > implementation [1]. When a SYN packet is received, the connection is tied > to a listening socket. Acco

Re: [PATCH bpf-next v4 2/3] bpf: selftests: remove percpu macros from bpf_util.h

2021-04-20 Thread Andrii Nakryiko
On Tue, Apr 20, 2021 at 8:58 AM Daniel Borkmann wrote: > > On 4/20/21 3:17 AM, Alexei Starovoitov wrote: > > On Thu, Apr 15, 2021 at 10:47 AM Pedro Tammela wrote: > >> > >> Andrii suggested to remove this abstraction layer and have the percpu > >> handling more explicit[1]. > >> > >> This patch a

Re: [PATCHv2 RFC bpf-next 0/7] bpf: Add support for ftrace probe

2021-04-20 Thread Steven Rostedt
On Tue, 20 Apr 2021 08:33:43 -0700 Alexei Starovoitov wrote: > I don't see how you can do it without BTF. I agree. > The mass-attach feature should prepare generic 6 or so arguments > from all functions it attached to. > On x86-64 it's trivial because 6 regs are the same. > On arm64 is now mo

Re: [PATCH net v2] igb: Fix XDP with PTP enabled

2021-04-20 Thread Nguyen, Anthony L
On Mon, 2021-04-19 at 09:23 +0200, Kurt Kanzenbach wrote: > When using native XDP with the igb driver, the XDP frame data doesn't > point to > the beginning of the packet. It's off by 16 bytes. Everything works > as expected > with XDP skb mode. > > Actually these 16 bytes are used to store the pa

Re: [PATCH net-next 2/6] igb: Add double-check MTA_REGISTER for i210 and i211

2021-04-20 Thread Nguyen, Anthony L
On Fri, 2021-04-16 at 14:12 -0700, Jakub Kicinski wrote: > On Fri, 16 Apr 2021 13:44:56 -0700 Tony Nguyen wrote: > > + bool is_failed; > > + int i; > > + > > + do { > > + is_failed = false; > > + for (i = hw->mac.mta_reg_count - 1; i >= 0; i--) { > > + if

Re: [PATCH] ptp: Don't print an error if ptp_kvm is not supported

2021-04-20 Thread Marc Zyngier
On Tue, 20 Apr 2021 14:24:19 +0100, Jon Hunter wrote: > Commit 300bb1fe7671 ("ptp: arm/arm64: Enable ptp_kvm for arm/arm64") > enable ptp_kvm support for ARM platforms and for any ARM platform that > does not support this, the following error message is displayed ... > > ERR KERN fail to initiali

[PATCH V2 16/16] net: iosm: infrastructure

2021-04-20 Thread M Chetan Kumar
1) Kconfig & Makefile changes for IOSM Driver compilation. 2) Modified driver/net Kconfig & Makefile for driver inclusion. 3) Add IOSM Driver documentation. 4) Modified MAINTAINER file for IOSM Driver addition. Signed-off-by: M Chetan Kumar --- v2: * Moved driver documentation to RsT file. * Modi

  1   2   3   >